src


Log

Author Commit Date CI Message
Behdad Esfahbod 508cc3d3 2015-12-17T17:31:17 [indic] Allow context when matching for Malayalam new-spec Test sequence: U+0995,U+09CD,U+09B0 With Nirmala shipped on Windows 10, this failed to form the below form. Works now. Reported by Sairus.
Behdad Esfahbod eaf1e93e 2015-12-17T16:57:47 [uniscribe] Handle E_NOT_SUFFICIENT_BUFFER as well as E_OUTOFMEMORY On Windows 10 we are seeing that other error message... Test sequence: U+0995,U+-9CD,U+09B0 With Nirmala shipped on Windows 10, this failed to form the below form. Works now. Reported by Sairus.
Behdad Esfahbod 100fbeaf 2015-12-17T15:23:09 Fix ligature component of a mark happening after a ligature within a ligature! Say, if we are ligating "A B_C m D", then previously 'm' was being attached to 'B' in the combined A_B_C_D ligature. Now we attach it to 'C'. No test for this though :(.
Behdad Esfahbod 2f02fc79 2015-12-17T15:21:14 Improve ligature-component handling We use three bits for lig_id these days, so we finally got a report of two separate ligatures with the same lig_id happening adjacent to each other, and then the component-handling code was breaking things. Protect against that by ignoring same-lig-id but lig-comp=0 glyphs after a new ligature. Fixes https://github.com/behdad/harfbuzz/issues/198
Behdad Esfahbod 2ab0de9f 2015-12-17T11:59:15 [use] Fix halant detection Before, we were just checking the use_category(). This detects as halant a ligature that had the halant as first glyph (as seen in NotoSansBalinese.) Change that to use the is_ligated() glyph prop bit. The font is forming this ligature in ccmp, which is before the rphf / pref tests. So we need to make sure the "ligated" bit survives those tests. Since those only check the "substituted" bit, we now only clear that bit for them and "ligated" survives. Fixes https://github.com/behdad/harfbuzz/issues/180
Behdad Esfahbod 86bcbd65 2015-12-17T11:04:33 [arabic] Use glyph advance width in apply_stch() instead of extents That seems to be what Windows is doing, and makes more sense.
Behdad Esfahbod f11c11a1 2015-12-16T17:08:36 Fix Since: tags for new API https://github.com/behdad/harfbuzz/commit/e1d4d0f1dbd8518b5672245c05d73f22a9ed03ea#commitcomment-15006653
Steven R. Loomis a13b023d 2015-12-11T10:21:27 AIX fixes - use '-w' instead of '\<...\>' for check-header-guards grep manpage says these are the same - put '-q' first in the grep options - move VAR into hb-private.hh - hb-font-private.hh - use [VAR] instead of [] for variable array
Behdad Esfahbod 49e72634 2015-12-10T17:44:19 Limit use of AIX intrinsics to IBM's compiler
Behdad Esfahbod e1d4d0f1 2015-12-10T16:56:07 Merge branch 'font-extents' Fixes https://github.com/behdad/harfbuzz/pull/165
Behdad Esfahbod 31fa3892 2015-12-10T16:38:29 [ft] Use ftface->size->metrics for font extent info
Behdad Esfahbod 3ad16048 2015-12-10T16:37:49 [ot-font] Respect OS/2 fsSelection USE_TYPO_METRICS bit
Behdad Esfahbod 70b33eda 2015-12-10T15:54:42 Add atomic ops for AIX Patch from Volker Simonis.
Behdad Esfahbod 98460779 2015-12-07T21:38:47 Remove final pause from Arabic shaper Back in the old days, we used to apply 'calt' and 'cswh' in Arabic shaper, with a pause in between. Then we disabled the 'cswh' because Microsoft disabled it, but forgot to remove the unnecessary pause. Do that now. This has the benefit that it fixes shaping with monbaiti from Windows 10. In that version of that font, the lookups from 'calt' are duplicated in 'rclt', and Mongolian was changed to go through Universal Shaping Engine. We still use the Arabic shaper for Mongolian. With a pause after 'calt', we were applying the duplicate lookups from 'calt' and 'rclt' twice. It happened to be the case that these lookups were NOT idempotent. So we were getting wrong shaping. See thread "Windows 10 monbaiti.ttf upgrade (5.01 -> 5.51) caused loss of diacritical marks when shaped with harfbuz" on the mailing list. This fixes that.
Behdad Esfahbod dee0fbf9 2015-12-07T10:44:08 Merge pull request #192 from behdad/jfkthame-stch [issue 191] Make apply_stch() give a more precise fit
Behdad Esfahbod 255df680 2015-12-07T10:34:47 Fix undefined behavior in cmp function Fixes https://bugs.freedesktop.org/show_bug.cgi?id=93274
Behdad Esfahbod fcf9e61b 2015-12-07T10:30:43 Fix sorting order of ot_languages array Looks like the original sort was wrongly done. Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93275
Behdad Esfahbod 70952ddb 2015-12-07T10:28:46 Add test to make sure ot-languages array is sorted Currently fails. Part of https://bugs.freedesktop.org/show_bug.cgi?id=93275
Behdad Esfahbod 8c37556f 2015-12-07T09:34:58 Merge pull request #134 from ebraminio/dwrite Add working but less prefect DirectWrite backend
jfkthame a7ffe353 2015-12-05T17:47:37 Make apply_stch() give a more precise fit This aims to make Syriac Abbr Mark sizing more accurate when repeating segments are used, by adding an extra repeat and tightening up the spacing slightly rather than leaving a shortfall corresponding to a partial repeat-width.
Behdad Esfahbod 8e5f9026 2015-11-30T16:53:21 src/test.cc: wrong field printed Fixes https://github.com/behdad/harfbuzz/issues/188 Fixes https://bugs.freedesktop.org/show_bug.cgi?id=93182
Simon Cozens 6f2e6de1 2015-10-26T16:23:22 Get font ascender and descender metrics from OS/2 table.
Simon Cozens 097c998a 2015-10-26T16:22:38 Parse the OS/2 table.
Behdad Esfahbod 35d18585 2015-11-26T19:30:37 Fix a few docs blocks
Behdad Esfahbod 0e38c918 2015-11-26T19:26:26 [introspection] Make scanner happy with HB_EXTERN
Behdad Esfahbod ea512f71 2015-11-26T19:22:22 Use C-style casts instead of compare to 0, to convert hb_bool_t to bool
Behdad Esfahbod 67a36a72 2015-11-26T18:48:42 Fix vertical GPOS This was brorken earlier, though, it's really hard to notice it. Unlike the glyph_h_origin(), an unset glyph_v_origin() does NOT mean that the vertical origin is at 0,0. Related to https://github.com/behdad/harfbuzz/issues/187
Behdad Esfahbod c41c145c 2015-11-26T18:43:15 Make nil glyph_h_origin() function return true Fixes https://github.com/behdad/harfbuzz/issues/187 Funcs implementations that have a non-zero horizontal origin must implement the glyph_h_origin() callback, nothing new here. Other implementations (all I know of!) can simply not set glyph_h_origin() now. I did that for hb-ot and hb-ft in 44f82750807475aa5b16099ccccd917d488df703, though that broke the fallback shaper because the default was returning false...
Behdad Esfahbod 766963ad 2015-11-24T15:38:43 Merge pull request #114 from ThePhD/vc++-fixes Fix all VC++ warnings and errors
Behdad Esfahbod b344af80 2015-11-24T15:30:27 Merge pull request #177 from fanc999/exporting Enable use of compiler directives to export symbols
Martin Hosken 1979f6fe 2015-11-23T10:03:56 Fix y_scale problems in hb-gr
Chun-wei Fan 835bbdc7 2015-11-19T18:34:12 Public headers: Decorate public symbols with HB_EXTERN This prepares the headers for exporting symbols using visibility attributes or __declspec(dllexport), so that we do not need to maintain symbols listing files, as this is what was and is done in GLib and GTK+.
ThePhD f798b8e2 2015-11-21T16:57:26 c-style cast
Behdad Esfahbod a6991813 2015-11-20T13:28:42 Merge pull request #176 from behdad/missing-braces Add braces for subobject initializer in _hb_font_funcs_nil
Behdad Esfahbod 1dc32ea4 2015-11-20T13:24:19 Whitespace
Behdad Esfahbod f94c0ecb 2015-11-20T13:21:29 Define HB_MARK_AS_FLAG_T as a macro instead of using templates The generic template operator overloading was causing more problems than it solved. Eg: https://github.com/behdad/harfbuzz/pull/163 https://github.com/behdad/harfbuzz/issues/175 So, just use macros. Fixes https://github.com/behdad/harfbuzz/issues/175 Fixes https://github.com/behdad/harfbuzz/pull/178
jfkthame f19c6db1 2015-11-20T08:43:49 Add braces for subobject initializer in _hb_font_funcs_nil To avoid triggering -Wmissing-braces; see https://bugzilla.mozilla.org/show_bug.cgi?id=1226175#c8
Behdad Esfahbod 9cc1ed4f 2015-11-19T12:39:09 Do not allow recursiving to same position and same lookup This is just to make it harder to be extremely slow. There definitely are ways still, just harder. Oh well... how do we tame this problem without solving halting problem?! Fixes https://github.com/behdad/harfbuzz/issues/174
Behdad Esfahbod 13188cba 2015-11-19T11:59:03 Revert "Fix hang in OOM situations" This reverts commit f0599db761d7fc2d585d86e757a797f75ebc7499. Commit abadc1717d997b69f987fdf1be9e12156d2d13d6 provides a better fix for this.
Behdad Esfahbod 18e1c6b6 2015-11-19T11:50:58 Revert "Make sure we make progress in OOM situations" This reverts commit 68b507a3c3c62c28c38e13fee733702bb703b6ca. Commit abadc1717d997b69f987fdf1be9e12156d2d13d6 provides a better fix for this.
Behdad Esfahbod 63fe05c8 2015-11-18T23:52:34 Fix make distcheck
Behdad Esfahbod 37b40cd8 2015-11-18T23:04:45 Fix another move_to assertion failure If buf->idx is at end, don't set end past it... Fixes https://github.com/behdad/harfbuzz/issues/173
Behdad Esfahbod abadc171 2015-11-18T17:52:08 Try to better handle OOM situations Fixes assert fail in https://github.com/behdad/harfbuzz/issues/161 with libharfbuzz-fuzzing.
Behdad Esfahbod ff16ef33 2015-11-18T16:27:32 Enable building a bounded version of the library for fuzzing test/fuzzing/hb-fuzzer links against libharfbuzz-fuzzing.so now.
Behdad Esfahbod e0082ae6 2015-11-17T18:42:13 Move things around
Chun-wei Fan 167c3271 2015-11-09T17:17:56 Fix build on MSVC >= 2012 Use the DEFINE_ENUM_FLAG_OPERATORS macro in winnt.h on Visual Studio, which defines the bitwise operators for the enumerations that we want to mark as hb_mark_as_flags_t, which will take care of the situation on newer Visual Studio (>= 2012), where the build breaks with C2057 errors as the underlying types of the enumerations is not clear to the compiler when we do a bitwise op within the declaration of the enumerations themselves. Also disable the C4200 (nonstandard extension used : zero-sized array in struct/union) and C4800 ('type' : forcing value to bool 'true' or 'false' (performance warning)) warnings as the C4200 is the intended scenario and C4800 is harmless but is so far an unavoidable side effect of using DEFINE_ENUM_FLAG_OPERATORS.
Chun-wei Fan 4d27bb87 2015-11-06T14:28:30 hb-ot-shape-complex-arabic.cc: Fix build on Visual Studio Visual Studio does not like declaring a enum variable within a for statement, so fix the build by declaring the enum before doing the for loop.
Behdad Esfahbod d5f0d7c9 2015-11-07T07:50:58 Merge pull request #167 from KonstantinRitt/unicode_cp_opt Micro optimizations to UTF-16 and UTF-32 codecs
Behdad Esfahbod 04ff23e7 2015-11-06T16:29:44 [arabic] Improve stretch length calculation Err on the side of being too short, than too wide. Reduces chance of overlaps with neighboring glyphs.
Behdad Esfahbod 59821ab8 2015-11-06T16:27:44 [arabic] Don't stretch over cased letters Addresses https://github.com/behdad/harfbuzz/commit/6e6f82b6f3dde0fc6c3c7d991d9ec6cfff57823d#commitcomment-14248516
Behdad Esfahbod 5337db29 2015-11-06T16:18:09 Revert "Don't process lookups if buffer is in error" This reverts commit f92bd86cc8c11d262d1830c631cb7c63fc9d4bc8. We don't want to be like cairo, where as soon as there's an error, nothing works anymore. So, lets process lookups as long as there's no new memory needed. That's also a model that hides fewer bugs.
Konstantin Ritt 529a9331 2015-11-07T02:00:04 Micro optimization to hb_utf16_t and hb_utf32_t ::prev() Implement reverse lookup instead of re-using next()
Konstantin Ritt 44ae9be7 2015-11-07T01:58:38 Nano optimization to hb_utf16_t and hb_utf32_t ::next()
Behdad Esfahbod f1c4adbc 2015-11-06T09:46:05 Fix typo
Behdad Esfahbod 68b507a3 2015-11-06T00:09:26 Make sure we make progress in OOM situations
Behdad Esfahbod f0599db7 2015-11-05T23:52:41 Fix hang in OOM situations Fixes https://github.com/behdad/harfbuzz/issues/161
Behdad Esfahbod f92bd86c 2015-11-05T23:52:29 Don't process lookups if buffer is in error
Behdad Esfahbod 4301703b 2015-11-05T23:44:59 Limit buffer max size growth https://github.com/behdad/harfbuzz/issues/161
Behdad Esfahbod 6e6f82b6 2015-11-05T17:29:03 Implement SYRIAC ABBREVIATION MARK with 'stch' feature The feature is enabled for any character in the Arabic shaper. We should experiment with using it for Arabic subtending marks. Though, that has a directionality problem as well, since those are used with digits... Fixes https://github.com/behdad/harfbuzz/issues/141
Behdad Esfahbod c743ec58 2015-11-05T17:33:57 [ft] Fix extents with negative scales Fixes https://github.com/behdad/harfbuzz/issues/162
Behdad Esfahbod 73fec399 2015-11-05T15:22:18 Reserve a few scratch-flags bits for complex shapers
Behdad Esfahbod 13686337 2015-11-05T13:24:15 Add new shaper method postprocess_glyphs() Unused currently. To be used for Syriac stretch implementation. https://github.com/behdad/harfbuzz/issues/141
Behdad Esfahbod e95eb23a 2015-11-04T22:55:11 Don't try zeroing marks by GDEF if there are no non-ASCII This one is a hack, but should be ok.
Behdad Esfahbod 7fa54ed7 2015-11-04T22:54:49 Don't try zeroing mark attachments by Unicode if there's no non-ASCII
Behdad Esfahbod 550bd14d 2015-11-04T22:58:58 Actually commit changes for previous commit
Behdad Esfahbod ff31b3c1 2015-11-04T22:42:41 Skip GPOS cursive / attachment adjustmnent if none happened I'm starting to really like how free these new scratch_flags are.
Behdad Esfahbod 0f407325 2015-11-04T22:28:44 Minor
Behdad Esfahbod 497a6c20 2015-11-04T22:24:19 Skip forming clusters if text is all ASCII
Behdad Esfahbod 28de104f 2015-11-04T22:00:25 Move variable-sized struct member to end Hopefully makes clang build happy
Behdad Esfahbod 5bc28b5f 2015-11-04T21:53:16 Optimize positioning for when h_origin is nil
Behdad Esfahbod 762770c9 2015-11-04T21:42:55 Add font->has_...() to check for individual nil font funcs Hopefully this wouldn't break any compiler. There was some magic moments to getting this to compile...
Behdad Esfahbod 88e9a9bc 2015-11-04T21:16:26 Minor reshaping of hb_font_funcs_t implementation In anticipation of further changes. No functional changes.
Behdad Esfahbod a6a7715b 2015-11-04T20:51:21 Comments
Behdad Esfahbod 6c48ec83 2015-11-04T20:47:42 [ot] Remove font funcs that do nothing
Behdad Esfahbod 75ea2daa 2015-11-04T20:43:59 [ot] Port ot font funcs to allocated object
Behdad Esfahbod 44f82750 2015-11-04T20:40:05 [ft] Remove font funcs that do nothing
Behdad Esfahbod 7918c261 2015-11-04T20:37:49 [ft] Port ft font funcs to allocated object
Behdad Esfahbod da29b437 2015-11-04T20:22:44 Separate nil font-funcs from parent-peeking font-funcs API change: all fonts created with hb_font_create() now inherit from (ie have parent) hb_font_get_empty().
Behdad Esfahbod bee901b3 2015-11-04T19:28:17 Optimize positioning direction calculations It makes the binary smaller AND faster. Yumm!
Behdad Esfahbod e3e4bb01 2015-11-04T18:58:02 Don't do fractions if buffer is ASCII-only
Behdad Esfahbod 6986208b 2015-11-04T18:46:22 Optimize runs without Default_Ignorable's Now that we have a buffer-wide scratch flags facility, use it to optimize away a few passes.
Behdad Esfahbod 14c2de32 2015-11-04T18:00:57 Limit max edits during sanitize to 8 Used to be 100. If a tabe needs more than one or two edits, it's probably completely bogus... Might help with speeding up fuzzing for https://github.com/behdad/harfbuzz/issues/157
Behdad Esfahbod 9cbc39ae 2015-11-04T18:00:53 Minor
Behdad Esfahbod 52e6c4e1 2015-11-04T17:45:06 If font doesn't support U+2011, fall back to U+2010 Test passes now.
Behdad Esfahbod 75483aaf 2015-11-04T17:43:36 Untangle if/else waterfall
Behdad Esfahbod 49ef6309 2015-11-04T17:27:07 Adjust the width of various spaces if font does not cover them See discussion here: https://github.com/behdad/harfbuzz/commit/81ef4f407d9c7bd98cf62cef951dc538b13442eb There's no way to disable this fallback, but I don't think it would be needed. Let's hope for the best! Fixes https://github.com/behdad/harfbuzz/issues/153
Behdad Esfahbod aa7044de 2015-11-04T16:25:57 Generalize flags types
Behdad Esfahbod 7793aad9 2015-11-04T14:48:46 Normalize various spaces to space if font doesn't support This resurrects the space fallback feature, after I disabled the compatibility decomposition. Now I can release HarfBuzz again without breaking Pango! It also remembers which space character it was, such that later on we can approximate the width of this particular space character. That part is not implemented yet. We normalize all GC=Zs chars except for U+1680 OGHA SPACE MARK, which is better left alone.
Behdad Esfahbod 85658394 2015-11-04T14:46:52 Protect against possible invalid-memory access after OOM
Behdad Esfahbod 4cc80bed 2015-11-04T14:46:10 Fix typo! Ouch! Fortunately that function was unused.
Behdad Esfahbod 9ac4b965 2015-11-04T14:18:39 Add Unicode space category Unused so far.
Behdad Esfahbod 8249ec3f 2015-11-04T13:26:17 Make top-byte of unicode_props available to be used differently per-GC
Behdad Esfahbod cc5d3a33 2015-11-04T13:21:25 Towards using top-byte of unicode-props for more things
Behdad Esfahbod 2f38dde5 2015-11-04T13:17:33 Add _hb_glyph_info_is_unicode_mark() Unused right now.
Behdad Esfahbod 90d75f93 2015-11-03T12:58:12 Tighten ccc-setting a bit and document it
Behdad Esfahbod df698f32 2015-11-03T12:15:12 [ot-font] Fix hmtx table length checking, *again* Exactly the same problem that I fixed in 63ef0b41dc48d6112d1918c1b1de9de8ea90adb5 I rewrote the table checking yesterday in 67f8821fb25d9bd55719f5e29a582ae1af4b02b3 and introduced the exact same issue again. :( Good thing we have ongoing fuzzing going now. Was discovered immediately by libFuzzer. Thanks kcc! https://github.com/behdad/harfbuzz/issues/139#issuecomment-153449473 Fixes https://github.com/behdad/harfbuzz/issues/156
Behdad Esfahbod ed2024ef 2015-11-02T17:58:12 [perf] Micro-optimize
Behdad Esfahbod 76a5310a 2015-11-02T17:52:45 Remove irrelevant comment I tried moving the is_default_ignorable() function to an INTERNAL function. That made the binary size grow by 5k AND things got a tad bit slower!
Behdad Esfahbod 8259669f 2015-11-02T17:44:05 Minor
Behdad Esfahbod 9382c471 2015-11-02T17:36:51 Combine unicode_props0/1 into a uint16 Slightly faster. In prep for more changes.