src


Log

Author Commit Date CI Message
Behdad Esfahbod 61820bc4 2015-01-26T14:25:52 [API] Add hb_buffer_add_latin1() This is by no ways to promote non-Unicode encodings. This is an entry point that takes Unicode codepoints that happen to all be the first 256 characters and hence fit in 8bit strings. This is useful eg in Chrome where strings that can fit in 8bit are implemented that way, and this avoids copying into UTF-8 or UTF-16. Perhaps we should rename this to hb_buffer_add_codepoints8(). I'm also curious if anyone would be really interested in hb_buffer_add_codepoints16(). Please discuss!
Behdad Esfahbod 78c6e86c 2015-01-26T14:08:36 Fix hb_buffer_add_codepoints to actually NOT validate
Konstantin Ritt f3537b62 2015-01-25T09:50:51 Move some code around Just to keep Windows specific workarounds in a single place.
Konstantin Ritt afb62d88 2015-01-25T08:16:26 Do not define MemoryBarrier on WinCE There is a _HBMemoryBarrier() wrapper function that emulates MemoryBarrier() behavior when it is not defined.
Konstantin Ritt 7db326a1 2015-01-25T08:13:24 Fix build on WinRT There is no environment (like WinCE) and the basic version of InitializeCriticalSection is unsupported. https://codereview.qt-project.org/#/c/92496/
Behdad Esfahbod a319d077 2015-01-23T12:44:24 [ft] Handle negative x_scale / y_scale
Behdad Esfahbod b0b38bb8 2015-01-21T19:19:33 [coretext] Fix positioning of notdef
Behdad Esfahbod 70622e50 2015-01-21T18:50:57 [coretext] Fix scaling Before we were not accounting for possible differences in x_scale and y_scale, as well as the signs of those. All should be in good shape now.
Behdad Esfahbod 221ba02b 2015-01-21T16:42:09 [coretext] Use vertical advance for notdef in vertical direction
Behdad Esfahbod 7988da24 2015-01-21T18:33:50 Add convenience make target "make lib" in src/
Behdad Esfahbod 67dfa8c7 2015-01-19T17:00:31 When matching second glyph of kerning pairs, use bsearch Roboto has glyphs (like 'F') that have 200 kerning pairs. Add a handcoded bsearch instead of previous linear search. This doesn't show much speedup though, apparently we spend the bulk of the time somewhere before here.
Behdad Esfahbod e9f5c65b 2015-01-19T14:42:11 [bindings] Minor
Roozbeh Pournader 5eb939dd 2015-01-18T14:30:08 Change New Tai Lue shaping engine from SEA to default This is to reflect the UTC decision to change the encoding model of New Tai Lue from logical to visual to be similar to Thai, Lao, and Tai Viet: http://www.unicode.org/L2/L2014/14250.htm#141-C26 The visual encoding is already the current practice of encoding New Tai Lue on the web anyway: http://www.unicode.org/L2/L2014/14195-newtailue.txt Fixes behdad/harfbuzz#66.
Behdad Esfahbod 1aaa7d67 2015-01-17T20:16:56 [indic] Fix out-of-bounds access
Behdad Esfahbod 238d6a38 2015-01-07T10:51:44 [bindings] Update sample.py
Behdad Esfahbod 2cd53235 2015-01-06T19:16:38 [bindings] Use hb_glib_blob_create() in sample hb_blob_create() is considered C-only API.
Behdad Esfahbod 0ef179e2 2015-01-06T16:58:33 [glib] Add hb_glib_blob_create() that takes GBytes
Behdad Esfahbod b91904a4 2015-01-06T15:43:14 [bindings] Replace deprecated allow-none with optional and nullable
Behdad Esfahbod 81a31f3e 2015-01-06T15:37:31 [bindings] Make sample Python 2/3 compatible
Behdad Esfahbod b632e799 2015-01-06T14:05:26 Fix up gobject-introspection a bit Minimal shaping works now!
Chris Peterson fb85d618 2015-01-04T19:31:10 Add #ifdef HB_USE_ATEXIT to fix -Wunused-function warnings
Chris Peterson d1897a98 2015-01-03T19:46:19 Fix hb_atomic_ptr_cmpexch -Wunused-value warnings
Behdad Esfahbod f34aaba8 2014-12-28T18:56:15 [ft] Don't set font ppem For discussion see: http://lists.freedesktop.org/archives/harfbuzz/2012-April/001905.html Over time we have had added NO_HINTING all over the place in hb-ft. Finish it off. Not setting ppem on hb-font disables get_contour_point() calls which is good anyway. See comments in the commit.
Behdad Esfahbod 350f3a02 2014-12-28T17:44:26 [ft] Add hb_ft_face_create_referenced() and hb_ft_font_create_referenced() When I originally wrote hb-ft, FreeType objects did not support reference counting. As such, hb_ft_face_create() and hb_ft_font_create() had a "destroy" callback and client was responsible for making sure FT_Face is kept around as long as the hb-font/face are alive. However, since this was not clearly documented, some clienets didn't correctly did that. In particular, some clients assumed that it's safe to destroy FT_Face and then hb_face_t. This, indeed, used to work, until 45fd9424c723f115ca98995b8f8a25185a6fc71d, which make face destroy access font tables. Now, I fixed that issue in 395b35903e052aecc97d0807e4f813c64c0d2b0b since the access was not needed, but the problem remains that not all clients handle this correctly. See: https://bugs.freedesktop.org/show_bug.cgi?id=86300 Fortunately, FT_Reference_Face() was added to FreeType in 2010, and so we can use it now. Originally I wanted to change hb_ft_face_create() and hb_ft_font_create() to reference the face if destroy==NULL was passed in. That would improve pretty much all clients, with little undesired effects. Except that FreeType itself, when compiled with HarfBuzz support, calls hb_ft_font_create() with destroy==NULL and saves the resulting hb-font on the ft-face (why does it not free it immediately?). Making hb-face reference ft-face causes a cycling reference there. At least, that's my current understanding. At any rate, a cleaner approach, even if it means all clients will need a change, is to introduce brand new API. Which this commit does. Some comments added to hb-ft.h, hoping to make future clients make better choices. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=75299
Behdad Esfahbod 9a3b7488 2014-12-28T17:27:39 Remove redundant check for FT_Face_GetCharVariantIndex We require FreeType >= 2.8.3. This symbol was introduced earlier than that.
Behdad Esfahbod affacf2f 2014-12-28T16:20:31 [ft] Open blob in READONLY mode HB_MEMORY_MODE_READONLY_MAY_MAKE_WRITABLE is deprecated and fairly useless now.
Behdad Esfahbod 395b3590 2014-12-28T16:03:26 Avoid accessing layout tables at face destruction "Fixes" https://bugs.freedesktop.org/show_bug.cgi?id=86300 Based on discussion someone else who had a similar issue, most probably the user is releasing FT_Face before destructing hb_face_t / hb_font_t. While that's a client bug, and while we can (and should) use FreeType refcounting to help avoid that, it happens that we were accessing the table when we didn't really have to. Avoid that.
Behdad Esfahbod 7d5e7613 2014-12-18T18:22:21 Fail blob creation if length overflows or is too large Fail if blob start plus length overflows; or if blob length is greater than 2GB. It takes a while for fonts to get to that size. In the mean time, it protects against bugs like this: http://www.icu-project.org/trac/ticket/11450 Also avoids some weird issues with 32bit vs 64bit systems as we accept length as unsigned int. As such, a length of -1 will cause overflow on 32bit machines, but happily accepted on a 64bit machine. Avoid that.
Behdad Esfahbod d5a50520 2014-12-18T18:09:41 Assert that blob length doesn't overflow address. This will crash now, if blob was created with wrong length. Check for that coming next commit.
Behdad Esfahbod 093c520d 2014-12-12T21:07:53 [otlayout] Mark variables that are C arrays as opposed to OT::ArrayOf
Behdad Esfahbod 9df0a520 2014-12-12T20:54:28 [otlayout] Avoid invalid access with Context format 3
Behdad Esfahbod 295ef1dd 2014-12-12T20:43:18 [ot] Debug get_coverage
Behdad Esfahbod 00f6a8e3 2014-12-12T20:36:49 [ot] Print format in dispatch trace
Behdad Esfahbod 5c7d6f02 2014-12-12T20:28:49 Minor
Behdad Esfahbod 153beebb 2014-12-12T19:46:09 [ot] Make sure all toplevel tables have tableTag
Behdad Esfahbod 282b13f9 2014-12-12T19:32:46 [sanitize] Improve debug output some more
Behdad Esfahbod 0766ee1f 2014-12-12T18:23:20 [sanitize] Improve debug output
Behdad Esfahbod e6f80fa1 2014-12-10T12:05:24 [indic] Allow ZWJ/ZWNJ before SM In Oriya, a ZWJ/ZWNJ might be added before candrabindu to encourage or stop ligation of the candrabindu. This is clearly specified in the Unicode section on Oriya. Allow it there. Note that Uniscribe doesn't allow this. Micro tests added using Noto Sans Oriya draft. No changes in numbers. Currently at: BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%) DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%) GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%) GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%) KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%) KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%) MALAYALAM: 1048147 out of 1048334 tests passed. 187 failed (0.0178378%) ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%) SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%) TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%) TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
Behdad Esfahbod fde3e4a4 2014-10-29T11:23:08 In hb_ot_collect_glyphs(), don't recurse to a lookup more than once Otherwise, we might process a lookup thousands of times, with no benefit. This pathological case was hit by Noto Nastaliq Urdu Draft in Firefox's code to determine whether space glyph is involved in any GSUB/GPOS rules. A test page is at http://behdad.org/urdu See: https://bugzilla.mozilla.org/show_bug.cgi?id=1090869
Behdad Esfahbod 5a5640d8 2014-10-14T21:26:13 Move code around
Behdad Esfahbod 666b42f7 2014-10-14T21:24:59 Move macros around Fixes https://bugs.freedesktop.org/show_bug.cgi?id=84491
Behdad Esfahbod 5c87120b 2014-10-14T20:07:31 Fix misc warnings Fixes https://github.com/behdad/harfbuzz/pull/51
Behdad Esfahbod 8afaf096 2014-10-02T16:40:41 [ft] Add NO_HINTING in a couple other places
Behdad Esfahbod 5de04073 2014-10-01T18:18:25 Help clang with gcov
Behdad Esfahbod c0b82ba3 2014-10-01T14:24:07 Create ragel-generated files in srcdir
Behdad Esfahbod 79bbb10b 2014-10-01T13:33:21 Clean ragel-generated headers in maintainercleanfiles
Behdad Esfahbod 8971cac8 2014-10-01T12:41:03 Don't use tmp files in Makefile Useful for code-coverage generation of the ragel-generated files as they will now contain the correct .hh filename in them.
Behdad Esfahbod 22723186 2014-10-01T11:56:07 check-static-inits: Filter out zero-length sections When compiling with -O0, zero-sized constructors were showing up and confusing the test.
Behdad Esfahbod b695a3dc 2014-10-01T11:55:14 check-static-inits: check for static finalizers
Behdad Esfahbod 250398b1 2014-10-01T11:28:01 Hide other bubble-sort
Behdad Esfahbod c1e87442 2014-10-01T11:07:08 Hide bubble-sort!
Behdad Esfahbod 15685299 2014-09-25T17:45:49 [ot-font] Add hb_ot_face_cmap_accelerator_t
Behdad Esfahbod d088ccaf 2014-09-25T17:26:56 [ot-font] Minor
Behdad Esfahbod d7c160a1 2014-09-25T17:15:35 [ot-font] Handle missing vertical metrics tables
Behdad Esfahbod be1cca27 2014-09-25T16:53:24 [ot-font] Add metrics_accel_t
Behdad Esfahbod d41b809e 2014-09-25T13:04:08 [ot-font] Start adding vertical support
Behdad Esfahbod 22f0de50 2014-08-25T12:54:57 Fix build
Behdad Esfahbod d457e3f0 2014-08-25T12:31:19 [arabic] Don't #include __FILE__ Fine! https://code.google.com/p/chromium/issues/detail?id=406957
Behdad Esfahbod 9ceb673d 2014-08-25T11:48:12 [arabic] Allow disabling win1256 fallback code By defining HB_NO_WIN1256.
Behdad Esfahbod 8a931950 2014-08-22T12:06:57 [ot] Prefer Windows platform cmap tables / accept all Unicode encodingIDs Some fonts on the Mac ship with (0,1).
Behdad Esfahbod 270971a0 2014-08-15T14:28:04 [win32] Avoid preprocessor warnings re macros
Behdad Esfahbod 8c6bd34d 2014-08-14T13:33:37 Fix check-symbols on OS X
Behdad Esfahbod 522b1cc5 2014-08-14T13:29:30 [coretext] Hide feature_mappings
Behdad Esfahbod 0d2c2f23 2014-08-14T13:25:55 Simplify hb-object
Behdad Esfahbod 9d861b81 2014-08-14T13:15:21 Really fix clang build this time
Behdad Esfahbod 272226f2 2014-08-14T13:11:33 Revert "Fix build on clang after previous commit" This reverts commit 9c80cbc87f23040a334e30c750f64523d9ef10c8.
Behdad Esfahbod 9c80cbc8 2014-08-14T13:09:52 Fix build on clang after previous commit
Behdad Esfahbod a5a27073 2014-08-14T13:05:36 Rewrite this==NULL checks to avoid undefined behavior Fixes https://code.google.com/p/chromium/issues/detail?id=403594
Behdad Esfahbod cc3b2d43 2014-08-14T12:59:16 Remove this==NULL check from face->reference_table() Not supposed to happen, and apparently this is undefined in C++. https://code.google.com/p/chromium/issues/detail?id=403594
Behdad Esfahbod cd7ea4f7 2014-08-14T12:57:02 Make hb_object_t members private In preparation for fixing: https://code.google.com/p/chromium/issues/detail?id=403594
Behdad Esfahbod 20076cc4 2014-08-12T19:26:35 [coretext] Add version guards for kCTLanguageAttributeName
Behdad Esfahbod 1b3011c2 2014-08-12T19:17:19 [coretext] Pass buffer language to CoreText
Behdad Esfahbod 3eb6a4db 2014-08-12T19:10:33 [coretext] Minor
Behdad Esfahbod 08acfe0d 2014-08-12T18:57:08 [hb-coretext] Fix cluster order of notdef runs in RTL text
Behdad Esfahbod 30eed75d 2014-08-12T17:15:09 [shape-plan] Fix typo! The only effect is, if shaper_list was not NULL and no shaper was found, we now don't insert anything into cache and return earlier.
Behdad Esfahbod dc9aba6f 2014-08-12T17:14:36 [shape-plan] Better debug messages
Behdad Esfahbod e956c65b 2014-08-12T17:03:27 [shape-plan] Simplify macro
Behdad Esfahbod 29e25550 2014-08-12T17:02:59 Fix gcc warning
Behdad Esfahbod 8d5eebc0 2014-08-12T16:50:22 [shape-plan] Fix shape-plan caching with more than one requested shaper Wasn't breaking out of loop, ouch! http://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1246370.html
Behdad Esfahbod bc3d0dc6 2014-08-12T16:49:18 [shape-plan] Add debug tracing
Behdad Esfahbod 81b8d977 2014-08-12T15:49:47 [coretext] Fix buffer resizing Was very broken. Now fixed and tested.
Behdad Esfahbod c3e924fb 2014-08-12T14:25:11 [coretext] Rewind scratch-allocated arrays when not needed anymore
Behdad Esfahbod 8fd4d70b 2014-08-12T13:12:31 [wince] Two more Windows CE fixes Report has it that it builds (and works) now: https://codereview.qt-project.org/#/c/92087/
Behdad Esfahbod fd0001d7 2014-08-12T10:32:41 [coretext] Compare CGFont and PS name, if CTFont didn't match See comments. Fixes vertical text. CoreText backend is in very good shape now! Also see: 5a0eed3b50629be4826e4e9428f2c3255195395d 25f4fb9b56bb3f8bec821571c78f8829e40daa54 Fixes http://github.com/behdad/harfbuzz/pull/36
Behdad Esfahbod 5a0eed3b 2014-08-11T23:47:16 [coretext] Implement vertical shaping Currently doesn't work though, we detect font fallback. Apparently matching on ct_font is not safe for this. Looks like commit 25f4fb9b56bb3f8bec821571c78f8829e40daa54 wasn't enough after all.
Behdad Esfahbod 1b55077f 2014-08-11T20:45:12 [coretext] Remove unnecessary alt_size Wasn't needed after a6b8dc87421de33746b0b14d86d2d1532aec02af.
Behdad Esfahbod 10b1104d 2014-08-11T20:02:45 [coretext] Use CFRunStatus Assert that all runs had expected direction, and take hint for non-monotone clusters.
Behdad Esfahbod fd1a6aa8 2014-08-11T20:01:37 [coretext] Minor
Behdad Esfahbod 130856c7 2014-08-11T19:16:26 [coretext] Remove debug printf!
Behdad Esfahbod b5fbc3b8 2014-08-11T18:40:01 API: Do not clear buffer-flags in hb_buffer_clear_contents() After 763e5466c0a03a7c27020e1e2598e488612529a7, one doesn't need to set flags for different pieces of text. The flags now are something the client sets up once, depending on how it actually uses the buffer. As such, don't clear it in clear_contents(). Tests updated.
Behdad Esfahbod 104484ce 2014-08-11T18:23:43 Minor
Behdad Esfahbod 4acce77d 2014-08-11T17:46:50 [coretext] Pass buffer direction to CoreText Have to use a CTTypesetter for this.
Behdad Esfahbod 5ec45dd3 2014-08-11T17:46:12 [coretext] Minor It's hard to handle all possible NULL returns from CoreText. Add one more...
Behdad Esfahbod 624a299b 2014-08-11T15:29:18 [coretext] Attach marks to base clusters Fixes https://githu.com/behdad/harfbuzz/issues/49 to the extent that it can be fixed.
Behdad Esfahbod 3c41ccb5 2014-08-11T15:11:59 [coretext] Use input clusters Before, this shaper was returning UTF-16 cluster indices instead of returning whatever cluster values the user had had set up in the buffer. Ouch!
Behdad Esfahbod a6b8dc87 2014-08-11T15:08:19 [coretext] Fix buffer resize handling We can't really resize buffer and continue in this shaper as we are using the scratch buffer for string_ref and log_cluster. Restructure shaper to retry from (almost) scratch.
Behdad Esfahbod 9b3c60c8 2014-08-11T13:25:43 [coretext] Always compute log_clusters To be used soon.
Behdad Esfahbod 15c633dd 2014-08-11T13:42:42 Minor
Behdad Esfahbod 9ce067c7 2014-08-11T02:04:38 [coretext] Simplify cluster mapping
Behdad Esfahbod 49f7fb63 2014-08-10T19:19:38 [coretext] Minor