|
8d05bf7d
|
2019-01-22T12:34:05
|
|
Fix cast-align error
If compiler doesn't inline StructAtOffset, this was an error since we
only disable cast-align at call-site. So, move the cast out.
../src/hb-machinery.hh: In instantiation of 'const Type& StructAtOffset(const void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:146:85: required from here
../src/hb-machinery.hh:63:12: error: cast from 'const char*' to 'const unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<const Type*> ((const char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:147:79: required from here
../src/hb-machinery.hh:66:12: error: cast from 'char*' to 'unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<Type*> ((char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
5d4b0377
|
2019-01-22T12:11:24
|
|
Convert unsigned enum class consts to static constexpr
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
|
|
|
3d9a6e62
|
2019-01-22T12:02:06
|
|
Whitespace
|
|
|
c81f02fd
|
2019-01-22T12:00:44
|
|
pragma GCC diagnostic error "-Wvla"
|
|
|
ef006549
|
2019-01-22T12:08:57
|
|
Convert tag enum class consts to static constexpr
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
|
|
|
70a52d6b
|
2019-01-22T12:15:23
|
|
Convert all other enum class consts to static constexpr
Fixes https://github.com/harfbuzz/harfbuzz/issues/1553
|
|
|
39e1b6d0
|
2019-01-22T12:07:43
|
|
Convert boolean enum class consts to static constexpr
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
|
|
|
271cb7c1
|
2019-01-22T12:05:35
|
|
Make some enum constants unsigned
|
|
|
380c3cff
|
2019-01-20T19:51:08
|
|
Use enum for class constant
|
|
|
6d042a18
|
2019-01-20T19:49:59
|
|
[CFF] Use enum for tableTag
|
|
|
c1cbbb94
|
2019-01-20T19:47:52
|
|
Use static constexpr for large class constants
|
|
|
043b610f
|
2019-01-19T09:20:46
|
|
Fix sign compare warnings
../../third_party/harfbuzz-ng/src/src/hb-map.hh(56,45): warning: comparison of integers of different signs: 'const hb_codepoint_t' (aka 'const unsigned int') and 'hb_map_t::(anonymous enum at ../../third_party/harfbuzz-ng/src/src/hb-map.hh:169:3)' [-Wsign-compare]
bool is_unused () const { return key == INVALID; }
|
|
|
ce317d03
|
2019-01-19T09:18:03
|
|
Fix warning
warning: '_WIN64' is not defined, evaluates to 0 [-Wundef]
|
|
0c2bd1b1
|
2019-01-19T16:30:07
|
|
[dwrite] Fix delete-non-virtual-dtor warning (#1550)
|
|
|
89bcfb20
|
2019-01-18T14:59:18
|
|
Remove TRACE_COLLECT_GLYPHS
|
|
|
f13b6786
|
2019-01-18T14:53:54
|
|
[pragma] Only add if GCC or clang
|
|
|
c2ea7a9d
|
2019-01-18T13:45:33
|
|
[directwrite] More fix
|
|
|
9714d3ec
|
2019-01-18T21:55:21
|
|
[dwrite] Try to fix delete-non-virtual-dtor warnings
Fixes #1548 hopefully
|
|
|
0772c06f
|
2019-01-18T12:53:06
|
|
Remove tracing from closure
|
|
|
d9f6be3a
|
2019-01-18T12:48:01
|
|
Fix -Wundef errors with __GNUC__
Fixes https://github.com/harfbuzz/harfbuzz/issues/1549
|
|
28917e58
|
2019-01-18T09:43:51
|
|
init interp_env_t::hintmask_size
fixes issue #1547
|
|
|
9b4e51b2
|
2019-01-18T12:23:02
|
|
[pragma] Enable error -Wdelete-non-virtual-dtor
Currently fails directwrite backend.
|
|
|
e6527228
|
2019-01-18T12:22:07
|
|
[directwrite] Fix error
hb-directwrite.cc: In constructor 'TextAnalysis::TextAnalysis(const wchar_t*, uint32_t, const wchar_t*, DWRITE_READING_DIRECTION)':
hb-directwrite.cc:489:18: error: 'TextAnalysis::mText' will be initialized after [-Werror=reorder]
const wchar_t* mText;
^~~~~
hb-directwrite.cc:488:12: error: 'uint32_t TextAnalysis::mTextLength' [-Werror=reorder]
uint32_t mTextLength;
^~~~~~~~~~~
hb-directwrite.cc:282:3: error: when initialized here [-Werror=reorder]
TextAnalysis (const wchar_t* text, uint32_t textLength,
^~~~~~~~~~~~
hb-directwrite.cc: In function 'hb_bool_t _hb_directwrite_shape_full(hb_shape_plan_t*, hb_font_t*, hb_buffer_t*, const hb_feature_t*, unsigned int, float)':
|
|
|
b900f780
|
2019-01-18T10:08:23
|
|
[pragma] More cast-align whitelist
|
|
|
0d8b931b
|
2019-01-18T10:03:43
|
|
[pragma] Allow cast-align in hb-font.cc
../src/hb-machinery.hh: In instantiation of 'const Type& StructAtOffset(const void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:144:85: required from here
../src/hb-machinery.hh:63:12: error: cast from 'const char*' to 'const unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<const Type*> ((const char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:145:79: required from here
../src/hb-machinery.hh:66:12: error: cast from 'char*' to 'unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<Type*> ((char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = int]':
|
|
|
a25174a5
|
2019-01-18T09:59:36
|
|
[pragma] GCC diagnostic error "-Wreorder"
|
|
|
46600905
|
2019-01-18T09:53:16
|
|
[pragma] GCC diagnostic warning "-Wmaybe-uninitialized"
|
|
|
7a634d7d
|
2019-01-18T09:49:14
|
|
[pragma] Massage more
|
|
|
16e5ba85
|
2019-01-18T09:46:17
|
|
[pragma] More
|
|
|
2bd530d5
|
2019-01-18T09:28:22
|
|
[pragma] Reorg again
https://github.com/harfbuzz/harfbuzz/issues/1546
|
|
|
c04272fa
|
2019-01-18T08:49:45
|
|
[pragma] GCC diagnostic ignored "-Wunknown-warning-option"
Try at fixing https://github.com/harfbuzz/harfbuzz/issues/1546
|
|
|
4d3c8f96
|
2019-01-17T19:58:54
|
|
[uniscribe] More warnings
|
|
|
6a5d2b21
|
2019-01-17T19:57:17
|
|
[uniscribe] Fix warnings
|
|
|
5b13e458
|
2019-01-17T19:52:32
|
|
Fix build
|
|
|
a77bd6bb
|
2019-01-17T19:33:41
|
|
[pragma] GCC diagnostic ignored "-Wclass-memaccess"
|
|
|
436c7b29
|
2019-01-17T19:03:33
|
|
[pragma] ignored -Wunsafe-loop-optimizations // TODO fix
|
|
|
e3b3181e
|
2019-01-17T19:02:06
|
|
[pragma] error -Wclass-memaccess
|
|
|
1a6b97a4
|
2019-01-17T18:55:03
|
|
[pragma] More
|
|
|
06e80916
|
2019-01-17T18:47:32
|
|
[pragma] More
|
|
|
1077e40b
|
2019-01-17T18:36:10
|
|
[pragma] Flesh out more
|
|
|
7e6bd510
|
2019-01-17T18:24:18
|
|
Use NNOffsetTo<> in rest of places
|
|
|
b1152d5e
|
2019-01-17T18:17:04
|
|
Use NNOffsetTo<>
|
|
|
205d72a1
|
2019-01-17T18:10:38
|
|
Add NNOffsetTo<>
|
|
|
c99d13d8
|
2019-01-17T17:56:27
|
|
[AAT] Comment
|
|
|
f39b5603
|
2019-01-17T17:49:55
|
|
Comment
|
|
|
347ad454
|
2019-01-17T17:47:29
|
|
[AAT] Remove unused code
|
|
|
b344d438
|
2019-01-17T17:44:39
|
|
[AAT] Allow null in ankr lookupTable offset
|
|
|
14a560a2
|
2019-01-17T17:42:44
|
|
[pragma GCC] Ignore -Wtype-limits
|
|
|
3f2daae6
|
2019-01-17T15:27:31
|
|
More GCC pragmas
|
|
|
d6c5473e
|
2019-01-17T15:22:46
|
|
Rename macro
|
|
|
a9946b7c
|
2019-01-17T15:22:28
|
|
Add more GCC warning pragmas
|
|
|
868b0c0c
|
2019-01-17T15:08:36
|
|
Move -Wcast-align to hb.hh
|
|
|
8874eef8
|
2019-01-17T15:04:44
|
|
Add pragram GCC diagnostic ignored "-Wunused-macros"
|
|
|
cc8e9a43
|
2019-01-17T14:54:32
|
|
[AAT] Fully sanitize ankr table at sanitize time
Third try to fix access. Followup 6879efc2c1596d11a6a6ad296f80063b558d5e0f
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12532
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=922303
|
|
|
6879efc2
|
2019-01-17T14:06:37
|
|
[AAT] Fix anchor bound checking, again
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12532
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=922303
|
|
|
a262eb3d
|
2019-01-17T14:06:32
|
|
[aat] Minor
|
|
|
c986ca15
|
2019-01-15T13:58:19
|
|
Improve overflow avoidance
Better fix for 480406cd3ef9e5ab8476ddfa04498bf23906c508
This way we behave the same on 32bit and 64bit archs.
|
|
|
0d2727f4
|
2019-01-14T18:23:17
|
|
fix FDSelect fuzzing bug (#1539)
Rewrote struct FDSelect3_4.ranges as ArrayOf
Updated FDSelect3_4::sanitize () to call ranges.sanitize ()
nRanges now a function to return a reference to ranges.len
|
|
|
9f6172d6
|
2019-01-14T20:45:31
|
|
Move _POSIX_SOURCE definition
Fixes https://github.com/harfbuzz/harfbuzz/issues/1308
|
|
|
480406cd
|
2019-01-14T15:27:34
|
|
Fix assertion on address overflow
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=917031
|
|
|
7a6686a5
|
2019-01-14T15:09:14
|
|
[AAT] Fix mort ContextualSubtable offset access
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12312
|
|
|
a3fa7d33
|
2019-01-14T14:37:36
|
|
[AAT] Fix ankr table access
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=918340
|
|
|
760303d4
|
2019-01-11T15:27:35
|
|
deleted a duplicate fontdicts_mod.fini() call (#1538)
|
|
|
7b48641a
|
2019-01-08T12:37:48
|
|
fix leak in subset_enc_supp_codes (#1537)
oss-fuzz issue 12310
|
|
|
97f67a3c
|
2019-01-04T23:10:39
|
|
[ci] Enable more of GCC compile warnings (#1533)
|
|
26c5b54f
|
2018-12-31T04:30:43
|
|
CircleCI: Test for Python 3 syntax errors and undefined names (#1522)
Catch missing imports and errors like #1520 and #1521
__E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org) issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
|
|
|
f4da28b1
|
2018-12-30T12:58:34
|
|
Python 3 fixes to gen-os2-unicode-ranges.py (#1521)
In Python 3, __reload()__ was moved and __sys.setdefaultencoding()__ because the default is already utf-8. Also __Error()__ is an _undefined name_ and __Exception()__ creates a generic exception.
|
|
|
d092fb27
|
2018-12-30T01:53:03
|
|
Ouch! Fix build on C++<11
|
|
|
89949ed2
|
2018-12-30T01:52:19
|
|
Fix ubsan with passing nullptr to qsort()
|
|
|
357a0a7a
|
2018-12-27T18:29:23
|
|
Fix build on C++ < 11
|
|
|
54c0a173
|
2018-12-27T18:27:36
|
|
[vector] Fix warning
|
|
|
1043ddbe
|
2018-12-27T18:27:11
|
|
[aat] Minor
|
|
|
71da9ca6
|
2018-12-27T18:01:06
|
|
[vector] Remove use of arrayZ() by using casts
|
|
|
fa333e34
|
2018-12-27T17:56:22
|
|
[vector] Remove static_array
Was good idea, but with C++ types with constructor/destructor, was getting in
the way as compiler was destructing those items where it was not desired.
Since C++ does not allow zero-sized arrays, just remove it...
|
|
|
ab2258a4
|
2018-12-27T17:45:05
|
|
[vector] Use allocated = -1 to signify failure
|
|
|
09fa536d
|
2018-12-27T08:33:09
|
|
fix lealk with cff2::accelerator_templ_t::topDict (#1517)
|
|
|
3b81442c
|
2018-12-24T11:31:04
|
|
[vector] Change pre-alloced count from 8 to 2
I'm thinking about dropping it to zero, but that needs slight code changes.
|
|
|
d25a2f14
|
2018-12-23T20:19:52
|
|
Fix a few warnings
|
|
|
85003b59
|
2018-12-22T16:19:10
|
|
[iter] Fix warning
|
|
|
e4355b1c
|
2018-12-22T16:11:22
|
|
[set] Add iter_t as alias to const_iter_t
|
|
|
33f8de61
|
2018-12-22T15:10:18
|
|
[set] Change to const_iter
|
|
|
f88fed5c
|
2018-12-22T11:11:10
|
|
[set] Cache length in iterator
|
|
|
d0a706c7
|
2018-12-22T19:47:48
|
|
Minor, remove redundant inline
|
|
|
ae6e348d
|
2018-12-22T19:47:29
|
|
Minor, tweak spaces
|
|
|
29f0b6bc
|
2018-12-22T07:47:04
|
|
CFF renaming (#1507)
* reimplement ByteStr as byte_str_t based on hb_ubytes_t
Unuse start_embed<ByteStr>
Also renamed SubByteStr to byte_str_ref_t
More renaming to come
* substr renamed to str_ref in line with its type byte_str_ref_t
* uncamelize non-table struct names
* uncamelized non-struct types OpCode etc
* add byte_str_t copy ctor
* test
* test2
* undo tests
* fix bot failure
* undo the previous change
* fixed tabs, added inline
* Revert "fixed tabs, added inline"
This reverts commit 21163c30e9d18759414f7fe2518628241599f039.
* fix tabs
|
|
|
89d04129
|
2018-12-21T20:07:52
|
|
[set] Actually derive iterator from hb_sorted_iter_t<>
|
|
|
fc35919d
|
2018-12-21T20:06:17
|
|
[set] Implement unified iterator
|
|
|
4911e67d
|
2018-12-21T20:00:52
|
|
[set] Mark some internals protected
|
|
|
954b9854
|
2018-12-21T19:55:02
|
|
[iter] Add hb_sorted_iter_t<>
|
|
|
b205105c
|
2018-12-21T19:48:21
|
|
[iter] Change operator[] operand to be signed
To fix older compilers again (this was the case in hb_array_t).
hb-ot-layout-common.hh:1353: note: candidate 2: operator[](T*, int) <built-in>
hb-ot-layout-common.hh:1354: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-iter.hh:63: note: candidate 1: Item& hb_iter_t<Iter, Item>::operator[](unsigned int) const [with Iter = hb_array_t<const OT::IntType<short unsigned int, 2u> >, Item = const OT::IntType<short unsigned int, 2u>]
hb-ot-layout-common.hh:1354: note: candidate 2: operator[](T*, int) <built-in>
hb-ot-layout-common.hh: In member function 'bool OT::ClassDef::serialize(hb_serialize_context_t*, hb_array_t<const OT::IntType<short unsigned int, 2u> >, hb_array_t<const OT::IntType<short unsigned int, 2u> >)':
hb-ot-layout-common.hh:1490: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
hb-iter.hh:63: note: candidate 1: Item& hb_iter_t<Iter, Item>::operator[](unsigned int) const [with Iter = hb_array_t<const OT::IntType<short unsigned int, 2u> >, Item = const OT::IntType<short unsigned int, 2u>]
hb-ot-layout-common.hh:1490: note: candidate 2: operator[](T*, int) <built-in>
|
|
|
25786f49
|
2018-12-21T19:29:00
|
|
[array] Port to hb_iter_t<>
hb_array_t is its own iterator...
|
|
|
2a33ab05
|
2018-12-21T18:49:27
|
|
[iter] Change __more__ to fallback to __len__
|
|
|
474a1205
|
2018-12-21T18:46:51
|
|
[array/vector] Rename len to length
|
|
|
2fc1860a
|
2018-12-21T18:09:45
|
|
[iter] Split hb_iter_t<> into hb_iter_t<> and hb_iter_mixin_t<>
|
|
|
865deeb3
|
2018-12-21T17:35:58
|
|
Adjust internal header dependencies
|
|
|
8e5c2bc6
|
2018-12-21T17:29:11
|
|
[Makefile.am] Minor
|
|
|
f419cef4
|
2018-12-21T17:22:09
|
|
[iter] Include from hb.hh
|
|
|
7557e348
|
2018-12-21T17:21:19
|
|
[iter] Move hb_fill() and hb_copy() to hb-iter.hh
|
|
|
5e1840e0
|
2018-12-21T16:39:57
|
|
[iter] Disallow copy-construction or assignment of hb_iter_t<>
Should only be done by subclass.
|
|
|
65e8bd56
|
2018-12-21T16:20:30
|
|
[iter] Fix hb_copy() return value
|