src


Log

Author Commit Date CI Message
Behdad Esfahbod c2b151d9 2014-08-10T18:52:07 Fix hb_in_range() for types smaller than int As exercised by hb-coretext .notdef code.
Behdad Esfahbod 26a963b9 2014-08-10T18:04:50 [wince] Try to fix some stuff on Windows CE Based on errors seen here: http://testresults.qt-project.org/ci/QtBase_dev_Integration/build_03837/wince70embedded-armv4i-msvc2008_Windows_7/log.txt.gz Fully untested.
Behdad Esfahbod 92aeee3f 2014-08-10T17:42:19 Minor
Behdad Esfahbod b9993d8d 2014-08-10T17:40:24 [coretext] Fix assert on Yosemite Apparently those functions documented as sometimes returning NULL actually exercise that right in OS X 10.10 Yosemite. The scratch was too small for that. I *think* I fixed it, but haven't tested as I don't have Yosemite.
Behdad Esfahbod 087733dd 2014-04-18T11:21:08 [coretext] Use CGFont as face_data
Behdad Esfahbod d277c3d7 2014-08-07T15:38:52 [arabic] Bug 82306 - Mandaic had errors in its Unicode Joining_Type Fixes https://bugs.freedesktop.org/show_bug.cgi?id=82306
Behdad Esfahbod 38fb30d7 2014-08-06T13:34:49 Use atexit() only if it's safe to call from shared library Apparently they are not (advertised as?) safe on BSD systems. We ignore the case of static libraries. Whitelisted on glibc, Android, and MSVC / mingw. https://bugs.freedesktop.org/show_bug.cgi?id=82246
Behdad Esfahbod d5e61470 2014-08-05T14:19:01 [arabic] Fix fallback shaping regression Was broken in 615d00ea252739da57edbd980ff27e573. Fixes https://github.com/behdad/harfbuzz/pull/48 Micro-test added.
Behdad Esfahbod d7c850f8 2014-08-02T17:46:38 [uniscribe] Minor
Behdad Esfahbod 8f3eebf7 2014-08-02T17:18:46 Make sure gsubgpos buffer vars are available during fallback_position Add buffer var allocation asserts to a few key places.
Behdad Esfahbod 2053f369 2014-08-02T16:31:16 Disable 'liga' for vertical text The reason we turned it on is because Kazuraki uses it. But that's not reason enough. Until the OpenType spec gets its act together re adding design-direction to lookups, this is better user experience.
Behdad Esfahbod 763e5466 2014-08-02T16:17:44 Make it easier to use HB_BUFFER_FLAG_BOT/EOT Previously, we expected users to provide BOT/EOT flags when the text *segment* was at paragraph boundaries. This meant that for clients that provide full paragraph to HarfBuzz (eg. Pango), they had code like this: hb_buffer_set_flags (hb_buffer, (item_offset == 0 ? HB_BUFFER_FLAG_BOT : 0) | (item_offset + item_length == paragraph_length ? HB_BUFFER_FLAG_EOT : 0)); hb_buffer_add_utf8 (hb_buffer, paragraph_text, paragraph_length, item_offset, item_length); After this change such clients can simply say: hb_buffer_set_flags (hb_buffer, HB_BUFFER_FLAG_BOT | HB_BUFFER_FLAG_EOT); hb_buffer_add_utf8 (hb_buffer, paragraph_text, paragraph_length, item_offset, item_length); Ie, HarfBuzz itself checks whether the segment is at the beginning/end of the paragraph. Clients that only pass item-at-a-time to HarfBuzz continue not setting any flags whatsoever. Another way to put it is: if there's pre-context text in the buffer, HarfBuzz ignores the BOT flag. If there's post-context, it ignores EOT flag.
Behdad Esfahbod 0a5ae933 2014-08-02T15:00:34 Merge branch 'win1256'
Behdad Esfahbod 6ab6be32 2014-08-02T14:58:38 [arabic/win1256] Remove unused MultipleSubst macros
Behdad Esfahbod abfa4252 2014-08-01T19:05:33 [arabic/win1256] Really fix lam-alef this time https://bugzilla.mozilla.org/show_bug.cgi?id=1045139#c26 https://github.com/behdad/harfbuzz/commit/b276e897d17519a2c28f79d024904ac2bdd86bcf#commitcomment-7243499
Behdad Esfahbod 55977f2a 2014-08-01T16:14:33 [arabic/win1256] Hook up lamMedi lookup Restructure lookup array to accommodate. https://bugzilla.mozilla.org/show_bug.cgi?id=1045139#c18
Behdad Esfahbod e839e252 2014-08-01T16:09:31 [arabic/win1256] Fix TEH MARBUTA final form https://bugzilla.mozilla.org/show_bug.cgi?id=1045139#c18
Behdad Esfahbod a2de1932 2014-07-31T18:21:05 [arabic/win1256] Fix shaping of JEEM, HAH, and KHAH https://bugzilla.mozilla.org/show_bug.cgi?id=1045139#c16
Behdad Esfahbod 1789ccb1 2014-07-31T11:04:00 [arabic/win1256] Remove GCC'ism The table can now compile independently too. If we cannot make it work on MSVC, we can always generate the data and distribute it. The code now compiles cleanly with: gcc -c -xc -std=c99 -Werror -pedantic hb-ot-shape-complex-arabic-win1256.hh g++ -c -xc -std=c++1x -Werror -pedantic hb-ot-shape-complex-arabic-win1256.hh See: https://github.com/behdad/harfbuzz/commit/a97f537cec209649302899975d76ca2b2661da7a#commitcomment-7218736
Behdad Esfahbod f28b1c82 2014-07-30T02:15:44 [arabic] Implement Windows-1256 private shaping Bug 1045139 - The Arabic text with "MS Sans Serif" font is rendered bad https://bugzilla.mozilla.org/show_bug.cgi?id=1045139 This is only enabled on Windows platforms, and requires support from Uniscribe to work. But for clients that do hook up to Uniscribe, this fixes shaping of Windows-1256-encoded bitmap fonts like "MS Sans Serif". The code and table together have just less than a 1kb footprint when enabled. UNTESTED. I might even have broken regular Arabic fallback shaping.
Behdad Esfahbod ac53443f 2014-07-31T18:51:37 [hangul] Don't apply 'calt' See comments. Micro-test added.
Behdad Esfahbod 88911e8c 2014-07-29T19:47:26 Minor
Behdad Esfahbod 9e834e29 2014-07-26T20:34:01 [hebrew] Zero mark advance by GDEF late Seems to be what Uniscribe does. At this point I think it's work checking our default... Fixes Bug 76767 - Zeroing of advance of 2nd component of multiple substitution with SBL Hebrew https://bugs.freedesktop.org/show_bug.cgi?id=76767 Micro-test added.
Behdad Esfahbod 6f2d9ba5 2014-07-26T19:17:44 Add old-Myanmar shaper Looks like Unsicribe responds to the 'mymr' tag by zeroing marks GDEF_LATE instead of generic-shaper UNICODE_LATE. Implement that. Fixes Bug 81775 - Incorrect Rendering with harfbuzz-ng myanmar unicode https://bugs.freedesktop.org/show_bug.cgi?id=81775 Micro-test added based on Padauk.
Behdad Esfahbod 595d2b96 2014-07-26T18:44:15 Minor
Behdad Esfahbod fe6788bc 2014-07-25T12:40:56 Typo
Behdad Esfahbod 6e69200a 2014-07-25T12:30:47 Fix snprintf() format Patch from Maks Naumov. Fixes https://github.com/behdad/harfbuzz/pull/22
Behdad Esfahbod 5c5cdbbd 2014-07-25T12:21:49 Make sure broken feature strings are not partially parsed If user doesn't check hb_feature_from_string() return value, we don't want them to end up see the partially-parsed feature.
Behdad Esfahbod a795fe63 2014-07-25T12:15:33 Allow quotation marks around feature tag in hb_feature_from_string() With this, I believe we accept CSS feature strings completely.
Behdad Esfahbod 3f646184 2014-07-25T12:04:27 Allow space at the end of feature string with values, eg 'dlig=1 '
Behdad Esfahbod f31f7d22 2014-07-25T12:03:52 Minor
Behdad Esfahbod 60cb18a5 2014-07-25T12:01:22 Allow on/off in hb_feature_from_string() We now allow things like "dlig on" / "dlig=on".
Behdad Esfahbod d9e618ec 2014-07-25T11:56:01 Remove duplicate definition of ISALNUM It's defined in hb-private.h already.
Behdad Esfahbod 2ee5f665 2014-07-25T11:53:46 Fix parsing of features like "- liga" (with the space)
Behdad Esfahbod e15fa7a8 2014-07-25T11:44:35 Do not require the '=' in hb_feature_from_string() Towards accepting CSS font-feature-settings strings.
Behdad Esfahbod f4fe9bae 2014-07-25T11:39:55 Reject tags longer than 4 chars in hb_feature_from_string()
Behdad Esfahbod 7e8c3895 2014-07-25T11:18:11 Minor warnings fixes Some systems insist on -Wmissing-field-initializers. We have too many, by design. Fix a few easy ones.
Behdad Esfahbod fc0daafa 2014-07-23T16:48:51 [indic] Handle old-spec Malayalam reordering with final Halant See comment. Micro-tests added.
Behdad Esfahbod d6d349d1 2014-07-23T11:38:49 Give CC to gir-scanner From: https://github.com/Alexpux/MINGW-packages/blob/master/mingw-w64-harfbuzz/0001-give-cc-to-gir-scanner.all.patch
Behdad Esfahbod 3f310dc0 2014-07-22T16:26:27 Disallow changing settings on immutable face Ouch!
Behdad Esfahbod 0fc0a102 2014-07-21T11:12:54 [win] Fix Cygwin build https://github.com/behdad/harfbuzz/commit/db308280488c2ee11ba865a9922eb6a0c1abeef3#commitcomment-7077778
Behdad Esfahbod 1132a7dd 2014-07-20T01:17:40 Add HB_TAG_MAX_SIGNED / _HB_SCRIPT_MAX_VALUE_SIGNED To make C language police happy.
Behdad Esfahbod df999763 2014-07-19T17:31:23 [gobject] Skip _HB_SCRIPT_MAX_VALUE Fixes https://github.com/behdad/harfbuzz/pull/38
Behdad Esfahbod f1a8d50a 2014-07-19T16:52:32 [win] Don't define visibility attribtue under Cygwin
Behdad Esfahbod 9c77027d 2014-07-19T16:37:22 [win] Turn STRICT on for including windows.h
Behdad Esfahbod db308280 2014-07-19T16:32:04 [win] Consolidate windows.h include tips and tricks
Behdad Esfahbod f26d59d4 2014-07-19T16:10:21 More fixing MemoryBarrier() on Mingw32 Set requested windows header to Vista. See discussion: https://github.com/behdad/harfbuzz/commit/fbb2847f541389f40718af71c4945024ae177ab2#commitcomment-7054700
Behdad Esfahbod 385cf37c 2014-07-17T18:22:07 Fix hb_in_range() unused-var warning on Windows
Behdad Esfahbod e3b42f1a 2014-07-17T17:13:54 [arabic] Disable 'cswh' again Ouch!
Behdad Esfahbod 82f4d9d5 2014-07-17T15:57:37 [arabic] Add note re disabled 'cswh'
Behdad Esfahbod 615d00ea 2014-07-17T13:36:09 [arabic] Apply init/medi/isol/fini/... in separate stages Follows the order of the Arabic/Syriac specs. Also don't stop between rlig and calt in non-Arabic scripts. Micro-tests for Arabic and Mongolian added for the latter.
Behdad Esfahbod 7cd33f23 2014-07-17T14:22:11 Micro optimization
Behdad Esfahbod 164c13d7 2014-07-17T14:16:38 Another try to fix Mongolian free variation selectors This reverts bf029281 and fixes it properly. That commit was not enough as it was only inheriting the shaping_action for prev_action, but not curr_action. Micro-test added. https://code.google.com/p/chromium/issues/detail?id=393896
Behdad Esfahbod 5209c505 2014-07-17T12:23:44 Revert "Show U+FFFD REPLACEMENT CHARACTER for invalid Unicode codepoints" We now handle U+FFFD replacement in hb_buffer_add_utf*(). Any other manipulation can happen in user callbacks. No need for this. https://github.com/behdad/harfbuzz/commit/efe74214bbb68eaa3d7621e73869b5d58210107e#commitcomment-7039404 This reverts commit efe74214bbb68eaa3d7621e73869b5d58210107e. Conflicts: src/hb-ot-shape-normalize.cc
Dominik Röttsches 9e7c7201 2014-07-17T14:40:34 Fix CoreText build after a8b89a09f6d3a34
Behdad Esfahbod a4d64375 2014-07-16T20:15:45 Minor
Behdad Esfahbod 976c8f45 2014-07-16T15:34:20 New API: hb_buffer_[sg]et_replacement_codepoint() With this change, we now by default replace broken UTF-8/16/32 bits with U+FFFD. This can be changed by calling new API on the buffer. Previously the replacement value used to be (hb_codepoint_t)-1. Note that hb_buffer_clear_contents() does NOT reset the replacement character. See discussion here: https://github.com/behdad/harfbuzz/commit/6f13b6d62daae4989e3cc2fe4b168e5c59650964 New API: hb_buffer_set_replacement_codepoint() hb_buffer_get_replacement_codepoint()
Behdad Esfahbod bcba8b45 2014-07-16T14:59:04 New API hb_buffer_add_codepoints() Like hb_buffer_add_utf32, but doesn't do any Unicode validation. This is like what hb_buffer_add_utf32 used to be until a couple commits ago.
Behdad Esfahbod 625dbf14 2014-07-16T14:49:55 [buffer] Templatize UTF-* functions
Behdad Esfahbod e634fed4 2014-07-16T14:17:26 [buffer] Validate UTF-32 input Same as what we do for UTF-8 and UTF-16.
Behdad Esfahbod b98c5db3 2014-07-16T13:44:01 Minor refactoring
Behdad Esfahbod 3b861421 2014-07-16T13:22:05 Fix Mongolian Variation Selectors for fonts without GDEF Originally we fixed those in 79d1007a501fd63c0ba4d51038c513e6b8b94740. However, fonts like MongolianWhite don't have GDEF, but have IgnoreMarks in their LigatureSubstitute init/etc features. We were synthesizing a GDEF class of mark for Mongolian Variation Selectors and as such the ligature lookups where not matching. Uniscribe doesn't do that. I tried with more sophisticated fixes, like, if there is no GDEF and a lookup-flag mismatch happens, instead of rejecting a match, try skipping that glyph. That surely produces some interesting behavior, but since we don't want to support fonts missing GDEF more than we have to, I went for this simpler fix which is to always mark default-ignorables as base when synthesizing GDEF. Micro-test added. Fixes rest of https://bugs.freedesktop.org/show_bug.cgi?id=65258
Behdad Esfahbod 878a2537 2014-07-16T13:21:26 Minor
Behdad Esfahbod ec181e50 2014-07-16T13:10:03 Minor moving around
Behdad Esfahbod e7ce50d9 2014-07-16T12:30:39 [indic] Fix access past end of array
Behdad Esfahbod 73e23b0a 2014-07-15T18:43:49 Whitespace
Behdad Esfahbod b7bc0b67 2014-07-11T16:20:28 Simplify / speed up UTF-8 code
Behdad Esfahbod af2490c0 2014-07-11T16:10:58 Only accept well-formed UTF-8 sequences Enable tests that were disabled before, and adjust one test, and add more tests.
Behdad Esfahbod 7323d385 2014-07-11T15:10:05 Simplify hb_utf_prev<16> to call hb_utf_next<16>
Behdad Esfahbod c09a607a 2014-07-11T15:05:36 Use hb_in_range() for arabic and indic tables Though, looks like gcc was smart enough to produce the same code before...
Behdad Esfahbod 7627100f 2014-07-11T14:54:42 Mark unsigned integer literals with the u suffix Simplifies hb_in_range() calls as the type can be inferred. The rest is obsessiveness, I admit.
Behdad Esfahbod a8b89a09 2014-07-11T14:18:01 Simplify hb_in_range() It's both faster and produces smaller code. Now I feel stupid for not writing it this way before.
Behdad Esfahbod db8934fa 2014-07-11T13:58:36 Simplify hb_utf_prev<8> to call hb_utf_next<8>
Behdad Esfahbod efe74214 2014-07-11T11:59:48 Show U+FFFD REPLACEMENT CHARACTER for invalid Unicode codepoints Only if the font doesn't support it. Ie, this gives the user to use non-Unicode codepoints as private values and return a meaningful glyph for them. But if it's invalid and font callback doesn't like it, and if font has U+FFFD, show that instead. Font functions that do not want this automatic replacement to happen should return true from get_glyph() if unicode > 0x10FFFF. Replaces https://github.com/behdad/harfbuzz/pull/27
Behdad Esfahbod 6f13b6d6 2014-07-10T19:31:40 When parsing UTF-16, generate invalid codepoint for lonely low surrogate Test passes now.
Behdad Esfahbod 6334495a 2014-07-10T19:22:07 Use zh-Hans / zh-Hant when converting OT language tag to hb_language_t
Behdad Esfahbod f381e320 2014-07-10T19:20:35 Fix lang matching logic Previous code was broken logically, but harmless.
Behdad Esfahbod ee5350d6 2014-07-10T19:06:45 Accept BCP 47 zh-Hans / zh-Hant language tags
Behdad Esfahbod 8b16ff12 2014-07-09T17:40:52 [uniscribe] Fix build after recent changes to Offset
Behdad Esfahbod 73f7f891 2014-07-09T17:17:18 Define _POSIX_C_SOURCE only if it is not defined Fixes https://github.com/behdad/harfbuzz/pull/45
Behdad Esfahbod 0cd94491 2014-07-09T16:51:38 [ucdn] Update to Unicode 7.0.0 data From http://github.com/behdad/ucdn
Behdad Esfahbod 68f72448 2014-06-30T15:46:53 [indic] Remove some more now-unused special-cases
Behdad Esfahbod e79c9489 2014-06-30T15:39:39 [indic] Remove special-casing of U+1CF2,1CF3 These were introduced in a498565cedf0441ae723c5e5969f637d792a15e7, but IndicSyllabicCategory has had the correct value already, so the special code was never needed.
Behdad Esfahbod d743ce78 2014-06-30T15:24:02 [indic-table] Update to Unicode 7.0 data Touch code just enough to preserve previous syllable structure and functionality as closely as possible. Many further cleanups coming later.
Behdad Esfahbod 5fa21b3a 2014-06-30T14:30:54 [indic-table] Fix category frequency counts in comments
Behdad Esfahbod 5c4e3e9a 2014-06-30T14:25:18 Whitespace
Behdad Esfahbod af528b66 2014-06-27T18:07:00 Fix typo; ouch!
Behdad Esfahbod 7d4ada66 2014-06-27T17:30:59 Mark unsed members with a "Z" suffix There may be more. There are members that are by definition redundant or reserved and not needed, NOT what we *currently* don't use. I'm sure there's more...
Behdad Esfahbod 23afcff1 2014-06-27T17:22:36 [ot-font] Implement Unicode variation selectors
Behdad Esfahbod a5a47369 2014-06-27T17:03:22 [cmap] Implement subtable format 14
Behdad Esfahbod 586b6062 2014-06-27T15:39:47 Minor: final bits of cleanup
Behdad Esfahbod 51d9ba09 2014-06-27T15:27:15 Minor
Behdad Esfahbod 3084767e 2014-06-27T15:24:35 Minor: Remove LongArrayOf
Behdad Esfahbod 41ea5949 2014-06-27T15:23:18 Minor: Remove LongSortedArrayOf
Behdad Esfahbod bb6ecf2c 2014-06-27T15:13:44 Minor: Remove LongOffsetArrayOf and LongOffsetLongArrayOf
Behdad Esfahbod 99d28171 2014-06-27T15:12:52 Minor: Remove GenericOffset
Behdad Esfahbod 9da552dc 2014-06-27T15:09:42 Minor: Remove some GenericXXX templates
Behdad Esfahbod 36073ede 2014-06-27T14:48:54 Minor: Reorder template parameter order
Behdad Esfahbod 0394ec1b 2014-06-27T14:40:35 Minor: Introduce GenericOffset
Behdad Esfahbod 0d1b3419 2014-06-26T19:13:34 Minor: Use template parameter default values for OffsetTo