kc3-lang/libevent

Branch :

Log

Author Commit Date CI Message
1ae82cd8 2010-10-27 17:32:41 Set _EVENT_SIZEOF_VOID_P correctly on win32 and win64
f817bfa4 2010-10-27 17:31:52 Fix some ints to evutil_socket_t; make tests pass on win64.
19c71e74 2010-10-27 10:36:08 Fix som event_warns that should have been event_warnx
e8a903ce 2010-10-27 10:27:04 Merge remote branch 'trondn/master'
f5ad31c1 2010-10-27 12:47:07 Check return value for ioctlsocket on win32
5d389dc0 2010-10-26 22:27:57 Fix some uses of int for socket in regress
84a7053e 2010-10-26 21:33:22 Merge remote branch 'github/20_http_read_after_write'
73bf07fe 2010-10-26 21:33:13 Merge remote branch 'github/20_abi_breaks'
093fb989 2010-10-26 21:33:05 Merge remote branch 'github/20_ratelim_size'
4f20eeaa 2010-10-26 21:32:53 Merge remote branch 'github/20_chain_realign'
fbaf0770 2010-10-26 12:09:20 Fix bugs in posix thread-id calculation when sizeof(pthread_t) != sizeof(long) When pthread_t was smaller, our calculated thread IDs would include uninitialized RAM, and so our unit tests would fail because thread_ids would never match one another. When pthread_t was larger and alignment was big-endian, our calculated thread IDs would only have the most significant bytes of the pthread_t, when in practice all the entropy is in the low-order bytes. Found with help from Dagobert Michelsen.
ac1931ac 2010-10-26 11:07:26 Remove event-config.h from .gitignore; it moved to include/event2
e56ff65a 2010-10-26 11:01:58 Fix a minor syntax error that most compilers didn't care about
a4063c06 2010-10-26 10:38:30 Note that 2.0.9 will break the ABI, and make changes we were postponing. We had to turn a couple of 32-bit size arguments into 64-bit arguments or size_t arguments (since otherwise we would have had to do it post 2.0.x-stable, and that would be worse).
2cbb1a16 2010-10-26 10:27:29 Make rate-limits go up to SIZE_MAX/EV_SSIZE_MAX, not just INT32_MAX Someday, when networks are far faster and people frequently want a burst value greater than 2GB per tick, this will seem very forsightful indeed. For now, it breaks ABI, but not source. Fixes bug 3092096.
e4f34e8a 2010-10-25 22:36:23 Correct logic for realigning a chain in evbuffer_add The old logic was both too eager to realign (it would move a whole chain to save a byte) and too reluctant to realign (it would only realign when data would fit into the misaligned portion, without considering the space at the end of the chain). The new logic matches that from evbuffer_expand_singlechain: it only realigns a chain when not much data is to be moved, and there's a bunch of space to be regained. Spotted by Yan Lin.
74c0e862 2010-10-25 21:53:15 Avoid missed-request bug when entire http request arrives before data is flushed The trigger for starting to read the first line of a request used to be, "When data has arrived and we're looking for the first line." But that's not good enough: if the entire next request gets read into our bufev->inbuf while we're still processing the current request, we'll never see any more data arrive, and so will never process it. So the fix is to make sure that whenever we hit evhttp_send_done, we call evhttp_read_cb. We can't call it directly, though, since evhttp_send_done is reachable from the user API, and evhttp_read_cb can invoke user functions, and we don't want to force everyone to have reentrant callbacks. So, we use a deferred_cb. Found by Ivan Andropov. This is bug 3008344.
8e342e56 2010-10-25 16:09:11 Correctly count req->body_size on http usage without Content-Length There was a dumb bug where we would look at the length of the input buffer immediately _after_ we drained it.
58a1cc6b 2010-10-25 16:00:47 Fix a bug where we would read too much data in HTTP bodies or requests. We were using evbuffer_add_buffer, which moved the entire buffer contents. But if we had a valid content_length, we only wanted to move up to the amount of data remaining in ntoread. Our bug would make us put our ntoread in the negative, which would in turn make us read all data until the connection closed. Found by Denis Bilenko. Should fix bug 2963172.
525da3e1 2010-10-25 15:49:42 Fix Content-Length when trying send more than 100GB of data (!) on an evhttp.
f1250eb6 2010-10-25 15:23:41 add a requested docstring for event_rpcgen.CommandLine.__init__
9c71a341 2010-10-25 15:13:32 Merge remote branch 'github/http_and_listener'
ac7e52d8 2010-10-25 14:29:30 Make evbuffer_add_file take ev_off_t, not off_t This change has no effect on non-windows platforms, since those either define off_t to 64-bits, or allow you to decide whether it should be 64-bits yourself via some LARGEFILE-like macro. On Windows, however, off_t is always 32-bit, so it's a bad choice for "file size" or "file offset" values. Instead, I'm adding an ev_off_t type, and using it in the one place where we used off_t to mean "the size of a file" or "an offset into a file" in the API. This breaks ABI compatibility on Windows.
006efa7d 2010-10-25 11:50:51 Functions to actually use evhttp_bound_socket with/as evconnlistener.
46ee061c 2010-10-25 11:47:05 Add a function to change a listener's callback. You can also now initialize listeners with no callbacks set; if so, they won't get enabled until the callback is set to non-NULL.
2c66983a 2010-10-24 11:51:14 Simplify the logic for choosing EPOLL_CTL_ADD vs EPOLL_CTL_MOD Previously, we chose "ADD" whenever old_events==new_events, (since we expected the add to fail with EEXIST), or whenever old_events was==0, and MOD otherwise (i.e., when old_events was nonzero and not equal to new_events). But now that we retry failed MOD events as ADD *and* failed ADD events as MOD, the important thing is now to try to guess right the largest amount of the time, since guessing right means we do only one syscall, but guessing wrong means we do two. When old_events is 0, ADD is probably right (unless we're hitting the dup bug, when we'll fall back). And when old_events is set and != new_events, MOD is almost certainly right for the same reasons as before. But when old_events is equal to new events, then MOD will work fine unless we closed and reopened the fd, in which case we'll have to fall back to the ADD case. (Redundant del/add pairs are more common than closes for most use cases.) This change lets us avoid calculating new_events, which ought to save a little time in epoll.c
c281aba3 2010-10-24 11:38:29 Fix a nasty bug related to use of dup() with epoll on Linux Current versions of the Linux kernel don't seem to remove the struct epitem for a given (file,fd) combo when the fd is closed unless the file itself is also completely closed. This means that if you do: fd = dup(fd_orig); add(fd); close(fd); dup2(fd_orig, fd); add(fd); you will get an EEXIST when you should have gotten a success. This could cause warnings and dropped events when using dup and epoll. The solution is pretty simple: when we get an EEXIST from EPOLL_CTL_ADD, we retry with EPOLL_CTL_MOD. Unit test included to demonstrate the bug. Found due to the patient efforts of Gilad Benjamini; diagnosed with help from Nicholas Marriott.
bf11e7dd 2010-10-21 15:33:13 Merge branch 'http_uri_parse'
bc98f5e6 2010-10-21 14:53:21 Unit tests for evhttp_uri_set*
45f6869c 2010-10-21 14:41:12 Make evhttp_uri non-public, and give it accessor functions.
70e1b607 2010-10-21 14:05:04 Document that two bufferevent functions only work on socket bufferevents
aab49b60 2010-10-21 14:04:24 Add a bufferevent_get_base function
d9ffa899 2010-10-21 12:48:13 Update the HTTP regression tests to use Libevent2 apis for non-http stuff
1f507d75 2010-10-21 12:27:16 Stop using Libevent-1 headers in regress_http
2a3b5872 2010-10-21 12:23:10 Merge branch 'http_small_tweaks' Conflicts: http-internal.h
cd00079b 2010-10-21 12:19:28 Add evhttp_connection_get_base() to get the event_base from an http connection Based on a patch by Mark Ellzey from 27 July 2010. Closes ticket 3052406
1213d3dd 2010-10-20 13:41:02 Fix a 100%-CPU bug where an SSL connection would sometimes never stop trying to write If an SSL connection becamse disabled or suspended before became open, it could (under the right circumstances) wind up without ever getting its write callback disabled. The most correct fix is probably more subtle, and involves checking all caseswhen a write callback is enabled or disabled. This fix is more blunt, and explicitly checks whether the callback should have been disabled at the end of the callback to prevent infinite looping. Diagnosed with help from Sebastian Hahn
2075fbcf 2010-10-19 13:15:48 Add evhttp_parse_query_str to be used with evhttp_uri_parse. The old evhttp_parse_query() doesn't work well with struct evhttp_uri.query, since it expects to get whole URIs, rather than just the query portion.
3a334628 2010-10-19 13:02:18 Document behavior of URI parsing more thoroughly. Also, move evhttp_uri struct into http.h, since it is part of the API.
a5a76e68 2010-10-19 12:35:50 Add a huge pile of tests for the new URI functions, and make them pass.
ad923a11 2010-10-19 12:33:50 Improvements to tinytest_macros.h First, handle cases where we have %s in a tt_want or tt_assert. Second, add tt_want_*_op that do a tt_*_op test, but do not exit the test on failure. We should push these upstream to tinytest some time.
eaa5f1d9 2010-10-19 11:26:59 Revise evhttp_uri_parse implementation to handle more of RFC3986
fadbfd4e 2010-10-18 14:43:54 Clean up error handling in uri_parse a little
7d45431e 2010-10-18 14:38:48 Do not silently truncate URIs in evhttp_uri_join. Also avoid evbuffer_pullup.
86212341 2010-10-18 14:34:20 Make evhttp_uri_parse and friends conform to memory management standards
86dd720a 2010-08-08 16:46:39 Introduce absolute URI parsing helpers. See evhttp_uri_parse(), evhttp_uri_free() and evhttp_uri_join() for details.
f13e449b 2010-10-18 14:20:06 Merge branch 'http_parse'
49f4bf7c 2010-10-18 13:58:02 Add evhttp_request_get_command so code can tell GET from POST without peeking at the struct.
e5870690 2010-10-18 13:53:31 Modernize header usage in bench_http.c
9dc5f44a 2010-10-14 22:12:32 Increment version in git to 2.0.8-rc-dev
ef18c994 2010-10-14 18:36:07 Increment the version to 2.0.8-rc NOTE: This is not the official release until I tag it. If you see this commit, and you decide that Libevent 2.0.8-rc is now finalized, you might get something besides 2.0.8-rc.
15be0493 2010-10-14 18:35:11 Changelog and readme for 2.0.8-rc
4ebf9509 2010-10-14 14:40:40 Fixes for MSVC compilation
d3b096c0 2010-10-14 13:54:15 Make the --enable-gcc-warnings option include signed comparison warnings
e06f514d 2010-10-14 13:51:24 Fix signed/unsigned warnings on win32
6be589ae 2010-10-14 13:48:40 Fix signed/unsigned warnings on opensolaris, where iov_len is signed
e5c214a4 2010-10-14 13:16:41 Fix -Wsigned-compare warnings in test/*
f2763fa8 2010-10-14 13:16:00 add limits.h to event_tagging.c so opensolaris will build
5e4bafbb 2010-10-14 13:15:32 fix a signed/unsigned warning in kqueue.c
02f6259f 2010-10-14 11:44:32 New unit test for ssl bufferevents starting with connected SSLs.
93bb7d8e 2010-10-14 11:41:10 Fix a case where an ssl bufferevent with CLOSE_ON_FREE didn't close its fd This could happen when we got an SSL with a BIO already set on it.
ac27eb82 2010-10-08 00:59:02 Correct logic on disabling underlying bufferevents when disabling a filter Previously, whenever writing was disabled on a bufferevent_filter (or a filtering SSL bufferevent), we would stop writing on the underlying bufferevent. This would make for trouble, though, since if you implemented common patterns like "stop writing once data X has been flushed", your bufferevent filter would disable the underlying bufferevent after the data was flushed to the underlying bufferevent, but before actually having it written to the network. Now, we have filters leave their underlying bufferevents enabled for reading and writing for reading and writing immediately. They are not disabled, unless the user wants to disable them, which is now allowed. To handle the case where we want to choke reading on the underlying bufferevent because the filter no longer wants to read, we use bufferevent_suspend_read(). This is analogous to the way that we use bufferevent_suspend_write() to suspend writing on a filtering bufferevent when the underlying bufferevent's output buffer has hit its high watermark.
223ee40f 2010-10-14 10:53:26 Avoid spurious reads from just-created open openssl bufferevents When handshaking, we listen for reads or writes from the transport. But when we're connected, we start out with writes enabled and reads disabled, which means we should not have the transport read for us.
34331e45 2010-10-08 01:09:02 The corrected bufferevent filter semantics let us fix our openssl tests
34d64f8a 2010-10-12 13:46:14 Fix serious bugs in per-bufferevent rate-limiting code Our old code was too zealous about deleting the refill events that would actually make connections able to read or write again after they had run out of bandwidth. Under some circumstances, this could cause a bufferevent to never actually refill one of its rate-limiting buckets. Also, the code treated setting a per-connection rate-limit on a connection that already had a group-limit as if it were changing the limit on a connection whose allocation had already run out. This patch fixes both of those problems.
819b1715 2010-10-12 12:59:13 Handle rate-limiting for reading on OpenSSL bufferevents correctly. We were looking at the number of bytes read on the wbio, not in the rbio. But these are usually different BIOs, and the reading is supposed to happen on the rbio.
7ad90f6a 2010-10-09 00:02:31 Merge branch '20_internal_prio'
a8148ced 2010-10-08 13:05:13 New evhttp_uri(encode|decode) functions to handle + and NUL characters right The old evhttp_decode_uri() function would act as tough it was doing an (illegal, undefined) decode operation on a whole URL at once, and treat + characters following a ? as different from + characters preceding one. But that's not useful: If you are decoding a URI before splitting off query parameters, you are begging to fail as soon as somebody gives you a value with an encoded & in it. The new evhttp_uridecode() function takes an argument that says whether to decode + signs. Both uridecode and uriencode also now support encoding or decoding to strings with internal 0-valued characters.
2e63a604 2010-10-08 12:57:11 evhttp_encode_uri encodes all reserved characters, including !$'()*+,/:=@ Perviously, some characters not listed as "unreserved" by RFC 3986 (notably "!$'()*+,/:=@") were not encoded by evhttp_encode_uri. This made trouble, especially when encoding path components (where @ and / are bad news) and parameters (where + should get encoded so it doesn't later decode into a space). Spotted by Bas Verhoeven.
08ebd267 2010-10-07 21:06:25 Merge branch 'iovmax'
12057035 2010-10-07 18:05:01 Turn some booleans in evconnlistener_iocp into one-bit bitfields.
62b429af 2010-10-07 13:41:39 Make iocp/listener/error work; don't accept again if lev is disabled.
481ef920 2010-09-23 17:41:49 Fix allocation error for IOCP listeners. Probably harmless, since struct event is big
127d4f21 2010-09-23 16:49:58 Add a LEV_OPT_THREADSAFE option for threadsafe evconnlisteners
3b844893 2010-10-06 12:35:38 Tweak evhttp_parse_query hack to avoid breaking abi
b1756d01 2010-10-06 11:48:52 Let evhttp_parse_query return -1 on failure We already detected certain malformed queries, but we responded by aborting the query-parsing process half-way through without telling the user. Now, if query-parsing fails, no headers are returned, and evhttp_parse_query returns -1.
fdc640b0 2010-10-05 21:34:07 Fix an EINVAL on evbuffer_write_iovec on OpenSolaris. The writev() call is limited to at most IOV_MAX iovecs (or UIO_MAXIOV, depending on whom you ask). This isn't a problem anywhere we've tested except on OpenSolaris, where IOV_MAX was a mere 16. This patch makes us go from "use up to 128 iovecs when writing" to "use up to 128 iovecs when writing, or IOV_MAX/UIO_MAXIOV, whichever is less". This is still wrong if you somehow find a platform that defines IOV_MAX < UIO_MAXIOV, but I hereby claim that such a platform is too stupid to worry about for now. Found by Michael Herf.
5b7a3706 2010-10-05 14:29:48 Fix warnings on mingw with gcc 4.5
145f221e 2010-10-05 13:06:32 Define symbolic constants to use in place of SHUT_RD etc
e0fd8708 2010-10-05 13:01:54 Send a shutdown(SHUT_WR) before closing an http connection This avoids getting an ECONNRESET from the TCP stack. Fixes bug 2928690
0faaee01 2010-09-30 23:15:47 Fix a spurious-call bug on epoll.c We were trying to check whether any events had really been notified on an fd before calling evmap_io_active on it, but instead we were checking for an event pointer, which was always true. In practice, this patch shouldn't change much, since epoll_wait shouldn't return an event unless there is actually an event going on. Spotted by an anonymous bug reporter on Sourceforge. Closes bug 3078425.
a8b7674c 2010-09-28 01:09:17 Merge remote branch 'github/signed_compare'
a78ac0fa 2010-09-27 16:05:20 Merge remote branch 'github/win_lib'
d49b5e33 2010-09-27 15:12:55 Do not search outside of the system directory for windows DLLs Hardens against some attacks.
b3953927 2010-09-27 21:14:28 Fix compile in kqueue.c Commit 38d09606 removed the evsigbase pointer, but forgot to remove an assignment to it in kqueue.c.
9c8db0f8 2010-09-23 22:45:55 Fix all warnings in the main codebase flagged by -Wsigned-compare Remember, the code int is_less_than(int a, unsigned b) { return a < b; } is buggy, since the C integer promotion rules basically turn it into int is_less_than(int a, unsigned b) { return ((unsigned)a) < b; } and we really want something closer to int is_less_than(int a, unsigned b) { return a < 0 || ((unsigned)a) < b; } . Suggested by an example from Ralph Castain
045eef4c 2010-09-23 14:23:45 Unit tests for listener error callbacks
c4be8d82 2010-09-20 12:47:39 Add error callback to evconnlistener
e1198997 2010-09-21 22:44:39 Make event.c debugging messages report fds
ec2b05ed 2010-09-21 22:23:32 Make debugging output for epoll backend more comprehensive
90651b32 2010-09-17 00:24:50 Put internal events at highest priority (If we allow user events to starve internal events, then internal events never actually happen, signals don't get acked, etc)
38d09606 2010-09-15 12:50:31 Remove event_base.evsigbase; nothing used it.
4858b794 2010-09-15 01:54:51 Remove the now-useless evsig_caught and evsig_process
95a7d418 2010-09-15 01:40:02 Make default signal backend fully threadsafe Jason Toffaletti discovered with helgrind that our signal handler was messing with evsig_base, which can be set from lots of places in the code. Ordinarly, we'd just stick a lock on it, except that it is illegal (and genuinely error-prone) to call pthread_mutex_acquire() from inside a signal handler. The solution is to only store the fd we write to in a static variable, write the signal number to the fd, and put evsig_cb in charge of activating signal events. I have no idea how we'll cope if we want to enable this to handle siginfo (where available) in the future.
720bd933 2010-09-15 01:08:39 Warn when using the error-prone EV_SIGNAL interface in an error-prone way. Also, fix a couple of race conditions in signal.c When using the signal.c signal backend, Libevent currently only allows one event_base to actually receive signals at a time. (This has been the behavior since at least 1.4 and probably much earlier.) Now, we detect and warn if you're likely to be racing about which signal goes to which thread. We also add a lock to control modifications of the evsig_base field, to avoid race conditions like those found by Jason Toffaletti. Also, more comments. Comments are good.
040a019f 2010-09-09 17:19:20 Obey enabled status when unsuspending
f0bd83ea 2010-09-09 16:13:09 Bump to the latest version of tinytest This lets us do without libevent-specific code in tinytest.c, and lets us add a feature to skip individual tests from the command line.
a5ce9ad4 2010-09-09 16:01:42 Make SSL tests cover enabling/disabling EV_READ. I want my 80% coverage.
5811d74c 2010-09-09 15:59:18 Bump version to 2.0.7-rc-dev
fe008ed6 2010-09-09 14:59:27 Make all versioning changes for 2.0.7-rc, and add ChangeLog