kc3-lang/libevent
Branch :
Log
| Author | Commit | Date | CI | Message |
|---|---|---|---|---|
 |
90d80ef4 | 2018-11-23 00:29:55 | cmake: do not build both (SHARED and STATIC) for MSVC/win32 MSVC does not support SHARED and STATIC libraries with the same name, so let's just build SHARED libraries by default instead (yes we can add prefix but let's stick with this). The reason for this is that in windows shared libraries requires .lib file too, but this is not static library it is imported library for shared (doh...), for more info [1] and [2]. [1]: https://docs.microsoft.com/en-us/windows/desktop/dlls/dynamic-link-library-creation [2]: https://blogs.msdn.microsoft.com/oldnewthing/20091013-00/?p=16403 And when we build both static library can and will override shared library imported part, let's take a look at event_extra.lib: - before patch [3]: $ less libevent-fail/lib/Debug/event_extra.lib | head ==> use library:contained_file to view a file in the archive rw-rw-rw- 100666/100666 59568 Nov 21 23:55 2018 event_extra_static.dir/Debug/evrpc.obj rw-rw-rw- 100666/100666 252219 Nov 21 23:55 2018 event_extra_static.dir/Debug/evdns.obj rw-rw-rw- 100666/100666 203850 Nov 21 23:55 2018 event_extra_static.dir/Debug/http.obj rw-rw-rw- 100666/100666 25907 Nov 21 23:55 2018 event_extra_static.dir/Debug/event_tagging.obj [3]: https://ci.appveyor.com/project/azat/libevent/builds/20472024/job/t0o93v042jai0dj7 - "after patch" [4] (not after but the same effect): $ less libevent-ok/lib/Debug/event_extra.lib | head ==> use library:contained_file to view a file in the archive --------- 0/0 509 Nov 21 23:38 2018 event_extra.dll ... [4]: https://ci.appveyor.com/project/azat/libevent/builds/20478998/job/ca9k3c76amc4qr76 Refs: #691 | |
|
c9a073ea | 2018-11-22 23:00:11 | cmake: introduce EVENT__LIBRARY_TYPE option Long time ago in [1] cmake build was forced to compile both libraries (SHARED and STATIC), since this is how our autotools build works. [1]: 7182c2f561570cd9ceb704623ebe9ae3608c7b43 ("cmake: build SHARED and STATIC libraries (like autoconf does)") And there is no way to configure this (and indeed you need to do this for MSVC for example), so let's introduce option for this -- EVENT__LIBRARY_TYPE. Plus now we have INTERFACE libraries, that we can use internally in libevent's cmake rules to avoid strict to _shared/_static variant of the libraries to link with samples/tests (we prefer SHARED over STATIC for linking). Also bump minimal cmake required version to 3.1 by the following reasons: - 3.1 is required for RPATH configuration under APPLE - 3.0 is required for add_library(INTERFACE) (did not found it in 2.8.x documentation) - remove extra conditions (anyway 3.1 was release 4 years ago, so I guess that most of the systems will have it) | |
|
d705e8c0 | 2018-11-21 07:31:57 | cmake: drop redundant add_dependencies() | |
|
4d2f013b | 2018-11-21 00:10:43 | Merge branch 'TT_RETRIABLE' * TT_RETRIABLE: Mark a lot of flacky tests with TT_RETRIABLE (for linux/win32 only) regress: introduce TT_RETRIABLE Fixes: #704 | |
|
fe5b0719 | 2018-11-20 11:46:44 | Mark a lot of flacky tests with TT_RETRIABLE (for linux/win32 only) This patch mark testcases that only fail under travis-ci/appveyor with TT_RETRIABLE, since otherwise there is too much noise, other issues (like failures under vagrant boxes) would be investigated separatelly. linux (from travis-ci only): - http/cancel_by_host_no_ns - http/cancel_by_host_inactive_server - http/cancel_by_host_ns_timeout - http/cancel_by_host_ns_timeout_inactive_server - thread/conditions_simple - util/monotonic_prc_precise - util/usleep - main/del_wait vagrant/ubuntu box (this is the only exception): - thread/no_events win32 (from appveyor only): - main/active_later - main/persistent_active_timeout And we should use TT_RETRIABLE over TT_OFF_BY_DEFAULT/TT_SKIP when it make sense. But there is still "test-ratelim__group_lim" left. | |
|
63b065be | 2018-11-20 01:06:04 | regress: introduce TT_RETRIABLE We have some tests that has false-positive due to real/CPU time bound, but they are pretty generic and we do not want to skip them by default. TT_RETRIABLE is the flag that will indicate tinytest to retry the test in case of failure, use it to avoid next possible false-positives: - real time-related - CPU time-related Since I guess it is better to see/grepping RETRYING messages over ignoring completely failed builds. No configuration switch for number of retries was done on purpose (only 3 retries and no more). And this is how it looks BTW: $ gcc ../test/tinytest_demo.c ../test/tinytest.c $ ./a.out --verbose --no-fork demo/timeout_retry demo/timeout_retry: FAIL ../test/tinytest_demo.c:201: assert(i != 1): 1 vs 1 [timeout_retry FAILED] [RETRYING timeout_retry (3)] demo/timeout_retry: OK ../test/tinytest_demo.c:201: assert(i != 1): 2 vs 1 OK ../test/tinytest_demo.c:213: assert(t2-t1 >= 4): 5 vs 4 OK ../test/tinytest_demo.c:215: assert(t2-t1 <= 6): 5 vs 6 1 tests ok. (0 skipped) | |
|
57765b23 | 2018-11-20 00:58:47 | bufferevent: add debug messages when .setfd/.getfd/.enable/.disable failed | |
|
b98d32d0 | 2018-11-14 00:20:20 | http: improve error path for bufferevent_{setfd,enable,disable}() We have calls to the next functions but do not check return values, though they can be invalid and it is better to show this somehow. Also do bufferevent_setfd() first and only after it bufferevent_enable()/bufferevent_disable() since: a) it is more natural b) it will avoid extra operations c) it will not fail first bufferevent_enable() (this is the case for buffbufferevent_async at least) In this case we could add more information for issues like #709 | |
|
3036f15a | 2018-11-20 06:20:51 | regress_http: fix compilation with !EVENT__HAVE_OPENSSL Fixes: 811c63f7 ("regress: test for HTTP/HTTPS with IOCP enabled") | |
|
f8d510f6 | 2018-11-13 23:20:10 | regress_bufferevent: add TT_IOCP_LEGACY/TT_IOCP | |
|
903c6ace | 2018-11-13 23:30:51 | t/bench_http: disable buffering (win32 do not show anything otherwise) Refs: #255 | |
|
56f3bdef | 2018-11-13 23:23:09 | s/http-server: check for EVTHREAD_USE_WINDOWS_THREADS_IMPLEMENTED | |
|
3d815cf2 | 2018-11-13 22:47:43 | Merge branch 'iocp-fixes' * iocp-fixes: regress: test for HTTP/HTTPS with IOCP enabled bev_async: trigger/run only deferred callbacks bev_async: do not initialize timeouts multiple times bev_async: set "ok" on setfd if fd>=0 (like we do during creation) bev_async: ignore ERROR_INVALID_PARAMETER on .setfd for iocp Closes: #709 Refs: nmathewson/Libevent#160 | |
|
811c63f7 | 2018-11-13 11:25:35 | regress: test for HTTP/HTTPS with IOCP enabled Next tests added: - iocp/http/simple - iocp/http/https_simple | |
|
908e710d | 2018-11-13 21:31:44 | bev_async: trigger/run only deferred callbacks Otherwise callbacks will be runned even without event_loop, due to nature of IOCP. A simple example is: evhttp_connection_free(client) # freeing the client will trigger evhttp_connection_free() for the # client on the server side, and hence there will double free evhttp_free(server) Fixes: iocp/http/simple | |
|
2bf673a4 | 2018-11-13 11:47:14 | bev_async: do not initialize timeouts multiple times You cannot event_assign() event multiple times, this is UB, and most likely will fail. Fixes: af9b2a7ae0be11c79a909d212b1833a9379e4ba0 ("Initialize async bufferevent timeout CBs unconditionally") | |
|
e73875df | 2018-11-11 21:51:46 | bev_async: set "ok" on setfd if fd>=0 (like we do during creation) Otherwise after .setfd, .enable will not work. | |
|
a54c0349 | 2018-11-11 21:35:20 | bev_async: ignore ERROR_INVALID_PARAMETER on .setfd for iocp listener already calls event_iocp_port_associate_() the second call will return ERROR_INVALID_PARAMETER. Plus we already ignore it on creation, so why we should care about it here? | |
|
5dc88b38 | 2018-11-13 21:26:12 | Fix conceivable UAF of the bufferevent in evhttp_connection_free() Although this is not a problem, since bufferevent uses finalizers and will free itself only from the loop (well this is not a problem if you do not play games with various event_base in different threads) it generates questions, so rewrite it in more reliable way. Fixes: #712 | |
|
7bcf576b | 2018-11-30 22:25:41 | Use BEV_UPCASE() everywhere Done with coccinelle and manual line rewrap: $ cat > BEV_UPCAST.cocci @@ expression field_; expression var; @@ - EVUTIL_UPCAST(var, struct bufferevent_private, field_) + BEV_UPCAST(var) $ spatch --sp-file BEV_UPCASE.cocci --in-place bufferevent*.c > /dev/null | |
|
b2d4fb41 | 2018-11-13 09:25:13 | regress: add EVENT_NO_FILE_BUFFERING, to disable buffering for stdout/stderr Useful for win32 | |
|
f2da6198 | 2018-11-13 08:24:55 | event: add some debug information into loop for event_base_free_queues_() Refs: 7c8d0152dda18ecc52d3099fea235b04ddb850d9 ("Free event queues even for recursive finalizers") | |
|
9a4b8ec1 | 2018-11-13 11:10:25 | Merge branch 'sample-http-server' Some improvements for http-server sample: - getopt - persistent port via -p option - IOCP for win32 via -I - disable buffering - enable debug logging via -v/EVENT_DEBUG_LOGGING_ALL - cleanup (by signal and separate error path on errors) * sample-http-server: s/http-server: graceful cleanup s/http-server: enable debug logging if EVENT_DEBUG_LOGGING_ALL env isset s/http-server: turn off buffering (otherwise do output on win32) s/http-server: add an option to use IOCP s/http-server: add options (for persistent port) Refs: #709 | |
|
bdd71f18 | 2018-11-13 10:48:41 | s/http-server: graceful cleanup | |
|
41b6b279 | 2018-11-13 10:26:17 | s/http-server: enable debug logging if EVENT_DEBUG_LOGGING_ALL env isset | |
|
3c8ded5c | 2018-11-08 11:19:16 | s/http-server: turn off buffering (otherwise do output on win32) | |
|
5d3f9d4d | 2018-11-08 11:13:21 | s/http-server: add an option to use IOCP | |
|
ed705ba7 | 2018-11-13 10:33:24 | s/http-server: add options (for persistent port) | |
|
8c1838be | 2018-11-08 00:21:08 | Remove Vagrantfile (will be moved into libevent-extras) Since: - it is not a library - this file should have (if I had enough time) enough fixes in itself and should not polute libevent history - it "requires" (it more cleaner to use it in this way) script -- tools/vagrant-tests.py (indeed, from libevent-extras) - will has it's own issues/README/... https://github.com/libevent/libevent-extras | |
|
1fc1c7ef | 2018-11-08 00:36:07 | regress_ssl: fix ssl/bufferevent_wm_filter for non defered callbacks Even after referenced patch there is still possible recursive callbacks from evbuffer_drain(bev_input), i.e.: wm_transfer() -> evbuffer_drain() -> wm_transfer() inc(ctx->get) But if we will increment ctx->get before drain that we will not add more data to buffer. Refs: 54c6fe3c ("regress_ssl: make ssl/bufferevent_wm_filter more fault-tolerance") CI: https://ci.appveyor.com/project/nmathewson/libevent/build/job/f0rv299i71wnuxdq#L2546 | |
|
9afe7a6c | 2018-11-06 11:30:18 | appveyor: skip travis patches (by commit subject/files) | |
|
54fdd6bb | 2018-11-05 17:04:47 | appveyor: cache build directory to reduce overall time (6x time faster) various build checks (i.e. detecting headers/macroses/functions) takes 7 minutes (from 13 minutes in total) for cmake, which is too high. By using cache we can reduce this to ~0. And set APPVEYOR_SAVE_CACHE_ON_ERROR so that cmake checks will be cached (anyway all sources will be built from scratch due to timestamp updates while extracting from sources). | |
|
50618935 | 2018-11-06 01:22:13 | appveyor: disable verbosity | |
|
1503a9a1 | 2018-11-05 18:00:41 | appveyor: do not run on branches that has "travis" in it's name | |
|
6d3a5396 | 2018-11-05 18:30:38 | cmake: set CMP0075 to NEW (for ws2_32.lib in win32) Otherwise cmake complains: Policy CMP0075 is not set: Include file check macros honor CMAKE_REQUIRED_LIBRARIES. Run "cmake --help-policy CMP0075" for policy details. Use the cmake_policy command to set the policy and suppress this warning. CMAKE_REQUIRED_LIBRARIES is set to: ws2_32.lib For compatibility with CMake 3.11 and below this check is ignoring it. | |
|
65904773 | 2018-11-05 18:23:31 | cmake: set CMP0074 to NEW (for OPENSSL_ROOT in appveyor) We have $env:OPENSSL_ROOT (env) equals to -DOPENSSL_ROOT (cmake variable) anyway. cmake complains: Policy CMP0074 is not set: find_package uses <PackageName>_ROOT variables. Run "cmake --help-policy CMP0074" for policy details. Use the cmake_policy command to set the policy and suppress this warning. Environment variable OpenSSL_ROOT is set to: C:/OpenSSL-Win64/bin For compatibility, CMake is ignoring the variable. This warning is for project developers. Use -Wno-dev to suppress it. | |
|
58e853f2 | 2018-11-05 22:58:25 | travis: use homebrew via addon (-~4min/16% from the build time) | |
|
54c6fe3c | 2018-11-05 22:25:15 | regress_ssl: make ssl/bufferevent_wm_filter more fault-tolerance Due to inplace callbacks (i.e. no BEV_OPT_DEFER_CALLBACKS) we cannot be sure that wm_transfer() will not be called recursively and indeed it still happens sometimes, and the referenced patch increase amount of this times, especially for linux/poll. Fixes: 66304a23cf748714159c988e78f35401c5352827 ("Fix ssl/bufferevent_wm_filter when bev does not reach watermark on break") | |
|
9040707f | 2018-11-05 21:33:54 | regress_http: disable http/read_on_write_error under win32 EVHTTP_CON_READ_ON_WRITE_ERROR works only if an error already read from the socket, but if we already got EPIPE on write we cannot read from the socket anymore, and win32 does not guarantee that read will happens before (although it happens from time to time). In the referenced patch I just replaced callback with not expecting 417, but like I already wrote, this is not always true (i.e. it is flacky). Fixes: 3b581693ac1967f7f8d98491cb772a1b415eb4cd ("test/http: read_on_write_error: fix it for win32") | |
|
0345adf7 | 2018-11-05 18:02:05 | travis-ci: exclude appveyor branches | |
|
3ed93997 | 2018-11-04 19:48:11 | cmake: do not detect _GNU_SOURCE/__GNU_LIBRARY__ if it is cached | |
|
9d93fbe7 | 2018-11-04 21:41:20 | Merge branch 'ssl_bufferevent_wm_filter-fix' * ssl_bufferevent_wm_filter-fix: Fix ssl/bufferevent_wm_filter when bev does not reach watermark on break regress_ssl: cover watermarks with deferred callbacks regress_ssl: improve bufferevent_wm/bufferevent_wm_filter logging | |
|
66304a23 | 2018-11-04 20:40:04 | Fix ssl/bufferevent_wm_filter when bev does not reach watermark on break For the ssl/bufferevent_wm* we have next configuration: - payload_len = 1024 - wm_high = 5120 - limit = 40960 - to_read = 512 In this test we expect that with high watermark installed to "wm_high" we will read "limit" bytes by reading "to_read" at a time, but adding "payload_len" at a time (this "to_read"/"payload_len" limits is installed to finally overflow watermark). Once we read "limit" bytes we break, by disable EV_READ and reset callbacks. Although this will not work if when we want to break we do not reach watermark, this is because watermarks installs evbuffer callback for the input buffer and if the watermark does not reached it will enable EV_READ while be_openssl_enable() will read from the underlying buffer (in case the openssl bufferevent created via bufferevent_openssl_filter_new()) and call callback again (until it will reach watermark or read al from the underlying buffer -- this is why it stops in our caes). And this is exactly what happened in win32, you can see this in the following logs: - win32 before: OK C:\vagrant\test\regress_ssl.c:829: wm_transfer-client(00DC2750): in: 4608, out: 0, got: 40960 OK C:\vagrant\test\regress_ssl.c:834: wm_transfer-client(00DC2750): break OK C:\vagrant\test\regress_ssl.c:829: wm_transfer-client(00DC2750): in: 4608, out: 0, got: 41472 OK C:\vagrant\test\regress_ssl.c:834: wm_transfer-client(00DC2750): break OK C:\vagrant\test\regress_ssl.c:829: wm_transfer-client(00DC2750): in: 4608, out: 0, got: 41984 OK C:\vagrant\test\regress_ssl.c:834: wm_transfer-client(00DC2750): break OK C:\vagrant\test\regress_ssl.c:829: wm_transfer-client(00DC2750): in: 4608, out: 0, got: 42496 OK C:\vagrant\test\regress_ssl.c:834: wm_transfer-client(00DC2750): break - win32 after: OK C:\vagrant\test\regress_ssl.c:821: wm_transfer-client(00FC26F0): break OK C:\vagrant\test\regress_ssl.c:836: wm_transfer-client(00FC26F0): in: 4800, out: 0, got: 40960 - linux before: OK ../test/regress_ssl.c:829: wm_transfer-client(0x55555566f5e0): in: 5120, out: 0, got: 40960 OK ../test/regress_ssl.c:834: wm_transfer-client(0x55555566f5e0): break - linux after: OK ../test/regress_ssl.c:821: wm_transfer-client(0x55555566f5e0): break OK ../test/regress_ssl.c:836: wm_transfer-client(0x55555566f5e0): in: 5120, out: 0, got: 40960 (As you can see in linux case we already reach watermark hence it passed before). So fix the issue by breaking before draining. But during fixing this I was thinking is this right? I.e. reading from the be_openssl_enable(), maybe we should force deferred callbacks at least? | |
|
e8c407e7 | 2018-11-04 20:15:14 | regress_ssl: cover watermarks with deferred callbacks | |
|
fb7f43f0 | 2018-11-04 20:03:50 | regress_ssl: improve bufferevent_wm/bufferevent_wm_filter logging - add bev pointer - use EV_SIZE_FMT over %zu (win32) | |
|
e29afd4b | 2018-11-02 23:43:57 | regress_http: make https_basic non time dependent Fixes: #454 | |
|
6f988ee1 | 2018-11-04 01:21:48 | Merge branch 'check-O_NONBLOCK-in-debug' * check-O_NONBLOCK-in-debug: regress: use non blocking descriptors whenever it is possible assert that fds are nonblocking in debug mode Closes: nmathewson/Libevent#90 | |
|
4cbdb39c | 2018-11-04 00:59:33 | regress: use non blocking descriptors whenever it is possible Next tests uses fds without O_NONBLOCK flag - main/free_active_base - main/many_events - et/et (has some other bits cleaned up by using TT_* flags and test setup/cleanup callbacks) And hence they will fail in debug mode (EVENT_DEBUG_MODE=): Assertion flags & O_NONBLOCK failed in event_debug_assert_socket_nonblocking_ | |
 |
965ed54c | 2014-01-08 14:57:14 | assert that fds are nonblocking in debug mode Check that each fd that had been added with some event do has O_NOBLOCK after event_enable_debug_mode() Rebased and do not check signals (EV_SIGNAL) by azat. Refs: nmathewson/Libevent#90 Refs: #96 | |
|
69bc2da7 | 2018-10-31 06:34:40 | Add cmake rules into dist archive Fixes: #502 Refs: #551 | |
|
33053cdd | 2018-10-31 01:22:30 | Merge branch 'event-ET-#636-v2' * event-ET-#636-v2: Preserve ET bit for backends with changelist Epoll ET setting lost with multiple events for same fd Cover ET with multiple events for same fd Add ET flag into event_base_dump_events() Fixes: #636 | |
|
a1293bd2 | 2018-10-30 23:59:24 | Preserve ET bit for backends with changelist | |
 |
b77d3e78 | 2018-10-30 08:50:08 | Epoll ET setting lost with multiple events for same fd After two or more events have been registered for the same file descriptor using EV_ET, if one of the events is deleted, then the epoll_ctl() call issued by libevent drops the EPOLLET flag resulting in level triggered notifications. [ azat: use existing "et" in the evmap_io_del_() ] | |
|
77c0e510 | 2018-10-31 00:09:38 | Cover ET with multiple events for same fd [ azat: test cleanup ] | |
|
aa07cbac | 2018-10-29 22:22:00 | Add ET flag into event_base_dump_events() | |
|
e17e1ee9 | 2018-10-28 20:52:32 | appveyor: reconfigure tests with allow_failure and fast_finish | |
|
fb866645 | 2018-10-28 19:48:37 | Merge branch 'win32-visibility-event_debug_logging_mask_' * win32-visibility-event_debug_logging_mask_: Introduce EVENT_VISIBILITY_WANT_DLLIMPORT regress_http: use TT_BLAZER() over event_debug() Fixes: #702 | |
|
9cba915e | 2018-10-28 19:30:34 | Introduce EVENT_VISIBILITY_WANT_DLLIMPORT And use it in places where event_debug() should be called (since it requires access to "event_debug_logging_mask_" and in win32 it is tricky). One of this places that is covered by this patch is the test for event_debug(). | |
|
5cfb6120 | 2018-10-28 19:27:05 | regress_http: use TT_BLAZER() over event_debug() Later is pretty tricky due to exporting event_debug_logging_mask_ symbol for win32. | |
|
23e79fd7 | 2018-10-28 18:11:22 | Check existence of IPV6_V6ONLY in evutil_make_listen_socket_ipv6only() (mingw32) MinGW 32-bit 5.3.0 does not defines it and our appveyour [1] build reports this instantly: evutil.c: In function 'evutil_make_listen_socket_ipv6only': evutil.c:392:40: error: 'IPV6_V6ONLY' undeclared (first use in this function) return setsockopt(sock, IPPROTO_IPV6, IPV6_V6ONLY, (void*) &one, [1]: https://www.appveyor.com/docs/windows-images-software/#mingw-msys-cygwin Another solution will be to use mingw64 which has it, but I guess we do want that #ifdef anyway. | |
|
931ec237 | 2018-10-28 16:46:24 | Convert evbuffer_strspn() (internal helper) to use size_t As pointed by @yankeehacker in #590: Signed to Unsigned Conversion Error - buffer.c:1623 Description: This assignment creates a type mismatch by populating an unsigned variable with a signed value. The signed integer will be implicitly cast to an unsigned integer, converting negative values into positive ones. If an attacker can control the signed value, it may be possible to trigger a buffer overflow if the value specifies the length of a memory write. Remediation: Do not rely on implicit casts between signed and unsigned values because the result can take on an unexpected value and violate weak assumptions made elsewhere in the program. Fixes: #590 | |
|
f83ac92d | 2018-10-28 15:16:24 | buffer: add an assert for last_with_datap to suppress static analyzer ../buffer.c:2231:6: warning: Access to field 'flags' results in a dereference of a null pointer if (CHAIN_SPACE_LEN(*firstchainp) == 0) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../buffer.c:130:30: note: expanded from macro 'CHAIN_SPACE_LEN' #define CHAIN_SPACE_LEN(ch) ((ch)->flags & EVBUFFER_IMMUTABLE ? \ | |
 |
731469b3 | 2014-06-13 16:08:04 | libevent.pc: link against core/extra Since we want people to stop using -levent, have the pkg-config file also stop linking against that. This makes it easier to delete the libevent.so library entirely. Closes: #141 | |
|
fb42e0fa | 2018-10-28 02:00:16 | bench_cascase: include getopt.h only for _WIN32 (like in other places) Fixes: #561 | |
 |
99a3887d | 2017-09-23 06:57:16 | Define __EXT_POSIX2 for QNX POSIX 1003.2 extension is necessary for getopt interface. Reported here [1] (not mine, I can't test) [1]: https://mail-index.netbsd.org/pkgsrc-users/2017/09/20/msg025601.html Closes: #563 (cherry-pick) | |
|
9fe952a0 | 2018-10-27 19:34:52 | regress_ssl: reset static variables on test setup/cleanup and eliminate leaks One tricky bit is reply to the BIO_C_GET_FD command, since otherwise it will try to close(0) and accepted bev in ssl/bufferevent_connect_sleep will leak. Other seems more or less trivial. This was done to make sure that for at least generic cases does not leak (tricky cases was listed here nmathewson/Libevent#83). And this will allow run ssl/.. with --no-fork | |
|
7cec9b95 | 2018-10-27 19:41:52 | test: export basic_test_setup/basic_test_cleanup to extend them | |
|
5264c03f | 2018-10-27 23:58:18 | travis-ci: do not notify irc.oftc.net#libevent I think that this just introduce noise that people just turns off. So very questionable let's remove it. | |
|
acf09c00 | 2018-10-27 18:35:08 | be_openssl: avoid leaking of SSL structure From nmathewson/Libevent#83 by @fancycode: There are a few code paths where the passed SSL object is not released in error cases, even if BEV_OPT_CLOSE_ON_FREE is passed as option while for others it is released. That way it's impossible for the caller to know it he has to free it on errors himself or not. Line numbers are from "bufferevent_openssl.c" in 911abf3: L1414 ("underlying == NULL" passed) L1416 (bio could not be created) L1446 (different fd passed) L1325 (both underlying and fd passed) L1328 (out-of-memory) L1333 ("bufferevent_init_common_" failed) In all error cases after the "bufferevent_ops_openssl" has been assigned, the option is evaluated on "bufferevent_free" (L1399) and the SSL object released (L1226). Fixes: nmathewson/Libevent#83 | |
|
474d72ae | 2018-10-27 18:29:57 | be_openssl: drop close_flag parameter of the BIO_new_bufferevent() | |
|
26ef859a | 2018-10-27 17:21:35 | Add evhttp_parse_query_str_flags() And a set of flags: - EVHTTP_URI_QUERY_LAST - EVHTTP_URI_QUERY_NONCONFORMANT Fixes: #15 | |
|
d161ec38 | 2018-10-27 17:36:09 | regress_http: basic evhttp_parse_query_str() coverage | |
|
8348b413 | 2018-10-27 14:58:30 | cmake: add various warning flags like autotools has This is mostly to match autotools and reduce amount mixiing declarations and code. Added: - -Wextra (the same as -W), -Wno-unused-parameter -Wstrict-aliasing - -fno-strict-aliasing (gcc 2.9.5+) - -Winit-self -Wmissing-field-initializers -Wdeclaration-after-statement (4.0+) - -Waddress -Wno-unused-function -Wnormalized=id -Woverride-init (4.2+) - -Wlogical-op (4.5+) Removed: - -Wformat (include in -Wall) Plus use CMAKE_C_COMPILER_ID over CMAKE_COMPILER_IS_GNUCC, as cmake-variables(7) suggesting, and add common GNUC/CLANG variables. v2: drop checks for flags, since add_compiler_flags() will check if such flags exists anyway (but just to note, gcc ignores non existing warning flags by default). | |
|
006c528a | 2018-10-27 16:49:39 | autotools: do not add warnings that is included into -Wall already Plus remove duplicates | |
 |
387d91f9 | 2018-06-04 16:43:34 | listener: ipv6only socket bind support According to RFC3493 and most Linux distributions, default value is to work in IPv4-mapped mode. If there is a requirement to bind same port on same ip addresses but different handlers for both IPv4 and IPv6, it is required to set IPV6_V6ONLY socket option to be sure that the code works as expected without affected by bindv6only sysctl setting in system. See an example working with this patch: https://gist.github.com/demirten/023008a63cd966e48b0ebcf9af7fc113 Closes: #640 (cherry-pick) | |
|
b2667b76 | 2018-10-25 00:50:50 | Merge branch 'evutil_found_ifaddr-dev' * evutil_found_ifaddr-dev: Cover evutil_v4addr_is_local_()/evutil_v6addr_is_local_() Split evutil_found_ifaddr() into helpers (evutil_v{4,6}addr_is_local()) Use INADDR_ANY over 0 in evutil_found_ifaddr() Replace EVUTIL_V4ADDR_IS_*() macroses with static inline functions Filter link-local IPv4 addresses in evutil_found_ifaddr() | |
|
32349ab6 | 2018-10-25 00:25:48 | Cover evutil_v4addr_is_local_()/evutil_v6addr_is_local_() | |
|
6966d39f | 2018-10-25 00:01:59 | Split evutil_found_ifaddr() into helpers (evutil_v{4,6}addr_is_local()) | |
|
d5f85257 | 2018-10-24 23:47:01 | Use INADDR_ANY over 0 in evutil_found_ifaddr() | |
|
ab406fca | 2018-10-24 23:43:28 | Replace EVUTIL_V4ADDR_IS_*() macroses with static inline functions Macros over static inline over and over again: - readability - type safety | |
|
117dc921 | 2018-10-24 11:51:57 | Filter link-local IPv4 addresses in evutil_found_ifaddr() Fixes: #668 | |
|
0ec12bc8 | 2018-10-23 00:12:23 | Merge branch 'http-request-line-parsing' * http-request-line-parsing: Fix http https_basic/https_filter_basic under valgrind (increase timeout) http: cover various non RFC3986 conformant URIs http: allow non RFC3986 conformant during parsing request-line (http server) http: do not try to parse request-line if we do not have enough bytes http: allow trailing spaces (and only them) in request-line (like nginx) http: cleanup of the request-line parsing | |
|
5f1b4dfa | 2018-10-23 00:06:47 | Fix http https_basic/https_filter_basic under valgrind (increase timeout) | |
|
15bfe712 | 2018-10-22 23:38:42 | http: cover various non RFC3986 conformant URIs - http/basic_trailing_space -- covers cases when there is trailing space after the request line (nginx handles this) - http/simple_nonconformant -- covers non RFC3986 conformant URIs | |
|
b94d913d | 2018-10-22 23:52:46 | http: allow non RFC3986 conformant during parsing request-line (http server) Reported-by: lsdyst@163.com | |
|
64ead341 | 2018-10-22 23:56:50 | http: do not try to parse request-line if we do not have enough bytes | |
|
254fbc81 | 2018-10-22 23:56:19 | http: allow trailing spaces (and only them) in request-line (like nginx) | |
|
6cf659b0 | 2018-10-22 23:25:01 | http: cleanup of the request-line parsing | |
|
2f43d1d4 | 2018-10-22 01:06:48 | Disable parallel jobs for the osx (due to CPU time deficit) in travis-ci As you can see right now linux workers has zero failed tests, while osx workers has 18 failed tests: [bufferevent_connect_hostname_emfile FAILED] [bufferevent_pair_release_lock FAILED] [bufferevent_timeout FAILED] [bufferevent_timeout_filter FAILED] [bufferevent_timeout_pair FAILED] [common_timeout FAILED] [del_wait FAILED] [immediatesignal FAILED] [loopexit FAILED] [loopexit_multiple FAILED] [monotonic_res FAILED] [no_events FAILED] [persistent_active_timeout FAILED] [persistent_timeout_jump FAILED] [signal_switchbase FAILED] [signal_while_processing FAILED] [simpletimeout FAILED] [usleep FAILED] And this patch should remove from this list time related failures (though maybe not all of them). | |
|
5d3e8c15 | 2018-10-22 01:00:54 | Use matrix.fast_finish for the travis-ci to mark the build ASAP AFAIR there is shortage of osx workers on travis-ci, IOW builds that requires them can wait fair amount of time in the queue by just waiting. Plus linux workers AFAICS can run multiple jobs in parallel (4-5), while osx does not. Hence if we do allow failures for osx (and right now they have a lot of failed tests) let's mark build result based on tests under linux only. So in a nut shell this will reduce build time from 5 hours to 20-30 minutes. | |
|
6ac8e775 | 2018-10-21 18:31:01 | Simplify bufferevent timeout tests to reduce CPU usage in between start/compare Between start (setting "started_at") and comparing the time when timeouts triggered with the start (test_timeval_diff_eq), there is too much various things that can introduce extra delays and eventually could fail the test on machine with shortage of CPU. And this is exactly what happend on: - travis-ci - #262 Here is a simple reproducer that I came up with for this issue: docker run --cpus=0.01 -e LD_LIBRARY_PATH=$PWD/lib -e PATH=/usr/bin:/bin:$PWD/bin -v $PWD:$PWD --rm -it debian:testing regress --no-fork --verbose bufferevent/bufferevent_timeout Under limited CPU (see reproducer) the test almost always has problems with that "write_timeout_at" exceed default timeval diff tolerance (test_timeval_diff_eq() has 50 tolerance), i.e.: FAIL ../test/regress_bufferevent.c:1040: assert(labs(timeval_msec_diff(((&started_at)), ((&res1.write_timeout_at))) - (100)) <= 50): 101 vs 50 But under some setup write timeout can even not triggered, and the reason for this is that we write to the bufferevent 1024*1024 bytes, and hence if evbuffer_write_iovec() will has some delay after writev() and not send more then one vector at a time [1], it is pretty simple to trigger, i.e.: FAIL ../test/regress_bufferevent.c:1040: assert(labs(timeval_msec_diff(((&started_at)), ((&res1.write_timeout_at))) - (100)) <= 50): 1540155888478 vs 50 [1]: https://gist.github.com/azat/b72773dfe7549fed865d439e03de05c1 So this patch just send static small payload for all cases (plus a few more asserts added). The outcome of this patch is that all regression tests passed on travis-ci for linux box [2]. While before it fails almost always [3]. Also reproducer with CPU limiting via docker also survive some iterations (and strictly speaking it should has less CPU then travis-ci workers I guess). [2]: https://travis-ci.org/azat/libevent/builds/444391481 [3]: https://travis-ci.org/libevent/libevent/builds/444336505 | |
 |
3e6553a1 | 2018-08-09 13:04:52 | evdns: handle NULL filename explicitly Otherwise we will try to open NULL filename and got EFAULT and anyway will got the same return code from evdns_base_resolv_conf_parse_impl() Closes: #680 (cherry-picked) | |
|
fb090aa6 | 2018-10-21 03:18:48 | Revert "travis-ci: use travis_retry to reduce number of problems with flacky tests" That was a bad idea, because all this patch did is just uses extra CPU time on travis-ci workers and eventually fail the build anyway. It also increases time of executing one matrix entry (x3). This reverts commit 7004ee8e869faabe3a284fb3d7eb859fb50ef90c. | |
|
bd2184d8 | 2018-10-21 03:15:34 | Merge branch 'regress-dns-fixes' * regress-dns-fixes: Do not rely on getservbyname() for most of the dns regression tests Turn off dns/getaddrinfo_race_gotresolve by default Fix an error for debug locking in dns/getaddrinfo_race_gotresolve | |
|
2cb8eae7 | 2018-10-21 03:03:25 | Do not rely on getservbyname() for most of the dns regression tests There is only one test that uses service name getaddrinfo_async, which manually check whether it works or not, other should not assume that it is available and works. There was already an attempt to overcome some possible limitations, like lack of "http" in /etc/services in d6bafbbeb27ff3943d6f3b6783bcded76384c31e ("test/dns: replace servname since solaris does not have "http"") | |
|
7198bbb8 | 2018-10-21 03:03:57 | Turn off dns/getaddrinfo_race_gotresolve by default It is: - pretty internal regression - CPU bound - right now failed on travis-ci machines | |
|
09c74f71 | 2018-10-21 02:50:04 | Fix an error for debug locking in dns/getaddrinfo_race_gotresolve When there is no /etc/services file evdns_getaddrinfo() will fail (with service="ssh") and hence it will go to then "end" label with locked rp.lock which in case of debug locking checks will bail with: [err] ../evthread.c:220: Assertion lock->count == 0 failed in debug_lock_free So add rp.locked flag, and unlock the lock before freeing it if it is in locked state. And here is how you can reproduce the issue: $ docker run -e LD_LIBRARY_PATH=$PWD/lib -e PATH=/usr/bin:/bin:$PWD/bin -v $PWD:$PWD --rm -it debian:testing regress dns/getaddrinfo_race_gotresolve (since debian:testing does not have /etc/services) | |
 |
95918754 | 2018-05-23 15:39:13 | Fix missing LIST_HEAD Despite the presence of 'sys/queue.h' in some stdlib implementations (i.e. uclibc) 'LIST_HEAD' macro can be missing. This fix defines this macro in the same manner as was done previously for 'TAILQ_'. Fixes: #539 Closes: #639 (cherry-picked) Backport: 2.1.9 | |
|
4c61a04c | 2018-10-18 23:16:05 | Make cmake's check_const_exists() rely on cache | |
|
878bb2d3 | 2018-10-17 23:21:32 | Merge branch 'be-wm-overrun-v2' * be-wm-overrun-v2: Fix hangs due to watermarks overruns in bufferevents implementations test: cover watermarks (with some corner cases) in ssl bufferevent Fixes: #690 |