-
Show log
Commit
-
Hash : c281aba3
Author :
Date : 2010-10-24T11:38:29
Fix a nasty bug related to use of dup() with epoll on Linux Current versions of the Linux kernel don't seem to remove the struct epitem for a given (file,fd) combo when the fd is closed unless the file itself is also completely closed. This means that if you do: fd = dup(fd_orig); add(fd); close(fd); dup2(fd_orig, fd); add(fd); you will get an EEXIST when you should have gotten a success. This could cause warnings and dropped events when using dup and epoll. The solution is pretty simple: when we get an EEXIST from EPOLL_CTL_ADD, we retry with EPOLL_CTL_MOD. Unit test included to demonstrate the bug. Found due to the patient efforts of Gilad Benjamini; diagnosed with help from Nicholas Marriott.
-
Files
- Makefile.am
- Makefile.nmake
- bench.c
- bench_cascade.c
- bench_http.c
- bench_httpclient.c
- regress.c
- regress.h
- regress.rpc
- regress_buffer.c
- regress_bufferevent.c
- regress_dns.c
- regress_et.c
- regress_http.c
- regress_iocp.c
- regress_listener.c
- regress_main.c
- regress_minheap.c
- regress_rpc.c
- regress_ssl.c
- regress_testutils.c
- regress_testutils.h
- regress_thread.c
- regress_util.c
- regress_zlib.c
- test-changelist.c
- test-eof.c
- test-init.c
- test-ratelim.c
- test-ratelim.sh
- test-time.c
- test-weof.c
- test.sh
- tinytest.c
- tinytest.h
- tinytest_demo.c
- tinytest_local.h
- tinytest_macros.h
-
Properties
