Commit 3874fd9865eef72a5cf5a761781b51f8db9fa267
2022-10-10T17:58:48
Fix strict aliasing problem in aarch64 ffi_call (#739) The assignment a = &dest in ffi_call_int may be moved after the call to extend_integer_type because that function accesses the assigned value with a different type. Co-authored-by: Andreas Schwab <schwab@suse.de>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53
diff --git a/src/aarch64/ffi.c b/src/aarch64/ffi.c
index 83e5653..be87051 100644
--- a/src/aarch64/ffi.c
+++ b/src/aarch64/ffi.c
@@ -323,24 +323,40 @@ extend_integer_type (void *source, int type)
switch (type)
{
case FFI_TYPE_UINT8:
- return *(UINT8 *) source;
+ UINT8 u8;
+ memcpy (&u8, source, sizeof (u8));
+ return u8;
case FFI_TYPE_SINT8:
- return *(SINT8 *) source;
+ SINT8 s8;
+ memcpy (&s8, source, sizeof (s8));
+ return s8;
case FFI_TYPE_UINT16:
- return *(UINT16 *) source;
+ UINT16 u16;
+ memcpy (&u16, source, sizeof (u16));
+ return u16;
case FFI_TYPE_SINT16:
- return *(SINT16 *) source;
+ SINT8 s16;
+ memcpy (&s16, source, sizeof (s16));
+ return s16;
case FFI_TYPE_UINT32:
- return *(UINT32 *) source;
+ UINT8 u32;
+ memcpy (&u32, source, sizeof (u32));
+ return u32;
case FFI_TYPE_INT:
case FFI_TYPE_SINT32:
- return *(SINT32 *) source;
+ SINT8 s32;
+ memcpy (&s32, source, sizeof (s32));
+ return s32;
case FFI_TYPE_UINT64:
case FFI_TYPE_SINT64:
- return *(UINT64 *) source;
+ UINT64 u64;
+ memcpy (&u64, source, sizeof (u64));
+ return u64;
break;
case FFI_TYPE_POINTER:
- return *(uintptr_t *) source;
+ uintptr_t uptr;
+ memcpy (&uptr, source, sizeof (uptr));
+ return uptr;
default:
abort();
}