Commit 98b52960485a261399f081915f36063de3854a5f

Anthony Green 2014-03-16T07:51:33

Merge pull request #94 from joshtriplett/esp-extra-stackery-perception ChangeLog: Document testsuite changes to remove fragile stack pointer checks

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
diff --git a/ChangeLog b/ChangeLog
index 2cd55b6..5850829 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,16 @@
 2014-03-16  Josh Triplett <josh@joshtriplett.org>
 
+	* testsuite/libffi.call/closure_stdcall.c,
+	testsuite/libffi.call/closure_thiscall.c: Remove fragile stack pointer
+	checks.  These files included inline assembly to save the stack
+	pointer before and after the call, and compare the values.  However,
+	compilers can and do leave the stack in different states for these two
+	pieces of inline assembly, such as by saving a temporary value on the
+	stack across the call; observed with gcc -Os, and verified as spurious
+	through careful inspection of disassembly.
+
+2014-03-16  Josh Triplett <josh@joshtriplett.org>
+
 	* testsuite/libffi.call/many.c: Avoid spurious failure due to excess
 	floating-point precision.
 	* testsuite/libffi.call/many_win32.c: Ditto.