Commit c00a49ecd165b2d06c1c9b249d212dc843fa116f

Josh Triplett 2014-03-15T22:08:19

testsuite/libffi.call/many.c: Avoid spurious failure due to excess precision The test case testsuite/libffi.call/many.c can spuriously fail due to excess floating-point precision. Instrumenting it with some printf calls shows differences well above FLT_EPSILON. (Note when instrumenting it that multiple computations of the difference, such as one in a print and another in the conditional, may produce different results.) Rather than complicating the test suite with architecture-specific flags to avoid excess precision, just simplify the floating-point computation to avoid a dependency on potential excess precision.

1
2
3
4
5
6
7
8
9
10
11
12
13
diff --git a/testsuite/libffi.call/many.c b/testsuite/libffi.call/many.c
index 11818e6..5447664 100644
--- a/testsuite/libffi.call/many.c
+++ b/testsuite/libffi.call/many.c
@@ -32,7 +32,7 @@ static float many(float f1,
 	 (double) f11, (double) f12, (double) f13);
 #endif
 
-  return f1/f2+f3/f4+f5/f6+f7/f8+f9/f10+f11/f12+f13;
+  return f1+f2+f3+f4+f5+f6+f7+f8+f9+f10+f11+f12+f13;
 }
 
 int main (void)