src


Log

Author Commit Date CI Message
Saleem Abdulrasool 3c372c38 2017-10-24T13:53:56 arm: fix a level of indirection issue Rather than relying on the stack being 0'ed out always, do it manually. The stack generally happened to be zero, and because the compiler realizes that the tests are dealing with chars truncates the read value. However, the top 3 nibbles of the value are undefined and may be non-zero. The indirection level caused a null-pointer dereference. Explicitly scribbling on the stack during the allocation causes test failures without the original zexting behaviour.
Sergei Trofimovich ed7488c0 2017-10-17T13:00:51 src/ia64/unix.S: unbreak small struct handling commit 6e8a4460833594d5af1b4539178025da0077df19 added FFI_TYPE_COMPLEX value type (comes after FFI_TYPE_POINTER) ia64 ffi_closure_unix reiles on the ordering of FFI_ enums as ia64 has ia64-specific FFI types: small struct and FPU extesions. As a result all tests handling small structs broke. The change fixes dispatch table by adding (no-op) FFI_TYPE_COMPLEX entry This has positive effect of unbreaking most tests on ia64: === libffi Summary === -# of expected passes 1595 -# of unexpected failures 295 +# of expected passes 1930 +# of unexpected failures 10 # of unsupported tests 30 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Saleem Abdulrasool 7ad0ae7f 2017-10-10T11:44:05 arm: zext return value parameters The closure function (invoked as closure->fun in ffi_closure_XXX_inner) will only populate the actual number of bytes for the true return type, which may be a character. This leaves garbage on the stack when the assembly closure function (i.e. ffi_closure_XXX) reads the return value off of the stack into r0 as a 4-byte value. ffi_closure_XXX always leaves room for at least 4 bytes here, so we can safely set them to 0. Otherwise, if there is garbage in any of these bytes, these end up in r0 and in the returned value as well.
Anthony Green 93d8e7dd 2017-09-27T21:51:34 Fix #265
Anthony Green 02a5145a 2017-09-27T21:43:03 Merge pull request #263 from ksjogo/master fix ios builds
Anthony Green 10099d6c 2017-09-27T20:54:09 Merge pull request #271 from frida/fix/qnx-cache-flushing arm: Fix cache flushing on QNX
Anthony Green db4dad97 2017-09-27T20:47:08 Merge pull request #312 from fjricci/fix_ub Fix misaligned memory access in ffi_call_int
Francis Ricci 9c12209d 2017-08-03T10:46:28 Fix misaligned memory access in ffi_call_int
Tony Reix 0ff9419f 2017-05-17T14:57:53 This patch enables FFI Go Closure on AIX.
Gregory Pakosz bd72848c 2017-04-27T13:20:36 Prefix ALIGN macros with FFI_
Ole André Vadla Ravnås 57d8ff04 2017-03-15T01:43:11 Simplify iOS trampoline table allocation By using VM_FLAGS_OVERWRITE there is no need for speculatively allocating on a page we just deallocated. This approach eliminates the race-condition and gets rid of the retry logic.
Johannes Goslar 00406945 2016-07-12T16:08:42 Update Xcodeproj Include all currently relevent files. Call autogen is build script. Fix compiler settings. Fix mach include.
Anthony Green a94c999b 2017-03-19T07:36:07 Handle fastcall declaration differently for some Microsoft compilers
Anthony Green a0b14eea 2017-03-17T09:20:40 Merge pull request #291 from ramon-garcia/visual-studio-build Build with Visual C++ (64 bits)
Ole André Vadla Ravnås d42ce7b9 2017-03-15T01:23:40 Fix error path so mutex is unlocked before returning In the unusual case where ffi_trampoline_table_alloc() fails.
Ramón García Fernández 1e0d107b 2017-01-08T20:12:59 Modify configure.host to detect compilation with Microsoft Visual C++ and use assembly with Intel syntax in that case
Richard Henderson 256ce51c 2016-09-01T13:54:51 Merge pull request #273 from wbx-github/master m68k: support ISA-A Coldfire CPUs
Richard Henderson 2ded2a4f 2016-09-01T13:30:45 Merge pull request #272 from yousong/mips64-soft-float Mips64 soft float
Yuriy Kolerov b545ff81 2016-08-23T20:23:37 ARC: Remove unused variable Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com>
Waldemar Brodkorb 52a11f6d 2016-08-20T00:52:19 m68k: support ISA-A Coldfire CPUs Fix compilation for m68k/coldfire CPUs like mcf5208. Signed-off-by: Thorsten Glaser <tg@mirbsd.de> Signed-off-by: Waldemar Brodkorb <wbx@uclibc-ng.org>
Yousong Zhou 7a0d2c83 2016-08-15T15:00:13 mips: fix MIPS softfloat build issue The patch for o32.S is taken from OpenWrt packages repo 3a7a4bf "libffi: fix MIPS softfloat build issue with current binutils" Signed-off-by: Felix Fietkau <nbd@openwrt.org> Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
Tom Tromey 06d7c519 2016-08-10T15:06:16 Merge pull request #269 from frida/fix/aarch64-variadic-closures-on-ios aarch64: Fix handling of variadic closures on iOS
Tom Tromey aa7ed78c 2016-08-10T15:03:37 Merge pull request #268 from frida/fix/aarch64-large-aggregates aarch64: Fix handling of aggregates larger than 16 bytes
Ole André Vadla Ravnås 4da814b1 2016-08-10T22:48:09 aarch64: Fix handling of aggregates larger than 16 bytes Instead of allocating stack space for a pointer we would allocate stack space for the actual aggregate size.
s1341 ed848834 2016-08-10T14:57:22 arm: Fix cache flushing on QNX Use `msync()` directly as `__clear_cache()` is broken in the qnx650_gcc4.8.3 toolchain.
Ole André Vadla Ravnås 5e9ac7e2 2016-08-10T15:22:19 aarch64: Fix warning about unused function on iOS
Ole André Vadla Ravnås 4d1f11f6 2016-08-10T15:21:42 aarch64: Fix operand size warning reported by Clang
Ole André Vadla Ravnås 301166b1 2016-08-10T15:59:56 aarch64: Fix handling of variadic closures on iOS
Tom Tromey cf4b2a50 2016-06-17T10:09:44 Don't dereference "ecif" before NULL check Fixes #260
Richard Henderson 794a54d4 2016-06-05T14:57:00 Mark win64.S with GNU-stack note
Iain Sandoe 52fbd12d 2016-05-26T09:00:00 [Darwin-ppc, build] Fixes for clang build. clang is experimental on powerpc-darwin, but the changes are appropriate to cctools as as well. Use the 'official' simplified cmpwi insn, rather than the implied one accepted by cctools. Do not re-use a set value.
Iain Sandoe 92810b4b 2016-05-26T08:56:51 [Darwin-x86, build] Fix up label prefixes, remove .purgem Darwin uses a label prefix of _. cctools assembler will not accept .purgem as a directive.
Berker Peksag 74b3f520 2016-05-19T18:05:36 Remove unused FFI_CLOSURE_TEST It was here since the first commit c6dddbd (warning: huge diff) and it wasn't defined by the configure script. It was probably used manually during development.
Tom Tromey 0969a1c1 2016-05-18T10:09:28 Merge pull request #232 from berkerpeksag/signcompare Fix -Wsign-compare warnings in x86/ffi64.c
Berker Peksag 1e82e1cd 2016-03-07T18:38:10 Define _GNU_SOURCE on Linux for mremap() This was committed to CPython's libffi copy in https://bugs.python.org/issue10309 mremap() documentation says _GNU_SOURCE needs to be defined in order to use mremap(): see the synopsis section at http://linux.die.net/man/2/mremap Original commit: https://hg.python.org/cpython/rev/9986fff720a2 Original patch was written by Hallvard B Furuseth.
Berker Peksag 4a677a42 2016-03-05T09:58:38 Fix -Wsign-compare warnings in x86/ffi64.c This was originally reported on the Python tracker: httpa://bugs.python.org/issue23958 The original patch was written by Steve R. Hastings. I've updated it to current master of libffi.
Tom Tromey 9443eaed 2016-05-17T17:04:50 Merge pull request #242 from somasis/master Fix usage on musl libc
Richard Henderson 48bfae1f 2016-05-02T20:58:57 Merge pull request #236 from andreas-schwab/master Define FFI_SIZEOF_JAVA_RAW for aarch64 ILP32
Kylie McClain e169ba2b 2016-04-29T21:04:07 Fix usage on musl libc A gcc compiled on musl does not define __gnu_linux__, it defines __linux__. Only on glibc does __gnu_linux__ get defined, but both define __linux__, so we should check for that instead. With this patch, libffi works perfectly, and passes its testsuite entirely on musl libc systems.
Richard Henderson e5843a3a 2016-04-15T16:10:08 x86: Fix calling convention for ffi_closure_win64_inner Also enable testing for the cross-abi calls.
Richard Henderson d0675197 2016-03-07T12:14:22 x86: Copy fix for clang .org from unix64.S Clang doesn't understand .org with symbolic operands.
Andreas Schwab d76975db 2016-03-16T12:23:07 Define FFI_SIZEOF_JAVA_RAW for aarch64 ILP32 Like x32, aarch64 ILP32 needs to define FFI_SIZEOF_JAVA_RAW. This fixes the java interpreter.
Tom Tromey 38a4d72c 2015-11-17T21:18:20 add ffi_get_struct_offsets
Anthony Green 49b95eda 2016-02-20T06:49:40 Merge pull request #194 from amodra/master Correct powerpc sysv stack argument accounting
Anthony Green 415723b4 2016-02-20T06:49:19 Merge pull request #104 from joshtriplett/efi64 Support the Windows/EFI calling convention on all x86-64 targets
Anthony Green 69143d06 2016-02-20T06:44:28 Merge pull request #197 from foxsen/mips_go_closure Mips go closure support
Russell Keith-Magee bc4fc07a 2015-12-21T00:37:06 Fixed #181 -- Corrected problems with ARMv7 build under iOS. Based on a patch from @fealebenpae, with input from @SolaWing and @rth7680, and testing from @superdump.
Zhang Fuxin 505346e1 2015-08-26T09:57:10 fix type error in unwind code
foxsen 5953c66b 2015-08-20T20:28:13 add unwind infor for *go_closure; reorder the labels to make thing more clear
Zhang Fuxin f0ecd5d4 2015-08-11T12:47:36 fix O32 stack unwind code add missing 1: label
foxsen 6f0201c8 2015-08-04T18:25:34 various fixes for go closure support. Now all n64 tests passed.
foxsen 697dd4e8 2015-08-04T12:53:33 add support for go closure support on mips
Alan Modra 43fc5bca 2015-08-03T23:34:05 Correct powerpc sysv stack argument accounting ppc32 starts using the stack for integer arg passing when we run out of integer arg passing registers. Similarly, we start using the stack for floating point args when we run out of floating point registers. The decision on where an integer arg goes does not depend on number of floating point args, nor does the decision on where a floating point arg goes depend on number of integer args. Alignment of stack args also simply depends on number of stack args. This patch untangles the horrible mess we had, with intarg_count being wrongly used to count both integer args and stack words. * src/powerpc/ffi_sysv.c (ffi_prep_cif_sysv_core): Count fprs, gprs, and stack words separately. (ffi_prep_args_SYSV): Similarly.
Josh Triplett 1f6b5a91 2015-07-26T16:27:34 Support the WIN64/EFI64 calling convention on all X86_64 platforms Add a new calling convention FFI_EFI64, alias FFI_WIN64, on all X86_64 platforms. This allows libffi compiled on a 64-bit x86 platform to call EFI functions. Compile in ffiw64.c and win64.S on all X86_64 platforms. When compiled for a platform other than X86_WIN64, ffiw64.c suffixes its functions with _efi64, to avoid conflict with the platform's actual implementations of those functions.
Josh Triplett 6de51f3e 2015-07-26T16:23:55 src/x86/ffiw64.c: Don't assign a "char *" to an "unsigned char *" Declare a local variable to match the type of the struct field assigned to it, rather than adding unsigned to the type. Fixes a -Wpointer-sign warning.
Josh Triplett eaa59755 2015-07-26T17:17:16 src/x86/win64.S: Handle name mangling and PIC Move the macros from unix64.S into a shared header asmnames.h and use them in win64.S too.
Josh Triplett c8e82d9f 2015-07-26T16:18:57 src/x86/win64.S: Support compiling on non-WIN64 platforms Non-WIN64 versions of the GNU assembler don't support the .seh_* directives for structured exception handling, so wrap them in a macro that compiles to nothing. Handle the registers used for the non-Windows x86-64 calling convention when on a non-Windows platform. Distinguish between cases that should refer to the native argument registers (defined as arg0, arg1, arg2, and arg3) and cases that should always refer to the Windows argument registers.
Russell Keith-Magee e3d2812c 2015-04-25T19:03:03 Modified arm/sysv.S to remove directives not allowed by clang.
Andrew Pinski 95df3791 2015-02-11T08:31:48 aarch64: Handle ILP32 ABI
Richard Henderson 2104b2a4 2015-01-26T12:43:57 sparc: Re-introduce hand-written unwind info Fixes the build with the Solaris assembler.
Anthony Green 31a61853 2015-01-21T05:55:47 Merge pull request #170 from fealebenpae/aarch64-trampoline-table Support closures on ARM64 iOS
Richard Henderson 3ac1610a 2015-01-19T20:48:40 x86: Fix cygwin32 build The section syntax is just that little bit different.
Richard Henderson 1ad0b171 2015-01-16T13:30:05 sparc: Also mark the return address in unwind info
Richard Henderson d68c8aed 2015-01-16T11:40:33 sparc: Solaris fixes, part 2 /bin/as seems to only understand single-digit labels /bin/as knows nothing about .rept/.endr
Rainer Orth b740ab7c 2015-01-16T11:32:23 sparc: Solaris fixes * /bin/as requires .type fn,#function instead of @function. * /bin/as doesn't support .macro/.endm. I'm using preprocessor macros instead to implement E in src/sparc/v[89].S.
Rainer Orth f1560b7b 2015-01-16T11:31:37 x86: Solaris fixes * Solaris/x86 /bin/as doesn't support .org, so I've just disabled the uses in src/x86/{sysv, unix64}.S, as on Darwin. * Solaris/x86 needs to use EH_FRAME_FLAGS so manually and compiler generated .eh_frame sections match, otherwise libffi.so fails to link: * Solaris/x86 /bin/as has different COMDAT syntax; I've disabled it for the moment.
Yavor Georgiev 53636634 2015-01-16T15:19:38 aarch64: implement the trampoline table workaround for ffi closures on Apple systems This is a direct copy/paste port of the ARM code, with changes because of Aarch64 pc-relative addressing restrictions.
Yavor Georgiev 05e65b4e 2015-01-16T15:18:04 aarch64: rewrite range syntax into list to appease Clang Clang's assembler in Xcode 6 appears to choke when the operand of st4 is a range, but is happy with a list.
Richard Henderson f27c4e46 2015-01-13T07:22:07 x86: Fix thinko in ffi_raw_call Missed structure initialization for raw path. Apparently there are no tests for this outside gcc.
Anthony Green 1c61e73a 2015-01-10T09:23:30 Merge pull request #165 from rth7680/pcc Support PCC as producer and consumer
Anthony Green dd0b59a5 2015-01-10T09:22:55 Merge pull request #164 from rth7680/darwin Fix build on darwin
Anthony Green 9131039c 2015-01-10T09:22:42 Merge pull request #160 from nobu/msvc-no-complex x86: MSVC does not support Complex type
Anthony Green 4ca2262a 2015-01-10T09:21:37 Merge pull request #159 from nobu/fix-void-arith x86: Fix void pointer arithmetic
Richard Henderson 3fa5d70c 2015-01-05T13:03:06 x86: Avoid fastcall when building with pcc Apparently, PCC doesn't support the fastcall calling convention. Nor does it issue a warning or error for the attribute that it does not understand.
Richard Henderson a03d2310 2014-12-24T16:03:34 x86: Load structure return address into eax
Richard Henderson b7f6d7aa 2014-12-10T13:37:36 x86: Reinstate hand-written unwind info for sysv.S
Richard Henderson 6cedf81c 2014-12-10T09:43:58 x86: Expand FFI_GO_CLOSURE If we're going to have to hand-write unwind info for darwin, these macros make the job harder.
Iain Sandoe ae842a51 2014-11-25T11:43:40 x86: More Darwin unwind fixups EHFrame{N} IIRC is a special cue to ld64 that it should treat the unwind in the object as "special/legacy" .. [these days everything is .cfi_xxxx (except, cctools-as, as you noted)] .. without that much confusion arises with ld64's atom-isation of the eh_frame section. xxxx.eh labels are not needed for darwin ld64 >= 85.2.1 (i.e. darwin9, xcode 3.1.4) to all intents and purposes, that's all that matters now, since I think that anyone trying to build on 10.4/darwin8/xcode2.5 would have to use a later ld64 (from odcctools) for other reasons.
Richard Henderson 8fa3c9f2 2014-11-25T09:27:54 x86: Reinstate hand-written unwind info for unix64.S One more try to get default Darwin to work.
Richard Henderson 5f35e0ff 2014-11-24T16:26:50 x86: Avoid using gas local labels Which are unsupported by Darwin cctools as. Thankfully this doesn't uglify the source too much.
Richard Henderson ed1ca277 2014-11-24T13:02:03 x86: Remove use of .cfi_escape The unwind info isn't 100% correct at all points during the epilogue, and not annotating is just as incorrect as the annotation. This works better on systems that do not support DW_OP_call_frame_cfa.
Richard Henderson 1b12593d 2014-11-24T12:55:43 x86: Honor alignment of arguments Darwin aligns long-double to 16, and thus all of the long double tests were failing due to not honoring that. We ought to be able to devise a test case for GCC using __attribute__((aligned)) that would have failed too.
Richard Henderson 042b8daf 2014-11-24T11:24:02 x86: Use .balign not .align The Apple assembler defaults to power of two alignment, rather than byte alignment like everyone else. Force byte alignment by using the proper directive.
Richard Henderson 0172bc02 2014-11-24T10:42:02 x86: Disable .org for Darwin
Richard Henderson 9f112619 2014-11-22T20:02:43 x86: Best guess at update for Darwin
Nobuyoshi Nakada 7282d328 2014-12-22T17:14:40 x86: MSVC does not support Complex type
Nobuyoshi Nakada 5f8881a5 2014-12-22T17:08:08 x86: Fix void pointer arithmetic
Richard Henderson 7ba30b19 2014-12-19T11:38:17 s390: Inline and tidy ffi_prep_args As per discussion with Ulrich Weigand, document the restrictions on the code within ffi_call_int as we simultaneously prepare stack frames for ffi_call_SYSV and the target function.
Richard Henderson f69ec6f3 2014-12-18T16:21:07 s390: Use pc-relative insns in 31-bit mode It's silly to stick to esa/390 features when the compiler won't. Detect when brasl and larl are used by the compiler and then use them in the assembly.
Richard Henderson 2f530de1 2014-12-18T16:01:59 s390: Reorganize assembly Avoid using ffi_prep_args as a callback; do all the work setting up the frame within ffi_call_int directly. Save fewer registers in ffi_closure_SYSV.
Richard Henderson 97512ded 2014-12-18T16:01:15 s390: Avoid aliasing warnings
Richard Henderson c860ca9a 2014-12-17T13:24:03 s390: Kill trailing whitespace
Dominik Vogt 02b7c899 2014-12-17T13:20:51 s390: Go closure support
Anthony Green 75b2199f 2014-12-12T10:13:56 Merge pull request #157 from rth7680/x86 Two fixes for x86
Anthony Green 8a3a2723 2014-12-12T10:13:27 Merge pull request #156 from rth7680/sparc sparc: Define FFI_TARGET_SPECIFIC_VARIADIC for v9
Richard Henderson 2f652469 2014-12-11T14:16:00 x86: Handle void arguments as if an empty structure Since libffi currently doesn't allow empty structures, libgo currently maps them to ffi_type_void. Given that we'll abort on this case, handle it gracefully.
Richard Henderson 097ccfd6 2014-12-10T13:25:14 x86: Fix some unwind errors
James Greenhalgh 9ae3bc87 2014-12-06T23:58:41 Fix for https://github.com/atgreen/libffi/issues/141
Richard Henderson 590663b3 2014-11-18T12:56:58 powerpc: Fix ffi_go_closure_linux64 Unlike ffi_closure_LINUX64, this entry point is called normally, so we already have the TOC in R2 and the closure in R11. * powerpc/linux64_closure.S (ffi_closure_LINUX64): Remove a register dependency chain. (ffi_go_closure_linux64): Don't load r11 or r2.
Alan Modra fa1040c1 2014-11-10T09:42:31 GO closures for powerpc linux Plus .cfi async unwind info, rearrangement of ffi_call_linux64 and ffi_call_SYSV function params to avoid register copies, tweaks to trampolines. * src/powerpc/ffitarget.h (FFI_GO_CLOSURES): Define. * src/powerpc/ffi.c (ffi_call_int): New function with extra closure param, and args rearranged on ffi_call_linux64 and ffi_call_SYSV calls, extracted from .. (ffi_call): ..here. (ffi_call_go, ffi_prep_go_closure): New functions. * src/powerpc/ffi_linux64.c (ffi_prep_closure_loc_linux64): Make hidden. Only flush insn part of ELFv2 trampoline. Don't shuffle ELFv1 trampoline. (ffi_closure_helper_LINUX64): Replace closure param with cif, fun, user_data params. * src/powerpc/ffi_powerpc.h (ffi_go_closure_sysv): Declare. (ffi_go_closure_linux64): Declare. (ffi_call_SYSV, fi_call_LINUX64): Update. (ffi_prep_closure_loc_sysv, ffi_prep_closure_loc_linux64): Declare. (ffi_closure_helper_SYSV, ffi_closure_helper_LINUX64): Update. * src/powerpc/ffi_sysv.c (ASM_NEEDS_REGISTERS): Increase to 6. (ffi_prep_closure_loc_sysv): Use bcl in trampoline, put data words last, flush just the insn part. (ffi_closure_helper_SYSV): Replace closure param with cif, fun and user_data params. * src/powerpc/linux64.S (ffi_call_LINUX64): Replace hand-written .eh_frame with .cfi directives. Adjust for changed param order. Pass extra "closure" param to user function in static chain. Add .cfi directives to describe epilogue. Don't provide traceback table for ELFv2 or _CALL_LINUX. * src/powerpc/linux64_closure.S (ffi_closure_LINUX64): Replace hand-written .eh_frame with .cfi directives. Adjust for changed ffi_closure_helper_LINUX64 params. Add .cfi directives to describe epilogue. Don't provide traceback table for ELFv2 or _CALL_LINUX. (ffi_go_closure_linux64): New function. * src/powerpc/sysv.S: Remove redundant .globl ffi_prep_args_SYSV. (ffi_call_SYSV): Make hidden. Replace hand-written .eh_frame with .cfi directives. Adjust for changed params. Pass extra "closure" param to user function in static chain. Add .cfi directives to describe epilogue. * src/powerpc/ppc_closure.S (ffi_closure_SYSV): Make hidden. Replace hand-written .eh_frame with .cfi directives. Adjust for changed ffi_closure_helper_SYSV params. Add .cfi directives to describe epilogue. Don't just use nops in the dead __NO_FPRS__ epilogues. (ffi_go_closure_sysv): New function.