Log

Author Commit Date CI Message
Sergei Trofimovich 11de69dd 2018-02-11T11:29:39 ia64: fix variadic function closures with FP arguments libffi test framework already flagged failures as: ``` FAIL: libffi.call/cls_double_va.c -W -Wall -Wno-psabi -O0 output pattern test, is 7.0 res: 4 0.0 res: 4 ? should match 7.0 ?es: 4 ?.0 res: 4 ``` Failure happens here at ```c // testsuite/libffi.call/cls_double_va.c ... char* format = "%.1f\n"; double doubleArg = 7; ... CHECK(ffi_prep_closure_loc(pcl, &cif, cls_double_va_fn, NULL, code) == FFI_OK); res = ((int(*)(char*, ...))(code))(format, doubleArg); ``` libffi expects 'doubleArg' to be located in 'f9' (second FP argument) but gcc placed it to 'r33' (second GR). ia64 software [1] manual described argument passing ABI in "8.5.2 Register Parameters" as: """ If an actual parameter is known to correspond to a floating-point formal parameter, the following rules apply: a) The actual parameter is passed in the next available floating-point parameter register, if one is available. Floating-point parameter registers are allocated as needed from the range f8-f15, starting with f8. b) If all available floating-point parameter registers have been used, the actual parameter is passed in the appropriate general register(s). (This case can occur only as a result of homogeneous floating-point aggregates, described below.) If a floating-point actual parameter is known to correspond to a variable-argument specification in the formal parameter list, the following rule applies: c) The actual parameter is passed in the appropriate general register(s). If the compiler cannot determine, at the point of call, whether the corresponding formal parameter is a varargs parameter, it must generate code that satisfies both of the above conditions. (The compiler’s determination may be based on prototype declarations, language standard assumptions, analysis, or other user options or information.) """ We have [c] case here and gcc uses only GR for parameter passing. The change binds known variadic arguments ro GRs instead of FPs as those are always expected to be initialized for all variadic call types. This fixes all 10 failures on ia64-unknown-linux-gnu: ``` === libffi Summary === -# of expected passes 1945 -# of unexpected failures 10 + +# of expected passes 1955 ``` [1]: https://www.intel.com/content/dam/www/public/us/en/documents/guides/itanium-software-runtime-architecture-guide.pdf Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Anthony Green 9429968b 2018-02-10T23:23:33 Merge pull request #403 from frida/fix/x86-sysv-pic-closure-regression Fix x86 SysV closure in PIC mode
Anthony Green f08b2be6 2018-02-10T23:21:49 Merge pull request #405 from andreas-schwab/master Fix passing struct by value on aarch64
Andreas Schwab 482b37f0 2017-09-18T12:44:08 Fix passing struct by value on aarch64 This fixes the ctypes test in the python testsuite.
Ole André Vadla Ravnås 28d3b61b 2018-01-20T23:56:17 Fix x86 SysV closure in PIC mode The assembly single-line comments swallowed up the remaining assembly code of the macros due to lack of line-endings. This is a regression introduced in b7f6d7a.
Anthony Green c194448e 2018-01-10T09:38:15 adjust env usage in travis
Anthony Green 5314b106 2018-01-10T07:22:51 test static lib
Anthony Green bec6135d 2018-01-10T07:20:04 Merge pull request #393 from thejunkjon/master Linker error "recompile with -fPIC" for x86_64
Anthony Green f6ecf10c 2018-01-05T16:51:44 Merge pull request #401 from wzssyqa/jr-r6 mips/ffi.c: fix encoding for jr on r6
YunQiang Su 746dbe3a 2018-01-03T10:07:41 mips/ffi.c: fix encoding for jr on r6 mips/ffi.c: instruction jr has a different encoding for r6
Anthony Green c50ba182 2018-01-01T15:18:46 Merge pull request #398 from emaste/master Enable symbol versioning when ld is LLVM's lld
Anthony Green 54cb3e23 2017-12-31T07:46:05 Merge pull request #396 from wzssyqa/master mips/n32.S: disable .set mips4 on mips r6
Ed Maste af6949b7 2017-12-17T23:08:12 Enable symbol versioning when ld is LLVM's lld Fixes #397
YunQiang Su 94c102aa 2017-12-10T14:25:01 Not set mips on mips r6 MIPS release changed encodes of some instructions, include ll/sc etc. if .set mips4 on mips r6, as will generate some wrong encode of some instructions.
jon d15581c6 2017-12-01T00:34:30 Updating calls to ffi_closure_unix64_inner and ffi_closure_win64_inner to use PLT. Without this fix, statically linking libffi causes the linker error i.e. 'requires dynamic R_X86_64_PC32 reloc against ffi_closure_unix64_inner which may overflow at runtime; recompile with -fPIC)'
Anthony Green 716bfd83 2017-11-05T09:02:37 Merge pull request #387 from trofi/master Makefile.am: add 'src/s390/internal.h' to source tarball
Sergei Trofimovich cd5e9f8b 2017-11-05T13:56:42 Makefile.am: add 'src/s390/internal.h' to source tarball commit 2f530de168e0253ac06e044c832132c496e8788b ("s390: Reorganize assembly") introduced new header (similar to other arches) but did not add it to source tarball. As a result build from 'make dist' tarballs failed as: ``` ../src/s390/ffi.c:34:10: fatal error: internal.h: No such file or directory #include "internal.h" ^~~~~~~~~~~~ ``` To fix it the change adds file to 'Makefile.am'. Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Anthony Green 4fdbb057 2017-11-03T07:05:31 Merge pull request #320 from 0-wiz-0/master Support NetBSD with mprotect.
Anthony Green b302bc3d 2017-11-03T07:03:55 Merge pull request #322 from compnerd/aarch64-base aarch64: fix index base register for AArch64
Anthony Green 14eac938 2017-11-03T06:49:03 Merge pull request #384 from yan12125/fix-sgidefs-checking Fix linux detection (closes #303)
Yen Chi Hsuan 9fc9dc53 2017-10-27T16:12:56 Fix linux detection (closes #303)
Saleem Abdulrasool 1fb788ac 2017-10-10T11:37:00 aarch64: fix index base register for AArch64 The base is passed in `x3`, not in `x2`. This fixes the indexing base so that the right value is used.
Anthony Green ad15ae76 2017-10-25T13:16:49 Merge pull request #298 from frida/fix/ios-trampoline-table-complexity Simplify iOS trampoline table allocation
Anthony Green dc2ff5ba 2017-10-25T13:11:40 Merge pull request #323 from compnerd/x86-alloca-alignment x86: align alloca to 16-byte boundary
Anthony Green 927da716 2017-10-25T13:05:53 Merge pull request #379 from jlj/master Xcode build improvements
Anthony Green a0455c03 2017-10-25T13:04:23 Merge pull request #383 from hjl-tools/hjl/master Hjl/master
Anthony Green 0faf6145 2017-10-25T13:03:55 Merge pull request #381 from compnerd/ffi-nullptr-deref arm: fix a level of indirection issue
H.J. Lu 9d9d92b4 2017-10-25T04:59:31 Skip WIN64/EFI64 support for x32 Since x32 doesn't support WIN64/EFI64, skip it if __ILP32__ is defined.
H.J. Lu b2a343ff 2017-10-25T04:36:49 Don't include WIN64/EFI64 for x32 Since x32 doesn't support WIN64/EFI64, don't include it for x32. Also x32 has sizeof size_t == 4. But TARGET should be X86_64.
Saleem Abdulrasool 3c372c38 2017-10-24T13:53:56 arm: fix a level of indirection issue Rather than relying on the stack being 0'ed out always, do it manually. The stack generally happened to be zero, and because the compiler realizes that the tests are dealing with chars truncates the read value. However, the top 3 nibbles of the value are undefined and may be non-zero. The indirection level caused a null-pointer dereference. Explicitly scribbling on the stack during the allocation causes test failures without the original zexting behaviour.
Jean-Luc Jumpertz 181fc4cc 2017-10-23T15:02:29 Merge branch 'master' based on ksjogo/libffi Added a tvOS target in Xcode project. Misc Xcode project cleanup. Fix macOS build target in Xcode project. # Conflicts: # src/aarch64/ffi.c # src/x86/ffi64.c
Jean-Luc Jumpertz 54529ba1 2017-10-23T09:49:35 Added a tvOS target in Xcode project. Misc Xcode project cleanup.
Saleem Abdulrasool 79d1509c 2017-10-10T11:39:45 x86: align alloca to 16-byte boundary Align the stack allocation to a 16-byte boundary. This ensures that the stack parameters are 16-byte aligned which is needed for some instructions.
Tom Tromey 8d26e8c6 2017-10-17T10:46:49 Merge pull request #326 from trofi/master src/ia64/unix.S: unbreak small struct handling
Sergei Trofimovich ed7488c0 2017-10-17T13:00:51 src/ia64/unix.S: unbreak small struct handling commit 6e8a4460833594d5af1b4539178025da0077df19 added FFI_TYPE_COMPLEX value type (comes after FFI_TYPE_POINTER) ia64 ffi_closure_unix reiles on the ordering of FFI_ enums as ia64 has ia64-specific FFI types: small struct and FPU extesions. As a result all tests handling small structs broke. The change fixes dispatch table by adding (no-op) FFI_TYPE_COMPLEX entry This has positive effect of unbreaking most tests on ia64: === libffi Summary === -# of expected passes 1595 -# of unexpected failures 295 +# of expected passes 1930 +# of unexpected failures 10 # of unsupported tests 30 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Anthony Green 1c9171ec 2017-10-10T23:19:57 Merge pull request #324 from compnerd/arm-zext arm: zext return value parameters
Saleem Abdulrasool 7ad0ae7f 2017-10-10T11:44:05 arm: zext return value parameters The closure function (invoked as closure->fun in ffi_closure_XXX_inner) will only populate the actual number of bytes for the true return type, which may be a character. This leaves garbage on the stack when the assembly closure function (i.e. ffi_closure_XXX) reads the return value off of the stack into r0 as a 4-byte value. ffi_closure_XXX always leaves room for at least 4 bytes here, so we can safely set them to 0. Otherwise, if there is garbage in any of these bytes, these end up in r0 and in the returned value as well.
Joerg Sonnenberger 2bfcd299 2017-10-02T15:34:03 Support NetBSD with mprotect. Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
Tom Tromey 9f1f8741 2017-10-01T20:25:50 Merge pull request #319 from angerman/patch-5 Adds `local.exp` to DISTCLEANFILES
Moritz Angermann 6cf0dea7 2017-10-02T10:20:16 Change CLEANFILES to DISTCLEANFILES
Tom Tromey dca078f4 2017-10-01T20:19:53 Merge pull request #316 from angerman/patch-2 Add `configure.host` and `libtool-version` to the `EXTRA_DIST` files
Tom Tromey 540258d1 2017-10-01T20:17:02 Merge pull request #317 from angerman/patch-3 Add src/x86/asmnames.h to noinst_HEADERS
Moritz Angermann bccba9a3 2017-10-01T12:48:17 Merged
Moritz Angermann 6b6df1a7 2017-10-01T12:37:53 Adds `local.exp` to CLEANFILES With #315, #316, #317, #318 and this patch, running ``` AM_DISTCHECK_CONFIGURE_FLAGS=--disable-docs make distcheck ``` should complete successfully.
Moritz Angermann 59d65d74 2017-10-01T12:23:31 Include `libtool-version` in the EXTRA_DIST files.
Moritz Angermann 4c6aa78d 2017-10-01T11:32:41 Add src/x86/asmnames.h to noinst_HEADERS In eaa59755fcbb692a8cb763c7f9f24a350aadbd30, macros from `unix64.S` were extracted into `asmnames.h` to be used with `win64.S` as well. As such these are required by `unix64.S`, which fails to build without them.
Moritz Angermann a1e6ccb6 2017-10-01T11:28:40 Add `configure.host` to the `EXTRA_DIST` files When running `make dist`, `configure.host` would not result in the distribution tarball, however `configure` would try to read it, and as such the tarball would not be buildable.
Anthony Green 93d8e7dd 2017-09-27T21:51:34 Fix #265
Anthony Green 02a5145a 2017-09-27T21:43:03 Merge pull request #263 from ksjogo/master fix ios builds
Anthony Green 10099d6c 2017-09-27T20:54:09 Merge pull request #271 from frida/fix/qnx-cache-flushing arm: Fix cache flushing on QNX
Anthony Green c8f1aa3d 2017-09-27T20:53:50 Merge pull request #307 from zw3rk/master Support -ios triple
Anthony Green db4dad97 2017-09-27T20:47:08 Merge pull request #312 from fjricci/fix_ub Fix misaligned memory access in ffi_call_int
Anthony Green 8a16f2f4 2017-09-27T20:45:15 Merge pull request #308 from trex58/master This patch enables FFI Go Closure on AIX.
Jean-Luc Jumpertz a78da739 2017-09-04T15:55:34 Fix macOS build target in Xcode project. - Add missing files for desktop platforms in generate-darwin-source-and-headers.py, and in the Xcode project. - Add a static library target for macOS. - Fix "implicit conversion loses integer precision" warnings for iOS mad macOS targets.
Francis Ricci 9c12209d 2017-08-03T10:46:28 Fix misaligned memory access in ffi_call_int
Tom Tromey b2309106 2017-07-12T12:43:06 Merge pull request #309 from rurban/oldgcc __attribute__ deprecated (msg) only since gcc 4.5
Reini Urban 9c6cb588 2017-06-18T18:26:05 __attribute__ deprecated (msg) only since gcc 4.5 make it work with older compilers
Moritz Angermann 50e408ce 2017-05-21T20:44:10 add i?86-*-ios -- the iOS simulator (32bit)
Moritz Angermann a08cabe6 2017-05-21T20:25:16 add x86_64-*-ios -- the iOS simulator
Tony Reix 0ff9419f 2017-05-17T14:57:53 This patch enables FFI Go Closure on AIX.
Moritz Angermann 19ab448d 2017-05-16T08:32:06 Support -ios triple Autoconf hasn’t had an update since 2014, and it doesn’t look like it will soon[1] This updates config.{guess,sub} It adds support for e.g. `-ios`, which allows to have targets like `aarch64-apple-ios`. It basically does exactly what the config.guess script says: > It is advised that you download the most up to date version of the config scripts from The configure.ac script has been updated to relax `*-apple-darwin*` to `*-apple-*`. Similarly the `.gitignore` and `autogen.sh` needed to be updated to respect the newer `config.{sub,guess}` — [1]: http://lists.gnu.org/archive/html/autoconf/2016-07/msg00017.html
Tom Tromey c0cc9f1d 2017-05-08T15:20:39 Merge pull request #302 from gpakosz/align-macros Prefix ALIGN macros with FFI_
Gregory Pakosz bd72848c 2017-04-27T13:20:36 Prefix ALIGN macros with FFI_
ksjogo 7d504f7a 2017-03-30T13:32:58 update for xcode 8.3
Ole André Vadla Ravnås 57d8ff04 2017-03-15T01:43:11 Simplify iOS trampoline table allocation By using VM_FLAGS_OVERWRITE there is no need for speculatively allocating on a page we just deallocated. This approach eliminates the race-condition and gets rid of the retry logic.
ksjogo 7f558a9b 2016-07-25T01:18:30 set ios deployment target to 7.0
ksjogo e76fa94b 2016-07-14T11:28:18 fix ltmain.sh in xcode builds
ksjogo 22b2fd6f 2016-07-13T14:40:07 add valid architectures
Johannes Goslar 00406945 2016-07-12T16:08:42 Update Xcodeproj Include all currently relevent files. Call autogen is build script. Fix compiler settings. Fix mach include.
Anthony Green b841ae70 2017-03-19T07:42:09 remove stray quote
Anthony Green a94c999b 2017-03-19T07:36:07 Handle fastcall declaration differently for some Microsoft compilers
Anthony Green 69963d39 2017-03-19T07:33:39 We don't support 32-bit builds with the Microsoft toolchain
Anthony Green 073bc9d5 2017-03-19T07:25:24 Enable appveyor ci support
Anthony Green a0b14eea 2017-03-17T09:20:40 Merge pull request #291 from ramon-garcia/visual-studio-build Build with Visual C++ (64 bits)
Anthony Green fa5a0fe2 2017-03-16T07:50:07 Merge pull request #238 from KubaKaszycki/master Update README with a new port
Anthony Green 5b91bbd3 2017-03-16T00:40:58 Merge pull request #288 from yan12125/std-includedir Install public headers in the standard path
Anthony Green d754c510 2017-03-16T00:39:07 Merge pull request #299 from matijaskala/patch-1 detect other x32 hosts
Anthony Green ebe7f447 2017-03-16T00:36:10 Remove osx testing. gcc was symlinked to clang. dejagnu c++ tests fail with clang.
Anthony Green c9c2aa24 2017-03-15T09:58:39 Revert previous two changes. clang/MacOS problem can only be solved within dejagnu.
Anthony Green 5a8fca94 2017-03-15T09:52:39 Fix typo
Anthony Green 5b10a019 2017-03-15T09:34:01 Work around dejagnu/clang problems
Anthony Green b6751258 2017-03-15T08:54:52 Require sudo for installing packages
Matija Skala 41185b56 2017-03-15T12:50:41 detect other x32 hosts primarily x86_64-pc-linux-muslx32 while at it, add x86_64-x32-pc-linux-{gnu,musl} as well
Richard Henderson 6e2e041b 2017-03-14T19:37:45 Merge pull request #297 from frida/fix/error-path Fix error path so mutex is unlocked before returning
Ole André Vadla Ravnås 5e4fcdcc 2017-03-15T01:43:11 Simplify iOS trampoline table allocation By using VM_FLAGS_OVERWRITE there is no need for speculatively allocating on a page we just deallocated. This approach eliminates the race-condition and gets rid of the retry logic.
Ole André Vadla Ravnås d42ce7b9 2017-03-15T01:23:40 Fix error path so mutex is unlocked before returning In the unusual case where ffi_trampoline_table_alloc() fails.
Tom Tromey dabbd145 2017-02-27T21:10:00 Merge pull request #295 from terrillmoore/patch-1 Correct typos in libffi.texi
Terry Moore 6caabd19 2017-02-26T15:06:53 Correct typos in libffi.texi One "it's" should be "its", and one "is" should be "in".
Ramón García Fernández 1e0d107b 2017-01-08T20:12:59 Modify configure.host to detect compilation with Microsoft Visual C++ and use assembly with Intel syntax in that case
Yen Chi Hsuan 982b89c0 2016-11-13T19:17:19 Install public headers in the standard path
Anthony Green 60e4250a 2016-09-04T09:34:18 make executable
Anthony Green c3caf388 2016-09-04T09:21:18 Update travis to test linux 32/64 and osx with a mix of gcc and clang
Anthony Green c5b408ee 2016-09-04T09:17:46 xfail the unwindtest for osx as per issue #279
Richard Henderson 256ce51c 2016-09-01T13:54:51 Merge pull request #273 from wbx-github/master m68k: support ISA-A Coldfire CPUs
Richard Henderson 2ded2a4f 2016-09-01T13:30:45 Merge pull request #272 from yousong/mips64-soft-float Mips64 soft float
Tom Tromey 408c9c7d 2016-08-23T11:32:17 Merge pull request #274 from dr-hannibal/ykolerov-unused ARC: Remove unused variable
Yuriy Kolerov b545ff81 2016-08-23T20:23:37 ARC: Remove unused variable Signed-off-by: Yuriy Kolerov <yuriy.kolerov@synopsys.com>
Waldemar Brodkorb 52a11f6d 2016-08-20T00:52:19 m68k: support ISA-A Coldfire CPUs Fix compilation for m68k/coldfire CPUs like mcf5208. Signed-off-by: Thorsten Glaser <tg@mirbsd.de> Signed-off-by: Waldemar Brodkorb <wbx@uclibc-ng.org>
Yousong Zhou e247b562 2016-08-15T17:34:37 doc: fix typo Name of last argument to ffi_get_struct_offsets is `offsets`, not `sizes` Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
Yousong Zhou 7a0d2c83 2016-08-15T15:00:13 mips: fix MIPS softfloat build issue The patch for o32.S is taken from OpenWrt packages repo 3a7a4bf "libffi: fix MIPS softfloat build issue with current binutils" Signed-off-by: Felix Fietkau <nbd@openwrt.org> Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>