-
Show log
Commit
-
Hash : e58e22b2
Author :
Date : 2023-02-02T07:02:53
From Dave Anglin: A couple of years ago the 32-bit hppa targets were converted from using a trampoline executed on the stack to the function descriptor technique used by ia64. This is more efficient and avoids having to have an executable stack. However, function pointers on 32-bit need the PLABEL bit set in the pointer. It distinguishes between pointers that point directly to the executable code and pointer that point to a function descriptor. We need the later for libffi. But as a result, it is not possible to convert using casts data pointers to function pointers. The solution at the time was to set the PLABEL bit in hppa closure pointers using FFI_CLOSURE_PTR. However, I realized recently that this was a bad choice. Packages like python-cffi allocate their own closure pointers, so this isn't going to work well there. A better solution is to leave closure pointers unchanged and only set the PLABEL bit in pointers used to point to executable code. The attached patch drops the FFI_CLOSURE_PTR and FFI_RESTORE_PTR defines. This allows some cleanup in the hppa closure routines. The FFI_FN define is now used to set the PLABEL bit on hppa. ffi_closure_alloc is modified to set the PLABEL bit in the value set in *code. I also added a FFI_CL define to convert a function pointer to a closure pointer. It is only used in one test case.
-
Files
- closure.exp
- closure_fn0.c
- closure_fn1.c
- closure_fn2.c
- closure_fn3.c
- closure_fn4.c
- closure_fn5.c
- closure_fn6.c
- closure_loc_fn0.c
- closure_simple.c
- cls_12byte.c
- cls_16byte.c
- cls_18byte.c
- cls_19byte.c
- cls_1_1byte.c
- cls_20byte.c
- cls_20byte1.c
- cls_24byte.c
- cls_2byte.c
- cls_3_1byte.c
- cls_3byte1.c
- cls_3byte2.c
- cls_3float.c
- cls_4_1byte.c
- cls_4byte.c
- cls_5_1_byte.c
- cls_5byte.c
- cls_64byte.c
- cls_6_1_byte.c
- cls_6byte.c
- cls_7_1_byte.c
- cls_7byte.c
- cls_8byte.c
- cls_9byte1.c
- cls_9byte2.c
- cls_align_double.c
- cls_align_float.c
- cls_align_longdouble.c
- cls_align_longdouble_split.c
- cls_align_longdouble_split2.c
- cls_align_pointer.c
- cls_align_sint16.c
- cls_align_sint32.c
- cls_align_sint64.c
- cls_align_uint16.c
- cls_align_uint32.c
- cls_align_uint64.c
- cls_dbls_struct.c
- cls_double.c
- cls_double_va.c
- cls_float.c
- cls_longdouble.c
- cls_longdouble_va.c
- cls_many_mixed_args.c
- cls_many_mixed_float_double.c
- cls_multi_schar.c
- cls_multi_sshort.c
- cls_multi_sshortchar.c
- cls_multi_uchar.c
- cls_multi_ushort.c
- cls_multi_ushortchar.c
- cls_pointer.c
- cls_pointer_stack.c
- cls_schar.c
- cls_sint.c
- cls_sshort.c
- cls_struct_va1.c
- cls_uchar.c
- cls_uint.c
- cls_uint_va.c
- cls_ulong_va.c
- cls_ulonglong.c
- cls_ushort.c
- err_bad_abi.c
- ffitest.h
- huge_struct.c
- nested_struct.c
- nested_struct1.c
- nested_struct10.c
- nested_struct11.c
- nested_struct12.c
- nested_struct13.c
- nested_struct2.c
- nested_struct3.c
- nested_struct4.c
- nested_struct5.c
- nested_struct6.c
- nested_struct7.c
- nested_struct8.c
- nested_struct9.c
- problem1.c
- single_entry_structs1.c
- single_entry_structs2.c
- single_entry_structs3.c
- stret_large.c
- stret_large2.c
- stret_medium.c
- stret_medium2.c
- testclosure.c
- unwindtest.cc
- unwindtest_ffi_call.cc
-
Properties
-
Git HTTP https://git.kmx.io/kc3-lang/libffi.git Git SSH git@git.kmx.io:kc3-lang/libffi.git Public access ? public Description A portable foreign-function interface library.
Users
Tags
