-
Show log
Commit
-
Hash : fa2b6ea0
Author :
Date : 2024-01-12T18:21:41
Eliminate duplicate copies of jpeg_nbits_table ef9a4e05ba919494cbebe50e15f332de5ab97e82 (libjpeg-turbo 1.4.x), which was based on https://bug815473.bmoattachments.org/attachment.cgi?id=692126 (https://bugzilla.mozilla.org/show_bug.cgi?id=815473), modified the C baseline Huffman encoder so that it precomputes jpeg_nbits_table, in order to facilitate sharing the table among multiple processes. However, libjpeg-turbo never shared the table, and because the table was implemented as a static array, f3a8684cd1c28e557d394470962a7a224c76ddbc (libjpeg-turbo 1.5.x) and 37bae1a0e977ee1ba769e6f0aa27e519ab6e58c6 (libjpeg-turbo 2.0.x) each introduced a duplicate copy of the table for (respectively) the SSE2 baseline Huffman encoder and the C progressive Huffman encoder. This commit does the following: - Move the duplicated code in jchuff.c and jcphuff.c, originally introduced in 0cfc4c17b740cb2cbb11f9d85c8ab3745d5b913a and 37bae1a0e977ee1ba769e6f0aa27e519ab6e58c6, into a header (jpeg_nbits.h). - Credit the co-author of 0cfc4c17b740cb2cbb11f9d85c8ab3745d5b913a. (Refer to https://sourceforge.net/p/libjpeg-turbo/patches/57). - Modify the SSE2 baseline Huffman encoder so that the C Huffman encoders can share its definition of jpeg_nbits_table. - Move the definition of jpeg_nbits_table into a C source file (jpeg_nbits.c) rather than a header, and define the table only if USE_CLZ_INTRINSIC is undefined and the SSE2 baseline Huffman encoder will not be built. - Apply hidden symbol visibility to the shared definition of jpeg_nbits_table, if the compiler supports the necessary attribute. (In practice, only Visual C++ doesn't.) Closes #114 See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1501523
-
Files
- jccolext-avx2.asm
- jccolext-sse2.asm
- jccolor-avx2.asm
- jccolor-sse2.asm
- jcgray-avx2.asm
- jcgray-sse2.asm
- jcgryext-avx2.asm
- jcgryext-sse2.asm
- jchuff-sse2.asm
- jcphuff-sse2.asm
- jcsample-avx2.asm
- jcsample-sse2.asm
- jdcolext-avx2.asm
- jdcolext-sse2.asm
- jdcolor-avx2.asm
- jdcolor-sse2.asm
- jdmerge-avx2.asm
- jdmerge-sse2.asm
- jdmrgext-avx2.asm
- jdmrgext-sse2.asm
- jdsample-avx2.asm
- jdsample-sse2.asm
- jfdctflt-sse.asm
- jfdctfst-sse2.asm
- jfdctint-avx2.asm
- jfdctint-sse2.asm
- jidctflt-sse2.asm
- jidctfst-sse2.asm
- jidctint-avx2.asm
- jidctint-sse2.asm
- jidctred-sse2.asm
- jquantf-sse2.asm
- jquanti-avx2.asm
- jquanti-sse2.asm
- jsimd.c
- jsimdcpu.asm
