Copy in XkbCompatMapRec and XkbSymInterpretRec These contain actions, so transition them ahead to XkbcAction and move them into XKBcommon.h. Signed-off-by: Daniel Stone <daniel@fooishbar.org>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384
diff --git a/include/X11/extensions/XKBcommon.h b/include/X11/extensions/XKBcommon.h
index 3d451f8..6992cbd 100644
--- a/include/X11/extensions/XKBcommon.h
+++ b/include/X11/extensions/XKBcommon.h
@@ -185,7 +185,7 @@ typedef struct _XkbcDesc {
XkbcClientMapPtr map;
XkbIndicatorPtr indicators;
XkbNamesPtr names;
- XkbCompatMapPtr compat;
+ XkbcCompatMapPtr compat;
XkbGeometryPtr geom;
} XkbcDescRec, *XkbcDescPtr;
diff --git a/src/alloc.c b/src/alloc.c
index 173a4c2..1d1d069 100644
--- a/src/alloc.c
+++ b/src/alloc.c
@@ -35,8 +35,8 @@ THE USE OR PERFORMANCE OF THIS SOFTWARE.
int
XkbcAllocCompatMap(XkbcDescPtr xkb, unsigned which, unsigned nSI)
{
- XkbCompatMapPtr compat;
- XkbSymInterpretRec *prev_interpret;
+ XkbcCompatMapPtr compat;
+ XkbcSymInterpretRec *prev_interpret;
if (!xkb)
return BadMatch;
@@ -52,7 +52,7 @@ XkbcAllocCompatMap(XkbcDescPtr xkb, unsigned which, unsigned nSI)
prev_interpret = compat->sym_interpret;
compat->sym_interpret = _XkbTypedRealloc(compat->sym_interpret,
- nSI, XkbSymInterpretRec);
+ nSI, XkbcSymInterpretRec);
if (!compat->sym_interpret) {
_XkbFree(prev_interpret);
compat->size_si = compat->num_si = 0;
@@ -61,17 +61,17 @@ XkbcAllocCompatMap(XkbcDescPtr xkb, unsigned which, unsigned nSI)
if (compat->num_si != 0)
_XkbClearElems(compat->sym_interpret, compat->num_si,
- compat->size_si - 1, XkbSymInterpretRec);
+ compat->size_si - 1, XkbcSymInterpretRec);
return Success;
}
- compat = _XkbTypedCalloc(1, XkbCompatMapRec);
+ compat = _XkbTypedCalloc(1, XkbcCompatMapRec);
if (!compat)
return BadAlloc;
if (nSI > 0) {
- compat->sym_interpret = _XkbTypedCalloc(nSI, XkbSymInterpretRec);
+ compat->sym_interpret = _XkbTypedCalloc(nSI, XkbcSymInterpretRec);
if (!compat->sym_interpret) {
_XkbFree(compat);
return BadAlloc;
@@ -89,7 +89,7 @@ XkbcAllocCompatMap(XkbcDescPtr xkb, unsigned which, unsigned nSI)
void
XkbcFreeCompatMap(XkbcDescPtr xkb, unsigned which, Bool freeMap)
{
- XkbCompatMapPtr compat;
+ XkbcCompatMapPtr compat;
if (!xkb || !xkb->compat)
return;
diff --git a/src/galloc.c b/src/galloc.c
index b45ce74..a81d9ba 100644
--- a/src/galloc.c
+++ b/src/galloc.c
@@ -556,7 +556,9 @@ XkbcAllocGeomPoints(XkbOutlinePtr ol, int nPts)
int
XkbcAllocGeomKeys(XkbRowPtr row, int nKeys)
{
- return _XkbAllocKeys(row, nKeys);
+ int ret = _XkbAllocKeys(row, nKeys);
+ fprintf(stderr, "!!! allocated %d keys at %p\n", nKeys, row->keys);
+ return ret;
}
int
diff --git a/src/malloc.c b/src/malloc.c
index 9b842a5..0211264 100644
--- a/src/malloc.c
+++ b/src/malloc.c
@@ -662,7 +662,7 @@ XkbcChangeKeycodeRange(XkbcDescPtr xkb, int minKC, int maxKC,
if (xkb->server->vmodmap) {
bzero(&xkb->server->vmodmap[minKC],
- tmp * sizeof(unsigned short));
+ tmp * sizeof(uint32_t));
if (changes)
changes->map.changed = _ExtendRange(changes->map.changed,
XkbVirtualModMapMask, minKC,
diff --git a/src/xkbcomp/action.c b/src/xkbcomp/action.c
index 1076030..63b2591 100644
--- a/src/xkbcomp/action.c
+++ b/src/xkbcomp/action.c
@@ -334,7 +334,7 @@ ReportNotFound(unsigned action, unsigned field, const char *what, char *bad)
static Bool
HandleNoAction(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
return ReportIllegal(action->type, field);
@@ -392,7 +392,7 @@ CheckModifierField(XkbcDescPtr xkb,
static Bool
HandleSetLatchMods(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
XkbcModAction *act;
@@ -437,7 +437,7 @@ HandleSetLatchMods(XkbcDescPtr xkb,
static Bool
HandleLockMods(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
XkbcModAction *act;
@@ -512,7 +512,7 @@ CheckGroupField(unsigned action,
static Bool
HandleSetLatchGroup(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
XkbGroupAction *act;
@@ -557,7 +557,7 @@ HandleSetLatchGroup(XkbcDescPtr xkb,
static Bool
HandleLockGroup(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
XkbGroupAction *act;
@@ -583,7 +583,7 @@ HandleLockGroup(XkbcDescPtr xkb,
static Bool
HandleMovePtr(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
ExprResult rtrn;
@@ -648,7 +648,7 @@ static LookupEntry lockWhich[] = {
static Bool
HandlePtrBtn(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
ExprResult rtrn;
@@ -710,7 +710,7 @@ static LookupEntry ptrDflts[] = {
static Bool
HandleSetPtrDflt(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
ExprResult rtrn;
@@ -783,7 +783,7 @@ static LookupEntry isoNames[] = {
static Bool
HandleISOLock(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
ExprResult rtrn;
@@ -830,7 +830,7 @@ HandleISOLock(XkbcDescPtr xkb,
static Bool
HandleSwitchScreen(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
ExprResult rtrn;
@@ -922,7 +922,7 @@ LookupEntry ctrlNames[] = {
static Bool
HandleSetLockControls(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
ExprResult rtrn;
@@ -954,7 +954,7 @@ static LookupEntry evNames[] = {
static Bool
HandleActionMessage(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
ExprResult rtrn;
@@ -1032,7 +1032,7 @@ HandleActionMessage(XkbcDescPtr xkb,
static Bool
HandleRedirectKey(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
ExprResult rtrn;
@@ -1083,7 +1083,7 @@ HandleRedirectKey(XkbcDescPtr xkb,
static Bool
HandleDeviceBtn(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
ExprResult rtrn;
@@ -1153,7 +1153,7 @@ HandleDeviceBtn(XkbcDescPtr xkb,
static Bool
HandleDeviceValuator(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
#if 0
@@ -1168,7 +1168,7 @@ HandleDeviceValuator(XkbcDescPtr xkb,
static Bool
HandlePrivate(XkbcDescPtr xkb,
- XkbAnyAction * action,
+ XkbcAnyAction * action,
unsigned field, ExprDef * array_ndx, ExprDef * value)
{
ExprResult rtrn;
@@ -1200,7 +1200,7 @@ HandlePrivate(XkbcDescPtr xkb,
ACTION("Extra %d bytes ignored\n", len - 6);
return False;
}
- strncpy((char *) action->data, rtrn.str, 7);
+ strncpy((char *) action->pad, rtrn.str, XkbcAnyActionDataSize);
}
free(rtrn.str);
return True;
@@ -1215,9 +1215,9 @@ HandlePrivate(XkbcDescPtr xkb,
return False;
}
ndx = rtrn.uval;
- if (ndx > 6)
+ if (ndx >= XkbcAnyActionDataSize)
{
- ERROR("The data for a private action is 7 bytes long\n");
+ ERROR("The data for a private action is 18 bytes long\n");
ACTION("Attempt to use data[%d] ignored\n", ndx);
return False;
}
@@ -1229,7 +1229,7 @@ HandlePrivate(XkbcDescPtr xkb,
ACTION("Illegal datum %d ignored\n", rtrn.ival);
return False;
}
- action->data[ndx] = rtrn.uval;
+ action->pad[ndx] = rtrn.uval;
return True;
}
}
@@ -1237,7 +1237,7 @@ HandlePrivate(XkbcDescPtr xkb,
}
typedef Bool(*actionHandler) (XkbcDescPtr /* xkb */ ,
- XkbAnyAction * /* action */ ,
+ XkbcAnyAction * /* action */ ,
unsigned /* field */ ,
ExprDef * /* array_ndx */ ,
ExprDef * /* value */
@@ -1290,7 +1290,7 @@ ApplyActionFactoryDefaults(XkbcAction * action)
int
HandleActionDef(ExprDef * def,
XkbcDescPtr xkb,
- XkbAnyAction * action, unsigned mergeMode, ActionInfo * info)
+ XkbcAnyAction * action, unsigned mergeMode, ActionInfo * info)
{
ExprDef *arg;
register char *str;
@@ -1305,7 +1305,7 @@ HandleActionDef(ExprDef * def,
exprOpText(def->op));
return False;
}
- str = XkbcAtomGetString(def->value.action.name);
+ str = XkbcAtomText(def->value.action.name);
if (!str)
{
WSGO("Missing name in action definition!!\n");
diff --git a/src/xkbcomp/action.h b/src/xkbcomp/action.h
index 9f1e10f..685dbcf 100644
--- a/src/xkbcomp/action.h
+++ b/src/xkbcomp/action.h
@@ -66,7 +66,7 @@ typedef struct _ActionInfo
extern int HandleActionDef(ExprDef * /* def */ ,
XkbcDescPtr /* xkb */ ,
- XkbAnyAction * /* action */ ,
+ XkbcAnyAction * /* action */ ,
unsigned /* mergeMode */ ,
ActionInfo * /* info */
);
diff --git a/src/xkbcomp/compat.c b/src/xkbcomp/compat.c
index 1f3a40e..3c6146a 100644
--- a/src/xkbcomp/compat.c
+++ b/src/xkbcomp/compat.c
@@ -39,7 +39,7 @@
typedef struct _SymInterpInfo
{
CommonInfo defs;
- XkbSymInterpretRec interp;
+ XkbcSymInterpretRec interp;
} SymInterpInfo;
#define _SI_VirtualMod (1<<0)
@@ -120,7 +120,7 @@ InitCompatInfo(CompatInfo * info, XkbcDescPtr xkb)
info->dflt.interp.act.type = XkbSA_NoAction;
for (i = 0; i < XkbcAnyActionDataSize; i++)
{
- info->dflt.interp.act.data[i] = 0;
+ info->dflt.interp.act.pad[i] = 0;
}
ClearIndicatorMapInfo(&info->ledDflt);
info->ledDflt.defs.fileID = info->fileID;
@@ -148,7 +148,7 @@ ClearCompatInfo(CompatInfo * info, XkbcDescPtr xkb)
info->dflt.interp.act.type = XkbSA_NoAction;
for (i = 0; i < XkbcAnyActionDataSize; i++)
{
- info->dflt.interp.act.data[i] = 0;
+ info->dflt.interp.act.pad[i] = 0;
}
ClearIndicatorMapInfo(&info->ledDflt);
info->nInterps = 0;
@@ -787,7 +787,7 @@ HandleCompatMapFile(XkbFile * file,
static void
CopyInterps(CompatInfo * info,
- XkbCompatMapPtr compat, Bool needSymbol, unsigned pred)
+ XkbcCompatMapPtr compat, Bool needSymbol, unsigned pred)
{
SymInterpInfo *si;
@@ -842,7 +842,7 @@ CompileCompatMap(XkbFile *file, XkbcDescPtr xkb, unsigned merge,
scanFile, info.name);
}
}
- size = info.nInterps * sizeof(XkbSymInterpretRec);
+ size = info.nInterps * sizeof(XkbcSymInterpretRec);
if (size > 0)
{
CopyInterps(&info, xkb->compat, True, XkbSI_Exactly);
diff --git a/src/xkbcomp/symbols.c b/src/xkbcomp/symbols.c
index db64977..69964ad 100644
--- a/src/xkbcomp/symbols.c
+++ b/src/xkbcomp/symbols.c
@@ -993,7 +993,7 @@ AddActionsToKey(KeyInfo * key,
register int i;
unsigned ndx, nActs;
ExprDef *act;
- XkbAnyAction *toAct;
+ XkbcAnyAction *toAct;
if (!GetGroupIndex(key, arrayNdx, ACTIONS, &ndx))
return False;
@@ -1035,7 +1035,7 @@ AddActionsToKey(KeyInfo * key,
}
key->actsDefined |= (1 << ndx);
- toAct = (XkbAnyAction *) key->acts[ndx];
+ toAct = (XkbcAnyAction *) key->acts[ndx];
act = value->value.child;
for (i = 0; i < nActs; i++, toAct++)
{