Move CompileKeymap into xkbcomp.c It's nicer to see the code where its used. Removes keymap.c. Signed-off-by: Ran Benita <ran234@gmail.com>
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339
diff --git a/Makefile.am b/Makefile.am
index 23b4921..d0af6e5 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -51,7 +51,6 @@ libxkbcommon_la_SOURCES = \
src/xkbcomp/indicators.h \
src/xkbcomp/keycodes.c \
src/xkbcomp/keycodes.h \
- src/xkbcomp/keymap.c \
src/xkbcomp/keytypes.c \
src/xkbcomp/misc.c \
src/xkbcomp/parser.y \
diff --git a/src/xkbcomp/keymap.c b/src/xkbcomp/keymap.c
deleted file mode 100644
index 2904310..0000000
--- a/src/xkbcomp/keymap.c
+++ /dev/null
@@ -1,163 +0,0 @@
-/************************************************************
- Copyright (c) 1994 by Silicon Graphics Computer Systems, Inc.
-
- Permission to use, copy, modify, and distribute this
- software and its documentation for any purpose and without
- fee is hereby granted, provided that the above copyright
- notice appear in all copies and that both that copyright
- notice and this permission notice appear in supporting
- documentation, and that the name of Silicon Graphics not be
- used in advertising or publicity pertaining to distribution
- of the software without specific prior written permission.
- Silicon Graphics makes no representation about the suitability
- of this software for any purpose. It is provided "as is"
- without any express or implied warranty.
-
- SILICON GRAPHICS DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS
- SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY
- AND FITNESS FOR A PARTICULAR PURPOSE. IN NO EVENT SHALL SILICON
- GRAPHICS BE LIABLE FOR ANY SPECIAL, INDIRECT OR CONSEQUENTIAL
- DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE,
- DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE
- OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH
- THE USE OR PERFORMANCE OF THIS SOFTWARE.
-
- ********************************************************/
-
-#include "xkbcomp-priv.h"
-#include "indicators.h"
-
-/**
- * Compile the given file and store the output in xkb.
- * @param file A list of XkbFiles, each denoting one type (e.g.
- * FILE_TYPE_KEYCODES, etc.)
- */
-struct xkb_keymap *
-CompileKeymap(struct xkb_context *ctx, XkbFile *file)
-{
- unsigned have = 0;
- bool ok;
- enum xkb_file_type mainType;
- const char *mainName;
- struct xkb_keymap *keymap = XkbcAllocKeyboard(ctx);
- struct {
- XkbFile *keycodes;
- XkbFile *types;
- XkbFile *compat;
- XkbFile *symbols;
- } sections = { NULL };
-
- if (!keymap)
- return NULL;
-
- mainType = file->type;
- mainName = file->name ? file->name : "(unnamed)";
-
- /*
- * Other aggregate file types are converted to FILE_TYPE_KEYMAP
- * in the parser.
- */
- if (mainType != FILE_TYPE_KEYMAP) {
- ERROR("Cannot compile a %s file alone into a keymap\n",
- XkbcFileTypeText(mainType));
- goto err;
- }
-
- /* Check for duplicate entries in the input file */
- for (file = (XkbFile *) file->defs; file; file = (XkbFile *) file->common.next)
- {
- if (have & file->type) {
- ERROR("More than one %s section in a %s file\n",
- XkbcFileTypeText(file->type), XkbcFileTypeText(mainType));
- ACTION("All sections after the first ignored\n");
- continue;
- }
- else if (!(file->type & LEGAL_FILE_TYPES)) {
- ERROR("Cannot define %s in a %s file\n",
- XkbcFileTypeText(file->type), XkbcFileTypeText(mainType));
- continue;
- }
-
- switch (file->type) {
- case FILE_TYPE_KEYCODES:
- sections.keycodes = file;
- break;
- case FILE_TYPE_TYPES:
- sections.types = file;
- break;
- case FILE_TYPE_SYMBOLS:
- sections.symbols = file;
- break;
- case FILE_TYPE_COMPAT:
- sections.compat = file;
- break;
- case FILE_TYPE_GEOMETRY:
- continue;
- default:
- WSGO("Unknown file type %d\n", file->type);
- ACTION("Ignored\n");
- continue;
- }
-
- if (!file->topName || strcmp(file->topName, mainName) != 0) {
- free(file->topName);
- file->topName = strdup(mainName);
- }
-
- have |= file->type;
- }
-
- if (REQUIRED_FILE_TYPES & (~have)) {
- enum xkb_file_type bit;
- enum xkb_file_type missing;
-
- missing = REQUIRED_FILE_TYPES & (~have);
-
- for (bit = 1; missing != 0; bit <<= 1) {
- if (missing & bit) {
- ERROR("Required section %s missing from keymap\n",
- XkbcFileTypeText(bit));
- missing &= ~bit;
- }
- }
-
- goto err;
- }
-
- /* compile the sections we have in the file one-by-one, or fail. */
- if (sections.keycodes == NULL ||
- !CompileKeycodes(sections.keycodes, keymap, MERGE_OVERRIDE))
- {
- ERROR("Failed to compile keycodes\n");
- goto err;
- }
- if (sections.types == NULL ||
- !CompileKeyTypes(sections.types, keymap, MERGE_OVERRIDE))
- {
- ERROR("Failed to compile key types\n");
- goto err;
- }
- if (sections.compat == NULL ||
- !CompileCompatMap(sections.compat, keymap, MERGE_OVERRIDE))
- {
- ERROR("Failed to compile compat map\n");
- goto err;
- }
- if (sections.symbols == NULL ||
- !CompileSymbols(sections.symbols, keymap, MERGE_OVERRIDE))
- {
- ERROR("Failed to compile symbols\n");
- goto err;
- }
-
- ok = UpdateModifiersFromCompat(keymap);
- if (!ok)
- goto err;
-
- return keymap;
-
-err:
- ACTION("Failed to compile keymap\n");
- xkb_map_unref(keymap);
- return NULL;
-}
diff --git a/src/xkbcomp/xkbcomp.c b/src/xkbcomp/xkbcomp.c
index 49f7d4c..48e02bc 100644
--- a/src/xkbcomp/xkbcomp.c
+++ b/src/xkbcomp/xkbcomp.c
@@ -63,15 +63,137 @@ keymap_file_from_components(struct xkb_context *ctx,
&keycodes->common, 0);
}
+/**
+ * Compile the given file and store the output in keymap.
+ * @param file A list of XkbFiles, each denoting one type (e.g.
+ * FILE_TYPE_KEYCODES, etc.)
+ */
static struct xkb_keymap *
compile_keymap(struct xkb_context *ctx, XkbFile *file)
{
- struct xkb_keymap *keymap;
+ unsigned have = 0;
+ bool ok;
+ enum xkb_file_type main_type;
+ const char *main_name;
+ struct xkb_keymap *keymap = XkbcAllocKeyboard(ctx);
+ struct {
+ XkbFile *keycodes;
+ XkbFile *types;
+ XkbFile *compat;
+ XkbFile *symbols;
+ } sections = { NULL };
+
+ if (!keymap)
+ return NULL;
+
+ main_type = file->type;
+ main_name = file->name ? file->name : "(unnamed)";
+
+ /*
+ * Other aggregate file types are converted to FILE_TYPE_KEYMAP
+ * in the parser.
+ */
+ if (main_type != FILE_TYPE_KEYMAP) {
+ ERROR("Cannot compile a %s file alone into a keymap\n",
+ XkbcFileTypeText(main_type));
+ goto err;
+ }
+
+ /* Check for duplicate entries in the input file */
+ for (file = (XkbFile *)file->defs; file;
+ file = (XkbFile *)file->common.next) {
+ if (have & file->type) {
+ ERROR("More than one %s section in a %s file\n",
+ XkbcFileTypeText(file->type), XkbcFileTypeText(main_type));
+ ACTION("All sections after the first ignored\n");
+ continue;
+ }
+ else if (!(file->type & LEGAL_FILE_TYPES)) {
+ ERROR("Cannot define %s in a %s file\n",
+ XkbcFileTypeText(file->type), XkbcFileTypeText(main_type));
+ continue;
+ }
+
+ switch (file->type) {
+ case FILE_TYPE_KEYCODES:
+ sections.keycodes = file;
+ break;
+ case FILE_TYPE_TYPES:
+ sections.types = file;
+ break;
+ case FILE_TYPE_SYMBOLS:
+ sections.symbols = file;
+ break;
+ case FILE_TYPE_COMPAT:
+ sections.compat = file;
+ break;
+ default:
+ continue;
+ }
+
+ if (!file->topName || strcmp(file->topName, main_name) != 0) {
+ free(file->topName);
+ file->topName = strdup(main_name);
+ }
+
+ have |= file->type;
+ }
+
+ if (REQUIRED_FILE_TYPES & (~have)) {
+ enum xkb_file_type bit;
+ enum xkb_file_type missing;
+
+ missing = REQUIRED_FILE_TYPES & (~have);
+
+ for (bit = 1; missing != 0; bit <<= 1) {
+ if (missing & bit) {
+ ERROR("Required section %s missing from keymap\n",
+ XkbcFileTypeText(bit));
+ missing &= ~bit;
+ }
+ }
- keymap = CompileKeymap(ctx, file);
+ goto err;
+ }
+
+ /* compile the sections we have in the file one-by-one, or fail. */
+ if (sections.keycodes == NULL ||
+ !CompileKeycodes(sections.keycodes, keymap, MERGE_OVERRIDE))
+ {
+ ERROR("Failed to compile keycodes\n");
+ goto err;
+ }
+ if (sections.types == NULL ||
+ !CompileKeyTypes(sections.types, keymap, MERGE_OVERRIDE))
+ {
+ ERROR("Failed to compile key types\n");
+ goto err;
+ }
+ if (sections.compat == NULL ||
+ !CompileCompatMap(sections.compat, keymap, MERGE_OVERRIDE))
+ {
+ ERROR("Failed to compile compat map\n");
+ goto err;
+ }
+ if (sections.symbols == NULL ||
+ !CompileSymbols(sections.symbols, keymap, MERGE_OVERRIDE))
+ {
+ ERROR("Failed to compile symbols\n");
+ goto err;
+ }
+
+ ok = UpdateModifiersFromCompat(keymap);
+ if (!ok)
+ goto err;
FreeXKBFile(file);
return keymap;
+
+err:
+ ACTION("Failed to compile keymap\n");
+ xkb_map_unref(keymap);
+ FreeXKBFile(file);
+ return NULL;
}
struct xkb_keymap *
diff --git a/src/xkbcomp/xkbcomp.h b/src/xkbcomp/xkbcomp.h
index 8cd3fe5..eaf2d81 100644
--- a/src/xkbcomp/xkbcomp.h
+++ b/src/xkbcomp/xkbcomp.h
@@ -246,9 +246,6 @@ typedef struct _XkbFile
unsigned flags;
} XkbFile;
-extern struct xkb_keymap *
-CompileKeymap(struct xkb_context *ctx, XkbFile *file);
-
extern bool
CompileKeycodes(XkbFile *file, struct xkb_keymap *keymap,
enum merge_mode merge);