kc3-lang/libxkbcommon/src/atom.h

• Show log

  Commit

• Hash : 112cccb1
  Author :
  Date : 2012-07-23T16:03:34
  

  Some atom related optimizations
  
  We often get a strdup'd string, just to pass it over the atom_intern and
  then immediately free it. But atom_intern then strdup's it again (if
  it's not interned already); so instead we can have the interning "steal"
  the memory instead of allocing a new one and freeing the old one. This
  is done by a new xkb_atom_steal function.
  
  It also turns out, that every time we strdup an atom, we don't actually
  modify it afterwards. Since we are guaranteed that the atom table will
  live as long as the context, we can just use xkb_atom_text instead. This
  removes a some more dynamic allocations.
  
  For this change we had to remove the ability to append two strings, e.g.
      "foo" + "bar" -> "foobar"
  which is only possible with string literals. This is unused and quite
  useless for our purposes.
  
  xkb_atom_strdup is left unused, as it may still be useful.
  
  Running rulescomp in valgrind, Before:
  ==7907== total heap usage: 173,698 allocs, 173,698 frees, 9,775,973 bytes allocated
  After:
  ==6348== total heap usage: 168,403 allocs, 168,403 frees, 9,732,648 bytes allocated
  
  Signed-off-by: Ran Benita <ran234@gmail.com>
  

Download

• src/atom.h

• /*
   * Copyright 2009  Dan Nicholson
   *
   * Permission is hereby granted, free of charge, to any person obtaining a
   * copy of this software and associated documentation files (the "Software"),
   * to deal in the Software without restriction, including without limitation
   * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   * and/or sell copies of the Software, and to permit persons to whom the
   * Software is furnished to do so, subject to the following conditions:
   *
   * The above copyright notice and this permission notice shall be included in
   * all copies or substantial portions of the Software.
   *
   * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
   * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
   * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
   * AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
   * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
   * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
   *
   * Except as contained in this notice, the names of the authors or their
   * institutions shall not be used in advertising or otherwise to promote the
   * sale, use or other dealings in this Software without prior written
   * authorization from the authors.
   */
  
  #ifndef ATOM_H
  #define ATOM_H
  
  #include "xkb-priv.h"
  
  struct atom_table;
  
  struct atom_table *
  atom_table_new(void);
  
  void
  atom_table_free(struct atom_table *table);
  
  xkb_atom_t
  atom_intern(struct atom_table *table, const char *string,
              bool steal);
  
  char *
  atom_strdup(struct atom_table *table, xkb_atom_t atom);
  
  const char *
  atom_text(struct atom_table *table, xkb_atom_t atom);
  
  #endif /* ATOM_H */
  

Download