• Show log

    Commit

  • Hash : 74f85d05
    Author : Ran Benita
    Date : 2015-08-23T23:02:10

    test/x11comp: remove duplicate FOUR_LEVEL_KEYPAD from test keymap
    
    The `test/data/keymaps/host.xkb` file contains a duplicate definition of
    this type. On my computer (linux, xkbcomp 1.3.0, xserver 1.17.2), the
    test passes as is, but if I remove the duplicate definition, the
    roundtrip brings it back and the test fails. I can also reproduce it
    without relation to the test, by loading `test/data/keymaps/host.xkb`
    (without the duplicate) using
    
        xkbcomp -I $(pwd)/test/data/keymaps/host.xkb $DISPLAY
    
    and downloading it again using
    
        xkbcomp $DISPLAY out.xkb
    
    the duplicate is added. On Mac OS X however, the duplicate is removed
    (correctly), so the test fails there.
    
    xkbcommon itself, which was forked from xkbcomp, doesn't have this bug;
    in fact, doing
    
        ./test/print-compiled-keymap -k keymaps/host.xkb
    
    removes the duplicate if it is present.
    
    This is (probably) a regression in xkbcomp or xserver compared to the
    versions used in Mac OS X. Since getting a patch for any of these two is
    hopeless from my experience, I did not try to investigate further.
    
    I am not sure why, but if I also add a `PC_SUPER_LEVEL2` type, the
    duplicate of `FOUR_LEVEL_KEYPAD` doesn't show up. Hopefully the test
    will work on all platforms now.
    
    https://github.com/xkbcommon/libxkbcommon/issues/26
    
    Reported-by: @nuko8
    Signed-off-by: Ran Benita <ran234@gmail.com>
    

  • Properties

  • Git HTTP https://git.kmx.io/kc3-lang/libxkbcommon.git
    Git SSH git@git.kmx.io:kc3-lang/libxkbcommon.git
    Public access ? public
    Description
    Users
    thodg_w kc3_lang_org thodg_l thodg_m www_kmx_io thodg
    Tags