Hash :
0cd1087a
Author :
Date :
2024-09-12T01:43:56
xkbcli how-to-type: Enhance arguments parsing & doc Currently the positional parameter of the CLI is either a Unicode code point or a keysym. However their respective format is not documented. It turns out that there are multiple issues due to the use of `strtol`: - Code points can be parsed as octal, decimal and hexadecimal, while keysyms can only be parsed as hexadecimal. Some programs outputs keysyms in their decimal form (e.g. `wev`) so it is worth to bring symmetry with code points. - Octal format is unusual for both and is triggered by leading zeros, which is unintuitive in this context. - `U+NNNN` format is the standard format for Unicode code points but is not supported. - Plain characters are not supported, e.g.: a, é, ß, Æ, γ, 🦆, etc. Although this is probably the easiest format for most users. Fixed the issues above: - Allow the code point to be passed exactly in the following formats: - Literal character (requires UTF-8 character encoding of the terminal); - Decimal number; - Hexadecimal number: either `0xNNNN` or `U+NNNN` (any digit count) - Allow the keysym to be passed exactly in the following formats: - Decimal number; - Hexadecimal number: `0xNNNN` (any digit count); - Name. - Improve both `--help` message and manual page.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323
/*
* Copyright © 2020 Ran Benita <ran@unusedvar.com>
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice (including the next
* paragraph) shall be included in all copies or substantial portions of the
* Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
* DEALINGS IN THE SOFTWARE.
*/
#include "config.h"
#include <getopt.h>
#include <stdbool.h>
#include <stdlib.h>
#include <unistd.h>
#include <errno.h>
#include "xkbcommon/xkbcommon.h"
#include "src/utils.h"
#include "src/keysym.h"
#include "src/utf8-decoding.h"
#define ARRAY_SIZE(arr) ((sizeof(arr) / sizeof(*(arr))))
static uint32_t
parse_char_or_codepoint(const char *raw) {
size_t raw_length = strlen_safe(raw);
size_t length = 0;
if (!raw_length)
return INVALID_UTF8_CODE_POINT;
/* Try to parse the parameter as a UTF-8 encoded single character */
uint32_t codepoint = utf8_next_code_point(raw, raw_length, &length);
/* If parsing failed or did not consume all the string, then try other formats */
if (codepoint == INVALID_UTF8_CODE_POINT ||
length == 0 || length != raw_length) {
char *endp;
long val;
int base = 10;
/* Detect U+NNNN format standard Unicode code point format */
if (raw_length >= 2 && raw[0] == 'U' && raw[1] == '+') {
base = 16;
raw += 2;
}
/* Use strtol with explicit bases instead of `0` in order to avoid
* unexpected parsing as octal. */
for (; base <= 16; base += 6) {
errno = 0;
val = strtol(raw, &endp, base);
if (errno != 0 || !isempty(endp) || val < 0 || val > 0x10FFFF) {
val = -1;
} else {
break;
}
}
if (val < 0) {
fprintf(stderr, "ERROR: Failed to convert argument to Unicode code point\n");
return INVALID_UTF8_CODE_POINT;
}
codepoint = (uint32_t) val;
}
return codepoint;
}
static void
usage(const char *argv0, FILE *fp)
{
fprintf(fp, "Usage: %s [--help] [--keysym] [--rules <rules>] [--model <model>] "
"[--layout <layout>] [--variant <variant>] [--options <options>]"
" <character/codepoint/keysym>\n", argv0);
fprintf(
fp,
"\n"
"Prints the key combinations (keycode + modifiers) in the keymap's layouts which\n"
"would produce the given Unicode code point or keysym.\n"
"\n"
"<character/codepoint/keysym> is either:\n"
"- a single character (requires a terminal which uses UTF-8 character encoding);\n"
"- a Unicode code point, interpreted as hexadecimal if prefixed with '0x' or 'U+'\n"
" else as decimal;\n"
"- a keysym if --keysym is used: either a numeric value (hexadecimal if prefixed\n"
" with '0x' else decimal) or a keysym name.\n"
"\n"
"Options:\n"
" --help\n"
" Print this help and exit\n"
" --keysym\n"
" Treat the argument as a keysym, not a Unicode code point\n"
"\n"
"XKB-specific options:\n"
" --rules <rules>\n"
" The XKB ruleset (default: '%s')\n"
" --model <model>\n"
" The XKB model (default: '%s')\n"
" --layout <layout>\n"
" The XKB layout (default: '%s')\n"
" --variant <variant>\n"
" The XKB layout variant (default: '%s')\n"
" --options <options>\n"
" The XKB options (default: '%s')\n"
"\n",
DEFAULT_XKB_RULES, DEFAULT_XKB_MODEL, DEFAULT_XKB_LAYOUT,
DEFAULT_XKB_VARIANT ? DEFAULT_XKB_VARIANT : "<none>",
DEFAULT_XKB_OPTIONS ? DEFAULT_XKB_OPTIONS : "<none>");
}
int
main(int argc, char *argv[])
{
const char *rules = NULL;
const char *model = NULL;
const char *layout_ = NULL;
const char *variant = NULL;
const char *options = NULL;
bool keysym_mode = false;
int err = EXIT_FAILURE;
struct xkb_context *ctx = NULL;
char *endp;
long val;
uint32_t codepoint;
xkb_keysym_t keysym;
int ret;
char name[XKB_KEYSYM_NAME_MAX_SIZE];
struct xkb_keymap *keymap = NULL;
xkb_keycode_t min_keycode, max_keycode;
xkb_mod_index_t num_mods;
enum options {
OPT_KEYSYM,
OPT_RULES,
OPT_MODEL,
OPT_LAYOUT,
OPT_VARIANT,
OPT_OPTIONS,
};
static struct option opts[] = {
{"help", no_argument, 0, 'h'},
{"keysym", no_argument, 0, OPT_KEYSYM},
{"rules", required_argument, 0, OPT_RULES},
{"model", required_argument, 0, OPT_MODEL},
{"layout", required_argument, 0, OPT_LAYOUT},
{"variant", required_argument, 0, OPT_VARIANT},
{"options", required_argument, 0, OPT_OPTIONS},
{0, 0, 0, 0},
};
while (1) {
int opt;
int option_index = 0;
opt = getopt_long(argc, argv, "h", opts, &option_index);
if (opt == -1)
break;
switch (opt) {
case OPT_KEYSYM:
keysym_mode = true;
break;
case OPT_RULES:
rules = optarg;
break;
case OPT_MODEL:
model = optarg;
break;
case OPT_LAYOUT:
layout_ = optarg;
break;
case OPT_VARIANT:
variant = optarg;
break;
case OPT_OPTIONS:
options = optarg;
break;
case 'h':
usage(argv[0], stdout);
exit(EXIT_SUCCESS);
default:
usage(argv[0], stderr);
exit(EXIT_INVALID_USAGE);
}
}
if (argc - optind != 1) {
fprintf(stderr, "ERROR: missing positional parameter\n");
goto parse_error;
}
if (keysym_mode) {
// Try to parse keysym name or hexadecimal value (0xNNNN)
keysym = xkb_keysym_from_name(argv[optind], XKB_KEYSYM_NO_FLAGS);
if (keysym == XKB_KEY_NoSymbol) {
// Try to parse numeric keysym in base 10, without prefix
val = strtol(argv[optind], &endp, 10);
if (errno != 0 || !isempty(endp) || val <= 0 || val > XKB_KEYSYM_MAX) {
fprintf(stderr, "ERROR: Failed to convert argument to keysym\n");
goto parse_error;
}
keysym = (uint32_t) val;
}
} else {
codepoint = parse_char_or_codepoint(argv[optind]);
if (codepoint == INVALID_UTF8_CODE_POINT)
goto parse_error;
keysym = xkb_utf32_to_keysym(codepoint);
if (keysym == XKB_KEY_NoSymbol) {
fprintf(stderr, "ERROR: Failed to convert code point to keysym\n");
goto parse_error;
}
}
ret = xkb_keysym_get_name(keysym, name, sizeof(name));
if (ret < 0 || (size_t) ret >= sizeof(name)) {
fprintf(stderr, "ERROR: Failed to get name of keysym\n");
goto err;
}
ctx = xkb_context_new(XKB_CONTEXT_NO_FLAGS);
if (!ctx) {
fprintf(stderr, "ERROR: Failed to create XKB context\n");
goto err;
}
struct xkb_rule_names names = {
.rules = rules,
.model = model,
.layout = layout_,
.variant = variant,
.options = options,
};
keymap = xkb_keymap_new_from_names(ctx, &names,
XKB_KEYMAP_COMPILE_NO_FLAGS);
if (!keymap) {
fprintf(stderr, "ERROR: Failed to create XKB keymap\n");
goto err;
}
printf("keysym: %s (%#x)\n", name, keysym);
printf("%-8s %-9s %-8s %-20s %-7s %-s\n",
"KEYCODE", "KEY NAME", "LAYOUT", "LAYOUT NAME", "LEVEL#", "MODIFIERS");
min_keycode = xkb_keymap_min_keycode(keymap);
max_keycode = xkb_keymap_max_keycode(keymap);
num_mods = xkb_keymap_num_mods(keymap);
for (xkb_keycode_t keycode = min_keycode; keycode <= max_keycode; keycode++) {
const char *key_name;
xkb_layout_index_t num_layouts;
key_name = xkb_keymap_key_get_name(keymap, keycode);
if (!key_name) {
continue;
}
num_layouts = xkb_keymap_num_layouts_for_key(keymap, keycode);
for (xkb_layout_index_t layout = 0; layout < num_layouts; layout++) {
const char *layout_name;
xkb_level_index_t num_levels;
layout_name = xkb_keymap_layout_get_name(keymap, layout);
if (!layout_name) {
layout_name = "?";
}
num_levels = xkb_keymap_num_levels_for_key(keymap, keycode, layout);
for (xkb_level_index_t level = 0; level < num_levels; level++) {
int num_syms;
const xkb_keysym_t *syms;
size_t num_masks;
xkb_mod_mask_t masks[100];
num_syms = xkb_keymap_key_get_syms_by_level(
keymap, keycode, layout, level, &syms
);
if (num_syms != 1) {
continue;
}
if (syms[0] != keysym) {
continue;
}
num_masks = xkb_keymap_key_get_mods_for_level(
keymap, keycode, layout, level, masks, ARRAY_SIZE(masks)
);
for (size_t i = 0; i < num_masks; i++) {
xkb_mod_mask_t mask = masks[i];
printf("%-8u %-9s %-8u %-20s %-7u [ ",
keycode, key_name, layout + 1, layout_name, level + 1);
for (xkb_mod_index_t mod = 0; mod < num_mods; mod++) {
if ((mask & (1 << mod)) == 0) {
continue;
}
printf("%s ", xkb_keymap_mod_get_name(keymap, mod));
}
printf("]\n");
}
}
}
}
err = EXIT_SUCCESS;
err:
xkb_keymap_unref(keymap);
xkb_context_unref(ctx);
return err;
parse_error:
usage(argv[0], stderr);
exit(EXIT_INVALID_USAGE);
}