Hash :
30a6533e
Author :
Date :
2019-03-08T12:15:17
Fix float casts in xmlXPathSubstringFunction
Rewrite conversion of double to int in xmlXPathSubstringFunction, adding
range checks to avoid undefined behavior. Make sure to add start and
length as floating-point numbers before converting to int. Fix a bug
when rounding negative start indices.
Remove unneeded calls to xmlXPathIs{Inf,NaN} and rely on IEEE math
instead. Avoid computing the string length. xmlUTF8Strsub works as
expected if the length of the requested substring exceeds the input.
Found with libFuzzer and UBSan.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152
========================
Expression: string(5)
Object is a string : 5
========================
Expression: string(0.5)
Object is a string : 0.5
========================
Expression: string(-0.5)
Object is a string : -0.5
========================
Expression: string(true())
Object is a string : true
========================
Expression: string(false())
Object is a string : false
========================
Expression: string(12345678901234567890)
Object is a string : 1.23456789012346e+19
========================
Expression: string(-12345678901234567890)
Object is a string : -1.23456789012346e+19
========================
Expression: concat("titi","toto")
Object is a string : tititoto
========================
Expression: concat("titi","toto","tata")
Object is a string : tititototata
========================
Expression: concat("titi",'toto')
Object is a string : tititoto
========================
Expression: concat("titi",'toto',"tata","last")
Object is a string : tititototatalast
========================
Expression: starts-with("tititoto","titi")
Object is a Boolean : true
========================
Expression: starts-with("tititoto","to")
Object is a Boolean : false
========================
Expression: contains("tititototata","titi")
Object is a Boolean : true
========================
Expression: contains("tititototata","toto")
Object is a Boolean : true
========================
Expression: contains("tititototata","tata")
Object is a Boolean : true
========================
Expression: contains("tititototata","tita")
Object is a Boolean : false
========================
Expression: substring("12345",2,3)
Object is a string : 234
========================
Expression: substring("12345",2)
Object is a string : 2345
========================
Expression: substring("12345",-4)
Object is a string : 12345
========================
Expression: substring("12345",3.4)
Object is a string : 345
========================
Expression: substring("12345",3.6)
Object is a string : 45
========================
Expression: substring("12345",1.5,2.6)
Object is a string : 234
========================
Expression: substring("12345",2.2,2.2)
Object is a string : 23
========================
Expression: substring("12345",0,3)
Object is a string : 12
========================
Expression: substring("12345",-8,10)
Object is a string : 1
========================
Expression: substring("12345",4,-10)
Object is a string :
========================
Expression: substring("12345",0 div 0, 3)
Object is a string :
========================
Expression: substring("12345",1, 0 div 0)
Object is a string :
========================
Expression: substring("12345",1 div 0, 3)
Object is a string :
========================
Expression: substring("12345",3,-1 div 0)
Object is a string :
========================
Expression: substring("12345",-42, 1 div 0)
Object is a string : 12345
========================
Expression: substring("12345",-1 div 0, 1 div 0)
Object is a string :
========================
Expression: substring("12345",-1 div 0,5)
Object is a string :
========================
Expression: substring("12345",-0.7,4)
Object is a string : 12
========================
Expression: substring("12345",-5000000000,5000000004)
Object is a string : 123
========================
Expression: string-length("")
Object is a number : 0
========================
Expression: string-length("titi")
Object is a number : 4