Commit 49025a97165f2fb1c47a7934be41e2eade8b5c14
2021-11-21T12:18:50
fix form errors
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
diff --git a/assets/css/app.scss b/assets/css/app.scss
index e30ec01..17afdec 100644
--- a/assets/css/app.scss
+++ b/assets/css/app.scss
@@ -36,6 +36,10 @@ pre.ssh_keys {
}
}
+.invalid-feedback {
+ display: inherit;
+}
+
/* LiveView specific classes for your customization */
.phx-no-feedback.invalid-feedback,
.phx-no-feedback .invalid-feedback {
diff --git a/lib/kmxgit_web/controllers/repository_controller.ex b/lib/kmxgit_web/controllers/repository_controller.ex
index 76cbb87..936bd2b 100644
--- a/lib/kmxgit_web/controllers/repository_controller.ex
+++ b/lib/kmxgit_web/controllers/repository_controller.ex
@@ -4,6 +4,7 @@ defmodule KmxgitWeb.RepositoryController do
alias Kmxgit.RepositoryManager
alias Kmxgit.RepositoryManager.Repository
alias Kmxgit.SlugManager
+ alias Kmxgit.Repo
def new(conn, params) do
action = Routes.repository_path(conn, :create, params["owner"])
@@ -65,18 +66,22 @@ defmodule KmxgitWeb.RepositoryController do
end
defp create_repo(conn, owner, params) do
- Repo.transaction do
- case RepositoryManager.create_repository(owner, params) do
- {:ok, repo} ->
- conn
- |> redirect(to: Routes.repository_path(conn, :show, owner.slug.slug, Repository.splat(repo)))
- {:error, changeset} ->
- IO.inspect(changeset)
- conn
- |> assign(:action, Routes.repository_path(conn, :create, owner.slug.slug))
- |> assign(:changeset, changeset)
- |> render("new.html")
- end
+ case Repo.transaction(fn ->
+ case RepositoryManager.create_repository(owner, params) do
+ {:ok, repo} -> {:ok, repo}
+ {:error, changeset} -> Repo.rollback changeset
+ end
+ end) do
+ {:ok, repo} ->
+ conn
+ |> redirect(to: Routes.repository_path(conn, :show, owner.slug.slug, Repository.splat(repo)))
+ {:error, changeset} ->
+ IO.inspect(changeset)
+ conn
+ |> assign(:action, Routes.repository_path(conn, :create, owner.slug.slug))
+ |> assign(:changeset, changeset)
+ |> assign(:owner, owner)
+ |> render("new.html")
end
end
diff --git a/lib/kmxgit_web/templates/repository/form.html.heex b/lib/kmxgit_web/templates/repository/form.html.heex
index 13717bd..1535a36 100644
--- a/lib/kmxgit_web/templates/repository/form.html.heex
+++ b/lib/kmxgit_web/templates/repository/form.html.heex
@@ -1,4 +1,4 @@
-<.form let={f} for={@changeset} action={@action}>
+<%= form_for @changeset, @action, fn f -> %>
<%= if @changeset.action do %>
<div class="alert alert-danger">
<p>Invalid parameters</p>
@@ -35,4 +35,4 @@
<%= submit gettext("Submit"), class: "btn btn-primary" %>
</div>
-</.form>
+<% end %>