gotweb/gotweb.c


Log

Author Commit Date CI Message
Christian Weisgerber abc59930 2021-09-05T19:41:03 indentation fixes
Stefan Sperling e385fc42 2021-08-30T15:48:05 use gmtime_r(3) instead of localtime_r(3) to display time in UTC as intended Problem noticed by naddy due to failing regress tests at midnight, and then analyzed with additional help from millert. ok naddy
Tracey Emery c333d3f7 2021-06-25T21:27:40 goto the right label, so we can get previous on the last page of briefs
Tracey Emery 178d3e72 2021-06-25T20:43:34 we will never have a previous link on the summary page
Tracey Emery f75a37be 2021-06-25T20:35:11 fix missed commit found check
Tracey Emery 5a911940 2021-06-25T20:21:01 fix a glaring logic error in navigation for commits, briefs, and tags. now, we get the proper commit id from the tailq.
Christian Weisgerber dbdddfee 2021-06-23T20:48:35 switch from SIMPLEQ to equivalent STAILQ macros The singly-linked tail queue macros were added to OpenBSD 6.9 and are more widely available on other systems. ok stsp
Stefan Sperling 7a6dddae 2021-06-18T08:06:21 make it possible to profile gotweb; tracey had the same diff
Stefan Sperling 245c7240 2021-06-17T16:36:47 unveil gmon.out if gotweb is being profiled ok tracey
Stefan Sperling 1d0f4054 2021-06-17T08:56:43 check for close(2) error in got_repo_close() and propagate errors up ok tracey
Tracey Emery 6648f956 2021-04-26T19:01:13 properly render an error page instead off returning 500. bug reported by Miniontoby via irc
Josh Rickmar ec6d1a36 2021-03-21T18:49:57 Fix strftime(3) short buffer checks strftime(3) returns 0 if the buffer was too short to write the complete string (including NUL) and will never return more than maxsize-1. ok stsp
Stefan Sperling 56b63ca4 2021-01-22T11:04:47 make fclose(3) failure checks consistent; check 'fclose() == EOF' everywhere ok millert, naddy
Stefan Sperling d9dff0e5 2020-12-26T21:32:01 switch reflist to TAILQ; insert elements more efficiently for sorted input ok naddy
Stefan Sperling 84de9106 2020-12-26T20:48:43 Add a refs argument to got_repo_match_object_id(), replacing 'resolve_tags' Make use of this where possible to avoid re-reading references from disk. ok naddy
Stefan Sperling 22c0f09d 2020-11-22T11:20:52 repair gotweb build after diff api changes
Stefan Sperling be659d10 2020-11-18T17:18:23 fix type of filesize output parameter of got_object_blob_dump_to_file()
Stefan Sperling 8b4e047e 2020-11-15T12:08:45 fix gotweb build; should have been part of 8fa913ec
Stefan Sperling c9d2b263 2020-11-11T11:09:51 make gotweb compile with the new diff implementation
Tracey Emery a5a8a332 2020-11-09T16:53:04 remove unused variable in gotweb.c, patch by Martin Vahlensieck (thanks)
Christian Weisgerber 62d463ca 2020-10-20T22:43:59 indentation fixes
Tracey Emery 9f6f3943 2020-09-24T22:44:11 restore code removed in b5f0780096f443734de8fc503ca92bf737e2a7b2 and complete code so sub directories work in gotweb This was pointed out by uwerler in IRC. ok stsp
Stefan Sperling abdd569e 2020-09-23T11:41:52 skip remote HEAD refs in gotweb's gw_get_commit(); matches got and tog
Stefan Sperling 3721d310 2020-09-23T11:40:09 repair gotweb build; broken since 48cae60d
Tracey Emery f71c0a3a 2020-06-23T20:27:11 move gw_conf malloc to parse.y and cleanup another one-line set/check fix rash pointer change in last edit
Tracey Emery c34ec417 2020-06-22T17:09:05 restructure gotweb parse.y to be like the new got parse.y correct a lot of incorrect error handling adjust copyrights
Tracey Emery e9a8bbf7 2020-05-29T13:47:04 fix from Martin Vahlensieck to return error instead of NULL (thank you) ok tracey stsp
Tracey Emery 19ff7638 2020-04-14T18:05:51 handle all khttp_urlpart errors
Tracey Emery 6918c609 2020-04-14T17:40:42 remove all asprintf from gw_output_site_link and fix error handling
Tracey Emery e6789209 2020-04-14T17:40:42 remove all asprintf from gw_output_repo_heads
Tracey Emery c6eb96ac 2020-04-14T17:40:42 reduce asprint usage in gw_output_repo_tree
Tracey Emery ebc6542a 2020-04-14T17:40:42 remove all asprintf from gw_blame_cb
Tracey Emery 12003b6a 2020-04-14T17:40:42 remove all asprintf from gw_output_repo_tags
Tracey Emery f7632464 2020-04-14T17:40:42 remove all asprintf from gw_tags
Tracey Emery 9ba68833 2020-04-14T17:40:42 remove all asprintf from gw_briefs
Tracey Emery 038dfa29 2020-04-14T17:40:42 remove all asprintf from gw_commits
Tracey Emery 2796ac23 2020-04-14T17:40:42 remove all asprintf from gw_index
Tracey Emery 32b9f7ed 2020-04-14T17:40:42 use khtml_printf where possible
Tracey Emery f08447b0 2020-04-14T17:40:42 use khttp_printf where possible
Tracey Emery 7b1f04a6 2020-03-11T14:59:15 remove 'Next' link from tags on summary page where no tags exist and commit briefs have set gw_trans->next_id if gw_briefs set gw_trans->next_id in gw_summary, it was being carried over to gw_tags, causing the 'Next' link to be displayed.
Tracey Emery 795c10a4 2020-02-20T13:39:19 initialize all missed kcgi_err enums. pointed out by kurt@
Tracey Emery 1a0f5bbd 2020-02-19T16:46:02 whitespace, remove unneeded jump
Tracey Emery ff4bb25f 2020-02-19T16:37:13 add new tags page and ability to navigate all tags
Tracey Emery 75f21c89 2020-02-18T21:42:37 reduce gw_index np_wrapper code to one if statement
Tracey Emery bf4484a3 2020-02-18T21:24:33 work if someone sets got_max_commits_display to 1, and check prev_id
Tracey Emery 55e46400 2020-02-18T20:39:38 add navigation to gw_briefs and gw_commits, fix logic error in original limit checking
Stefan Sperling bb63914a 2020-02-17T21:57:56 make tmp dir location a compile-time setting and change gotweb's tmp dir We are not sure whether a gotweb package can own /var/www/tmp on OpenBSD. Moving gotweb's tmp dir to /var/www/got/tmp sidesteps that issue.
Stefan Sperling fa44fa48 2020-02-17T20:48:35 remove needless file and folder parameters from blame's commit diff links
Stefan Sperling d90bcdd6 2020-02-17T20:42:02 improve error message when query contains an invalid repo name
Stefan Sperling 97a19438 2020-02-17T20:34:40 got_ref_get_name() cannot fail
Stefan Sperling 8f214b62 2020-02-17T20:34:27 don't use got_error_from_errno() in situations where errno was not set
Stefan Sperling c56af3fd 2020-02-17T20:24:04 add missing error check in gw_output_blob_buf()
Tracey Emery bc8c6114 2020-02-17T17:30:29 free missed n_header refs
Tracey Emery 795c5bd7 2020-02-17T17:23:16 check for correct opendir
Tracey Emery e227880d 2020-02-17T17:22:07 improve closedir error handling
Tracey Emery 8182bd34 2020-02-17T17:11:26 close potentially left open directory during an error condition
Tracey Emery 85993e64 2020-02-17T17:09:49 apply unveil earlier in gw_summary, instead of waiting on gw_briefs
Tracey Emery bf93a5c0 2020-02-15T16:35:04 handle commit briefs branch display in gw_briefs instead of gw_summary
Tracey Emery 1b33afc0 2020-02-14T23:48:52 improve gw_blame querystring checking. remove XXX comments, since repo_file is now checked before dumping blob
Tracey Emery 3b7fdcf4 2020-02-14T23:23:47 improve gw_blob querystring checking
Tracey Emery 9f33591a 2020-02-14T22:26:09 check required querystring commit exists for gw_tags
Tracey Emery 56997cd3 2020-02-14T22:19:41 rename commit to commit_id in gw_trans and fix setting gw_trans->commit_id from gw_index leave comment explaining this
Tracey Emery f9315db0 2020-02-14T22:07:17 initialize author and committer to prevent double free on error
Tracey Emery deac617c 2020-02-14T21:49:11 where we can, use a single open repo object to reduce opening and closing a repo
Tracey Emery 3c245a0e 2020-02-14T21:01:29 further simplify objects carries around in struct gw_header
Tracey Emery 4e8d6e3e 2020-02-14T20:56:45 simplify getting commit header info and open and close in scope discussed at length with stsp
Stefan Sperling 2011c142 2020-02-14T11:19:43 simplify gw_get_repo_age() and close several resource leaks
Stefan Sperling 7eb2c8df 2020-02-14T11:13:16 no need to dup refname in gw_output_repo_heads()
Stefan Sperling eb4f3ad3 2020-02-14T11:13:16 check for any symbolic refs and skip them, not just HEAD
Stefan Sperling 17d4bf8d 2020-02-14T11:13:16 refname in gw_get_repo_age() doesn't need to be duplicated; simplify
Stefan Sperling 742ba378 2020-02-14T10:50:54 there is no need to strdup() gw_trans->headref
Stefan Sperling 122f3af5 2020-02-14T10:41:25 add missing error checks in gw_get_header()
Stefan Sperling a4c23852 2020-02-14T10:25:50 gotweb: decorate only the branch's tip commit ID with "(branch)"; add XXX
Stefan Sperling b0a1bc86 2020-02-14T10:05:22 gw_free_headers() frees just one gw_header so rename it to gw_free_header()
Stefan Sperling 92786174 2020-02-14T09:48:39 make gotweb's summary page display which branch the commit briefs belong to
Tracey Emery 7ecc73af 2020-02-13T23:49:31 ensure we close the final checked dir in gw_load_got_path and use better error message
Tracey Emery cc18a904 2020-02-13T23:40:43 catch invalid actions and git paths earlier in querystring parsing
Tracey Emery 6f6f771f 2020-02-13T23:28:37 set gw_err in correct code path
Tracey Emery 88759617 2020-02-13T22:25:33 remove free(refs_str) that was reintroduced with rebase
Tracey Emery f1200fe3 2020-02-13T22:20:46 fixup initial action querystring error and use the err.tmpl finally
Stefan Sperling d81f9039 2020-02-13T20:49:27 jump to error handling consistently in gw_load_got_path()
Stefan Sperling a81394a7 2020-02-13T20:42:44 eliminate unnecessary strdup() via an intermediate variable in gw_get_commit()
Tracey Emery 53e81e48 2020-02-13T20:38:29 remove unneeded asprintf and clean up a couple of lines
Tracey Emery 5c65becf 2020-02-13T20:27:04 remove all usage of strdup("") and simply check for NULL instead
Tracey Emery 39fdad0d 2020-02-13T18:07:50 avoid strdup on author and committer
Tracey Emery d1635ae4 2020-02-13T18:02:36 backout changes in a942aa37d2d222c183405af276d7bd07f9657398 and expand strdup error checking
Stefan Sperling 4d6abe2b 2020-02-13T10:55:02 no need to deep-copy repo_file param from querystring; add some XXX comments
Stefan Sperling dda76f18 2020-02-13T10:52:18 add another XXX comment; I'm not quite sure what to do about this just yet
Stefan Sperling f652ec0c 2020-02-13T10:43:59 no need to deep-copy the repository name from the request; just point to it
Stefan Sperling 26dc3004 2020-02-13T10:40:47 put braces around multi-line if (...)
Stefan Sperling 5d1296de 2020-02-13T10:37:36 no need to copy gotweb's action name; just look it up in static memory
Stefan Sperling b0ca5974 2020-02-13T10:31:23 reduce indentation level of code in gw_parse_querystring; no functional change
Stefan Sperling 1620a2b8 2020-02-13T10:15:49 add XXX comment to code that seems... off...
Stefan Sperling 8f484ce9 2020-02-13T10:12:43 list all branch heads on gotweb summary page, not just the first one
Stefan Sperling 4619e1f2 2020-02-13T10:11:07 consistent error return from gw_init_gw_dir()
Stefan Sperling a02d5f81 2020-02-13T10:05:24 break out of loop on error, instead of returning, in gw_index()
Stefan Sperling d4159696 2020-02-13T10:02:21 remove unused second parameter from gw_apply_unveil()
Tracey Emery 1dcb8908 2020-02-12T14:51:25 fix missed viewport name attribute
Tracey Emery 00f13350 2020-02-10T16:37:31 order, consistency, minor jump cleanup
Tracey Emery a942aa37 2020-02-10T15:54:56 improve strdup error handling