thodg/got/lib/worklist.c

• Show log

  Commit

• Hash : 25dced9b
  Author :
  Date : 2019-09-15T13:46:51
  

  fix possible memleak in worklist_add() if path is too long

Download

• lib/worklist.c

• /*	$OpenBSD: worklist.c,v 1.4 2015/06/13 20:15:21 nicm Exp $	*/
  /*
   * Copyright (c) 2006 Joris Vink <joris@openbsd.org>
   * All rights reserved.
   *
   * Redistribution and use in source and binary forms, with or without
   * modification, are permitted provided that the following conditions
   * are met:
   *
   * 1. Redistributions of source code must retain the above copyright
   *    notice, this list of conditions and the following disclaimer.
   * 2. The name of the author may not be used to endorse or promote products
   *    derived from this software without specific prior written permission.
   *
   * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES,
   * INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY
   * AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL
   * THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
   * EXEMPLARY, OR CONSEQUENTIAL  DAMAGES (INCLUDING, BUT NOT LIMITED TO,
   * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
   * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
   * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
   * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
   * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
   */
  
  #include <sys/queue.h>
  
  #include <err.h>
  #include <signal.h>
  #include <stdlib.h>
  #include <stdio.h>
  #include <string.h>
  #include <unistd.h>
  
  #include "worklist.h"
  #include "got_error.h"
  
  /*
   * adds a path to a worklist.
   */
  const struct got_error *
  worklist_add(const char *path, struct wklhead *worklist)
  {
  	size_t len;
  	struct worklist *wkl;
  	sigset_t old, new;
  
  	wkl = calloc(1, sizeof(*wkl));
  	if (wkl == NULL)
  		return got_error_from_errno("calloc");
  
  	len = strlcpy(wkl->wkl_path, path, sizeof(wkl->wkl_path));
  	if (len >= sizeof(wkl->wkl_path)) {
  		free(wkl);
  		return got_error(GOT_ERR_NO_SPACE);
  	}
  
  	sigfillset(&new);
  	sigprocmask(SIG_BLOCK, &new, &old);
  	SLIST_INSERT_HEAD(worklist, wkl, wkl_list);
  	sigprocmask(SIG_SETMASK, &old, NULL);
  	return NULL;
  }
  
  /*
   * run over the given worklist, calling cb for each element.
   * this is just like worklist_clean(), except we block signals first.
   */
  void
  worklist_run(struct wklhead *list, void (*cb)(struct worklist *))
  {
  	sigset_t old, new;
  	struct worklist *wkl;
  
  	sigfillset(&new);
  	sigprocmask(SIG_BLOCK, &new, &old);
  
  	worklist_clean(list, cb);
  
  	while ((wkl = SLIST_FIRST(list)) != NULL) {
  		SLIST_REMOVE_HEAD(list, wkl_list);
  		free(wkl);
  	}
  
  	sigprocmask(SIG_SETMASK, &old, NULL);
  }
  
  /*
   * pass elements to the specified callback, which has to be signal safe.
   */
  void
  worklist_clean(struct wklhead *list, void (*cb)(struct worklist *))
  {
  	struct worklist *wkl;
  
  	SLIST_FOREACH(wkl, list, wkl_list)
  	    cb(wkl);
  }
  
  void
  worklist_unlink(struct worklist *wkl)
  {
  	(void)unlink(wkl->wkl_path);
  }
  

Download