|
03c4f86c
|
2020-06-08T12:42:59
|
|
cmake: enable warnings for missing function declarations
Over time, we have accumulated quite a lot of functions with missing
prototypes, missing `static` keywords or which were completely unused.
It's easy to miss these mistakes, but luckily GCC and Clang both have
the `-Wmissing-declarations` warning. Enabling this will cause them to
emit warnings for every not-static function that doesn't have a previous
declaration. This is a very sane thing to enable, and with the preceding
commits all these new warnings have been fixed.
So let's always enable this warning so we won't introduce new instances
of them.
|
|
fd1f0940
|
2020-06-08T12:42:26
|
|
refs: add missing function declaration
The function `git_reference__is_note` is not declared anywhere. Let's
add the declaration to avoid having non-static functions without
declaration.
|
|
6e1efcd6
|
2020-06-08T12:46:04
|
|
tree-wide: add missing header includes
We're missing some header includes leading to missing function
prototypes. While we currently don't warn about these, we should have
their respective headers included in order to detect the case where a
function signature change results in an incompatibility.
|
|
a6c9e0b3
|
2020-06-08T12:40:47
|
|
tree-wide: mark local functions as static
We've accumulated quite some functions which are never used outside of
their respective code unit, but which are lacking the `static` keyword.
Add it to reduce their linkage scope and allow the compiler to optimize
better.
|
|
c6184f0c
|
2020-06-08T21:07:36
|
|
tree-wide: do not compile deprecated functions with hard deprecation
When compiling libgit2 with -DDEPRECATE_HARD, we add a preprocessor
definition `GIT_DEPRECATE_HARD` which causes the "git2/deprecated.h"
header to be empty. As a result, no function declarations are made
available to callers, but the implementations are still available to
link against. This has the problem that function declarations also
aren't visible to the implementations, meaning that the symbol's
visibility will not be set up correctly. As a result, the resulting
library may not expose those deprecated symbols at all on some platforms
and thus cause linking errors.
Fix the issue by conditionally compiling deprecated functions, only.
While it becomes impossible to link against such a library in case one
uses deprecated functions, distributors of libgit2 aren't expected to
pass -DDEPRECATE_HARD anyway. Instead, users of libgit2 should manually
define GIT_DEPRECATE_HARD to hide deprecated functions. Using "real"
hard deprecation still makes sense in the context of CI to test we don't
use deprecated symbols ourselves and in case a dependant uses libgit2 in
a vendored way and knows it won't ever use any of the deprecated symbols
anyway.
|
|
7c499b54
|
2020-06-08T12:39:09
|
|
tree-wide: remove unused functions
We have some functions which aren't used anywhere. Let's remove them to
get rid of unneeded baggage.
|
|
b2217552
|
2020-06-07T01:02:38
|
|
Revert .github/workflows/main.yml
|
|
c16ba496
|
2020-06-07T00:37:55
|
|
yo
|
|
d1f3933e
|
2020-06-07T00:35:19
|
|
Update main.yml
|
|
e51002ab
|
2020-06-07T00:33:18
|
|
Update main.yml
|
|
8f48cbf7
|
2020-06-07T00:30:39
|
|
Update main.yml
|
|
6bf744dc
|
2020-06-07T00:28:47
|
|
Update main.yml
|
|
ad1c8e92
|
2020-06-07T00:26:53
|
|
Update main.yml
|
|
9f6e21a0
|
2020-06-07T00:24:45
|
|
Update main.yml
|
|
80c6b0a2
|
2020-06-07T00:16:57
|
|
Update bionic
|
|
4a95ee8d
|
2020-06-07T00:16:39
|
|
Update xenial
|
|
c2ac139c
|
2020-06-07T00:12:47
|
|
Update xenial
|
|
0d82e49f
|
2020-06-07T00:12:17
|
|
Update bionic
|
|
308fc153
|
2020-06-06T23:59:28
|
|
Update main.yml
|
|
074c7753
|
2020-06-06T23:49:42
|
|
Update main.yml
|
|
5f4b3017
|
2020-06-06T23:44:51
|
|
Update main.yml
|
|
78ed45d5
|
2020-06-06T23:25:25
|
|
Update main.yml
|
|
09d00c3e
|
2020-06-06T23:21:35
|
|
Update main.yml
|
|
92ab4213
|
2020-06-06T23:16:52
|
|
Update main.yml
|
|
2e8cc08e
|
2020-06-06T23:15:08
|
|
Update main.yml
|
|
7ebb420a
|
2020-06-06T23:06:11
|
|
Update main.yml
|
|
42c5d7c2
|
2020-06-06T23:02:10
|
|
Update main.yml
|
|
045429f5
|
2020-06-06T22:44:20
|
|
Update main.yml
|
|
e3683c72
|
2020-06-06T22:41:02
|
|
Update main.yml
|
|
fbb71d0c
|
2020-06-06T22:32:33
|
|
Update main.yml
|
|
982a1def
|
2020-06-06T22:30:16
|
|
Update main.yml
|
|
7e5a1ce3
|
2020-06-06T22:27:37
|
|
Update main.yml
|
|
a9e252d4
|
2020-06-06T22:23:19
|
|
Update main.yml
|
|
c199d5e8
|
2020-06-06T22:21:53
|
|
Update main.yml
|
|
aaf96aff
|
2020-06-06T22:00:36
|
|
Update main.yml
|
|
d7b0e918
|
2020-06-06T21:58:02
|
|
Update main.yml
|
|
37af2a0d
|
2020-06-06T21:55:27
|
|
Update main.yml
|
|
7c518a59
|
2020-06-06T21:22:44
|
|
Update main.yml
|
|
e310a0cb
|
2020-06-06T21:21:33
|
|
Update main.yml
|
|
7f6f2790
|
2020-06-06T21:20:51
|
|
Update main.yml
|
|
f5510222
|
2020-06-06T21:18:42
|
|
Update main.yml
|
|
070633db
|
2020-06-06T21:17:54
|
|
Update main.yml
|
|
f356952b
|
2020-06-06T21:01:51
|
|
Update main.yml
|
|
c31c10cc
|
2020-06-06T21:00:15
|
|
Update main.yml
|
|
a2c42999
|
2020-06-06T20:58:19
|
|
Update main.yml
|
|
4eb9c0a5
|
2020-06-06T20:57:51
|
|
Update main.yml
|
|
7861a86b
|
2020-06-06T20:56:01
|
|
Update main.yml
|
|
09439368
|
2020-06-06T20:53:23
|
|
Update main.yml
|
|
ddfeb4aa
|
2020-06-06T20:52:54
|
|
Update main.yml
|
|
2540fd08
|
2020-06-06T20:52:15
|
|
Update main.yml
|
|
6ad47348
|
2020-06-06T20:50:45
|
|
Update main.yml
|
|
8e794b0e
|
2020-06-06T20:49:30
|
|
Update main.yml
|
|
1849f89a
|
2020-06-06T20:42:15
|
|
Update main.yml
|
|
3454dd64
|
2020-06-06T20:38:56
|
|
Update main.yml
|
|
43667e57
|
2020-06-06T17:39:58
|
|
Update main.yml
|
|
560ca69a
|
2020-06-06T17:30:48
|
|
Update main.yml
|
|
41e18bd4
|
2020-06-06T17:28:06
|
|
Update main.yml
|
|
69b6027c
|
2020-06-06T17:26:58
|
|
Update main.yml
|
|
5a5335f4
|
2020-06-06T17:25:52
|
|
Update main.yml
|
|
a1b454e0
|
2020-06-06T17:24:32
|
|
Update main.yml
|
|
4a8f9f77
|
2020-06-06T17:22:57
|
|
Update main.yml
|
|
94017145
|
2020-06-06T17:20:23
|
|
Update main.yml
|
|
6c8ad0f8
|
2020-06-06T17:16:10
|
|
Update main.yml
|
|
6527b35e
|
2020-06-06T16:38:55
|
|
Update main.yml
|
|
309b6148
|
2020-06-06T16:38:01
|
|
Update main.yml
|
|
0a8fa2a5
|
2020-06-06T16:34:08
|
|
Update main.yml
|
|
0a4255e4
|
2020-06-06T16:30:27
|
|
Update main.yml
|
|
06e0abe1
|
2020-06-06T16:22:25
|
|
Update main.yml
|
|
fd6997af
|
2020-06-06T16:21:07
|
|
Update main.yml
|
|
91f02a8a
|
2020-06-06T16:20:35
|
|
Update main.yml
|
|
8d8cfee9
|
2020-06-06T16:16:30
|
|
Update main.yml
|
|
39d12f1c
|
2020-06-06T16:14:59
|
|
Update main.yml
|
|
872cc3dc
|
2020-06-06T16:13:38
|
|
Update main.yml
|
|
eb7e17ee
|
2020-06-06T16:12:18
|
|
Update main.yml
|
|
aa0b1d19
|
2020-06-06T16:08:00
|
|
Update main.yml
|
|
254108b0
|
2020-06-06T15:53:42
|
|
Update main.yml
|
|
cef3585b
|
2020-06-06T15:48:00
|
|
Update main.yml
|
|
e300547b
|
2020-06-06T15:37:42
|
|
Update main.yml
|
|
580c76ed
|
2020-06-06T15:35:58
|
|
Update main.yml
|
|
3b6fad6d
|
2020-06-06T15:33:19
|
|
Update main.yml
|
|
15fa1a49
|
2020-06-06T15:14:21
|
|
Update main.yml
|
|
340de10f
|
2020-06-06T15:03:21
|
|
Update main.yml
|
|
cdeff885
|
2020-06-06T14:53:07
|
|
Update main.yml
|
|
10d5987c
|
2020-06-06T14:45:07
|
|
Create main.yml
|
|
c708e5e5
|
2020-06-05T14:11:34
|
|
Merge pull request #5541 from libgit2/ethomson/clar_tap
clar: add tap output option
|
|
cad7a1ba
|
2020-06-05T08:42:38
|
|
clar: include the function name
|
|
b4290518
|
2020-06-05T07:53:32
|
|
Merge pull request #5545 from libgit2/ethomson/diff_parse
diff::parse: don't include `diff.h`
|
|
06d69dfc
|
2020-05-01T12:39:48
|
|
diff::parse: don't include `diff.h`
We don't call any internal functions in the test; we don't need to
include `../src/diff.h`.
|
|
2f8d0cf2
|
2020-06-04T12:37:48
|
|
Merge pull request #5543 from libgit2/ethomson/release_script_typo
release script: fix typo
|
|
b79f7d38
|
2020-06-04T09:49:38
|
|
release script: fix typo
|
|
f7250cc3
|
2020-06-04T07:23:15
|
|
clar: add tap output
|
|
691315e6
|
2020-06-03T15:47:42
|
|
clar: add an output abstraction layer
Add an output abstraction layer, with a single output format, "clap",
the clar protocol, which is the current output format for clar.
|
|
0187f36a
|
2020-06-03T15:22:44
|
|
clar: parse arguments before printing the header
We want to parse arguments before we start printing any output; the
arguments themselves may impact the way we display that output.
|
|
86b85492
|
2020-06-03T15:40:37
|
|
Merge pull request #5537 from libgit2/ethomson/clar_exactmatch
tests: offer exact name matching with a `$` suffix
|
|
107bf1f4
|
2020-06-03T11:47:13
|
|
clar: print indirection
|
|
53a8f463
|
2020-06-03T07:40:59
|
|
Merge pull request #5536 from libgit2/ethomson/http
httpclient: support googlesource
|
|
6de8aa7f
|
2020-06-02T12:21:22
|
|
Merge pull request #5532 from joshtriplett/pack-default-path
git_packbuilder_write: Allow setting path to NULL to use the default path
|
|
22f9a0fc
|
2020-06-02T12:12:41
|
|
Merge pull request #5531 from joshtriplett/mempack-threads
mempack: Use threads when building the pack
|
|
0d3ce2ac
|
2020-06-02T10:23:41
|
|
offer exact name matching with a `$` suffix
When using `-s` to specify a particular test, it will do a prefix match.
Thus, `-sapply::both::rename_a_to_b_to_c` will match both a test named
`test_apply_both__rename_a_to_b_to_c` and a test that begins with that
name, like `test_apply_both__rename_a_to_b_to_c_exact`.
Permit a trailing `$` to `-s` syntax. This allows a user to specify
`-sapply::both::rename_a_to_b_to_c$` to match _only_ the
`test_apply_both__rename_a_to_b_to_c` function.
We already filter to ensure that the given prefix matches the current
test name. Also ensure that the length of the test name matches the
length of the filter, sans trailing `$`.
|
|
d4b953f8
|
2020-06-02T09:26:11
|
|
Merge pull request #5528 from libgit2/ethomson/clar_internal
clar: use internal functions instead of /bin/cp and /bin/rm
|