Log

Author Commit Date CI Message
Russell Belfer 14997dc5 2013-10-08T12:45:43 More filemode cleanups for FAT on MacOS This cleans up some additional issues. The main change is that on a filesystem that doesn't support mode bits, libgit2 will now create new blobs with GIT_FILEMODE_BLOB always instead of being at the mercy to the filesystem driver to report executable or not. This means that if "core.filemode" lies and claims that filemode is not supported, then we will ignore the executable bit from the filesystem. Previously we would have allowed it. This adds an option to the new git_repository_reset_filesystem to recurse through submodules if desired. There may be other types of APIs that would like a "recurse submodules" option, but this one is particularly useful. This also has a number of cleanups, etc., for related things including trying to give better error messages when problems come up from the filesystem. For example, the FAT filesystem driver on MacOS appears to return errno EINVAL if you attempt to write a filename with invalid UTF-8 in it. We try to capture that with a better error message now.
Russell Belfer 5173ea92 2013-10-04T16:32:16 Add git_repository_reset_filesystem and fix tests When a repository is transferred from one file system to another, many of the config settings that represent the properties of the file system may be wrong. This adds a new public API that will refresh the config settings of the repository to account for the change of file system. This doesn't do a full "reinitialize" and operates on a existing git_repository object refreshing the config when done. This commit then makes use of the new API in clar as each test repository is set up. This commit also has a number of other clar test fixes where we were making assumptions about the type of filesystem, either based on outdated config data or based on the OS instead of the FS.
Russell Belfer b8f9059d 2013-10-03T15:16:06 More cleanups to remove WIN assumptions This cleans up more of the test suite to check actual filesystem behavior instead of relying on Windows vs. Mac vs. Linux to test.
Russell Belfer 840fb4fc 2013-10-03T14:42:37 Update repo init with fewer platform assumptions The repo init code was assuming Windows == no filemode, and Mac or Windows == no case sensitivity. Those assumptions are not consistently true depending on the mounted file system. This is a first step to removing those assumptions. It focuses on the repo init code and the tests of that code. There are still many other tests that are broken when those assumptions don't hold true, but this clears up one area of the code. Also, this moves the core.precomposeunicode logic to be closer to the current logic in core Git where it will be set to true on any filesystem where composed unicode is decomposed when read back.
Russell Belfer af302aca 2013-10-02T14:13:11 Clean up annoying warnings The indexer code was generating warnings on Windows 64-bit. I looked closely at the logic and was able to simplify it a bit. Also this fixes some other Windows and Linux warnings.
Russell Belfer 966bb17a 2013-10-01T16:41:07 Add to Git authors who have agreed to relicense In email, Torsten Bögershausen agreed that we could use his code from core Git in libgit2 under the modified license. Also, since his work is the basis for much of the precompose unicode support, I have added him to the AUTHORS file as well.
Russell Belfer 219d3457 2013-10-01T16:12:15 Initial iconv hookup for precomposed unicode This hooks up git_path_direach and git_path_dirload so that they will take a flag indicating if directory entry names should be tested and converted from decomposed unicode to precomposed form. This code will only come into play on the Apple platform and even then, only when certain types of filesystems are used. This involved adding a flag to these functions which involved changing a lot of places in the code. This was an opportunity to do a bit of code cleanup here and there, for example, getting rid of the git_futils_cleanupdir_r function in favor of a simple flag to git_futils_rmdir_r to not remove the top level entry. That ended up adding depth tracking during rmdir_r which led to a safety check for infinite directory recursion. Yay. This hasn't actually been tested on the Mac filesystems where the issue occurs. I still need to get test environment for that.
Russell Belfer 2fe54afa 2013-09-30T16:58:33 Put hooks in place for precompose in dirload fn This doesn't actual do string precompose but it puts the hooks in place into the iterators and the git_path_dirload function so that the actual precompose work is ready to go.
Russell Belfer 6b7991e2 2013-09-30T16:13:53 Add check if we need to precompose unicode on Mac This adds initialization of core.precomposeunicode to repo init on Mac. This is necessary because when a Mac accesses a repo on a VFAT or SAMBA file system, it will return directory entries in decomposed unicode even if the filesystem entry is precomposed. This also removes caching of a number of repo properties from the repo init pipeline because these are properties of the specific filesystem on which the repo is created, not of the system as a whole.
Russell Belfer 618b7689 2013-10-02T12:06:26 Wrap iconv stuff and write tests This adds a simple wrapper around the iconv APIs and uses it instead of the old code that was inlining the iconv stuff. This makes it possible for me to test the iconv logic in isolation. A "no iconv" version of the API was defined with macros so that I could have fewer ifdefs in the code itself.
Russell Belfer d0849f83 2013-10-02T11:07:18 Simplify git_path_is_empty_dir implementation This simplifies git_path_is_empty_dir on both Windows (getting rid of git_buf allocation inside the function) and other platforms (by just using git_path_direach), and adds tests for the function, and uses the function to simplify some existing tests.
Vicent Martí 146b4d1c 2013-10-03T08:18:41 Merge pull request #1888 from jamill/network_cancellation network cancellation improvements
Jameson Miller 7baa7631 2013-10-02T15:39:18 Style tweaks and changes for code review feedback
Vicent Martí ab136876 2013-10-03T04:36:29 Merge pull request #1887 from libgit2/ntk/topic/git_message_raw commit: Introduce git_commit_message_raw()
nulltoken 598f069b 2013-10-02T12:42:41 commit: Introduce git_commit_message_raw()
Russell Belfer c8f2ba99 2013-10-02T15:26:20 Merge pull request #1889 from libgit2/relative-redirect HTTP: handle "relative" redirects
Ben Straub 41a6de28 2013-10-02T14:45:57 HTTP: handle "relative" redirects
Jameson Miller 83db7e09 2013-10-02T15:10:39 Fix broken online push tests
Jameson Miller 5b188225 2013-10-02T13:45:32 Support cancellation in push operation This commit adds cancellation for the push operation. This work consists of: 1) Support cancellation during push operation - During object counting phase - During network transfer phase - Propagate GIT_EUSER error code out to caller 2) Improve cancellation support during fetch - Handle cancellation request during network transfer phase - Clear error string when cancelled during indexing 3) Fix error handling in git_smart__download_pack Cancellation during push is still only handled in the pack building and network transfer stages of push (and not during packbuilding).
Vicent Martí 5bfead1d 2013-10-02T05:56:37 Merge pull request #1855 from libgit2/cmn/clone-into An alternative for 'clone' with options
Carlos Martín Nieto 0e0cf787 2013-10-02T14:04:44 clone: put the callbacks struct directly in the clone options There's no need for this to be a pointer to somewhere else.
Carlos Martín Nieto ffc97d51 2013-09-20T23:23:42 remote: add some comments to the callback struct Hopefully clear up what they're for.
Carlos Martín Nieto 36a241ac 2013-09-20T23:14:52 clone: mention clone_into in the clone documentation Make the difference more explicit.
Carlos Martín Nieto fdc7e5e3 2013-09-20T23:14:12 clone: bring back NULL as defaults This wasremoved as part of the large culling a few commits ago.
Carlos Martín Nieto c833893c 2013-09-20T22:57:01 clone: re-allow using a custom remote name This is a small thing that by itself doesn't quite justify making the user use clone_into.
Carlos Martín Nieto eec1c1fe 2013-09-20T22:49:20 clone: const-ify checkout options The removal of many options which lead to the direct usage of the user's checkout options means we should make sure they remain const.
Carlos Martín Nieto b9bf5d70 2013-09-20T22:46:32 clone: re-add a way to ignore certificate errors This used to be done via transport flags, which was removed in a previous commit.
Carlos Martín Nieto 6ac15eff 2013-09-20T22:34:05 clone: remove more options from basic clone The basic clone function is there to make it easy to create a "normal" clone. Remove a bunch of options that are about changing the remote's configuration.
Carlos Martín Nieto d19870d9 2013-09-16T05:10:55 clone: implement git_clone_into This allows you to set up the repository and remote as you which to have them before performing the clone operation.
Carlos Martín Nieto e3c131c5 2013-09-16T05:02:25 remote: move the credentials callback to the struct Move this one as well, letting us have a single way of setting the callbacks for the remote, and removing fields from the clone options.
Carlos Martín Nieto d31402a3 2013-09-16T04:20:05 remote: put the _download() callback with the others The text progress and update_tips callbacks are already part of the struct, which was meant to unify the callback setup, but the download one was left out.
Carlos Martín Nieto e3a92f0d 2013-09-17T05:31:34 clone: implement git_clone on top of git_clone_into Unify the code bases.
Carlos Martín Nieto c8dbec48 2013-09-16T18:42:53 clone: remove the autotag option Downloading all tags is part of what makes it a clone instead of simply a fetch.
Carlos Martín Nieto fe3a40a4 2013-09-16T16:54:37 remote: add a convenience 'fetch' function.
Vicent Martí 71e33d26 2013-10-01T14:00:30 Merge pull request #1885 from ethomson/transport_register Add git_transport_register, git_transport_unregister
Philip Kelley 83786956 2013-01-04T14:39:05 Add git_transport_register, git_transport_unregister
Ben Straub 816d28e7 2013-10-01T12:56:47 Mark git__timer as inline on OSX
Vicent Martí c655aa52 2013-10-01T05:54:54 Merge pull request #1882 from linquize/config-subsection-fix Config subsection name should allow to have ']' and '\\' should allow to escape any characters
Linquize 8d741253 2013-10-01T09:46:56 Add negative test cases for config header with invalid characters
Linquize d52a93fa 2013-09-30T23:58:58 Add test case to test ']' and '\\' characters in config subsection
Linquize 566dd8ce 2013-09-30T23:38:22 Config subsection name should allow to have ']' and '\\' should allow to escape any characters
Vicent Martí fba14763 2013-09-30T15:03:35 Merge pull request #1879 from libgit2/redir-refactor Redir refactor
Vicent Martí a6884b6f 2013-09-30T14:58:45 Merge pull request #1412 from jamill/push_progress Initial Implementation of progress reports during push
Vicent Martí 9acde162 2013-09-30T14:57:48 Merge pull request #1881 from libgit2/ignore-submodules-in-stash Never consider submodules for stashing
Ben Straub ae5a9352 2013-09-30T14:47:56 Ensure submodule repos and indices are freed ...before the helper's cleanup method tries to delete their files.
Vicent Martí dc56fea7 2013-09-30T12:18:19 Merge pull request #1878 from libgit2/ntk/fix/warnings Fix x86/x64 size_t related warnings
Jameson Miller b176eded 2013-09-19T14:52:57 Initial Implementation of progress reports during push This adds the basics of progress reporting during push. While progress for all aspects of a push operation are not reported with this change, it lays the foundation to add these later. Push progress reporting can be improved in the future - and consumers of the API should just get more accurate information at that point. The main areas where this is lacking are: 1) packbuilding progress: does not report progress during deltafication, as this involves coordinating progress from multiple threads. 2) network progress: reports progress as objects and bytes are going to be written to the subtransport (instead of as client gets confirmation that they have been received by the server) and leaves out some of the bytes that are transfered as part of the push protocol. Basically, this reports the pack bytes that are written to the subtransport. It does not report the bytes sent on the wire that are received by the server. This should be a good estimate of progress (and an improvement over no progress).
Vicent Martí 5b09db15 2013-09-30T09:40:15 Merge pull request #1883 from libgit2/ntk/fix/empty_first_commit_line Remove leading newlines from commit message
nulltoken d27a441d 2013-09-30T11:30:28 commit: Trim message leading newlines Fix libgit2/libgit2sharp#522
nulltoken 27c8eb2a 2013-09-30T11:18:06 Tabify indentations
Justin Spahr-Summers 526d4c94 2013-09-27T21:39:28 Test that submodules don't affect stashing
Justin Spahr-Summers 4fe0b0b3 2013-09-27T17:07:06 Never consider submodules for stashing
Vicent Martí e6a1d9a2 2013-09-27T13:27:11 Merge pull request #1880 from ethomson/refdb_h_oopsie Add refdb.h to git2.h, reorder git2.h sanely
Edward Thomson 7d692454 2013-09-27T16:08:24 Add refdb.h to git2.h, reorder git2.h sanely
Ben Straub b59344bf 2013-09-26T16:48:08 Tighten up url-connection utility
Ben Straub 256961e4 2013-09-26T16:36:05 WHOOPS
Ben Straub 0049d4d1 2013-09-26T16:25:34 Make sure utility doesn't leak memory
Ben Straub 1b02baf4 2013-09-26T16:25:05 Adjust to new utility signature
Ben Straub ea59f659 2013-09-26T16:20:30 Deploy gitno_connection_data into transport (winhttp) ...and have that call manage replaced memory in the output structure.
Ben Straub 83fbd368 2013-09-26T15:58:41 Deploy gitno_connection_data into transport
nulltoken 8a1e925d 2013-09-26T12:00:35 Fix warnings
Ben Straub f30d91ce 2013-09-26T11:03:27 Refactor URL handling to use library call
Ben Straub 8988688c 2013-09-25T20:41:56 Migrate redirect URL handling to common utility
Ben Straub ac316e74 2013-09-25T14:25:38 Why are we disabling redirects?
Ben Straub 11f8336e 2013-09-25T14:12:07 Merge pull request #1877 from libgit2/win32-redirects Win32: handle http->https redirects
Vicent Martí 0ab832fa 2013-09-25T14:08:32 Merge pull request #1876 from arrbee/fix-error-handling-docs Bring error handling docs up to date
Ben Straub 4a88eb20 2013-09-25T12:13:09 Win32: handle http->https redirects
Russell Belfer aa94acf0 2013-09-25T11:53:02 The error handling docs are out of date The error handling docs date back to the early error redesign work and don't match up with the route we actually took. This brings them in line with actual practice both for external users and internal implementors, and notes some of the exceptions and possible bugs.
Vicent Martí e4ad52b6 2013-09-25T09:36:09 Merge pull request #1875 from ethomson/refdb_not_odb That's the refdb, it's not the odb...
Edward Thomson e0b267af 2013-09-25T10:49:25 That's the refdb, it's not the odb...
Vicent Martí b294f97e 2013-09-25T01:41:17 Merge pull request #1873 from mikeando/doc_cleanup Cleaned up some tables in checkout-internals doc
Vicent Martí a955412e 2013-09-25T01:40:43 Merge pull request #1874 from mikeando/doc_cleanup2 Fixed formatting of diff-internals.md
Mike Anderson 6918d81e 2013-09-25T11:14:06 Fixed formatting of diff-internals.md Indentation for lists was not working correctly.
Mike Anderson 53e0636c 2013-09-24T16:43:06 Cleaned up some tables in checkout-internals doc The markdown wasn't rendering correctly.
Vicent Martí d8de5c42 2013-09-24T15:55:51 Merge pull request #1872 from libgit2/config-isolate-xdg Make tests pass if XDG config exists
Russell Belfer 1c8de380 2013-09-20T16:58:04 Make tests pass if XDG config exists
Vicent Martí 4dbdbf64 2013-09-24T15:21:44 Merge pull request #1871 from libgit2/cross-protocol-redirects-alt Alternative fix for cross protocol redirects
Russell Belfer 46fbc88e 2013-09-24T14:50:06 Prevent HTTPS to HTTP redirect
Russell Belfer eb0ff130 2013-09-24T14:07:08 Disconnect path string to preserve after redirect The subtransport path was relying on pointing to data owned by the remote which meant that after a redirect, the updated path was getting lost for future requests. This updates the http transport to strdup the path and maintain its own lifetime. This also pulls responsibility for parsing the URL back into the http transport and isolates the functions that parse and free that connection data so that they can be reused between the initial parsing and the redirect parsing.
Vicent Martí 95bff9d4 2013-09-24T12:01:24 Merge pull request #1869 from ethomson/fs_iterator_race_2 Ignore files that disappear while iterating
Edward Thomson 5c3b8ef4 2013-09-24T14:52:58 Ignore files that disappear while iterating On occasion, files can disappear while we're iterating the filesystem, between calls to readdir and stat. Let's pretend those didn't exist in the first place.
Ben Straub c9144405 2013-09-23T11:37:35 Properly parse urls that include protocol://
Ben Straub 210d5325 2013-09-23T12:09:23 Allow redirects to use same host
Vicent Martí 4a1b4015 2013-09-24T10:32:40 Merge pull request #1865 from arrbee/various-cleanups Various warning cleanup and minor fixes
Vicent Martí 5dc8513b 2013-09-24T10:30:43 Merge pull request #1864 from libgit2/minimize-regex-usage Minimize regex usage
Russell Belfer d005885f 2013-09-24T10:20:16 Fix up filebuf tests a bit
Russell Belfer 634f10f6 2013-09-24T10:11:20 Fix incorrect return code in crlf filter The git_buf_text_gather_stats call returns a boolean indicating if the file looks like binary data. That shouldn't be an error; it should be used to skip CRLF processing though.
Russell Belfer d89b8b60 2013-09-24T09:30:02 Merge pull request #1867 from ethomson/remove_not_delete 'del' instead of 'delete' for the poor C++ users
Edward Thomson e3f3868a 2013-09-24T11:04:14 'del' instead of 'delete' for the poor C++ users
Russell Belfer a3c2d916 2013-09-23T21:59:32 Fix warnings in Makefile.embed
Russell Belfer 00e85927 2013-09-23T21:52:42 Clean up unnecessary git_buf_printf calls This replaces some git_buf_printf calls with simple calls to git_buf_put instead. Also, it fixes a missing va_end inside the git_buf_vprintf implementation.
Russell Belfer 71379313 2013-09-23T13:40:23 Fix warnings on Windows 64-bit build
Russell Belfer 1ca3e49f 2013-09-23T13:34:01 Clean up newly introduced warnings The attempt to "clean up warnings" seems to have introduced some new warnings on compliant compilers. This fixes those in a way that I suspect will also be okay for the non-compliant compilers. Also this fixes what appears to be an extra semicolon in the repo initialization template dir handling (and as part of that fix, handles the case where an error occurs correctly).
Russell Belfer 106c12f1 2013-09-23T13:31:15 Remove regex usage from places that don't need it In revwalk, we are doing a very simple check to see if a string contains wildcard characters, so a full regular expression match is not needed. In remote listing, now that we have git_config_foreach_match with full regular expression matching, we can take advantage of that and eliminate the regex here, replacing it with much simpler string manipulation.
Vicent Martí 10edb7a9 2013-09-22T13:46:39 Merge pull request #1863 from linquize/typo Fix typo in documentation
Carlos Martín Nieto 07fb67f9 2013-09-22T05:55:39 merge: reverse array and length parameter order Make it pair up with the one for commits. This fixes #1691.
Linquize 1b57699a 2013-09-22T09:11:43 Fix typo in documentation
Vicent Martí 92d19d16 2013-09-21T09:34:03 Merge pull request #1840 from linquize/warning Fix warning
Vicent Martí daef29ea 2013-09-20T09:41:49 Merge pull request #1861 from ben/molo-valgrind OSX 10.8 + Valgrind
Vicent Martí 2c9ed02e 2013-09-20T09:22:19 Merge pull request #1859 from linquize/init.templatedir Make init.templatedir work