Log

Author Commit Date CI Message
Edward Thomson 47fb33ba 2020-06-07T00:39:27 Introduce CI with GitHub Actions Add CI using GitHub Actions and GitHub Packages: * This moves our Linux build containers into GitHub Packages; we will identify the most recent commit that updated the docker descriptions, and then look for a docker image in libgit2's GitHub Packages registry for a container with the tag corresponding to that description. If there is not one, we will build the container and then push it to GitHub Packages. * We no longer need to manage authentication with our own credentials or PAT tokens. GitHub Actions provides a GITHUB_TOKEN that can publish artifacts, packages and commits to our repository within a workflow run. * We will use a matrix to build our various CI steps. This allows us to keep configuration in a single place without multiple YAML files.
Edward Thomson 4852d8da 2020-06-10T22:18:13 docker: don't take BASE as an argument The xenial image depends on ubuntu:xenial; the bionic one on ubuntu:bionic. No need for this to be a variable, that's just additional (unnecessary) state to manage in the CI setup(s).
Edward Thomson 8b8b69a7 2020-06-10T22:13:25 azure pipelines: use bundled zlib Azure Pipelines has a version of zlib hanging out on the filesystem; avoid trying to use it as it's either 64 _or_ 32 bit, so exactly one of our builds will fail.
Patrick Steinhardt 96a5f38f 2020-06-10T07:42:52 Merge pull request #5551 from pks-t/pks/missing-declarations Missing declarations
Patrick Steinhardt 6e1efcd6 2020-06-08T12:46:04 tree-wide: add missing header includes We're missing some header includes leading to missing function prototypes. While we currently don't warn about these, we should have their respective headers included in order to detect the case where a function signature change results in an incompatibility.
Patrick Steinhardt a6c9e0b3 2020-06-08T12:40:47 tree-wide: mark local functions as static We've accumulated quite some functions which are never used outside of their respective code unit, but which are lacking the `static` keyword. Add it to reduce their linkage scope and allow the compiler to optimize better.
Patrick Steinhardt 03c4f86c 2020-06-08T12:42:59 cmake: enable warnings for missing function declarations Over time, we have accumulated quite a lot of functions with missing prototypes, missing `static` keywords or which were completely unused. It's easy to miss these mistakes, but luckily GCC and Clang both have the `-Wmissing-declarations` warning. Enabling this will cause them to emit warnings for every not-static function that doesn't have a previous declaration. This is a very sane thing to enable, and with the preceding commits all these new warnings have been fixed. So let's always enable this warning so we won't introduce new instances of them.
Patrick Steinhardt fd1f0940 2020-06-08T12:42:26 refs: add missing function declaration The function `git_reference__is_note` is not declared anywhere. Let's add the declaration to avoid having non-static functions without declaration.
Patrick Steinhardt c6184f0c 2020-06-08T21:07:36 tree-wide: do not compile deprecated functions with hard deprecation When compiling libgit2 with -DDEPRECATE_HARD, we add a preprocessor definition `GIT_DEPRECATE_HARD` which causes the "git2/deprecated.h" header to be empty. As a result, no function declarations are made available to callers, but the implementations are still available to link against. This has the problem that function declarations also aren't visible to the implementations, meaning that the symbol's visibility will not be set up correctly. As a result, the resulting library may not expose those deprecated symbols at all on some platforms and thus cause linking errors. Fix the issue by conditionally compiling deprecated functions, only. While it becomes impossible to link against such a library in case one uses deprecated functions, distributors of libgit2 aren't expected to pass -DDEPRECATE_HARD anyway. Instead, users of libgit2 should manually define GIT_DEPRECATE_HARD to hide deprecated functions. Using "real" hard deprecation still makes sense in the context of CI to test we don't use deprecated symbols ourselves and in case a dependant uses libgit2 in a vendored way and knows it won't ever use any of the deprecated symbols anyway.
Patrick Steinhardt 7c499b54 2020-06-08T12:39:09 tree-wide: remove unused functions We have some functions which aren't used anywhere. Let's remove them to get rid of unneeded baggage.
Edward Thomson b2217552 2020-06-07T01:02:38 Revert .github/workflows/main.yml
Edward Thomson c16ba496 2020-06-07T00:37:55 yo
Edward Thomson d1f3933e 2020-06-07T00:35:19 Update main.yml
Edward Thomson e51002ab 2020-06-07T00:33:18 Update main.yml
Edward Thomson 8f48cbf7 2020-06-07T00:30:39 Update main.yml
Edward Thomson 6bf744dc 2020-06-07T00:28:47 Update main.yml
Edward Thomson ad1c8e92 2020-06-07T00:26:53 Update main.yml
Edward Thomson 9f6e21a0 2020-06-07T00:24:45 Update main.yml
Edward Thomson 80c6b0a2 2020-06-07T00:16:57 Update bionic
Edward Thomson 4a95ee8d 2020-06-07T00:16:39 Update xenial
Edward Thomson c2ac139c 2020-06-07T00:12:47 Update xenial
Edward Thomson 0d82e49f 2020-06-07T00:12:17 Update bionic
Edward Thomson 308fc153 2020-06-06T23:59:28 Update main.yml
Edward Thomson 074c7753 2020-06-06T23:49:42 Update main.yml
Edward Thomson 5f4b3017 2020-06-06T23:44:51 Update main.yml
Edward Thomson 78ed45d5 2020-06-06T23:25:25 Update main.yml
Edward Thomson 09d00c3e 2020-06-06T23:21:35 Update main.yml
Edward Thomson 92ab4213 2020-06-06T23:16:52 Update main.yml
Edward Thomson 2e8cc08e 2020-06-06T23:15:08 Update main.yml
Edward Thomson 7ebb420a 2020-06-06T23:06:11 Update main.yml
Edward Thomson 42c5d7c2 2020-06-06T23:02:10 Update main.yml
Edward Thomson 045429f5 2020-06-06T22:44:20 Update main.yml
Edward Thomson e3683c72 2020-06-06T22:41:02 Update main.yml
Edward Thomson fbb71d0c 2020-06-06T22:32:33 Update main.yml
Edward Thomson 982a1def 2020-06-06T22:30:16 Update main.yml
Edward Thomson 7e5a1ce3 2020-06-06T22:27:37 Update main.yml
Edward Thomson a9e252d4 2020-06-06T22:23:19 Update main.yml
Edward Thomson c199d5e8 2020-06-06T22:21:53 Update main.yml
Edward Thomson aaf96aff 2020-06-06T22:00:36 Update main.yml
Edward Thomson d7b0e918 2020-06-06T21:58:02 Update main.yml
Edward Thomson 37af2a0d 2020-06-06T21:55:27 Update main.yml
Edward Thomson 7c518a59 2020-06-06T21:22:44 Update main.yml
Edward Thomson e310a0cb 2020-06-06T21:21:33 Update main.yml
Edward Thomson 7f6f2790 2020-06-06T21:20:51 Update main.yml
Edward Thomson f5510222 2020-06-06T21:18:42 Update main.yml
Edward Thomson 070633db 2020-06-06T21:17:54 Update main.yml
Edward Thomson f356952b 2020-06-06T21:01:51 Update main.yml
Edward Thomson c31c10cc 2020-06-06T21:00:15 Update main.yml
Edward Thomson a2c42999 2020-06-06T20:58:19 Update main.yml
Edward Thomson 4eb9c0a5 2020-06-06T20:57:51 Update main.yml
Edward Thomson 7861a86b 2020-06-06T20:56:01 Update main.yml
Edward Thomson 09439368 2020-06-06T20:53:23 Update main.yml
Edward Thomson ddfeb4aa 2020-06-06T20:52:54 Update main.yml
Edward Thomson 2540fd08 2020-06-06T20:52:15 Update main.yml
Edward Thomson 6ad47348 2020-06-06T20:50:45 Update main.yml
Edward Thomson 8e794b0e 2020-06-06T20:49:30 Update main.yml
Edward Thomson 1849f89a 2020-06-06T20:42:15 Update main.yml
Edward Thomson 3454dd64 2020-06-06T20:38:56 Update main.yml
Edward Thomson 43667e57 2020-06-06T17:39:58 Update main.yml
Edward Thomson 560ca69a 2020-06-06T17:30:48 Update main.yml
Edward Thomson 41e18bd4 2020-06-06T17:28:06 Update main.yml
Edward Thomson 69b6027c 2020-06-06T17:26:58 Update main.yml
Edward Thomson 5a5335f4 2020-06-06T17:25:52 Update main.yml
Edward Thomson a1b454e0 2020-06-06T17:24:32 Update main.yml
Edward Thomson 4a8f9f77 2020-06-06T17:22:57 Update main.yml
Edward Thomson 94017145 2020-06-06T17:20:23 Update main.yml
Edward Thomson 6c8ad0f8 2020-06-06T17:16:10 Update main.yml
Edward Thomson 6527b35e 2020-06-06T16:38:55 Update main.yml
Edward Thomson 309b6148 2020-06-06T16:38:01 Update main.yml
Edward Thomson 0a8fa2a5 2020-06-06T16:34:08 Update main.yml
Edward Thomson 0a4255e4 2020-06-06T16:30:27 Update main.yml
Edward Thomson 06e0abe1 2020-06-06T16:22:25 Update main.yml
Edward Thomson fd6997af 2020-06-06T16:21:07 Update main.yml
Edward Thomson 91f02a8a 2020-06-06T16:20:35 Update main.yml
Edward Thomson 8d8cfee9 2020-06-06T16:16:30 Update main.yml
Edward Thomson 39d12f1c 2020-06-06T16:14:59 Update main.yml
Edward Thomson 872cc3dc 2020-06-06T16:13:38 Update main.yml
Edward Thomson eb7e17ee 2020-06-06T16:12:18 Update main.yml
Edward Thomson aa0b1d19 2020-06-06T16:08:00 Update main.yml
Edward Thomson 254108b0 2020-06-06T15:53:42 Update main.yml
Edward Thomson cef3585b 2020-06-06T15:48:00 Update main.yml
Edward Thomson e300547b 2020-06-06T15:37:42 Update main.yml
Edward Thomson 580c76ed 2020-06-06T15:35:58 Update main.yml
Edward Thomson 3b6fad6d 2020-06-06T15:33:19 Update main.yml
Edward Thomson 15fa1a49 2020-06-06T15:14:21 Update main.yml
Edward Thomson 340de10f 2020-06-06T15:03:21 Update main.yml
Edward Thomson cdeff885 2020-06-06T14:53:07 Update main.yml
Edward Thomson 10d5987c 2020-06-06T14:45:07 Create main.yml
Edward Thomson c708e5e5 2020-06-05T14:11:34 Merge pull request #5541 from libgit2/ethomson/clar_tap clar: add tap output option
Edward Thomson cad7a1ba 2020-06-05T08:42:38 clar: include the function name
Edward Thomson b4290518 2020-06-05T07:53:32 Merge pull request #5545 from libgit2/ethomson/diff_parse diff::parse: don't include `diff.h`
Edward Thomson 06d69dfc 2020-05-01T12:39:48 diff::parse: don't include `diff.h` We don't call any internal functions in the test; we don't need to include `../src/diff.h`.
Patrick Steinhardt 2f8d0cf2 2020-06-04T12:37:48 Merge pull request #5543 from libgit2/ethomson/release_script_typo release script: fix typo
Edward Thomson b79f7d38 2020-06-04T09:49:38 release script: fix typo
Edward Thomson f7250cc3 2020-06-04T07:23:15 clar: add tap output
Edward Thomson 691315e6 2020-06-03T15:47:42 clar: add an output abstraction layer Add an output abstraction layer, with a single output format, "clap", the clar protocol, which is the current output format for clar.
Edward Thomson 0187f36a 2020-06-03T15:22:44 clar: parse arguments before printing the header We want to parse arguments before we start printing any output; the arguments themselves may impact the way we display that output.
Patrick Steinhardt 86b85492 2020-06-03T15:40:37 Merge pull request #5537 from libgit2/ethomson/clar_exactmatch tests: offer exact name matching with a `$` suffix
Edward Thomson 107bf1f4 2020-06-03T11:47:13 clar: print indirection
Patrick Steinhardt 53a8f463 2020-06-03T07:40:59 Merge pull request #5536 from libgit2/ethomson/http httpclient: support googlesource