kmx git

Commit	Date	Message
5de4ec81	2013-10-21T15:36:38	Implement patience and minimal diff flags It seems that to implement these options, we just have to pass the appropriate flags through to the libxdiff code taken from core git. So let's do it (and add a test).
623460ab	2013-10-21T14:16:53	Fix warnings for win64
3b5f7954	2013-10-21T13:42:42	Create git_diff_line and extend git_diff_hunk Instead of having functions with so very many parameters to pass hunk and line data, this takes the existing git_diff_hunk struct and extends it with more hunk data, plus adds a git_diff_line. Those structs are used to pass back hunk and line data instead of the old APIs that took tons of parameters. Some work that was previously only being done for git_diff_patch creation (scanning the diff content for exact line counts) is now done for all callbacks, but the performance difference should not be noticable.
74a627f0	2013-10-21T09:07:19	Tweak to git_diff_delta structure for nfiles While the base git_diff_delta structure always contains two files, when we introduce conflict data, it will be helpful to have an indicator when an additional file is involved.
10672e3e	2013-10-15T15:10:07	Diff API cleanup This lays groundwork for separating formatting options from diff creation options. This groups the formatting flags separately from the diff list creation flags and reorders the options. This also tweaks some APIs to further separate code that uses patches from code that just looks at git_diffs.
3ff1d123	2013-10-11T14:51:54	Rename diff objects and split patch.h This makes no functional change to diff but renames a couple of the objects and splits the new git_patch (formerly git_diff_patch) into a new header file.
74353137	2013-10-09T11:57:03	After iconv init reset ref normalize error The iconv init was accidentally clearing the default error state during reference normalization. This resets so that normalization errors will be detected correctly.
95c148b2	2013-10-08T17:03:12	Merge pull request #1886 from libgit2/precompose-utf8 Add support for core.precomposeunicode on Mac
867f7c9b	2013-10-08T16:59:59	Rename new fn to git_repository_reinit_filesystem
92dac975	2013-10-08T16:35:57	Make reference lookups apply precomposeunicode Before these changes, looking up a reference would return the same precomposed or decomposed form of the reference name that was used to look it up, so on MacOS which ignores the difference between the two, a single reference could be looked up either way and git_reference_name would return the form of the name that was used to look it up! This change makes lookup always return the precomposed name if core.precomposeunicode is set regardless of which version was used to look it up. The reference iterator was already returning the precomposed form from earlier work. This also updates the CMakeLists.txt rules for enabling iconv usage because the clar tests for this code were actually not being activated properly with the old version. Finally, this moves git_repository_reset_filesystem from include/ git2/repository.h to include/git2/sys/repository.h since it is not really a function that normal library users should have to think about very often.
3dc3c723	2013-10-08T15:52:37	Combine WinHTTP API calls
a58eecd4	2013-10-08T13:40:52	WinHTTP: set Accept header for POSTs
14997dc5	2013-10-08T12:45:43	More filemode cleanups for FAT on MacOS This cleans up some additional issues. The main change is that on a filesystem that doesn't support mode bits, libgit2 will now create new blobs with GIT_FILEMODE_BLOB always instead of being at the mercy to the filesystem driver to report executable or not. This means that if "core.filemode" lies and claims that filemode is not supported, then we will ignore the executable bit from the filesystem. Previously we would have allowed it. This adds an option to the new git_repository_reset_filesystem to recurse through submodules if desired. There may be other types of APIs that would like a "recurse submodules" option, but this one is particularly useful. This also has a number of cleanups, etc., for related things including trying to give better error messages when problems come up from the filesystem. For example, the FAT filesystem driver on MacOS appears to return errno EINVAL if you attempt to write a filename with invalid UTF-8 in it. We try to capture that with a better error message now.
13f670a5	2013-04-15T09:07:57	tree: allow retrieval of raw attributes When a tool needs to recreate the tree object (for example an interface to another VCS), it needs to use the raw attributes, forgoing any normalization.
22661448	2013-10-04T19:35:32	Don't use git_atomic as an integer
cdc95a0d	2013-10-04T18:38:37	Use InterlockedCompareExchange for the lock
e411b74e	2013-10-04T19:33:48	Posix synchronized init, prototype win32 version
5173ea92	2013-10-04T16:32:16	Add git_repository_reset_filesystem and fix tests When a repository is transferred from one file system to another, many of the config settings that represent the properties of the file system may be wrong. This adds a new public API that will refresh the config settings of the repository to account for the change of file system. This doesn't do a full "reinitialize" and operates on a existing git_repository object refreshing the config when done. This commit then makes use of the new API in clar as each test repository is set up. This commit also has a number of other clar test fixes where we were making assumptions about the type of filesystem, either based on outdated config data or based on the OS instead of the FS.
da7b78fa	2013-10-04T14:03:12	index: Make _read() cope with index file creation
840fb4fc	2013-10-03T14:42:37	Update repo init with fewer platform assumptions The repo init code was assuming Windows == no filemode, and Mac or Windows == no case sensitivity. Those assumptions are not consistently true depending on the mounted file system. This is a first step to removing those assumptions. It focuses on the repo init code and the tests of that code. There are still many other tests that are broken when those assumptions don't hold true, but this clears up one area of the code. Also, this moves the core.precomposeunicode logic to be closer to the current logic in core Git where it will be set to true on any filesystem where composed unicode is decomposed when read back.
af302aca	2013-10-02T14:13:11	Clean up annoying warnings The indexer code was generating warnings on Windows 64-bit. I looked closely at the logic and was able to simplify it a bit. Also this fixes some other Windows and Linux warnings.
618b7689	2013-10-02T12:06:26	Wrap iconv stuff and write tests This adds a simple wrapper around the iconv APIs and uses it instead of the old code that was inlining the iconv stuff. This makes it possible for me to test the iconv logic in isolation. A "no iconv" version of the API was defined with macros so that I could have fewer ifdefs in the code itself.
d0849f83	2013-10-02T11:07:18	Simplify git_path_is_empty_dir implementation This simplifies git_path_is_empty_dir on both Windows (getting rid of git_buf allocation inside the function) and other platforms (by just using git_path_direach), and adds tests for the function, and uses the function to simplify some existing tests.
219d3457	2013-10-01T16:12:15	Initial iconv hookup for precomposed unicode This hooks up git_path_direach and git_path_dirload so that they will take a flag indicating if directory entry names should be tested and converted from decomposed unicode to precomposed form. This code will only come into play on the Apple platform and even then, only when certain types of filesystems are used. This involved adding a flag to these functions which involved changing a lot of places in the code. This was an opportunity to do a bit of code cleanup here and there, for example, getting rid of the git_futils_cleanupdir_r function in favor of a simple flag to git_futils_rmdir_r to not remove the top level entry. That ended up adding depth tracking during rmdir_r which led to a safety check for infinite directory recursion. Yay. This hasn't actually been tested on the Mac filesystems where the issue occurs. I still need to get test environment for that.
2fe54afa	2013-09-30T16:58:33	Put hooks in place for precompose in dirload fn This doesn't actual do string precompose but it puts the hooks in place into the iterators and the git_path_dirload function so that the actual precompose work is ready to go.
6b7991e2	2013-09-30T16:13:53	Add check if we need to precompose unicode on Mac This adds initialization of core.precomposeunicode to repo init on Mac. This is necessary because when a Mac accesses a repo on a VFAT or SAMBA file system, it will return directory entries in decomposed unicode even if the filesystem entry is precomposed. This also removes caching of a number of repo properties from the repo init pipeline because these are properties of the specific filesystem on which the repo is created, not of the system as a whole.
146b4d1c	2013-10-03T08:18:41	Merge pull request #1888 from jamill/network_cancellation network cancellation improvements
7baa7631	2013-10-02T15:39:18	Style tweaks and changes for code review feedback
ab136876	2013-10-03T04:36:29	Merge pull request #1887 from libgit2/ntk/topic/git_message_raw commit: Introduce git_commit_message_raw()
598f069b	2013-10-02T12:42:41	commit: Introduce git_commit_message_raw()
41a6de28	2013-10-02T14:45:57	HTTP: handle "relative" redirects
5b188225	2013-10-02T13:45:32	Support cancellation in push operation This commit adds cancellation for the push operation. This work consists of: 1) Support cancellation during push operation - During object counting phase - During network transfer phase - Propagate GIT_EUSER error code out to caller 2) Improve cancellation support during fetch - Handle cancellation request during network transfer phase - Clear error string when cancelled during indexing 3) Fix error handling in git_smart__download_pack Cancellation during push is still only handled in the pack building and network transfer stages of push (and not during packbuilding).
0e0cf787	2013-10-02T14:04:44	clone: put the callbacks struct directly in the clone options There's no need for this to be a pointer to somewhere else.
fdc7e5e3	2013-09-20T23:14:12	clone: bring back NULL as defaults This wasremoved as part of the large culling a few commits ago.
c833893c	2013-09-20T22:57:01	clone: re-allow using a custom remote name This is a small thing that by itself doesn't quite justify making the user use clone_into.
eec1c1fe	2013-09-20T22:49:20	clone: const-ify checkout options The removal of many options which lead to the direct usage of the user's checkout options means we should make sure they remain const.
b9bf5d70	2013-09-20T22:46:32	clone: re-add a way to ignore certificate errors This used to be done via transport flags, which was removed in a previous commit.
6ac15eff	2013-09-20T22:34:05	clone: remove more options from basic clone The basic clone function is there to make it easy to create a "normal" clone. Remove a bunch of options that are about changing the remote's configuration.
e3a92f0d	2013-09-17T05:31:34	clone: implement git_clone on top of git_clone_into Unify the code bases.
c8dbec48	2013-09-16T18:42:53	clone: remove the autotag option Downloading all tags is part of what makes it a clone instead of simply a fetch.
fe3a40a4	2013-09-16T16:54:37	remote: add a convenience 'fetch' function.
d19870d9	2013-09-16T05:10:55	clone: implement git_clone_into This allows you to set up the repository and remote as you which to have them before performing the clone operation.
e3c131c5	2013-09-16T05:02:25	remote: move the credentials callback to the struct Move this one as well, letting us have a single way of setting the callbacks for the remote, and removing fields from the clone options.
d31402a3	2013-09-16T04:20:05	remote: put the _download() callback with the others The text progress and update_tips callbacks are already part of the struct, which was meant to unify the callback setup, but the download one was left out.
83786956	2013-01-04T14:39:05	Add git_transport_register, git_transport_unregister
816d28e7	2013-10-01T12:56:47	Mark git__timer as inline on OSX
c655aa52	2013-10-01T05:54:54	Merge pull request #1882 from linquize/config-subsection-fix Config subsection name should allow to have ']' and '\\' should allow to escape any characters
566dd8ce	2013-09-30T23:38:22	Config subsection name should allow to have ']' and '\\' should allow to escape any characters
fba14763	2013-09-30T15:03:35	Merge pull request #1879 from libgit2/redir-refactor Redir refactor
a6884b6f	2013-09-30T14:58:45	Merge pull request #1412 from jamill/push_progress Initial Implementation of progress reports during push
9acde162	2013-09-30T14:57:48	Merge pull request #1881 from libgit2/ignore-submodules-in-stash Never consider submodules for stashing
dc56fea7	2013-09-30T12:18:19	Merge pull request #1878 from libgit2/ntk/fix/warnings Fix x86/x64 size_t related warnings
b176eded	2013-09-19T14:52:57	Initial Implementation of progress reports during push This adds the basics of progress reporting during push. While progress for all aspects of a push operation are not reported with this change, it lays the foundation to add these later. Push progress reporting can be improved in the future - and consumers of the API should just get more accurate information at that point. The main areas where this is lacking are: 1) packbuilding progress: does not report progress during deltafication, as this involves coordinating progress from multiple threads. 2) network progress: reports progress as objects and bytes are going to be written to the subtransport (instead of as client gets confirmation that they have been received by the server) and leaves out some of the bytes that are transfered as part of the push protocol. Basically, this reports the pack bytes that are written to the subtransport. It does not report the bytes sent on the wire that are received by the server. This should be a good estimate of progress (and an improvement over no progress).
d27a441d	2013-09-30T11:30:28	commit: Trim message leading newlines Fix libgit2/libgit2sharp#522
4fe0b0b3	2013-09-27T17:07:06	Never consider submodules for stashing
b59344bf	2013-09-26T16:48:08	Tighten up url-connection utility
256961e4	2013-09-26T16:36:05	WHOOPS
1b02baf4	2013-09-26T16:25:05	Adjust to new utility signature
ea59f659	2013-09-26T16:20:30	Deploy gitno_connection_data into transport (winhttp) ...and have that call manage replaced memory in the output structure.
83fbd368	2013-09-26T15:58:41	Deploy gitno_connection_data into transport
8a1e925d	2013-09-26T12:00:35	Fix warnings
f30d91ce	2013-09-26T11:03:27	Refactor URL handling to use library call
8988688c	2013-09-25T20:41:56	Migrate redirect URL handling to common utility
ac316e74	2013-09-25T14:25:38	Why are we disabling redirects?
4a88eb20	2013-09-25T12:13:09	Win32: handle http->https redirects
4dbdbf64	2013-09-24T15:21:44	Merge pull request #1871 from libgit2/cross-protocol-redirects-alt Alternative fix for cross protocol redirects
46fbc88e	2013-09-24T14:50:06	Prevent HTTPS to HTTP redirect
eb0ff130	2013-09-24T14:07:08	Disconnect path string to preserve after redirect The subtransport path was relying on pointing to data owned by the remote which meant that after a redirect, the updated path was getting lost for future requests. This updates the http transport to strdup the path and maintain its own lifetime. This also pulls responsibility for parsing the URL back into the http transport and isolates the functions that parse and free that connection data so that they can be reused between the initial parsing and the redirect parsing.
5c3b8ef4	2013-09-24T14:52:58	Ignore files that disappear while iterating On occasion, files can disappear while we're iterating the filesystem, between calls to readdir and stat. Let's pretend those didn't exist in the first place.
c9144405	2013-09-23T11:37:35	Properly parse urls that include protocol://
210d5325	2013-09-23T12:09:23	Allow redirects to use same host
4a1b4015	2013-09-24T10:32:40	Merge pull request #1865 from arrbee/various-cleanups Various warning cleanup and minor fixes
5dc8513b	2013-09-24T10:30:43	Merge pull request #1864 from libgit2/minimize-regex-usage Minimize regex usage
634f10f6	2013-09-24T10:11:20	Fix incorrect return code in crlf filter The git_buf_text_gather_stats call returns a boolean indicating if the file looks like binary data. That shouldn't be an error; it should be used to skip CRLF processing though.
e3f3868a	2013-09-24T11:04:14	'del' instead of 'delete' for the poor C++ users
00e85927	2013-09-23T21:52:42	Clean up unnecessary git_buf_printf calls This replaces some git_buf_printf calls with simple calls to git_buf_put instead. Also, it fixes a missing va_end inside the git_buf_vprintf implementation.
71379313	2013-09-23T13:40:23	Fix warnings on Windows 64-bit build
1ca3e49f	2013-09-23T13:34:01	Clean up newly introduced warnings The attempt to "clean up warnings" seems to have introduced some new warnings on compliant compilers. This fixes those in a way that I suspect will also be okay for the non-compliant compilers. Also this fixes what appears to be an extra semicolon in the repo initialization template dir handling (and as part of that fix, handles the case where an error occurs correctly).
106c12f1	2013-09-23T13:31:15	Remove regex usage from places that don't need it In revwalk, we are doing a very simple check to see if a string contains wildcard characters, so a full regular expression match is not needed. In remote listing, now that we have git_config_foreach_match with full regular expression matching, we can take advantage of that and eliminate the regex here, replacing it with much simpler string manipulation.
10edb7a9	2013-09-22T13:46:39	Merge pull request #1863 from linquize/typo Fix typo in documentation
07fb67f9	2013-09-22T05:55:39	merge: reverse array and length parameter order Make it pair up with the one for commits. This fixes #1691.
1b57699a	2013-09-22T09:11:43	Fix typo in documentation
92d19d16	2013-09-21T09:34:03	Merge pull request #1840 from linquize/warning Fix warning
2c9ed02e	2013-09-20T09:22:19	Merge pull request #1859 from linquize/init.templatedir Make init.templatedir work
417472e3	2013-09-20T09:02:58	Check error value from git_futils_find_template_dir
66566516	2013-09-08T17:15:42	Fix warning
0cd1c3bb	2013-09-18T23:06:10	Make init.templatedir work
5a284edc	2013-09-18T03:54:17	msvc: No void* arithmetic on Windows
4cf9323b	2013-09-17T18:49:47	Merge pull request #1860 from libgit2/cmn/indexer-hash indexer: check the packfile trailer
e0aa6fc1	2013-09-18T02:20:17	indexer: don't reiterate the class in the message
98eb2c59	2013-09-17T17:44:05	indexer: check the packfile trailer for correctness The packfile trailer gets sent over and we should check whether it's correct as part of our sanity checks of the packfile.
3d4f1698	2013-09-17T10:21:22	Merge pull request #1858 from linquize/win32-template-dir Configurable template dir for Win32
eefc32d5	2013-09-16T12:54:40	Bug fixes and cleanups This contains a few bug fixes and some header and API cleanups. The main API change is that filters should now use GIT_PASSTHROUGH to indicate that they wish to skip processing a file instead of GIT_ENOTFOUND. The bug fixes include a possible out-of-range buffer access in the ident filter, a filter ordering problem I introduced into the custom filter tests on Windows, and a filter buf NUL termination issue that was coming up on Linux.
eab3746b	2013-09-15T22:23:39	More filtering tests including order This adds more tests of filters, including the ident filter when mixed with custom filters. I was able to combine with the reverse filter and demonstrate that the order of filter application with the default priority constants matches the order of core Git. Also, this fixes two issues in the ident filter: preventing ident expansion on binary files and avoiding a NULL dereference when dollar sign characters are found without Id.
37f9e409	2013-09-13T21:43:00	Some tests with ident and crlf filters Fixed the filter order to match core Git, too. This test demonstrates an interesting behavior of core Git (which is totally reasonable and which libgit2 matches, although mostly by coincidence). If you use the ident filter and commit a file with a garbage ident in it, like '$Id: this is just garbage$' and then immediately do a 'git checkout-index' with the new file, Git will not consider the file out of date and will not overwrite the file with an updated $Id$. Libgit2 has the same behavior. If you remove the file and then do a checkout-index, it will be replaced with a filtered version that has injected the OID correctly.
13f36ffb	2013-09-13T16:30:21	Add clar helpers for testing file equality These are a couple of new clar helpers for testing that a file has expected contents that I extracted from the checkout code. Actually wrote this as part of an abandoned earlier attempt at a new filters API, but it will be useful now for some of the tests I'm going to write.
e399c7ee	2013-09-13T09:50:05	Fix win32 warnings I wish MSVC understood that "const char **" is not a const ptr, but it a non-const pointer to an array of const ptrs. Does that seem like too much to ask.
b47349b8	2013-09-12T14:48:24	Port tests from PR 1683 This ports over some of the tests from https://github.com/libgit2/libgit2/pull/1683 by @yorah and @ethomson
0e32635f	2013-09-12T14:47:15	Move binary check to CRLF filter itself Checkout should not reject binary files from filters, as a filter may actually wish to operate on binary files. The CRLF filter should reject binary files itself if it wishes to. Moreover, the CRLF filter requires this logic so that users can emulate the checkout data in their odb -> workdir filtering. Conflicts: src/checkout.c src/crlf.c
a9f51e43	2013-09-11T22:00:36	Merge git_buf and git_buffer This makes the git_buf struct that was used internally into an externally available structure and eliminates the git_buffer. As part of that, some of the special cases that arose with the externally used git_buffer were blended into the git_buf, such as being careful about git_buf objects that may have a NULL ptr and allowing for bufs with a valid ptr and size but zero asize as a way of referring to externally owned data.

5de4ec81

2013-10-21T15:36:38

Implement patience and minimal diff flags It seems that to implement these options, we just have to pass the appropriate flags through to the libxdiff code taken from core git. So let's do it (and add a test).

623460ab

2013-10-21T14:16:53

Fix warnings for win64

3b5f7954

2013-10-21T13:42:42

Create git_diff_line and extend git_diff_hunk Instead of having functions with so very many parameters to pass hunk and line data, this takes the existing git_diff_hunk struct and extends it with more hunk data, plus adds a git_diff_line. Those structs are used to pass back hunk and line data instead of the old APIs that took tons of parameters. Some work that was previously only being done for git_diff_patch creation (scanning the diff content for exact line counts) is now done for all callbacks, but the performance difference should not be noticable.

74a627f0

2013-10-21T09:07:19

Tweak to git_diff_delta structure for nfiles While the base git_diff_delta structure always contains two files, when we introduce conflict data, it will be helpful to have an indicator when an additional file is involved.

10672e3e

2013-10-15T15:10:07

Diff API cleanup This lays groundwork for separating formatting options from diff creation options. This groups the formatting flags separately from the diff list creation flags and reorders the options. This also tweaks some APIs to further separate code that uses patches from code that just looks at git_diffs.

3ff1d123

2013-10-11T14:51:54

Rename diff objects and split patch.h This makes no functional change to diff but renames a couple of the objects and splits the new git_patch (formerly git_diff_patch) into a new header file.

74353137

2013-10-09T11:57:03

After iconv init reset ref normalize error The iconv init was accidentally clearing the default error state during reference normalization. This resets so that normalization errors will be detected correctly.

95c148b2

2013-10-08T17:03:12

Merge pull request #1886 from libgit2/precompose-utf8 Add support for core.precomposeunicode on Mac

867f7c9b

2013-10-08T16:59:59

Rename new fn to git_repository_reinit_filesystem

92dac975

2013-10-08T16:35:57

Make reference lookups apply precomposeunicode Before these changes, looking up a reference would return the same precomposed or decomposed form of the reference name that was used to look it up, so on MacOS which ignores the difference between the two, a single reference could be looked up either way and git_reference_name would return the form of the name that was used to look it up! This change makes lookup always return the precomposed name if core.precomposeunicode is set regardless of which version was used to look it up. The reference iterator was already returning the precomposed form from earlier work. This also updates the CMakeLists.txt rules for enabling iconv usage because the clar tests for this code were actually not being activated properly with the old version. Finally, this moves git_repository_reset_filesystem from include/ git2/repository.h to include/git2/sys/repository.h since it is not really a function that normal library users should have to think about very often.

3dc3c723

2013-10-08T15:52:37

Combine WinHTTP API calls

a58eecd4

2013-10-08T13:40:52

WinHTTP: set Accept header for POSTs

14997dc5

2013-10-08T12:45:43

More filemode cleanups for FAT on MacOS This cleans up some additional issues. The main change is that on a filesystem that doesn't support mode bits, libgit2 will now create new blobs with GIT_FILEMODE_BLOB always instead of being at the mercy to the filesystem driver to report executable or not. This means that if "core.filemode" lies and claims that filemode is not supported, then we will ignore the executable bit from the filesystem. Previously we would have allowed it. This adds an option to the new git_repository_reset_filesystem to recurse through submodules if desired. There may be other types of APIs that would like a "recurse submodules" option, but this one is particularly useful. This also has a number of cleanups, etc., for related things including trying to give better error messages when problems come up from the filesystem. For example, the FAT filesystem driver on MacOS appears to return errno EINVAL if you attempt to write a filename with invalid UTF-8 in it. We try to capture that with a better error message now.

13f670a5

2013-04-15T09:07:57

tree: allow retrieval of raw attributes When a tool needs to recreate the tree object (for example an interface to another VCS), it needs to use the raw attributes, forgoing any normalization.

22661448

2013-10-04T19:35:32

Don't use git_atomic as an integer

cdc95a0d

2013-10-04T18:38:37

Use InterlockedCompareExchange for the lock

e411b74e

2013-10-04T19:33:48

Posix synchronized init, prototype win32 version

5173ea92

2013-10-04T16:32:16

Add git_repository_reset_filesystem and fix tests When a repository is transferred from one file system to another, many of the config settings that represent the properties of the file system may be wrong. This adds a new public API that will refresh the config settings of the repository to account for the change of file system. This doesn't do a full "reinitialize" and operates on a existing git_repository object refreshing the config when done. This commit then makes use of the new API in clar as each test repository is set up. This commit also has a number of other clar test fixes where we were making assumptions about the type of filesystem, either based on outdated config data or based on the OS instead of the FS.

da7b78fa

2013-10-04T14:03:12

index: Make _read() cope with index file creation

840fb4fc

2013-10-03T14:42:37

Update repo init with fewer platform assumptions The repo init code was assuming Windows == no filemode, and Mac or Windows == no case sensitivity. Those assumptions are not consistently true depending on the mounted file system. This is a first step to removing those assumptions. It focuses on the repo init code and the tests of that code. There are still many other tests that are broken when those assumptions don't hold true, but this clears up one area of the code. Also, this moves the core.precomposeunicode logic to be closer to the current logic in core Git where it will be set to true on any filesystem where composed unicode is decomposed when read back.

af302aca

2013-10-02T14:13:11

Clean up annoying warnings The indexer code was generating warnings on Windows 64-bit. I looked closely at the logic and was able to simplify it a bit. Also this fixes some other Windows and Linux warnings.

618b7689

2013-10-02T12:06:26

Wrap iconv stuff and write tests This adds a simple wrapper around the iconv APIs and uses it instead of the old code that was inlining the iconv stuff. This makes it possible for me to test the iconv logic in isolation. A "no iconv" version of the API was defined with macros so that I could have fewer ifdefs in the code itself.

d0849f83

2013-10-02T11:07:18

Simplify git_path_is_empty_dir implementation This simplifies git_path_is_empty_dir on both Windows (getting rid of git_buf allocation inside the function) and other platforms (by just using git_path_direach), and adds tests for the function, and uses the function to simplify some existing tests.

219d3457

2013-10-01T16:12:15

Initial iconv hookup for precomposed unicode This hooks up git_path_direach and git_path_dirload so that they will take a flag indicating if directory entry names should be tested and converted from decomposed unicode to precomposed form. This code will only come into play on the Apple platform and even then, only when certain types of filesystems are used. This involved adding a flag to these functions which involved changing a lot of places in the code. This was an opportunity to do a bit of code cleanup here and there, for example, getting rid of the git_futils_cleanupdir_r function in favor of a simple flag to git_futils_rmdir_r to not remove the top level entry. That ended up adding depth tracking during rmdir_r which led to a safety check for infinite directory recursion. Yay. This hasn't actually been tested on the Mac filesystems where the issue occurs. I still need to get test environment for that.

2fe54afa

2013-09-30T16:58:33

Put hooks in place for precompose in dirload fn This doesn't actual do string precompose but it puts the hooks in place into the iterators and the git_path_dirload function so that the actual precompose work is ready to go.

6b7991e2

2013-09-30T16:13:53

Add check if we need to precompose unicode on Mac This adds initialization of core.precomposeunicode to repo init on Mac. This is necessary because when a Mac accesses a repo on a VFAT or SAMBA file system, it will return directory entries in decomposed unicode even if the filesystem entry is precomposed. This also removes caching of a number of repo properties from the repo init pipeline because these are properties of the specific filesystem on which the repo is created, not of the system as a whole.

146b4d1c

2013-10-03T08:18:41

Merge pull request #1888 from jamill/network_cancellation network cancellation improvements

7baa7631

2013-10-02T15:39:18

Style tweaks and changes for code review feedback

ab136876

2013-10-03T04:36:29

Merge pull request #1887 from libgit2/ntk/topic/git_message_raw commit: Introduce git_commit_message_raw()

598f069b

2013-10-02T12:42:41

commit: Introduce git_commit_message_raw()

41a6de28

2013-10-02T14:45:57

HTTP: handle "relative" redirects

5b188225

2013-10-02T13:45:32

Support cancellation in push operation This commit adds cancellation for the push operation. This work consists of: 1) Support cancellation during push operation - During object counting phase - During network transfer phase - Propagate GIT_EUSER error code out to caller 2) Improve cancellation support during fetch - Handle cancellation request during network transfer phase - Clear error string when cancelled during indexing 3) Fix error handling in git_smart__download_pack Cancellation during push is still only handled in the pack building and network transfer stages of push (and not during packbuilding).

0e0cf787

2013-10-02T14:04:44

clone: put the callbacks struct directly in the clone options There's no need for this to be a pointer to somewhere else.

fdc7e5e3

2013-09-20T23:14:12

clone: bring back NULL as defaults This wasremoved as part of the large culling a few commits ago.

c833893c

2013-09-20T22:57:01

clone: re-allow using a custom remote name This is a small thing that by itself doesn't quite justify making the user use clone_into.

eec1c1fe

2013-09-20T22:49:20

clone: const-ify checkout options The removal of many options which lead to the direct usage of the user's checkout options means we should make sure they remain const.

b9bf5d70

2013-09-20T22:46:32

clone: re-add a way to ignore certificate errors This used to be done via transport flags, which was removed in a previous commit.

6ac15eff

2013-09-20T22:34:05

clone: remove more options from basic clone The basic clone function is there to make it easy to create a "normal" clone. Remove a bunch of options that are about changing the remote's configuration.

e3a92f0d

2013-09-17T05:31:34

clone: implement git_clone on top of git_clone_into Unify the code bases.

c8dbec48

2013-09-16T18:42:53

clone: remove the autotag option Downloading all tags is part of what makes it a clone instead of simply a fetch.

fe3a40a4

2013-09-16T16:54:37

remote: add a convenience 'fetch' function.

d19870d9

2013-09-16T05:10:55

clone: implement git_clone_into This allows you to set up the repository and remote as you which to have them before performing the clone operation.

e3c131c5

2013-09-16T05:02:25

remote: move the credentials callback to the struct Move this one as well, letting us have a single way of setting the callbacks for the remote, and removing fields from the clone options.

d31402a3

2013-09-16T04:20:05

remote: put the _download() callback with the others The text progress and update_tips callbacks are already part of the struct, which was meant to unify the callback setup, but the download one was left out.

83786956

2013-01-04T14:39:05

Add git_transport_register, git_transport_unregister

816d28e7

2013-10-01T12:56:47

Mark git__timer as inline on OSX

c655aa52

2013-10-01T05:54:54

Merge pull request #1882 from linquize/config-subsection-fix Config subsection name should allow to have ']' and '\\' should allow to escape any characters

566dd8ce

2013-09-30T23:38:22

Config subsection name should allow to have ']' and '\\' should allow to escape any characters

fba14763

2013-09-30T15:03:35

Merge pull request #1879 from libgit2/redir-refactor Redir refactor

a6884b6f

2013-09-30T14:58:45

Merge pull request #1412 from jamill/push_progress Initial Implementation of progress reports during push

9acde162

2013-09-30T14:57:48

Merge pull request #1881 from libgit2/ignore-submodules-in-stash Never consider submodules for stashing

dc56fea7

2013-09-30T12:18:19

Merge pull request #1878 from libgit2/ntk/fix/warnings Fix x86/x64 size_t related warnings

b176eded

2013-09-19T14:52:57

Initial Implementation of progress reports during push This adds the basics of progress reporting during push. While progress for all aspects of a push operation are not reported with this change, it lays the foundation to add these later. Push progress reporting can be improved in the future - and consumers of the API should just get more accurate information at that point. The main areas where this is lacking are: 1) packbuilding progress: does not report progress during deltafication, as this involves coordinating progress from multiple threads. 2) network progress: reports progress as objects and bytes are going to be written to the subtransport (instead of as client gets confirmation that they have been received by the server) and leaves out some of the bytes that are transfered as part of the push protocol. Basically, this reports the pack bytes that are written to the subtransport. It does not report the bytes sent on the wire that are received by the server. This should be a good estimate of progress (and an improvement over no progress).

d27a441d

2013-09-30T11:30:28

commit: Trim message leading newlines Fix libgit2/libgit2sharp#522

4fe0b0b3

2013-09-27T17:07:06

Never consider submodules for stashing

b59344bf

2013-09-26T16:48:08

Tighten up url-connection utility

256961e4

2013-09-26T16:36:05

WHOOPS

1b02baf4

2013-09-26T16:25:05

Adjust to new utility signature

ea59f659

2013-09-26T16:20:30

Deploy gitno_connection_data into transport (winhttp) ...and have that call manage replaced memory in the output structure.

83fbd368

2013-09-26T15:58:41

Deploy gitno_connection_data into transport

8a1e925d

2013-09-26T12:00:35

Fix warnings

f30d91ce

2013-09-26T11:03:27

Refactor URL handling to use library call

8988688c

2013-09-25T20:41:56

Migrate redirect URL handling to common utility

ac316e74

2013-09-25T14:25:38

Why are we disabling redirects?

4a88eb20

2013-09-25T12:13:09

Win32: handle http->https redirects

4dbdbf64

2013-09-24T15:21:44

Merge pull request #1871 from libgit2/cross-protocol-redirects-alt Alternative fix for cross protocol redirects

46fbc88e

2013-09-24T14:50:06

Prevent HTTPS to HTTP redirect

eb0ff130

2013-09-24T14:07:08

Disconnect path string to preserve after redirect The subtransport path was relying on pointing to data owned by the remote which meant that after a redirect, the updated path was getting lost for future requests. This updates the http transport to strdup the path and maintain its own lifetime. This also pulls responsibility for parsing the URL back into the http transport and isolates the functions that parse and free that connection data so that they can be reused between the initial parsing and the redirect parsing.

5c3b8ef4

2013-09-24T14:52:58

Ignore files that disappear while iterating On occasion, files can disappear while we're iterating the filesystem, between calls to readdir and stat. Let's pretend those didn't exist in the first place.

c9144405

2013-09-23T11:37:35

Properly parse urls that include protocol://

210d5325

2013-09-23T12:09:23

Allow redirects to use same host

4a1b4015

2013-09-24T10:32:40

Merge pull request #1865 from arrbee/various-cleanups Various warning cleanup and minor fixes

5dc8513b

2013-09-24T10:30:43

Merge pull request #1864 from libgit2/minimize-regex-usage Minimize regex usage

634f10f6

2013-09-24T10:11:20

Fix incorrect return code in crlf filter The git_buf_text_gather_stats call returns a boolean indicating if the file looks like binary data. That shouldn't be an error; it should be used to skip CRLF processing though.

e3f3868a

2013-09-24T11:04:14

'del' instead of 'delete' for the poor C++ users

00e85927

2013-09-23T21:52:42

Clean up unnecessary git_buf_printf calls This replaces some git_buf_printf calls with simple calls to git_buf_put instead. Also, it fixes a missing va_end inside the git_buf_vprintf implementation.

71379313

2013-09-23T13:40:23

Fix warnings on Windows 64-bit build

1ca3e49f

2013-09-23T13:34:01

Clean up newly introduced warnings The attempt to "clean up warnings" seems to have introduced some new warnings on compliant compilers. This fixes those in a way that I suspect will also be okay for the non-compliant compilers. Also this fixes what appears to be an extra semicolon in the repo initialization template dir handling (and as part of that fix, handles the case where an error occurs correctly).

106c12f1

2013-09-23T13:31:15

Remove regex usage from places that don't need it In revwalk, we are doing a very simple check to see if a string contains wildcard characters, so a full regular expression match is not needed. In remote listing, now that we have git_config_foreach_match with full regular expression matching, we can take advantage of that and eliminate the regex here, replacing it with much simpler string manipulation.

10edb7a9

2013-09-22T13:46:39

Merge pull request #1863 from linquize/typo Fix typo in documentation

07fb67f9

2013-09-22T05:55:39

merge: reverse array and length parameter order Make it pair up with the one for commits. This fixes #1691.

1b57699a

2013-09-22T09:11:43

Fix typo in documentation

92d19d16

2013-09-21T09:34:03

Merge pull request #1840 from linquize/warning Fix warning

2c9ed02e

2013-09-20T09:22:19

Merge pull request #1859 from linquize/init.templatedir Make init.templatedir work

417472e3

2013-09-20T09:02:58

Check error value from git_futils_find_template_dir

66566516

2013-09-08T17:15:42

Fix warning

0cd1c3bb

2013-09-18T23:06:10

Make init.templatedir work

5a284edc

2013-09-18T03:54:17

msvc: No void* arithmetic on Windows

4cf9323b

2013-09-17T18:49:47

Merge pull request #1860 from libgit2/cmn/indexer-hash indexer: check the packfile trailer

e0aa6fc1

2013-09-18T02:20:17

indexer: don't reiterate the class in the message

98eb2c59

2013-09-17T17:44:05

indexer: check the packfile trailer for correctness The packfile trailer gets sent over and we should check whether it's correct as part of our sanity checks of the packfile.

3d4f1698

2013-09-17T10:21:22

Merge pull request #1858 from linquize/win32-template-dir Configurable template dir for Win32

eefc32d5

2013-09-16T12:54:40

Bug fixes and cleanups This contains a few bug fixes and some header and API cleanups. The main API change is that filters should now use GIT_PASSTHROUGH to indicate that they wish to skip processing a file instead of GIT_ENOTFOUND. The bug fixes include a possible out-of-range buffer access in the ident filter, a filter ordering problem I introduced into the custom filter tests on Windows, and a filter buf NUL termination issue that was coming up on Linux.

eab3746b

2013-09-15T22:23:39

More filtering tests including order This adds more tests of filters, including the ident filter when mixed with custom filters. I was able to combine with the reverse filter and demonstrate that the order of filter application with the default priority constants matches the order of core Git. Also, this fixes two issues in the ident filter: preventing ident expansion on binary files and avoiding a NULL dereference when dollar sign characters are found without Id.

37f9e409

2013-09-13T21:43:00

Some tests with ident and crlf filters Fixed the filter order to match core Git, too. This test demonstrates an interesting behavior of core Git (which is totally reasonable and which libgit2 matches, although mostly by coincidence). If you use the ident filter and commit a file with a garbage ident in it, like '$Id: this is just garbage$' and then immediately do a 'git checkout-index' with the new file, Git will not consider the file out of date and will not overwrite the file with an updated $Id$. Libgit2 has the same behavior. If you remove the file and then do a checkout-index, it will be replaced with a filtered version that has injected the OID correctly.

13f36ffb

2013-09-13T16:30:21

Add clar helpers for testing file equality These are a couple of new clar helpers for testing that a file has expected contents that I extracted from the checkout code. Actually wrote this as part of an abandoned earlier attempt at a new filters API, but it will be useful now for some of the tests I'm going to write.

e399c7ee

2013-09-13T09:50:05

Fix win32 warnings I wish MSVC understood that "const char **" is not a const ptr, but it a non-const pointer to an array of const ptrs. Does that seem like too much to ask.

b47349b8

2013-09-12T14:48:24

Port tests from PR 1683 This ports over some of the tests from https://github.com/libgit2/libgit2/pull/1683 by @yorah and @ethomson

0e32635f

2013-09-12T14:47:15

Move binary check to CRLF filter itself Checkout should not reject binary files from filters, as a filter may actually wish to operate on binary files. The CRLF filter should reject binary files itself if it wishes to. Moreover, the CRLF filter requires this logic so that users can emulate the checkout data in their odb -> workdir filtering. Conflicts: src/checkout.c src/crlf.c

a9f51e43

2013-09-11T22:00:36

Merge git_buf and git_buffer This makes the git_buf struct that was used internally into an externally available structure and eliminates the git_buffer. As part of that, some of the special cases that arose with the externally used git_buffer were blended into the git_buf, such as being careful about git_buf objects that may have a NULL ptr and allowing for bufs with a valid ptr and size but zero asize as a way of referring to externally owned data.

thodg/libgit2/src

src

Log