kmx git

Commit	Date	Message
408a7b77	2017-02-24T17:37:00	appveyor: don't rewrite system mingw Download mingw-w64 into our build directory and execute it there, don't try to overwrite the system's mingw.
18c18e3d	2016-10-31T15:55:46	coverity: check for Coverity token only if necessary When running a Coverity build, we have to provide an authentication token in order to proof that we are actually allowed to run analysis in the name of a certain project. As this token should be secret, it is only set on the main repository, so when we were requested to run the Coverity script on another repository we do error out. But in fact we do also error out if the Coverity analysis should _not_ be run if there is no authentication token provided. Fix the issue by only checking for the authentication token after determining if analysis is indeed requested.
561276ee	2016-10-28T14:48:30	coverity: only analyze the master branch of the main repository We used to only execute Coverity analysis on the 'development' branch before commit 998f001 (Refine build limitation, 2014-01-15), which refined Coverity build limitations. While we do not really use the 'development' branch anymore, it does still make sense to only analyze a single branch, as otherwise Coverity might get confused. Re-establish the restriction such that we only analyze libgit2's 'master' branch. Also fix the message announcing why we do not actually analyze a certain build.
6c4d2d3e	2016-10-28T14:45:55	coverity: fix download URL
ec3f5a9c	2016-08-16T11:02:47	script: cibuild: build examples
db357667	2016-10-05T20:17:06	travis: take the newer ssh-keygen format into account The Mac machines have updated their SSH version and so the ssh-keygen format has changed. Ask it for MD5, which is the one that is output as hex.
94d565b9	2016-10-05T18:52:43	cibuild: set -x This lets us see the details of what we're doing instead of just seeing the output of unknown commands in the build output.
a37624ec	2016-07-24T16:05:17	Merge pull request #3815 from pks-t/pks/coverity-model Coverity user model
0239eff3	2016-07-24T14:51:28	ci: install homebrew's curl on mac
08556e6d	2016-07-22T17:45:03	ci: install homebrew's zlib on mac
4d8fe1cd	2016-06-07T09:20:35	coverity: model functions printing into git_buf The `git_buf` structure seems to be too complicated to correctly grasp for Coverity. As such, add simpler models trying to guide Coverity and remove false positives related to these functions.
956f1e23	2016-06-07T09:17:52	coverity: add user model The static analysis engine coverity allows for user models overriding how it treats functions when analyzing code. Like this, one can greatly reduce the rate of false positives and thus make it easier to spot actual errors. Add a user model that overrides function models for `git_buf_len` and `git_vector_insert`, which together amount for a majority of false positives.
db01724f	2016-03-14T13:42:10	CI: start the proxy before the build so it's ready It takes a bit for the propxy to get ready to accept connections, so start it before the build so we can be reasonably sure that it's going to be ready in time.
2f3f1ee0	2015-09-21T21:40:37	proxy: test proxy support on Travis
4848dd32	2016-03-14T17:45:15	Merge pull request #3647 from pks-t/pks/coverity-fixes-round6 Coverity fixes round 6
b1093e62	2016-03-09T19:01:33	Remove CI support for mingw32 The tests have never run successfully and we do have successful builds of mingw-w64, so remove these CI builds which do not add value.
2615d0d6	2016-03-02T01:50:34	coverity: report errors when uploading tarball Curl by default does not report errors by setting the error code. As the upload can fail through several conditions (e.g. the rate limit, leading to unauthorized access) we should indicate this information in Travis CI. To improve upon the behavior, use `--write-out=%{http_code}` to write out the HTTP code in addition to the received body and return an error if the code does not equal 201.
ba9bb664	2016-03-03T19:21:07	tests: create a ctest target for cred_callback
25205737	2016-03-03T10:08:00	test: make sure we retry the auth callback on all platforms We were missing this test on Windows, which meant we didn't notice that we never fixed the single authentication attempt it tries, nor its wrong return code. Enable this for the unix platforms as well over HTTP. We previously were doing it locally but disabled it on OS X due to issues with its sshd not accepting password authentication.
859ed5dd	2016-02-23T09:54:26	common: introduce GITERR_CHECK_ALLOC_BUF We commonly have to check if a git_buf has been allocated correctly or if we ran out of memory. Introduce a new macro similar to `GITERR_CHECK_ALLOC` which checks if we ran OOM and if so returns an error. Provide a `#nodef` for Coverity to mark the error case as an abort path.
f2a554b4	2016-02-22T14:43:28	coverity: hint git_vector_foreach does not deref NULL contents Coverity does not comprehend the connection between a vector's size and the contents pointer, that is that the vector's pointer is non-NULL when its size is positive. As the vector code should be reasonably well tested and users are expected to not manually modify a vector's contents it seems save to assume that the macros will never dereference a NULL pointer. Fix Coverity warnings by overriding the foreach macros with macros that explicitly aborting when (v)->contents is NULL.
40f6f225	2016-02-15T10:58:52	coverity: hint that string length is at least 2 When checking if a string is prefixed by a drive letter (e.g. "C:") we verify this by inspecting the first and second character of the string. Coverity thinks this is a defect as we do not check the string's length first, but in fact we only check the second character if the first character is part of the alphabet, that is it cannot be '\0'. Fix this by overriding the macro and explicitly checking the string's length.
5981ab1d	2016-02-15T09:41:08	coverity: add nodefs for abort macros Add nodefs for macros that abort the current flow due to errors. This includes macros that trigger on integer overflows and for the version check macro. This aids Coverity as we point out that these paths will cause a fatal error.
50174ab4	2016-02-10T11:06:23	coverity: use https URL for posting build When posting our instrumented build results to Coverity we have to include sensitive information, in particular our authorization token. Currently we use an unencrypted channel to post this information, leading to the token being transferred in plain. Fix this by using a secured connection instead.
8dddea42	2016-02-10T10:59:14	coverity: provide nodef for GITERR_CHECK_ALLOC Coverity currently lists a lot of errors with regard to GITERR_CHECK_ALLOC causing resource leaks. We know this macro is only invoked when we want to abort because we are out of memory. Coverity allows for overriding the default model where we know that certain functions guarantee a desired behavior. The user_nodefs.h is used to override the behavior of macros. Re-define GITERR_CHECK_ALLOC inside of it to specify its abort nature.
a0bdfe32	2015-07-06T18:42:39	travis: don't install CMake on OS X Homebrew will error out because it's already installed.
d41b8ed0	2015-07-06T18:32:31	travis: update the homebrew db We need to make sure we are asking for the current version of packages, or we might get 404s from the download service.
32f538ae	2015-06-27T15:02:53	Remove dependency installation file for travis builds. We're installing dependencies via the APT addon now.
51f87999	2015-06-26T18:05:17	Don't try to start ssh.
6042a050	2015-06-12T12:17:03	travis: fail if we fail the push tests These tests were not being taken into consideration for the failure of the test. They've been failing for a while now, but we hadn't noticed as Travis was reporting the builds successful.
7aa96593	2015-03-17T12:05:07	set PKG_CONFIG_LIBDIR in toolchain-mingw32.cmake
8f426d7d	2014-06-09T11:43:25	Win32: Enable WinHTTP for MinGW
3e329861	2015-03-10T16:08:34	Revert "Implement fail-fast for Travis as well" This reverts commit ba6c53b91b1d9c9dc49b7c0d8e8efbd9842c31dc.
4c88fd7c	2015-03-04T11:31:24	Add MinGW-w64 to matrix cache mingw-w64 downloads quiet curl and 7zip run appveyor steps in cmd for mingw
ba6c53b9	2015-03-03T21:07:12	Implement fail-fast for Travis as well
ac5fad27	2015-03-03T10:53:26	add mingw to appveyor matrix use MSYS makefiles generator add bash script for running mingw on appveyor add --login and fix run paths use msys style path to appveyor-mingw.sh add mingw path to /etc/fstab
6f446176	2014-11-21T10:59:20	Merge pull request #2710 from Therzok/shellcheckScripts Run shell scripts through shellcheck
a4fccbbf	2014-11-17T07:01:40	Run shell scripts through shellcheck
aa5a06c3	2014-11-20T00:52:52	travis: disable the cert callback on OSX The sshd on OSX has stopped responding to the setting which this test assumes is there, so let's disable it until we can figure out what's happening.
ebda0970	2014-09-16T02:07:39	script: use a parallel build on Travis
0fef3899	2014-09-16T01:25:53	Merge remote-tracking branch 'upstream/master' into cmn/host-cert-info
bf8756d6	2014-09-15T21:51:42	ssh: add test for host key Test that the certificate check callback gets the right fingerprint from the host we're connecting to.
26bf3a53	2014-08-10T17:13:00	travis: no need to clean out the test repository This was added to avoid the remote's default branch to be considered to the be notes one which the first network test leaves behind.
6a0d2b43	2014-08-27T15:09:07	Merge remote-tracking branch 'upstream/master' into cmn/ssh-retry
d4256ed5	2014-07-04T10:00:39	ssh: provide a factory function for setting ssh paths git allows you to set which paths to use for the git server programs when connecting over ssh; and we want to provide something similar. We do this by providing a factory function which can be set as the remote's transport callback which will set the given paths upon creation.
87339935	2014-06-26T22:38:54	travis: enable password authentication on OSX Our ssh tests assume that the server supports password authentication in a few places. This is convenient as we're not testing authentication methods, but what happens around them. Tell sshd on OSX to accept this form of authentication.
d7f962f4	2014-06-16T19:30:06	ssh: request credentials again on authentication failure Instead of completely giving up on the first failure, ask for credentials as long as we fail to authenticate.
72303307	2014-05-21T12:45:22	travis: build on osx too
039e354b	2014-04-30T11:57:54	ciscript: don't use an empty string as a number An empty string is not a valid number, and some shells complain. Check instead if $COVERITY is non-empty, which is a common convention and what we're doing anyway.
5dae3ffe	2014-02-05T19:27:27	Only run clone-failure test on private repo
998f0016	2014-01-15T12:32:12	Refine build limitation
53e6f480	2014-01-15T12:12:17	Only run coverity on development
9bf17d2c	2014-01-13T14:11:14	Add coverity-scan script
5875e8d2	2013-08-19T18:50:03	travis: exit on failure for anything related to building
68180808	2013-08-19T10:50:28	travis: really fail if the tests fail When implementing the ssh testing, the move to the script made it so the first test suite's exit code was ignored. Check whether the main tests fail and exit with an error in that case.
5be622fb	2013-08-11T01:37:44	Test SSH in travis Set up the ssh credentials so we are able to talk to localhost and issue git commands. Move to use a script, as the command list is getting somewhat long. While here, delay installing valgrind until we need it, as it and its dependencies are by far the largest downloads and this allows us to start compiling (and failing) faster and we only incur this cost when the test suite runs successfully.

408a7b77

2017-02-24T17:37:00

appveyor: don't rewrite system mingw Download mingw-w64 into our build directory and execute it there, don't try to overwrite the system's mingw.

18c18e3d

2016-10-31T15:55:46

coverity: check for Coverity token only if necessary When running a Coverity build, we have to provide an authentication token in order to proof that we are actually allowed to run analysis in the name of a certain project. As this token should be secret, it is only set on the main repository, so when we were requested to run the Coverity script on another repository we do error out. But in fact we do also error out if the Coverity analysis should _not_ be run if there is no authentication token provided. Fix the issue by only checking for the authentication token after determining if analysis is indeed requested.

561276ee

2016-10-28T14:48:30

coverity: only analyze the master branch of the main repository We used to only execute Coverity analysis on the 'development' branch before commit 998f001 (Refine build limitation, 2014-01-15), which refined Coverity build limitations. While we do not really use the 'development' branch anymore, it does still make sense to only analyze a single branch, as otherwise Coverity might get confused. Re-establish the restriction such that we only analyze libgit2's 'master' branch. Also fix the message announcing why we do not actually analyze a certain build.

6c4d2d3e

2016-10-28T14:45:55

coverity: fix download URL

ec3f5a9c

2016-08-16T11:02:47

script: cibuild: build examples

db357667

2016-10-05T20:17:06

travis: take the newer ssh-keygen format into account The Mac machines have updated their SSH version and so the ssh-keygen format has changed. Ask it for MD5, which is the one that is output as hex.

94d565b9

2016-10-05T18:52:43

cibuild: set -x This lets us see the details of what we're doing instead of just seeing the output of unknown commands in the build output.

a37624ec

2016-07-24T16:05:17

Merge pull request #3815 from pks-t/pks/coverity-model Coverity user model

0239eff3

2016-07-24T14:51:28

ci: install homebrew's curl on mac

08556e6d

2016-07-22T17:45:03

ci: install homebrew's zlib on mac

4d8fe1cd

2016-06-07T09:20:35

coverity: model functions printing into git_buf The `git_buf` structure seems to be too complicated to correctly grasp for Coverity. As such, add simpler models trying to guide Coverity and remove false positives related to these functions.

956f1e23

2016-06-07T09:17:52

coverity: add user model The static analysis engine coverity allows for user models overriding how it treats functions when analyzing code. Like this, one can greatly reduce the rate of false positives and thus make it easier to spot actual errors. Add a user model that overrides function models for `git_buf_len` and `git_vector_insert`, which together amount for a majority of false positives.

db01724f

2016-03-14T13:42:10

CI: start the proxy before the build so it's ready It takes a bit for the propxy to get ready to accept connections, so start it before the build so we can be reasonably sure that it's going to be ready in time.

2f3f1ee0

2015-09-21T21:40:37

proxy: test proxy support on Travis

4848dd32

2016-03-14T17:45:15

Merge pull request #3647 from pks-t/pks/coverity-fixes-round6 Coverity fixes round 6

b1093e62

2016-03-09T19:01:33

Remove CI support for mingw32 The tests have never run successfully and we do have successful builds of mingw-w64, so remove these CI builds which do not add value.

2615d0d6

2016-03-02T01:50:34

coverity: report errors when uploading tarball Curl by default does not report errors by setting the error code. As the upload can fail through several conditions (e.g. the rate limit, leading to unauthorized access) we should indicate this information in Travis CI. To improve upon the behavior, use `--write-out=%{http_code}` to write out the HTTP code in addition to the received body and return an error if the code does not equal 201.

ba9bb664

2016-03-03T19:21:07

tests: create a ctest target for cred_callback

25205737

2016-03-03T10:08:00

test: make sure we retry the auth callback on all platforms We were missing this test on Windows, which meant we didn't notice that we never fixed the single authentication attempt it tries, nor its wrong return code. Enable this for the unix platforms as well over HTTP. We previously were doing it locally but disabled it on OS X due to issues with its sshd not accepting password authentication.

859ed5dd

2016-02-23T09:54:26

common: introduce GITERR_CHECK_ALLOC_BUF We commonly have to check if a git_buf has been allocated correctly or if we ran out of memory. Introduce a new macro similar to `GITERR_CHECK_ALLOC` which checks if we ran OOM and if so returns an error. Provide a `#nodef` for Coverity to mark the error case as an abort path.

f2a554b4

2016-02-22T14:43:28

coverity: hint git_vector_foreach does not deref NULL contents Coverity does not comprehend the connection between a vector's size and the contents pointer, that is that the vector's pointer is non-NULL when its size is positive. As the vector code should be reasonably well tested and users are expected to not manually modify a vector's contents it seems save to assume that the macros will never dereference a NULL pointer. Fix Coverity warnings by overriding the foreach macros with macros that explicitly aborting when (v)->contents is NULL.

40f6f225

2016-02-15T10:58:52

coverity: hint that string length is at least 2 When checking if a string is prefixed by a drive letter (e.g. "C:") we verify this by inspecting the first and second character of the string. Coverity thinks this is a defect as we do not check the string's length first, but in fact we only check the second character if the first character is part of the alphabet, that is it cannot be '\0'. Fix this by overriding the macro and explicitly checking the string's length.

5981ab1d

2016-02-15T09:41:08

coverity: add nodefs for abort macros Add nodefs for macros that abort the current flow due to errors. This includes macros that trigger on integer overflows and for the version check macro. This aids Coverity as we point out that these paths will cause a fatal error.

50174ab4

2016-02-10T11:06:23

coverity: use https URL for posting build When posting our instrumented build results to Coverity we have to include sensitive information, in particular our authorization token. Currently we use an unencrypted channel to post this information, leading to the token being transferred in plain. Fix this by using a secured connection instead.

8dddea42

2016-02-10T10:59:14

coverity: provide nodef for GITERR_CHECK_ALLOC Coverity currently lists a lot of errors with regard to GITERR_CHECK_ALLOC causing resource leaks. We know this macro is only invoked when we want to abort because we are out of memory. Coverity allows for overriding the default model where we know that certain functions guarantee a desired behavior. The user_nodefs.h is used to override the behavior of macros. Re-define GITERR_CHECK_ALLOC inside of it to specify its abort nature.

a0bdfe32

2015-07-06T18:42:39

travis: don't install CMake on OS X Homebrew will error out because it's already installed.

d41b8ed0

2015-07-06T18:32:31

travis: update the homebrew db We need to make sure we are asking for the current version of packages, or we might get 404s from the download service.

32f538ae

2015-06-27T15:02:53

Remove dependency installation file for travis builds. We're installing dependencies via the APT addon now.

51f87999

2015-06-26T18:05:17

Don't try to start ssh.

6042a050

2015-06-12T12:17:03

travis: fail if we fail the push tests These tests were not being taken into consideration for the failure of the test. They've been failing for a while now, but we hadn't noticed as Travis was reporting the builds successful.

7aa96593

2015-03-17T12:05:07

set PKG_CONFIG_LIBDIR in toolchain-mingw32.cmake

8f426d7d

2014-06-09T11:43:25

Win32: Enable WinHTTP for MinGW

3e329861

2015-03-10T16:08:34

Revert "Implement fail-fast for Travis as well" This reverts commit ba6c53b91b1d9c9dc49b7c0d8e8efbd9842c31dc.

4c88fd7c

2015-03-04T11:31:24

Add MinGW-w64 to matrix cache mingw-w64 downloads quiet curl and 7zip run appveyor steps in cmd for mingw

ba6c53b9

2015-03-03T21:07:12

Implement fail-fast for Travis as well

ac5fad27

2015-03-03T10:53:26

add mingw to appveyor matrix use MSYS makefiles generator add bash script for running mingw on appveyor add --login and fix run paths use msys style path to appveyor-mingw.sh add mingw path to /etc/fstab

6f446176

2014-11-21T10:59:20

Merge pull request #2710 from Therzok/shellcheckScripts Run shell scripts through shellcheck

a4fccbbf

2014-11-17T07:01:40

Run shell scripts through shellcheck

aa5a06c3

2014-11-20T00:52:52

travis: disable the cert callback on OSX The sshd on OSX has stopped responding to the setting which this test assumes is there, so let's disable it until we can figure out what's happening.

ebda0970

2014-09-16T02:07:39

script: use a parallel build on Travis

0fef3899

2014-09-16T01:25:53

Merge remote-tracking branch 'upstream/master' into cmn/host-cert-info

bf8756d6

2014-09-15T21:51:42

ssh: add test for host key Test that the certificate check callback gets the right fingerprint from the host we're connecting to.

26bf3a53

2014-08-10T17:13:00

travis: no need to clean out the test repository This was added to avoid the remote's default branch to be considered to the be notes one which the first network test leaves behind.

6a0d2b43

2014-08-27T15:09:07

Merge remote-tracking branch 'upstream/master' into cmn/ssh-retry

d4256ed5

2014-07-04T10:00:39

ssh: provide a factory function for setting ssh paths git allows you to set which paths to use for the git server programs when connecting over ssh; and we want to provide something similar. We do this by providing a factory function which can be set as the remote's transport callback which will set the given paths upon creation.

87339935

2014-06-26T22:38:54

travis: enable password authentication on OSX Our ssh tests assume that the server supports password authentication in a few places. This is convenient as we're not testing authentication methods, but what happens around them. Tell sshd on OSX to accept this form of authentication.

d7f962f4

2014-06-16T19:30:06

ssh: request credentials again on authentication failure Instead of completely giving up on the first failure, ask for credentials as long as we fail to authenticate.

72303307

2014-05-21T12:45:22

travis: build on osx too

039e354b

2014-04-30T11:57:54

ciscript: don't use an empty string as a number An empty string is not a valid number, and some shells complain. Check instead if $COVERITY is non-empty, which is a common convention and what we're doing anyway.

5dae3ffe

2014-02-05T19:27:27

Only run clone-failure test on private repo

998f0016

2014-01-15T12:32:12

Refine build limitation

53e6f480

2014-01-15T12:12:17

Only run coverity on development

9bf17d2c

2014-01-13T14:11:14

Add coverity-scan script

5875e8d2

2013-08-19T18:50:03

travis: exit on failure for anything related to building

68180808

2013-08-19T10:50:28

travis: really fail if the tests fail When implementing the ssh testing, the move to the script made it so the first test suite's exit code was ignored. Check whether the main tests fail and exit with an error in that case.

5be622fb

2013-08-11T01:37:44

Test SSH in travis Set up the ssh credentials so we are able to talk to localhost and issue git commands. Move to use a script, as the command list is getting somewhat long. While here, delay installing valgrind until we need it, as it and its dependencies are by far the largest downloads and this allows us to start compiling (and failing) faster and we only incur this cost when the test suite runs successfully.

thodg/libgit2/script

script

Log