thodg/libgit2/tests/refs/transactions.c

• Show log

  Commit

• Hash : 3335a034
  Author :
  Date : 2019-10-10T15:28:46
  

  refs: fix locks getting forcibly removed
  
  The flag GIT_FILEBUF_FORCE currently does two things:
       1. It will cause the filebuf to create non-existing leading
          directories for the file that is about to be written.
       2. It will forcibly remove any pre-existing locks.
  While most call sites actually do want (1), they do not want to
  remove pre-existing locks, as that renders the locking mechanisms
  effectively useless.
  Introduce a new flag `GIT_FILEBUF_CREATE_LEADING_DIRS` to
  separate both behaviours cleanly from each other and convert
  callers to use it instead of `GIT_FILEBUF_FORCE` to have them
  honor locked files correctly.
  
  As this conversion removes all current users of `GIT_FILEBUF_FORCE`,
  this commit removes the flag altogether.
  

Download

• tests/refs/transactions.c

• #include "clar_libgit2.h"
  #include "git2/transaction.h"
  
  static git_repository *g_repo;
  static git_transaction *g_tx;
  
  void test_refs_transactions__initialize(void)
  {
     g_repo = cl_git_sandbox_init("testrepo");
     cl_git_pass(git_transaction_new(&g_tx, g_repo));
  }
  
  void test_refs_transactions__cleanup(void)
  {
  	git_transaction_free(g_tx);
  	cl_git_sandbox_cleanup();
  }
  
  void test_refs_transactions__single_ref_oid(void)
  {
  	git_reference *ref;
  	git_oid id;
  
  	git_oid_fromstr(&id, "a65fedf39aefe402d3bb6e24df4d4f5fe4547750");
  
  	cl_git_pass(git_transaction_lock_ref(g_tx, "refs/heads/master"));
  	cl_git_pass(git_transaction_set_target(g_tx, "refs/heads/master", &id, NULL, NULL));
  	cl_git_pass(git_transaction_commit(g_tx));
  
  	cl_git_pass(git_reference_lookup(&ref, g_repo, "refs/heads/master"));
  
  	cl_assert(!git_oid_cmp(&id, git_reference_target(ref)));
  	git_reference_free(ref);
  }
  
  void test_refs_transactions__single_ref_symbolic(void)
  {
  	git_reference *ref;
  
  	cl_git_pass(git_transaction_lock_ref(g_tx, "HEAD"));
  	cl_git_pass(git_transaction_set_symbolic_target(g_tx, "HEAD", "refs/heads/foo", NULL, NULL));
  	cl_git_pass(git_transaction_commit(g_tx));
  
  	cl_git_pass(git_reference_lookup(&ref, g_repo, "HEAD"));
  
  	cl_assert_equal_s("refs/heads/foo", git_reference_symbolic_target(ref));
  	git_reference_free(ref);
  }
  
  void test_refs_transactions__single_ref_mix_types(void)
  {
  	git_reference *ref;
  	git_oid id;
  
  	git_oid_fromstr(&id, "a65fedf39aefe402d3bb6e24df4d4f5fe4547750");
  
  	cl_git_pass(git_transaction_lock_ref(g_tx, "refs/heads/master"));
  	cl_git_pass(git_transaction_lock_ref(g_tx, "HEAD"));
  	cl_git_pass(git_transaction_set_symbolic_target(g_tx, "refs/heads/master", "refs/heads/foo", NULL, NULL));
  	cl_git_pass(git_transaction_set_target(g_tx, "HEAD", &id, NULL, NULL));
  	cl_git_pass(git_transaction_commit(g_tx));
  
  	cl_git_pass(git_reference_lookup(&ref, g_repo, "refs/heads/master"));
  	cl_assert_equal_s("refs/heads/foo", git_reference_symbolic_target(ref));
  	git_reference_free(ref);
  
  	cl_git_pass(git_reference_lookup(&ref, g_repo, "HEAD"));
  	cl_assert(!git_oid_cmp(&id, git_reference_target(ref)));
  	git_reference_free(ref);
  }
  
  void test_refs_transactions__single_ref_delete(void)
  {
  	git_reference *ref;
  
  	cl_git_pass(git_transaction_lock_ref(g_tx, "refs/heads/master"));
  	cl_git_pass(git_transaction_remove(g_tx, "refs/heads/master"));
  	cl_git_pass(git_transaction_commit(g_tx));
  
  	cl_git_fail_with(GIT_ENOTFOUND, git_reference_lookup(&ref, g_repo, "refs/heads/master"));
  }
  
  void test_refs_transactions__single_create(void)
  {
  	git_reference *ref;
  	const char *name = "refs/heads/new-branch";
  	git_oid id;
  
  	cl_git_fail_with(GIT_ENOTFOUND, git_reference_lookup(&ref, g_repo, name));
  
  	cl_git_pass(git_transaction_lock_ref(g_tx, name));
  
  	git_oid_fromstr(&id, "a65fedf39aefe402d3bb6e24df4d4f5fe4547750");
  	cl_git_pass(git_transaction_set_target(g_tx, name, &id, NULL, NULL));
  	cl_git_pass(git_transaction_commit(g_tx));
  
  	cl_git_pass(git_reference_lookup(&ref, g_repo, name));
  	cl_assert(!git_oid_cmp(&id, git_reference_target(ref)));
  	git_reference_free(ref);
  }
  
  void test_refs_transactions__unlocked_set(void)
  {
  	git_oid id;
  
  	cl_git_pass(git_transaction_lock_ref(g_tx, "refs/heads/master"));
  	git_oid_fromstr(&id, "a65fedf39aefe402d3bb6e24df4d4f5fe4547750");
  	cl_git_fail_with(GIT_ENOTFOUND, git_transaction_set_target(g_tx, "refs/heads/foo", &id, NULL, NULL));
  	cl_git_pass(git_transaction_commit(g_tx));
  }
  
  void test_refs_transactions__error_on_locking_locked_ref(void)
  {
  	git_oid id;
  	git_transaction *g_tx_with_lock;
  	git_repository *g_repo_with_locking_tx;
  	const char *g_repo_path = git_repository_path(g_repo);
  	
  	/* prepare a separate transaction in another instance of testrepo and lock master */
  	cl_git_pass(git_repository_open(&g_repo_with_locking_tx, g_repo_path));
  	cl_git_pass(git_transaction_new(&g_tx_with_lock, g_repo_with_locking_tx));
  	cl_git_pass(git_transaction_lock_ref(g_tx_with_lock, "refs/heads/master"));
  
  	/* lock reference for set_target */
  	cl_git_pass(git_oid_fromstr(&id, "a65fedf39aefe402d3bb6e24df4d4f5fe4547750"));
  	cl_git_fail_with(GIT_ELOCKED, git_transaction_lock_ref(g_tx, "refs/heads/master"));
  	cl_git_fail_with(GIT_ENOTFOUND, git_transaction_set_target(g_tx, "refs/heads/master", &id, NULL, NULL));
  
  	git_transaction_free(g_tx_with_lock);
  	git_repository_free(g_repo_with_locking_tx);
  }
  

Download