Hash :
cccacac5
Author :
Date :
2012-11-14T22:41:51
Add POSIX compat lstat() variant for win32 The existing p_lstat implementation on win32 is not quite POSIX compliant when setting errno to ENOTDIR. This adds an option to make is be compliant so that code (such as checkout) that cares to have separate behavior for ENOTDIR can use it portably. This also contains a couple of other minor cleanups in the posix_w32.c implementations to avoid unnecessary work.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117
#include "clar_libgit2.h"
#include "fileops.h"
#include "path.h"
#include "posix.h"
void test_core_stat__initialize(void)
{
cl_git_pass(git_futils_mkdir("root/d1/d2", NULL, 0755, GIT_MKDIR_PATH));
cl_git_mkfile("root/file", "whatever\n");
cl_git_mkfile("root/d1/file", "whatever\n");
}
void test_core_stat__cleanup(void)
{
git_futils_rmdir_r("root", NULL, GIT_RMDIR_REMOVE_FILES);
}
#ifdef GIT_WIN32
#define cl_assert_last_error(val) \
do { werr = GetLastError(); cl_assert_equal_i((val), (int)werr); } while (0)
#else
#define cl_assert_last_error(val)
#endif
#define cl_assert_error(val) \
do { err = errno; cl_assert_equal_i((val), err); } while (0)
void test_core_stat__0(void)
{
struct stat st;
int err;
#ifdef GIT_WIN32
DWORD werr;
#endif
cl_assert_equal_i(0, p_lstat("root", &st));
cl_assert(S_ISDIR(st.st_mode));
cl_assert_last_error(0);
cl_assert_error(0);
cl_assert_equal_i(0, p_lstat("root/", &st));
cl_assert(S_ISDIR(st.st_mode));
cl_assert_last_error(0);
cl_assert_error(0);
cl_assert_equal_i(0, p_lstat("root/file", &st));
cl_assert(S_ISREG(st.st_mode));
cl_assert_last_error(0);
cl_assert_error(0);
cl_assert_equal_i(0, p_lstat("root/d1", &st));
cl_assert(S_ISDIR(st.st_mode));
cl_assert_last_error(0);
cl_assert_error(0);
cl_assert_equal_i(0, p_lstat("root/d1/", &st));
cl_assert(S_ISDIR(st.st_mode));
cl_assert_last_error(0);
cl_assert_error(0);
cl_assert_equal_i(0, p_lstat("root/d1/file", &st));
cl_assert(S_ISREG(st.st_mode));
cl_assert_last_error(0);
cl_assert_error(0);
cl_assert(p_lstat("root/missing", &st) < 0);
cl_assert_last_error(ERROR_FILE_NOT_FOUND);
cl_assert_error(ENOENT);
cl_assert(p_lstat("root/missing/but/could/be/created", &st) < 0);
cl_assert_last_error(ERROR_PATH_NOT_FOUND);
#ifdef GIT_WIN32
cl_assert_error(ENOTDIR);
#else
cl_assert_error(ENOENT);
#endif
cl_assert(p_lstat_posixly("root/missing/but/could/be/created", &st) < 0);
cl_assert_error(ENOENT);
cl_assert(p_lstat("root/d1/missing", &st) < 0);
cl_assert_last_error(ERROR_FILE_NOT_FOUND);
cl_assert_error(ENOENT);
cl_assert(p_lstat("root/d1/missing/deeper/path", &st) < 0);
cl_assert_last_error(ERROR_PATH_NOT_FOUND);
#ifdef GIT_WIN32
cl_assert_error(ENOTDIR);
#else
cl_assert_error(ENOENT);
#endif
cl_assert(p_lstat_posixly("root/d1/missing/deeper/path", &st) < 0);
cl_assert_error(ENOENT);
cl_assert(p_lstat_posixly("root/d1/file/deeper/path", &st) < 0);
cl_assert_error(ENOTDIR);
cl_assert(p_lstat("root/file/invalid", &st) < 0);
cl_assert_error(ENOTDIR);
cl_assert(p_lstat_posixly("root/file/invalid", &st) < 0);
cl_assert_error(ENOTDIR);
cl_assert(p_lstat("root/file/invalid/deeper_path", &st) < 0);
cl_assert_error(ENOTDIR);
cl_assert(p_lstat_posixly("root/file/invalid/deeper_path", &st) < 0);
cl_assert_error(ENOTDIR);
cl_assert(p_lstat_posixly("root/d1/file/extra", &st) < 0);
cl_assert_error(ENOTDIR);
cl_assert(p_lstat_posixly("root/d1/file/further/invalid/items", &st) < 0);
cl_assert_error(ENOTDIR);
}