thodg/libgit2/tests/resources/revwalk.git/packed-refs

• Show log

  Commit

• Hash : 54fd80e3
  Author :
  Date : 2018-04-12T13:32:27
  

  revwalk: fix uninteresting revs sometimes not limiting graphwalk When we want to limit our graphwalk, we use the heuristic of checking whether the newest limiting (uninteresting) revision is newer than the oldest interesting revision. We do so by inspecting whether the first item's commit time of the user-supplied list of revisions is newer than the last added interesting revision. This is wrong though, as the user supplied list is in no way guaranteed to be sorted by increasing commit dates. This could lead us to abort the revwalk early before applying all relevant limiting revisions, outputting revisions which should in fact have been hidden. Fix the heuristic by instead checking whether _any_ of the limiting commits was made earlier than the last interesting commit. Add a test.

Download

• tests/resources/revwalk.git/packed-refs

• # pack-refs with: peeled fully-peeled sorted 
  3ae0f53011bdb7e68f99bde4943449f36c1c318a refs/heads/A
  061978578d7c9ff2ba92dd36d31fd8d809871030 refs/heads/B
  743398b425d6c216d6cfaae3786b5bc436393ae5 refs/heads/C
  790ba0facf6fd103699a5c40cd19dad277ff49cd refs/heads/D
  d3d783066cf7d95def6844b9c5118c1e7bcce7df refs/heads/E
  d3d783066cf7d95def6844b9c5118c1e7bcce7df refs/heads/master
  

Download