thodg/libgit2/src/config_entries.h

• Show log

  Commit

• Hash : b78f4ab0
  Author :
  Date : 2018-08-16T12:22:03
  

  config_entries: refactor entries iterator memory ownership Right now, the config file code requires us to pass in its backend to the config entry iterator. This is required with the current code, as the config file backend will first create a read-only snapshot which is then passed to the iterator just for that purpose. So after the iterator is getting free'd, the code needs to make sure that the snapshot gets free'd, as well. By now, though, we can easily refactor the code to be more efficient and remove the reverse dependency from iterator to backend. Instead of creating a read-only snapshot (which also requires us to re-parse the complete configuration file), we can simply duplicate the config entries and pass those to the iterator. Like that, the iterator only needs to make sure to free the duplicated config entries, which is trivial to do and clears up memory ownership by a lot.

Download

• src/config_entries.h

• /*
   * Copyright (C) the libgit2 contributors. All rights reserved.
   *
   * This file is part of libgit2, distributed under the GNU GPL v2 with
   * a Linking Exception. For full terms see the included COPYING file.
   */
  
  #include "common.h"
  
  #include "git2/sys/config.h"
  #include "config.h"
  
  typedef struct git_config_entries git_config_entries;
  
  int git_config_entries_new(git_config_entries **out);
  int git_config_entries_dup(git_config_entries **out, git_config_entries *entries);
  void git_config_entries_incref(git_config_entries *entries);
  void git_config_entries_free(git_config_entries *entries);
  /* Add or append the new config option */
  int git_config_entries_append(git_config_entries *entries, git_config_entry *entry);
  int git_config_entries_get(git_config_entry **out, git_config_entries *entries, const char *key);
  int git_config_entries_get_unique(git_config_entry **out, git_config_entries *entries, const char *key);
  int git_config_entries_iterator_new(git_config_iterator **out, git_config_entries *entries);
  

Download