thodg/libgit2/tests/submodule/add.c

• Show log

  Commit

• Hash : 69a282da
  Author :
  Date : 2018-03-28T06:48:55
  

  submodule: add more robust error handling when a submodule path is found on add

Download

• tests/submodule/add.c

• #include "clar_libgit2.h"
  #include "posix.h"
  #include "path.h"
  #include "submodule_helpers.h"
  #include "config/config_helpers.h"
  #include "fileops.h"
  #include "repository.h"
  
  static git_repository *g_repo = NULL;
  static const char *valid_blob_id = "fa49b077972391ad58037050f2a75f74e3671e92";
  
  void test_submodule_add__cleanup(void)
  {
  	cl_git_sandbox_cleanup();
  }
  
  static void assert_submodule_url(const char* name, const char *url)
  {
  	git_buf key = GIT_BUF_INIT;
  
  
  	cl_git_pass(git_buf_printf(&key, "submodule.%s.url", name));
  	assert_config_entry_value(g_repo, git_buf_cstr(&key), url);
  
  	git_buf_free(&key);
  }
  
  void test_submodule_add__url_absolute(void)
  {
  	git_submodule *sm;
  	git_repository *repo;
  	git_buf dot_git_content = GIT_BUF_INIT;
  
  	g_repo = setup_fixture_submod2();
  
  	/* re-add existing submodule */
  	cl_git_fail_with(
  		GIT_EEXISTS,
  		git_submodule_add_setup(NULL, g_repo, "whatever", "sm_unchanged", 1));
  
  	/* add a submodule using a gitlink */
  
  	cl_git_pass(
  		git_submodule_add_setup(&sm, g_repo, "https://github.com/libgit2/libgit2.git", "sm_libgit2", 1)
  		);
  	git_submodule_free(sm);
  
  	cl_assert(git_path_isfile("submod2/" "sm_libgit2" "/.git"));
  
  	cl_assert(git_path_isdir("submod2/.git/modules"));
  	cl_assert(git_path_isdir("submod2/.git/modules/" "sm_libgit2"));
  	cl_assert(git_path_isfile("submod2/.git/modules/" "sm_libgit2" "/HEAD"));
  	assert_submodule_url("sm_libgit2", "https://github.com/libgit2/libgit2.git");
  
  	cl_git_pass(git_repository_open(&repo, "submod2/" "sm_libgit2"));
  
  	/* Verify worktree path is relative */
  	assert_config_entry_value(repo, "core.worktree", "../../../sm_libgit2/");
  
  	/* Verify gitdir path is relative */
  	cl_git_pass(git_futils_readbuffer(&dot_git_content, "submod2/" "sm_libgit2" "/.git"));
  	cl_assert_equal_s("gitdir: ../.git/modules/sm_libgit2/", dot_git_content.ptr);
  
  	git_repository_free(repo);
  	git_buf_free(&dot_git_content);
  
  	/* add a submodule not using a gitlink */
  
  	cl_git_pass(
  		git_submodule_add_setup(&sm, g_repo, "https://github.com/libgit2/libgit2.git", "sm_libgit2b", 0)
  		);
  	git_submodule_free(sm);
  
  	cl_assert(git_path_isdir("submod2/" "sm_libgit2b" "/.git"));
  	cl_assert(git_path_isfile("submod2/" "sm_libgit2b" "/.git/HEAD"));
  	cl_assert(!git_path_exists("submod2/.git/modules/" "sm_libgit2b"));
  	assert_submodule_url("sm_libgit2b", "https://github.com/libgit2/libgit2.git");
  }
  
  void test_submodule_add__url_relative(void)
  {
  	git_submodule *sm;
  	git_remote *remote;
  	git_strarray problems = {0};
  
  	/* default remote url is https://github.com/libgit2/false.git */
  	g_repo = cl_git_sandbox_init("testrepo2");
  
  	/* make sure we don't default to origin - rename origin -> test_remote */
  	cl_git_pass(git_remote_rename(&problems, g_repo, "origin", "test_remote"));
  	cl_assert_equal_i(0, problems.count);
  	git_strarray_free(&problems);
  	cl_git_fail(git_remote_lookup(&remote, g_repo, "origin"));
  
  	cl_git_pass(
  		git_submodule_add_setup(&sm, g_repo, "../TestGitRepository", "TestGitRepository", 1)
  		);
  	git_submodule_free(sm);
  
  	assert_submodule_url("TestGitRepository", "https://github.com/libgit2/TestGitRepository");
  }
  
  void test_submodule_add__url_relative_to_origin(void)
  {
  	git_submodule *sm;
  
  	/* default remote url is https://github.com/libgit2/false.git */
  	g_repo = cl_git_sandbox_init("testrepo2");
  
  	cl_git_pass(
  		git_submodule_add_setup(&sm, g_repo, "../TestGitRepository", "TestGitRepository", 1)
  		);
  	git_submodule_free(sm);
  
  	assert_submodule_url("TestGitRepository", "https://github.com/libgit2/TestGitRepository");
  }
  
  void test_submodule_add__url_relative_to_workdir(void)
  {
  	git_submodule *sm;
  
  	/* In this repo, HEAD (master) has no remote tracking branc h*/
  	g_repo = cl_git_sandbox_init("testrepo");
  
  	cl_git_pass(
  		git_submodule_add_setup(&sm, g_repo, "./", "TestGitRepository", 1)
  		);
  	git_submodule_free(sm);
  
  	assert_submodule_url("TestGitRepository", git_repository_workdir(g_repo));
  }
  
  static void test_add_entry(
  	git_index *index,
  	const char *idstr,
  	const char *path,
  	git_filemode_t mode)
  {
  	git_index_entry entry = {{0}};
  
  	cl_git_pass(git_oid_fromstr(&entry.id, idstr));
  
  	entry.path = path;
  	entry.mode = mode;
  
  	cl_git_pass(git_index_add(index, &entry));
  }
  
  void test_submodule_add__path_exists_in_index(void)
  {
  	git_index *index;
  	git_submodule *sm;
  	git_buf filename = GIT_BUF_INIT;
  
  	g_repo = cl_git_sandbox_init("testrepo");
  
  	cl_git_pass(git_buf_joinpath(&filename, "subdirectory", "test.txt"));
  
  	cl_git_pass(git_repository_index__weakptr(&index, g_repo));
  
  	test_add_entry(index, valid_blob_id, filename.ptr, GIT_FILEMODE_BLOB);
  
  	cl_git_fail_with(git_submodule_add_setup(&sm, g_repo, "./", "subdirectory", 1), GIT_EEXISTS);
  
  	git_submodule_free(sm);
  	git_buf_free(&filename);
  }
  
  void test_submodule_add__file_exists_in_index(void)
  {
  	git_index *index;
  	git_submodule *sm;
  	git_buf name = GIT_BUF_INIT;
  
  	g_repo = cl_git_sandbox_init("testrepo");
  
  	cl_git_pass(git_repository_index__weakptr(&index, g_repo));
  
  	test_add_entry(index, valid_blob_id, "subdirectory", GIT_FILEMODE_BLOB);
  
  	cl_git_fail_with(git_submodule_add_setup(&sm, g_repo, "./", "subdirectory", 1), GIT_EEXISTS);
  
  	git_submodule_free(sm);
  	git_buf_free(&name);
  }
  

Download