thodg/libgit2/src/config_parse.h

• Show log

  Commit

• Hash : e51e29e8
  Author :
  Date : 2017-11-12T13:59:47
  

  config_parse: have `git_config_parse` own entry value and name
  
  The function `git_config_parse` uses several callbacks to pass data
  along to the caller as it parses the file. One design shortcoming here
  is that strings passed to those callbacks are expected to be freed by
  them, which is really confusing.
  
  Fix the issue by changing memory ownership here. Instead of expecting
  the `on_variable` callbacks to free memory for `git_config_parse`, just
  do it inside of `git_config_parse`. While this obviously requires a bit
  more memory allocation churn due to having to copy both name and value
  at some places, this shouldn't be too much of a burden.
  

Download

• src/config_parse.h

• /*
   * Copyright (C) the libgit2 contributors. All rights reserved.
   *
   * This file is part of libgit2, distributed under the GNU GPL v2 with
   * a Linking Exception. For full terms see the included COPYING file.
   */
  #ifndef INCLUDE_config_parse_h__
  #define INCLUDE_config_parse_h__
  
  #include "common.h"
  #include "array.h"
  #include "oid.h"
  #include "parse.h"
  
  static const char *git_config_escapes = "ntb\"\\";
  static const char *git_config_escaped = "\n\t\b\"\\";
  
  typedef struct config_file {
  	git_oid checksum;
  	char *path;
  	git_array_t(struct config_file) includes;
  } git_config_file;
  
  typedef struct {
  	struct config_file *file;
  	git_parse_ctx ctx;
  } git_config_parser;
  
  typedef int (*git_config_parser_section_cb)(
  	git_config_parser *parser,
  	const char *current_section,
  	const char *line,
  	size_t line_len,
  	void *data);
  
  typedef int (*git_config_parser_variable_cb)(
  	git_config_parser *parser,
  	const char *current_section,
  	const char *var_name,
  	const char *var_value,
  	const char *line,
  	size_t line_len,
  	void *data);
  
  typedef int (*git_config_parser_comment_cb)(
  	git_config_parser *parser,
  	const char *line,
  	size_t line_len,
  	void *data);
  
  typedef int (*git_config_parser_eof_cb)(
  	git_config_parser *parser,
  	const char *current_section,
  	void *data);
  
  int git_config_parse(
  	git_config_parser *parser,
  	git_config_parser_section_cb on_section,
  	git_config_parser_variable_cb on_variable,
  	git_config_parser_comment_cb on_comment,
  	git_config_parser_eof_cb on_eof,
  	void *data);
  
  #endif
  

Download