thodg/libgit2/cmake/SelectWinHTTP.cmake

• Show log

  Commit

• Hash : c5cd71b2
  Author :
  Date : 2021-12-23T18:23:34
  

  cmake: use PROJECT_SOURCE_DIR of CMAKE_SOURCE_DIR Also applies to *_BINARY_DIR. This effectively reverts 84083dcc8bd41332ccac9d7b537f3e254d79011c, which broke all users of libgit2 that use it as a CMake subdirectory (via `add_subdirectory()`). This is because CMAKE_SOURCE_DIR refers to the root-most CMake directory, which in the case of `add_subdirectory()` is a parent project to libgit2 and thus the paths don't make any sense to the configuration files. Corollary, CMAKE_SOURCE_DIR only makes sense if the CMake project is always the root project - which can rarely be guaranteed. In all honesty, CMake should deprecate and eventually remove CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR. It's been the source of headaches and confusion for years, they're rarely useful over CMAKE_CURRENT_(SOURCE|BINARY)_DIR or PROJECT_(SOURCE|BINARY)_DIR, and they cause a lot of confusing configuration and source code layouts to boot. Any time they are used, they break `add_subdirectory()` almost 100% of the time, cause confusing error messages, and hide subtle bugs.

Download

• cmake/SelectWinHTTP.cmake

• if(WIN32 AND USE_WINHTTP)
  	set(GIT_WINHTTP 1)
  
  	# Since MinGW does not come with headers or an import library for winhttp,
  	# we have to include a private header and generate our own import library
  	if(MINGW)
  		add_subdirectory("${PROJECT_SOURCE_DIR}/deps/winhttp" "${PROJECT_BINARY_DIR}/deps/winhttp")
  		list(APPEND LIBGIT2_SYSTEM_LIBS winhttp)
  		list(APPEND LIBGIT2_DEPENDENCY_INCLUDES "${PROJECT_SOURCE_DIR}/deps/winhttp")
  	else()
  		list(APPEND LIBGIT2_SYSTEM_LIBS "winhttp")
  		list(APPEND LIBGIT2_PC_LIBS "-lwinhttp")
  	endif()
  
  	list(APPEND LIBGIT2_SYSTEM_LIBS "rpcrt4" "crypt32" "ole32")
  	list(APPEND LIBGIT2_PC_LIBS "-lrpcrt4" "-lcrypt32" "-lole32")
  endif()
  

Download