thodg/libgit2/tests-clar/object/raw/convert.c

• Show log

  Commit

• Hash : a21cbb12
  Author :
  Date : 2013-05-22T10:37:12
  

  Significant rename detection rewrite This flips rename detection around so instead of creating a forward mapping from deltas to possible rename targets, instead it creates a reverse mapping, looking at possible targets and trying to find a source that they could have been renamed or copied from. This is important because each output can only have a single source, but a given source could map to multiple outputs (in the form of COPIED records). Additionally, this makes a couple of tweaks to the public rename detection APIs, mostly renaming a couple of options that control the behavior to make more sense and to be more like core Git. I walked through the tests looking at the exact results and updated the expectations based on what I saw. The new code is different from the old because it cannot give some nonsense results (like A was renamed to both B and C) which were part of the outputs previously.

Download

• tests-clar/object/raw/convert.c

• 
  #include "clar_libgit2.h"
  
  #include "odb.h"
  
  void test_object_raw_convert__succeed_on_oid_to_string_conversion(void)
  {
  	const char *exp = "16a0123456789abcdef4b775213c23a8bd74f5e0";
  	git_oid in;
  	char out[GIT_OID_HEXSZ + 1];
  	char *str;
  	int i;
  
  	cl_git_pass(git_oid_fromstr(&in, exp));
  
  	/* NULL buffer pointer, returns static empty string */
  	str = git_oid_tostr(NULL, sizeof(out), &in);
  	cl_assert(str && *str == '\0' && str != out);
  
  	/* zero buffer size, returns static empty string */
  	str = git_oid_tostr(out, 0, &in);
  	cl_assert(str && *str == '\0' && str != out);
  
  	/* NULL oid pointer, sets existing buffer to empty string */
  	str = git_oid_tostr(out, sizeof(out), NULL);
  	cl_assert(str && *str == '\0' && str == out);
  
  	/* n == 1, returns out as an empty string */
  	str = git_oid_tostr(out, 1, &in);
  	cl_assert(str && *str == '\0' && str == out);
  
  	for (i = 1; i < GIT_OID_HEXSZ; i++) {
  		out[i+1] = 'Z';
  		str = git_oid_tostr(out, i+1, &in);
  		/* returns out containing c-string */
  		cl_assert(str && str == out);
  		/* must be '\0' terminated */
  		cl_assert(*(str+i) == '\0');
  		/* must not touch bytes past end of string */
  		cl_assert(*(str+(i+1)) == 'Z');
  		/* i == n-1 charaters of string */
  		cl_git_pass(strncmp(exp, out, i));
  	}
  
  	/* returns out as hex formatted c-string */
  	str = git_oid_tostr(out, sizeof(out), &in);
  	cl_assert(str && str == out && *(str+GIT_OID_HEXSZ) == '\0');
  	cl_assert_equal_s(exp, out);
  }
  
  void test_object_raw_convert__succeed_on_oid_to_string_conversion_big(void)
  {
  	const char *exp = "16a0123456789abcdef4b775213c23a8bd74f5e0";
  	git_oid in;
  	char big[GIT_OID_HEXSZ + 1 + 3]; /* note + 4 => big buffer */
  	char *str;
  
  	cl_git_pass(git_oid_fromstr(&in, exp));
  
  	/* place some tail material */
  	big[GIT_OID_HEXSZ+0] = 'W'; /* should be '\0' afterwards */
  	big[GIT_OID_HEXSZ+1] = 'X'; /* should remain untouched   */
  	big[GIT_OID_HEXSZ+2] = 'Y'; /* ditto */
  	big[GIT_OID_HEXSZ+3] = 'Z'; /* ditto */
  
  	/* returns big as hex formatted c-string */
  	str = git_oid_tostr(big, sizeof(big), &in);
  	cl_assert(str && str == big && *(str+GIT_OID_HEXSZ) == '\0');
  	cl_assert_equal_s(exp, big);
  
  	/* check tail material is untouched */
  	cl_assert(str && str == big && *(str+GIT_OID_HEXSZ+1) == 'X');
  	cl_assert(str && str == big && *(str+GIT_OID_HEXSZ+2) == 'Y');
  	cl_assert(str && str == big && *(str+GIT_OID_HEXSZ+3) == 'Z');
  }
  
  static void check_partial_oid(
  	char *buffer, size_t count, const git_oid *oid, const char *expected)
  {
  	git_oid_nfmt(buffer, count, oid);
  	buffer[count] = '\0';
  	cl_assert_equal_s(expected, buffer);
  }
  
  void test_object_raw_convert__convert_oid_partially(void)
  {
  	const char *exp = "16a0123456789abcdef4b775213c23a8bd74f5e0";
  	git_oid in;
  	char big[GIT_OID_HEXSZ + 1 + 3]; /* note + 4 => big buffer */
  
  	cl_git_pass(git_oid_fromstr(&in, exp));
  
  	git_oid_nfmt(big, sizeof(big), &in);
  	cl_assert_equal_s(exp, big);
  
  	git_oid_nfmt(big, GIT_OID_HEXSZ + 1, &in);
  	cl_assert_equal_s(exp, big);
  
  	check_partial_oid(big, 1, &in, "1");
  	check_partial_oid(big, 2, &in, "16");
  	check_partial_oid(big, 3, &in, "16a");
  	check_partial_oid(big, 4, &in, "16a0");
  	check_partial_oid(big, 5, &in, "16a01");
  
  	check_partial_oid(big, GIT_OID_HEXSZ, &in, exp);
  	check_partial_oid(
  		big, GIT_OID_HEXSZ - 1, &in, "16a0123456789abcdef4b775213c23a8bd74f5e");
  	check_partial_oid(
  		big, GIT_OID_HEXSZ - 2, &in, "16a0123456789abcdef4b775213c23a8bd74f5");
  	check_partial_oid(
  		big, GIT_OID_HEXSZ - 3, &in, "16a0123456789abcdef4b775213c23a8bd74f");
  }
  

Download