thodg/libgit2/tests/odb/foreach.c

• Show log

  Commit

• Hash : 25e0b157
  Author :
  Date : 2013-12-06T15:07:57
  

  Remove converting user error to GIT_EUSER This changes the behavior of callbacks so that the callback error code is not converted into GIT_EUSER and instead we propagate the return value through to the caller. Instead of using the giterr_capture and giterr_restore functions, we now rely on all functions to pass back the return value from a callback. To avoid having a return value with no error message, the user can call the public giterr_set_str or some such function to set an error message. There is a new helper 'giterr_set_callback' that functions can invoke after making a callback which ensures that some error message was set in case the callback did not set one. In places where the sign of the callback return value is meaningful (e.g. positive to skip, negative to abort), only the negative values are returned back to the caller, obviously, since the other values allow for continuing the loop. The hardest parts of this were in the checkout code where positive return values were overloaded as meaningful values for checkout. I fixed this by adding an output parameter to many of the internal checkout functions and removing the overload. This added some code, but it is probably a better implementation. There is some funkiness in the network code where user provided callbacks could be returning a positive or a negative value and we want to rely on that to cancel the loop. There are still a couple places where an user error might get turned into GIT_EUSER there, I think, though none exercised by the tests.

Download

• tests/odb/foreach.c

• #include "clar_libgit2.h"
  #include "odb.h"
  #include "git2/odb_backend.h"
  #include "pack.h"
  
  static git_odb *_odb;
  static git_repository *_repo;
  
  void test_odb_foreach__cleanup(void)
  {
  	git_odb_free(_odb);
  	git_repository_free(_repo);
  
  	_odb = NULL;
  	_repo = NULL;
  }
  
  static int foreach_cb(const git_oid *oid, void *data)
  {
  	int *nobj = data;
  	(*nobj)++;
  
  	GIT_UNUSED(oid);
  
  	return 0;
  }
  
  /*
   * $ git --git-dir tests/resources/testrepo.git count-objects --verbose
   * count: 47
   * size: 4
   * in-pack: 1640
   * packs: 3
   * size-pack: 425
   * prune-packable: 0
   * garbage: 0
   */
  void test_odb_foreach__foreach(void)
  {
  	int nobj = 0;
  
  	cl_git_pass(git_repository_open(&_repo, cl_fixture("testrepo.git")));
  	git_repository_odb(&_odb, _repo);
  
  	cl_git_pass(git_odb_foreach(_odb, foreach_cb, &nobj));
  	cl_assert_equal_i(47 + 1640, nobj); /* count + in-pack */
  }
  
  void test_odb_foreach__one_pack(void)
  {
  	git_odb_backend *backend = NULL;
  	int nobj = 0;
  
  	cl_git_pass(git_odb_new(&_odb));
  	cl_git_pass(git_odb_backend_one_pack(&backend, cl_fixture("testrepo.git/objects/pack/pack-a81e489679b7d3418f9ab594bda8ceb37dd4c695.idx")));
  	cl_git_pass(git_odb_add_backend(_odb, backend, 1));
  	_repo = NULL;
  
  	cl_git_pass(git_odb_foreach(_odb, foreach_cb, &nobj));
  	cl_assert(nobj == 1628);
  }
  
  static int foreach_stop_cb(const git_oid *oid, void *data)
  {
  	int *nobj = data;
  	(*nobj)++;
  
  	GIT_UNUSED(oid);
  
  	return (*nobj == 1000) ? -321 : 0;
  }
  
  void test_odb_foreach__interrupt_foreach(void)
  {
  	int nobj = 0;
  
  	cl_git_pass(git_repository_open(&_repo, cl_fixture("testrepo.git")));
  	git_repository_odb(&_odb, _repo);
  
  	cl_assert_equal_i(-321, git_odb_foreach(_odb, foreach_stop_cb, &nobj));
  	cl_assert(nobj == 1000);
  }
  

Download