thodg/libgit2/src/transports/cred_helpers.c

• Show log

  Commit

• Hash : 0c7f49dd
  Author :
  Date : 2017-06-30T13:39:01
  

  Make sure to always include "common.h" first Next to including several files, our "common.h" header also declares various macros which are then used throughout the project. As such, we have to make sure to always include this file first in all implementation files. Otherwise, we might encounter problems or even silent behavioural differences due to macros or defines not being defined as they should be. So in fact, our header and implementation files should make sure to always include "common.h" first. This commit does so by establishing a common include pattern. Header files inside of "src" will now always include "common.h" as its first other file, separated by a newline from all the other includes to make it stand out as special. There are two cases for the implementation files. If they do have a matching header file, they will always include this one first, leading to "common.h" being transitively included as first file. If they do not have a matching header file, they instead include "common.h" as first file themselves. This fixes the outlined problems and will become our standard practice for header and source files inside of the "src/" from now on.

Download

• src/transports/cred_helpers.c

• /*
   * Copyright (C) the libgit2 contributors. All rights reserved.
   *
   * This file is part of libgit2, distributed under the GNU GPL v2 with
   * a Linking Exception. For full terms see the included COPYING file.
   */
  
  #include "common.h"
  
  #include "git2/cred_helpers.h"
  
  int git_cred_userpass(
  		git_cred **cred,
  		const char *url,
  		const char *user_from_url,
  		unsigned int allowed_types,
  		void *payload)
  {
  	git_cred_userpass_payload *userpass = (git_cred_userpass_payload*)payload;
  	const char *effective_username = NULL;
  
  	GIT_UNUSED(url);
  
  	if (!userpass || !userpass->password) return -1;
  
  	/* Username resolution: a username can be passed with the URL, the
  	 * credentials payload, or both. Here's what we do.  Note that if we get
  	 * this far, we know that any password the url may contain has already
  	 * failed at least once, so we ignore it.
  	 *
  	 * |  Payload    |   URL    |   Used    |
  	 * +-------------+----------+-----------+
  	 * |    yes      |   no     |  payload  |
  	 * |    yes      |   yes    |  payload  |
  	 * |    no       |   yes    |  url      |
  	 * |    no       |   no     |  FAIL     |
  	 */
  	if (userpass->username)
  		effective_username = userpass->username;
  	else if (user_from_url)
  		effective_username = user_from_url;
  	else
  		return -1;
  
  	if (GIT_CREDTYPE_USERNAME & allowed_types)
  		return git_cred_username_new(cred, effective_username);
  
  	if ((GIT_CREDTYPE_USERPASS_PLAINTEXT & allowed_types) == 0 ||
  			git_cred_userpass_plaintext_new(cred, effective_username, userpass->password) < 0)
  		return -1;
  
  	return 0;
  }
  

Download