thodg/libgit2/tests/online/push_util.c

• Show log

  Commit

• Hash : f0e693b1
  Author :
  Date : 2021-09-07T17:53:49
  

  str: introduce `git_str` for internal, `git_buf` is external
  
  libgit2 has two distinct requirements that were previously solved by
  `git_buf`.  We require:
  
  1. A general purpose string class that provides a number of utility APIs
     for manipulating data (eg, concatenating, truncating, etc).
  2. A structure that we can use to return strings to callers that they
     can take ownership of.
  
  By using a single class (`git_buf`) for both of these purposes, we have
  confused the API to the point that refactorings are difficult and
  reasoning about correctness is also difficult.
  
  Move the utility class `git_buf` to be called `git_str`: this represents
  its general purpose, as an internal string buffer class.  The name also
  is an homage to Junio Hamano ("gitstr").
  
  The public API remains `git_buf`, and has a much smaller footprint.  It
  is generally only used as an "out" param with strict requirements that
  follow the documentation.  (Exceptions exist for some legacy APIs to
  avoid breaking callers unnecessarily.)
  
  Utility functions exist to convert a user-specified `git_buf` to a
  `git_str` so that we can call internal functions, then converting it
  back again.
  

Download

• tests/online/push_util.c

• #include "clar_libgit2.h"
  #include "vector.h"
  #include "push_util.h"
  
  const git_oid OID_ZERO = {{ 0 }};
  
  void updated_tip_free(updated_tip *t)
  {
  	git__free(t->name);
  	git__free(t);
  }
  
  void push_status_free(push_status *s)
  {
  	git__free(s->ref);
  	git__free(s->msg);
  	git__free(s);
  }
  
  void record_callbacks_data_clear(record_callbacks_data *data)
  {
  	size_t i;
  	updated_tip *tip;
  	push_status *status;
  
  	git_vector_foreach(&data->updated_tips, i, tip)
  		updated_tip_free(tip);
  
  	git_vector_free(&data->updated_tips);
  
  	git_vector_foreach(&data->statuses, i, status)
  		push_status_free(status);
  
  	git_vector_free(&data->statuses);
  
  	data->pack_progress_calls = 0;
  	data->transfer_progress_calls = 0;
  }
  
  int record_update_tips_cb(const char *refname, const git_oid *a, const git_oid *b, void *data)
  {
  	updated_tip *t;
  	record_callbacks_data *record_data = (record_callbacks_data *)data;
  
  	cl_assert(t = git__calloc(1, sizeof(*t)));
  
  	cl_assert(t->name = git__strdup(refname));
  	git_oid_cpy(&t->old_oid, a);
  	git_oid_cpy(&t->new_oid, b);
  
  	git_vector_insert(&record_data->updated_tips, t);
  
  	return 0;
  }
  
  int create_deletion_refspecs(git_vector *out, const git_remote_head **heads, size_t heads_len)
  {
  	git_str del_spec = GIT_STR_INIT;
  	int valid;
  	size_t i;
  
  	for (i = 0; i < heads_len; i++) {
  		const git_remote_head *head = heads[i];
  		/* Ignore malformed ref names (which also saves us from tag^{} */
  		cl_git_pass(git_reference_name_is_valid(&valid, head->name));
  		if (!valid)
  			return 0;
  
  		/* Create a refspec that deletes a branch in the remote */
  		if (strcmp(head->name, "refs/heads/master")) {
  			cl_git_pass(git_str_putc(&del_spec, ':'));
  			cl_git_pass(git_str_puts(&del_spec, head->name));
  			cl_git_pass(git_vector_insert(out, git_str_detach(&del_spec)));
  		}
  	}
  
  	return 0;
  }
  
  int record_ref_cb(git_remote_head *head, void *payload)
  {
  	git_vector *refs = (git_vector *) payload;
  	return git_vector_insert(refs, head);
  }
  
  void verify_remote_refs(const git_remote_head *actual_refs[], size_t actual_refs_len, const expected_ref expected_refs[], size_t expected_refs_len)
  {
  	size_t i, j = 0;
  	git_str msg = GIT_STR_INIT;
  	const git_remote_head *actual;
  	char *oid_str;
  	bool master_present = false;
  
  	/* We don't care whether "master" is present on the other end or not */
  	for (i = 0; i < actual_refs_len; i++) {
  		actual = actual_refs[i];
  		if (!strcmp(actual->name, "refs/heads/master")) {
  			master_present = true;
  			break;
  		}
  	}
  
  	if (expected_refs_len + (master_present ? 1 : 0) != actual_refs_len)
  		goto failed;
  
  	for (i = 0; i < actual_refs_len; i++) {
  		actual = actual_refs[i];
  		if (master_present && !strcmp(actual->name, "refs/heads/master"))
  			continue;
  
  		if (strcmp(expected_refs[j].name, actual->name) ||
  			git_oid_cmp(expected_refs[j].oid, &actual->oid))
  			goto failed;
  
  		j++;
  	}
  
  	return;
  
  failed:
  	git_str_puts(&msg, "Expected and actual refs differ:\nEXPECTED:\n");
  
  	for(i = 0; i < expected_refs_len; i++) {
  		oid_str = git_oid_tostr_s(expected_refs[i].oid);
  		cl_git_pass(git_str_printf(&msg, "%s = %s\n", expected_refs[i].name, oid_str));
  	}
  
  	git_str_puts(&msg, "\nACTUAL:\n");
  	for (i = 0; i < actual_refs_len; i++) {
  		actual = actual_refs[i];
  		if (master_present && !strcmp(actual->name, "refs/heads/master"))
  			continue;
  
  		oid_str = git_oid_tostr_s(&actual->oid);
  		cl_git_pass(git_str_printf(&msg, "%s = %s\n", actual->name, oid_str));
  	}
  
  	cl_fail(git_str_cstr(&msg));
  
  	git_str_dispose(&msg);
  }
  

Download