thodg/libgit2/tests/diff/notify.c
-
Show log
Commit
-
Hash : 25e0b157
Author :
Date : 2013-12-06T15:07:57
Remove converting user error to GIT_EUSER This changes the behavior of callbacks so that the callback error code is not converted into GIT_EUSER and instead we propagate the return value through to the caller. Instead of using the giterr_capture and giterr_restore functions, we now rely on all functions to pass back the return value from a callback. To avoid having a return value with no error message, the user can call the public giterr_set_str or some such function to set an error message. There is a new helper 'giterr_set_callback' that functions can invoke after making a callback which ensures that some error message was set in case the callback did not set one. In places where the sign of the callback return value is meaningful (e.g. positive to skip, negative to abort), only the negative values are returned back to the caller, obviously, since the other values allow for continuing the loop. The hardest parts of this were in the checkout code where positive return values were overloaded as meaningful values for checkout. I fixed this by adding an output parameter to many of the internal checkout functions and removing the overload. This added some code, but it is probably a better implementation. There is some funkiness in the network code where user provided callbacks could be returning a positive or a negative value and we want to rely on that to cancel the loop. There are still a couple places where an user error might get turned into GIT_EUSER there, I think, though none exercised by the tests.
-
tests/diff/notify.c
-
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228
#include "clar_libgit2.h" #include "diff_helpers.h" static git_repository *g_repo = NULL; void test_diff_notify__initialize(void) { } void test_diff_notify__cleanup(void) { cl_git_sandbox_cleanup(); } static int assert_called_notifications( const git_diff *diff_so_far, const git_diff_delta *delta_to_add, const char *matched_pathspec, void *payload) { bool found = false; notify_expected *exp = (notify_expected*)payload; notify_expected *e; GIT_UNUSED(diff_so_far); for (e = exp; e->path != NULL; e++) { if (strcmp(e->path, delta_to_add->new_file.path)) continue; cl_assert_equal_s(e->matched_pathspec, matched_pathspec); found = true; break; } cl_assert(found); return 0; } static void test_notify( char **searched_pathspecs, int pathspecs_count, notify_expected *expected_matched_pathspecs, int expected_diffed_files_count) { git_diff_options opts = GIT_DIFF_OPTIONS_INIT; git_diff *diff = NULL; diff_expects exp; g_repo = cl_git_sandbox_init("status"); opts.flags |= GIT_DIFF_INCLUDE_IGNORED | GIT_DIFF_INCLUDE_UNTRACKED; opts.notify_cb = assert_called_notifications; opts.pathspec.strings = searched_pathspecs; opts.pathspec.count = pathspecs_count; opts.notify_payload = expected_matched_pathspecs; memset(&exp, 0, sizeof(exp)); cl_git_pass(git_diff_index_to_workdir(&diff, g_repo, NULL, &opts)); cl_git_pass(git_diff_foreach(diff, diff_file_cb, NULL, NULL, &exp)); cl_assert_equal_i(expected_diffed_files_count, exp.files); git_diff_free(diff); } void test_diff_notify__notify_single_pathspec(void) { char *searched_pathspecs[] = { "*_deleted", }; notify_expected expected_matched_pathspecs[] = { { "file_deleted", "*_deleted" }, { "staged_changes_file_deleted", "*_deleted" }, { NULL, NULL } }; test_notify(searched_pathspecs, 1, expected_matched_pathspecs, 2); } void test_diff_notify__notify_multiple_pathspec(void) { char *searched_pathspecs[] = { "staged_changes_cant_find_me", "subdir/modified_cant_find_me", "subdir/*", "staged*" }; notify_expected expected_matched_pathspecs[] = { { "staged_changes_file_deleted", "staged*" }, { "staged_changes_modified_file", "staged*" }, { "staged_delete_modified_file", "staged*" }, { "staged_new_file_deleted_file", "staged*" }, { "staged_new_file_modified_file", "staged*" }, { "subdir/deleted_file", "subdir/*" }, { "subdir/modified_file", "subdir/*" }, { "subdir/new_file", "subdir/*" }, { NULL, NULL } }; test_notify(searched_pathspecs, 4, expected_matched_pathspecs, 8); } void test_diff_notify__notify_catchall_with_empty_pathspecs(void) { char *searched_pathspecs[] = { "", "" }; notify_expected expected_matched_pathspecs[] = { { "file_deleted", NULL }, { "ignored_file", NULL }, { "modified_file", NULL }, { "new_file", NULL }, { "\xe8\xbf\x99", NULL }, { "staged_changes_file_deleted", NULL }, { "staged_changes_modified_file", NULL }, { "staged_delete_modified_file", NULL }, { "staged_new_file_deleted_file", NULL }, { "staged_new_file_modified_file", NULL }, { "subdir/deleted_file", NULL }, { "subdir/modified_file", NULL }, { "subdir/new_file", NULL }, { NULL, NULL } }; test_notify(searched_pathspecs, 1, expected_matched_pathspecs, 13); } void test_diff_notify__notify_catchall(void) { char *searched_pathspecs[] = { "*", }; notify_expected expected_matched_pathspecs[] = { { "file_deleted", "*" }, { "ignored_file", "*" }, { "modified_file", "*" }, { "new_file", "*" }, { "\xe8\xbf\x99", "*" }, { "staged_changes_file_deleted", "*" }, { "staged_changes_modified_file", "*" }, { "staged_delete_modified_file", "*" }, { "staged_new_file_deleted_file", "*" }, { "staged_new_file_modified_file", "*" }, { "subdir/deleted_file", "*" }, { "subdir/modified_file", "*" }, { "subdir/new_file", "*" }, { NULL, NULL } }; test_notify(searched_pathspecs, 1, expected_matched_pathspecs, 13); } static int abort_diff( const git_diff *diff_so_far, const git_diff_delta *delta_to_add, const char *matched_pathspec, void *payload) { GIT_UNUSED(diff_so_far); GIT_UNUSED(delta_to_add); GIT_UNUSED(matched_pathspec); GIT_UNUSED(payload); return -42; } void test_diff_notify__notify_cb_can_abort_diff(void) { git_diff_options opts = GIT_DIFF_OPTIONS_INIT; git_diff *diff = NULL; char *pathspec = NULL; g_repo = cl_git_sandbox_init("status"); opts.flags |= GIT_DIFF_INCLUDE_IGNORED | GIT_DIFF_INCLUDE_UNTRACKED; opts.notify_cb = abort_diff; opts.pathspec.strings = &pathspec; opts.pathspec.count = 1; pathspec = "file_deleted"; cl_git_fail(git_diff_index_to_workdir(&diff, g_repo, NULL, &opts)); pathspec = "staged_changes_modified_file"; cl_git_fail(git_diff_index_to_workdir(&diff, g_repo, NULL, &opts)); } static int filter_all( const git_diff *diff_so_far, const git_diff_delta *delta_to_add, const char *matched_pathspec, void *payload) { GIT_UNUSED(diff_so_far); GIT_UNUSED(delta_to_add); GIT_UNUSED(matched_pathspec); GIT_UNUSED(payload); return 42; } void test_diff_notify__notify_cb_can_be_used_as_filtering_function(void) { git_diff_options opts = GIT_DIFF_OPTIONS_INIT; git_diff *diff = NULL; char *pathspec = NULL; diff_expects exp; g_repo = cl_git_sandbox_init("status"); opts.flags |= GIT_DIFF_INCLUDE_IGNORED | GIT_DIFF_INCLUDE_UNTRACKED; opts.notify_cb = filter_all; opts.pathspec.strings = &pathspec; opts.pathspec.count = 1; pathspec = "*_deleted"; memset(&exp, 0, sizeof(exp)); cl_git_pass(git_diff_index_to_workdir(&diff, g_repo, NULL, &opts)); cl_git_pass(git_diff_foreach(diff, diff_file_cb, NULL, NULL, &exp)); cl_assert_equal_i(0, exp.files); git_diff_free(diff); }