thodg/libgit2/tests/core/integer.c

• Show log

  Commit

• Hash : 5ab0736b
  Author :
  Date : 2020-12-19T09:30:26
  

  Add tests for `git__multiply_int64_overflow` As it turns out, the implementation of `git__multiply_int64_overflow` is full of edge cases and tricky arithmetic. That means that it should have unit tests. As a result, a bug in `git__strntol64` was found (and fixed!) in clang+32-bit.

Download

• tests/core/integer.c

• #include "clar_libgit2.h"
  
  void test_core_integer__multiply_int64_no_overflow(void)
  {
  #if !defined(git__multiply_int64_overflow)
  	int64_t result = 0;
  	cl_assert(!git__multiply_int64_overflow(&result, 0x0ll, 0x0ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x0ll, 0x1ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x0ll, -0x1ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x0ll, 0x2ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x0ll, -0x2ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x0ll, 0x7ffffffffffffffll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x0ll, -0x7ffffffffffffffll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x0ll, 0x800000000000000ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x0ll, -0x800000000000000ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x0ll, 0x7fffffffffffffffll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x0ll, -0x7fffffffffffffffll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x0ll, -0x8000000000000000ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x1ll, 0x0ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x1ll, 0x1ll));
  	cl_assert_equal_i(result, 0x1ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x1ll, -0x1ll));
  	cl_assert_equal_i(result, -0x1ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x1ll, 0x2ll));
  	cl_assert_equal_i(result, 0x2ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x1ll, -0x2ll));
  	cl_assert_equal_i(result, -0x2ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x1ll, 0x7ffffffffffffffll));
  	cl_assert_equal_i(result, 0x7ffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x1ll, -0x7ffffffffffffffll));
  	cl_assert_equal_i(result, -0x7ffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x1ll, 0x800000000000000ll));
  	cl_assert_equal_i(result, 0x800000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x1ll, -0x800000000000000ll));
  	cl_assert_equal_i(result, -0x800000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x1ll, 0x7fffffffffffffffll));
  	cl_assert_equal_i(result, 0x7fffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x1ll, -0x7fffffffffffffffll));
  	cl_assert_equal_i(result, -0x7fffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x1ll, 0x0ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x1ll, 0x1ll));
  	cl_assert_equal_i(result, -0x1ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x1ll, -0x1ll));
  	cl_assert_equal_i(result, 0x1ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x1ll, 0x2ll));
  	cl_assert_equal_i(result, -0x2ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x1ll, -0x2ll));
  	cl_assert_equal_i(result, 0x2ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x1ll, 0x7ffffffffffffffll));
  	cl_assert_equal_i(result, -0x7ffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x1ll, -0x7ffffffffffffffll));
  	cl_assert_equal_i(result, 0x7ffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x1ll, 0x800000000000000ll));
  	cl_assert_equal_i(result, -0x800000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x1ll, -0x800000000000000ll));
  	cl_assert_equal_i(result, 0x800000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x1ll, 0x7fffffffffffffffll));
  	cl_assert_equal_i(result, -0x7fffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x1ll, -0x7fffffffffffffffll));
  	cl_assert_equal_i(result, 0x7fffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x2ll, 0x0ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x2ll, 0x1ll));
  	cl_assert_equal_i(result, 0x2ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x2ll, -0x1ll));
  	cl_assert_equal_i(result, -0x2ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x2ll, 0x2ll));
  	cl_assert_equal_i(result, 0x4ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x2ll, -0x2ll));
  	cl_assert_equal_i(result, -0x4ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x2ll, 0x7ffffffffffffffll));
  	cl_assert_equal_i(result, 0xffffffffffffffell);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x2ll, -0x7ffffffffffffffll));
  	cl_assert_equal_i(result, -0xffffffffffffffell);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x2ll, 0x800000000000000ll));
  	cl_assert_equal_i(result, 0x1000000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x2ll, -0x800000000000000ll));
  	cl_assert_equal_i(result, -0x1000000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x2ll, 0x0ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x2ll, 0x1ll));
  	cl_assert_equal_i(result, -0x2ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x2ll, -0x1ll));
  	cl_assert_equal_i(result, 0x2ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x2ll, 0x2ll));
  	cl_assert_equal_i(result, -0x4ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x2ll, -0x2ll));
  	cl_assert_equal_i(result, 0x4ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x2ll, 0x7ffffffffffffffll));
  	cl_assert_equal_i(result, -0xffffffffffffffell);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x2ll, -0x7ffffffffffffffll));
  	cl_assert_equal_i(result, 0xffffffffffffffell);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x2ll, 0x800000000000000ll));
  	cl_assert_equal_i(result, -0x1000000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x2ll, -0x800000000000000ll));
  	cl_assert_equal_i(result, 0x1000000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x2ll, -0x4000000000000000ll));
  	cl_assert_equal_i(result, -0x8000000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x7ffffffffffffffll, 0x0ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x7ffffffffffffffll, 0x1ll));
  	cl_assert_equal_i(result, 0x7ffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x7ffffffffffffffll, -0x1ll));
  	cl_assert_equal_i(result, -0x7ffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x7ffffffffffffffll, 0x2ll));
  	cl_assert_equal_i(result, 0xffffffffffffffell);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x7ffffffffffffffll, -0x2ll));
  	cl_assert_equal_i(result, -0xffffffffffffffell);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x7ffffffffffffffll, 0x0ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x7ffffffffffffffll, 0x1ll));
  	cl_assert_equal_i(result, -0x7ffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x7ffffffffffffffll, -0x1ll));
  	cl_assert_equal_i(result, 0x7ffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x7ffffffffffffffll, 0x2ll));
  	cl_assert_equal_i(result, -0xffffffffffffffell);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x7ffffffffffffffll, -0x2ll));
  	cl_assert_equal_i(result, 0xffffffffffffffell);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x800000000000000ll, 0x0ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x800000000000000ll, 0x1ll));
  	cl_assert_equal_i(result, 0x800000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x800000000000000ll, -0x1ll));
  	cl_assert_equal_i(result, -0x800000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x800000000000000ll, 0x2ll));
  	cl_assert_equal_i(result, 0x1000000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x800000000000000ll, -0x2ll));
  	cl_assert_equal_i(result, -0x1000000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x800000000000000ll, 0x0ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x800000000000000ll, 0x1ll));
  	cl_assert_equal_i(result, -0x800000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x800000000000000ll, -0x1ll));
  	cl_assert_equal_i(result, 0x800000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x800000000000000ll, 0x2ll));
  	cl_assert_equal_i(result, -0x1000000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x800000000000000ll, -0x2ll));
  	cl_assert_equal_i(result, 0x1000000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x7fffffffffffffffll, 0x0ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x7fffffffffffffffll, 0x1ll));
  	cl_assert_equal_i(result, 0x7fffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, 0x7fffffffffffffffll, -0x1ll));
  	cl_assert_equal_i(result, -0x7fffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x4000000000000000ll, 0x2ll));
  	cl_assert_equal_i(result, -0x8000000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x7fffffffffffffffll, 0x0ll));
  	cl_assert_equal_i(result, 0x0ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x7fffffffffffffffll, 0x1ll));
  	cl_assert_equal_i(result, -0x7fffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x7fffffffffffffffll, -0x1ll));
  	cl_assert_equal_i(result, 0x7fffffffffffffffll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x8000000000000000ll, 0x0ll));
  	cl_assert_equal_i(result, 0x0ll);
  #endif
  }
  
  void test_core_integer__multiply_int64_overflow(void)
  {
  #if !defined(git__multiply_int64_overflow)
  	int64_t result = 0;
  	cl_assert(git__multiply_int64_overflow(&result, 0x2ll, 0x4000000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x2ll, 0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x2ll, -0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x2ll, -0x8000000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x2ll, 0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x2ll, -0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x2ll, -0x8000000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7ffffffffffffffll, 0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7ffffffffffffffll, -0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7ffffffffffffffll, 0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7ffffffffffffffll, -0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7ffffffffffffffll, 0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7ffffffffffffffll, -0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7ffffffffffffffll, -0x8000000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7ffffffffffffffll, 0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7ffffffffffffffll, -0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7ffffffffffffffll, 0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7ffffffffffffffll, -0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7ffffffffffffffll, 0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7ffffffffffffffll, -0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7ffffffffffffffll, -0x8000000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x800000000000000ll, 0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x800000000000000ll, -0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x800000000000000ll, 0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x800000000000000ll, -0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x800000000000000ll, 0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x800000000000000ll, -0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x800000000000000ll, -0x8000000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x800000000000000ll, 0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x800000000000000ll, -0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x800000000000000ll, 0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x800000000000000ll, -0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x800000000000000ll, 0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x800000000000000ll, -0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x800000000000000ll, -0x8000000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x4000000000000000ll, 0x2ll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7fffffffffffffffll, 0x2ll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7fffffffffffffffll, -0x2ll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7fffffffffffffffll, 0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7fffffffffffffffll, -0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7fffffffffffffffll, 0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7fffffffffffffffll, -0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7fffffffffffffffll, 0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7fffffffffffffffll, -0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, 0x7fffffffffffffffll, -0x8000000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7fffffffffffffffll, 0x2ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7fffffffffffffffll, -0x2ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7fffffffffffffffll, 0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7fffffffffffffffll, -0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7fffffffffffffffll, 0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7fffffffffffffffll, -0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7fffffffffffffffll, 0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7fffffffffffffffll, -0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x7fffffffffffffffll, -0x8000000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x8000000000000000ll, 0x2ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x8000000000000000ll, -0x2ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x8000000000000000ll, 0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x8000000000000000ll, -0x7ffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x8000000000000000ll, 0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x8000000000000000ll, -0x800000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x8000000000000000ll, 0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x8000000000000000ll, -0x7fffffffffffffffll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x8000000000000000ll, -0x8000000000000000ll));
  #endif
  }
  
  void test_core_integer__multiply_int64_edge_cases(void)
  {
  #if !defined(git__multiply_int64_overflow)
  	int64_t result = 0;
  	cl_assert(!git__multiply_int64_overflow(&result, -0x8000000000000000ll, -0x1ll));
  	cl_assert_equal_i(result, -0x8000000000000000ll);
  	cl_assert(!git__multiply_int64_overflow(&result, -0x1ll, -0x8000000000000000ll));
  	cl_assert_equal_i(result, -0x8000000000000000ll);
  	cl_assert(git__multiply_int64_overflow(&result, 0x1ll, -0x8000000000000000ll));
  	cl_assert(git__multiply_int64_overflow(&result, -0x8000000000000000ll, 0x1ll));
  #endif
  }
  

Download