thodg/libgit2/tests/repo/setters.c

• Show log

  Commit

• Hash : f0e693b1
  Author :
  Date : 2021-09-07T17:53:49
  

  str: introduce `git_str` for internal, `git_buf` is external
  
  libgit2 has two distinct requirements that were previously solved by
  `git_buf`.  We require:
  
  1. A general purpose string class that provides a number of utility APIs
     for manipulating data (eg, concatenating, truncating, etc).
  2. A structure that we can use to return strings to callers that they
     can take ownership of.
  
  By using a single class (`git_buf`) for both of these purposes, we have
  confused the API to the point that refactorings are difficult and
  reasoning about correctness is also difficult.
  
  Move the utility class `git_buf` to be called `git_str`: this represents
  its general purpose, as an internal string buffer class.  The name also
  is an homage to Junio Hamano ("gitstr").
  
  The public API remains `git_buf`, and has a much smaller footprint.  It
  is generally only used as an "out" param with strict requirements that
  follow the documentation.  (Exceptions exist for some legacy APIs to
  avoid breaking callers unnecessarily.)
  
  Utility functions exist to convert a user-specified `git_buf` to a
  `git_str` so that we can call internal functions, then converting it
  back again.
  

Download

• tests/repo/setters.c

• #include "clar_libgit2.h"
  #include "git2/sys/repository.h"
  
  #include "posix.h"
  #include "util.h"
  #include "path.h"
  #include "futils.h"
  
  static git_repository *repo;
  
  void test_repo_setters__initialize(void)
  {
  	cl_fixture_sandbox("testrepo.git");
  	cl_git_pass(git_repository_open(&repo, "testrepo.git"));
  	cl_must_pass(p_mkdir("new_workdir", 0777));
  }
  
  void test_repo_setters__cleanup(void)
  {
  	git_repository_free(repo);
  	repo = NULL;
  
  	cl_fixture_cleanup("testrepo.git");
  	cl_fixture_cleanup("new_workdir");
  }
  
  void test_repo_setters__setting_a_workdir_turns_a_bare_repository_into_a_standard_one(void)
  {
  	cl_assert(git_repository_is_bare(repo) == 1);
  
  	cl_assert(git_repository_workdir(repo) == NULL);
  	cl_git_pass(git_repository_set_workdir(repo, "./new_workdir", false));
  
  	cl_assert(git_repository_workdir(repo) != NULL);
  	cl_assert(git_repository_is_bare(repo) == 0);
  }
  
  void test_repo_setters__setting_a_workdir_prettifies_its_path(void)
  {
  	cl_git_pass(git_repository_set_workdir(repo, "./new_workdir", false));
  
  	cl_assert(git__suffixcmp(git_repository_workdir(repo), "new_workdir/") == 0);
  }
  
  void test_repo_setters__setting_a_workdir_creates_a_gitlink(void)
  {
  	git_config *cfg;
  	git_buf buf = GIT_BUF_INIT;
  	git_str content = GIT_STR_INIT;
  
  	cl_git_pass(git_repository_set_workdir(repo, "./new_workdir", true));
  
  	cl_assert(git_path_isfile("./new_workdir/.git"));
  
  	cl_git_pass(git_futils_readbuffer(&content, "./new_workdir/.git"));
  	cl_assert(git__prefixcmp(git_str_cstr(&content), "gitdir: ") == 0);
  	cl_assert(git__suffixcmp(git_str_cstr(&content), "testrepo.git/") == 0);
  	git_str_dispose(&content);
  
  	cl_git_pass(git_repository_config(&cfg, repo));
  	cl_git_pass(git_config_get_string_buf(&buf, cfg, "core.worktree"));
  	cl_assert(git__suffixcmp(buf.ptr, "new_workdir/") == 0);
  
  	git_buf_dispose(&buf);
  	git_config_free(cfg);
  }
  
  void test_repo_setters__setting_a_new_index_on_a_repo_which_has_already_loaded_one_properly_honors_the_refcount(void)
  {
  	git_index *new_index;
  
  	cl_git_pass(git_index_open(&new_index, "./my-index"));
  	cl_assert(((git_refcount *)new_index)->refcount.val == 1);
  
  	git_repository_set_index(repo, new_index);
  	cl_assert(((git_refcount *)new_index)->refcount.val == 2);
  
  	git_repository_free(repo);
  	cl_assert(((git_refcount *)new_index)->refcount.val == 1);
  
  	git_index_free(new_index);
  
  	/*
  	 * Ensure the cleanup method won't try to free the repo as it's already been taken care of
  	 */
  	repo = NULL;
  }
  
  void test_repo_setters__setting_a_new_odb_on_a_repo_which_already_loaded_one_properly_honors_the_refcount(void)
  {
  	git_odb *new_odb;
  
  	cl_git_pass(git_odb_open(&new_odb, "./testrepo.git/objects"));
  	cl_assert(((git_refcount *)new_odb)->refcount.val == 1);
  
  	git_repository_set_odb(repo, new_odb);
  	cl_assert(((git_refcount *)new_odb)->refcount.val == 2);
  
  	git_repository_free(repo);
  	cl_assert(((git_refcount *)new_odb)->refcount.val == 1);
  
  	git_odb_free(new_odb);
  
  	/*
  	 * Ensure the cleanup method won't try to free the repo as it's already been taken care of
  	 */
  	repo = NULL;
  }
  

Download