thodg/libgit2/tests/config/conditionals.c

• Show log

  Commit

• Hash : 5811e3ba
  Author :
  Date : 2019-06-13T19:16:32
  

  config_file: use `wildmatch` to evaluate conditionals We currently use `p_fnmatch` to compute whether a given "gitdir:" or "gitdir/i:" conditional matches the current configuration file path. As git.git has moved to use `wildmatch` instead of `p_fnmatch` throughout its complete codebase, we evaluate conditionals inconsistently with git.git in some special cases. Convert `p_fnmatch` to use `wildmatch`. The `FNM_LEADINGDIR` flag cannot be translated to `wildmatch`, but in fact git.git doesn't use it here either. And in fact, dropping it while we go increases compatibility with git.git.

Download

• tests/config/conditionals.c

• #include "clar_libgit2.h"
  #include "buffer.h"
  #include "fileops.h"
  
  #ifdef GIT_WIN32
  # define ROOT_PREFIX "C:"
  #else
  # define ROOT_PREFIX
  #endif
  
  static git_repository *_repo;
  
  void test_config_conditionals__initialize(void)
  {
  	_repo = cl_git_sandbox_init("empty_standard_repo");
  }
  
  void test_config_conditionals__cleanup(void)
  {
  	cl_git_sandbox_cleanup();
  }
  
  static void assert_condition_includes(const char *keyword, const char *path, bool expected)
  {
  	git_config *cfg;
  	git_buf buf = GIT_BUF_INIT;
  
  	git_buf_printf(&buf, "[includeIf \"%s:%s\"]\n", keyword, path);
  	git_buf_puts(&buf, "path = other\n");
  
  	cl_git_mkfile("empty_standard_repo/.git/config", buf.ptr);
  	cl_git_mkfile("empty_standard_repo/.git/other", "[foo]\nbar=baz\n");
  	_repo = cl_git_sandbox_reopen();
  
  	cl_git_pass(git_repository_config(&cfg, _repo));
  
  	if (expected) {
  		git_buf_clear(&buf);
  		cl_git_pass(git_config_get_string_buf(&buf, cfg, "foo.bar"));
  		cl_assert_equal_s("baz", git_buf_cstr(&buf));
  	} else {
  		cl_git_fail_with(GIT_ENOTFOUND,
  				 git_config_get_string_buf(&buf, cfg, "foo.bar"));
  	}
  
  	git_buf_dispose(&buf);
  	git_config_free(cfg);
  }
  
  static char *sandbox_path(git_buf *buf, const char *suffix)
  {
  	char *path = p_realpath(clar_sandbox_path(), NULL);
  	cl_assert(path);
  	cl_git_pass(git_buf_attach(buf, path, 0));
  	cl_git_pass(git_buf_joinpath(buf, buf->ptr, suffix));
  	return buf->ptr;
  }
  
  void test_config_conditionals__gitdir(void)
  {
  	git_buf path = GIT_BUF_INIT;
  
  	assert_condition_includes("gitdir", ROOT_PREFIX "/", true);
  	assert_condition_includes("gitdir", "empty_stand", false);
  	assert_condition_includes("gitdir", "empty_stand/", false);
  	assert_condition_includes("gitdir", "empty_stand/.git", false);
  	assert_condition_includes("gitdir", "empty_stand/.git/", false);
  	assert_condition_includes("gitdir", "empty_stand*/", true);
  	assert_condition_includes("gitdir", "empty_stand*/.git", true);
  	assert_condition_includes("gitdir", "empty_stand*/.git/", false);
  	assert_condition_includes("gitdir", "empty_standard_repo", false);
  	assert_condition_includes("gitdir", "empty_standard_repo/", true);
  	assert_condition_includes("gitdir", "empty_standard_repo/.git", true);
  	assert_condition_includes("gitdir", "empty_standard_repo/.git/", false);
  
  	assert_condition_includes("gitdir", "./", false);
  
  	assert_condition_includes("gitdir", ROOT_PREFIX "/nonexistent", false);
  	assert_condition_includes("gitdir", ROOT_PREFIX "/empty_standard_repo", false);
  	assert_condition_includes("gitdir", "~/empty_standard_repo", false);
  
  	assert_condition_includes("gitdir", sandbox_path(&path, "/"), true);
  	assert_condition_includes("gitdir", sandbox_path(&path, "/*"), false);
  	assert_condition_includes("gitdir", sandbox_path(&path, "/**"), true);
  
  	assert_condition_includes("gitdir", sandbox_path(&path, "empty_standard_repo"), false);
  	assert_condition_includes("gitdir", sandbox_path(&path, "empty_standard_repo/"), true);
  	assert_condition_includes("gitdir", sandbox_path(&path, "empty_standard_repo/"), true);
  	assert_condition_includes("gitdir", sandbox_path(&path, "Empty_Standard_Repo"), false);
  	assert_condition_includes("gitdir", sandbox_path(&path, "Empty_Standard_Repo/"), false);
  
  	git_buf_dispose(&path);
  }
  
  void test_config_conditionals__gitdir_i(void)
  {
  	git_buf path = GIT_BUF_INIT;
  
  	assert_condition_includes("gitdir/i", sandbox_path(&path, "empty_standard_repo/"), true);
  	assert_condition_includes("gitdir/i", sandbox_path(&path, "EMPTY_STANDARD_REPO/"), true);
  
  	git_buf_dispose(&path);
  }
  
  void test_config_conditionals__invalid_conditional_fails(void)
  {
  	assert_condition_includes("foobar", ".git", false);
  }
  

Download