thodg/libgit2/tests/refs/peel.c

• Show log

  Commit

• Hash : cda18f9b
  Author :
  Date : 2017-10-06T11:24:11
  

  refs: do not use peeled OID if peeling to a tag If a reference stored in a packed-refs file does not directly point to a commit, tree or blob, the packed-refs file will also will include a fully-peeled OID pointing to the first underlying object of that type. If we try to peel a reference to an object, we will use that peeled OID to speed up resolving the object. As a reference for an annotated tag does not directly point to a commit, tree or blob but instead to the tag object, the packed-refs file will have an accomodating fully-peeled OID pointing to the object referenced by that tag. When we use the fully-peeled OID pointing to the referenced object when peeling, we obviously cannot peel that to the tag anymore. Fix this issue by not using the fully-peeled OID whenever we want to peel to a tag. Note that this does not include the case where we want to resolve to _any_ object type. Existing code may make use from the fact that we resolve those to commit objects instead of tag objects, even though that behaviour is inconsistent between packed and loose references. Furthermore, some tests of ours make the assumption that we in fact resolve those references to a commit.

Download

• tests/refs/peel.c

• #include "clar_libgit2.h"
  
  static git_repository *g_repo;
  static git_repository *g_peel_repo;
  
  void test_refs_peel__initialize(void)
  {
  	cl_git_pass(git_repository_open(&g_repo, cl_fixture("testrepo.git")));
  	cl_git_pass(git_repository_open(&g_peel_repo, cl_fixture("peeled.git")));
  }
  
  void test_refs_peel__cleanup(void)
  {
  	git_repository_free(g_repo);
  	g_repo = NULL;
  	git_repository_free(g_peel_repo);
  	g_peel_repo = NULL;
  }
  
  static void assert_peel_generic(
  	git_repository *repo,
  	const char *ref_name,
  	git_otype requested_type,
  	const char* expected_sha,
  	git_otype expected_type)
  {
  	git_oid expected_oid;
  	git_reference *ref;
  	git_object *peeled;
  
  	cl_git_pass(git_reference_lookup(&ref, repo, ref_name));
  	
  	cl_git_pass(git_reference_peel(&peeled, ref, requested_type));
  
  	cl_git_pass(git_oid_fromstr(&expected_oid, expected_sha));
  	cl_assert_equal_oid(&expected_oid, git_object_id(peeled));
  
  	cl_assert_equal_i(expected_type, git_object_type(peeled));
  
  	git_object_free(peeled);
  	git_reference_free(ref);
  }
  
  static void assert_peel(
  	const char *ref_name,
  	git_otype requested_type,
  	const char* expected_sha,
  	git_otype expected_type)
  {
  	assert_peel_generic(g_repo, ref_name, requested_type,
  			    expected_sha, expected_type);
  }
  
  static void assert_peel_error(int error, const char *ref_name, git_otype requested_type)
  {
  	git_reference *ref;
  	git_object *peeled;
  
  	cl_git_pass(git_reference_lookup(&ref, g_repo, ref_name));
  	
  	cl_assert_equal_i(error, git_reference_peel(&peeled, ref, requested_type));
  
  	git_reference_free(ref);
  }
  
  void test_refs_peel__can_peel_a_tag(void)
  {
  	assert_peel("refs/tags/test", GIT_OBJ_TAG,
  		"b25fa35b38051e4ae45d4222e795f9df2e43f1d1", GIT_OBJ_TAG);
  	assert_peel("refs/tags/test", GIT_OBJ_COMMIT,
  		"e90810b8df3e80c413d903f631643c716887138d", GIT_OBJ_COMMIT);
  	assert_peel("refs/tags/test", GIT_OBJ_TREE,
  		"53fc32d17276939fc79ed05badaef2db09990016", GIT_OBJ_TREE);
  	assert_peel("refs/tags/point_to_blob", GIT_OBJ_BLOB,
  		"1385f264afb75a56a5bec74243be9b367ba4ca08", GIT_OBJ_BLOB);
  }
  
  void test_refs_peel__can_peel_a_branch(void)
  {
  	assert_peel("refs/heads/master", GIT_OBJ_COMMIT,
  		"a65fedf39aefe402d3bb6e24df4d4f5fe4547750", GIT_OBJ_COMMIT);
  	assert_peel("refs/heads/master", GIT_OBJ_TREE,
  		"944c0f6e4dfa41595e6eb3ceecdb14f50fe18162", GIT_OBJ_TREE);
  }
  
  void test_refs_peel__can_peel_a_symbolic_reference(void)
  {
  	assert_peel("HEAD", GIT_OBJ_COMMIT,
  		"a65fedf39aefe402d3bb6e24df4d4f5fe4547750", GIT_OBJ_COMMIT);
  	assert_peel("HEAD", GIT_OBJ_TREE,
  		"944c0f6e4dfa41595e6eb3ceecdb14f50fe18162", GIT_OBJ_TREE);
  }
  
  void test_refs_peel__cannot_peel_into_a_non_existing_target(void)
  {
  	assert_peel_error(GIT_EINVALIDSPEC, "refs/tags/point_to_blob", GIT_OBJ_TAG);
  }
  
  void test_refs_peel__can_peel_into_any_non_tag_object(void)
  {
  	assert_peel("refs/heads/master", GIT_OBJ_ANY,
  		"a65fedf39aefe402d3bb6e24df4d4f5fe4547750", GIT_OBJ_COMMIT);
  	assert_peel("refs/tags/point_to_blob", GIT_OBJ_ANY,
  		"1385f264afb75a56a5bec74243be9b367ba4ca08", GIT_OBJ_BLOB);
  	assert_peel("refs/tags/test", GIT_OBJ_ANY,
  		"e90810b8df3e80c413d903f631643c716887138d", GIT_OBJ_COMMIT);
  }
  
  void test_refs_peel__can_peel_fully_peeled_packed_refs(void)
  {
  	assert_peel_generic(g_peel_repo,
  			    "refs/tags/tag-inside-tags", GIT_OBJ_ANY,
  			    "0df1a5865c8abfc09f1f2182e6a31be550e99f07",
  			    GIT_OBJ_COMMIT);
  	assert_peel_generic(g_peel_repo,
  			    "refs/foo/tag-outside-tags", GIT_OBJ_ANY,
  			    "0df1a5865c8abfc09f1f2182e6a31be550e99f07",
  			    GIT_OBJ_COMMIT);
  }
  
  void test_refs_peel__can_peel_fully_peeled_tag_to_tag(void)
  {
  	assert_peel_generic(g_peel_repo,
  			    "refs/tags/tag-inside-tags", GIT_OBJ_TAG,
  			    "c2596aa0151888587ec5c0187f261e63412d9e11",
  			    GIT_OBJ_TAG);
  	assert_peel_generic(g_peel_repo,
  			    "refs/foo/tag-outside-tags", GIT_OBJ_TAG,
  			    "c2596aa0151888587ec5c0187f261e63412d9e11",
  			    GIT_OBJ_TAG);
  }
  

Download