thodg/libgit2/tests/network/redirect.c

• Show log

  Commit

• Hash : c6ab183e
  Author :
  Date : 2019-03-11T11:43:08
  

  net: rename gitno_connection_data to git_net_url "Connection data" is an imprecise and largely incorrect name; these structures are actually parsed URLs. Provide a parser that takes a URL string and produces a URL structure (if it is valid). Separate the HTTP redirect handling logic from URL parsing, keeping a `gitno_connection_data_handle_redirect` whose only job is redirect handling logic and does not parse URLs itself.

Download

• tests/network/redirect.c

• #include "clar_libgit2.h"
  #include "net.h"
  #include "netops.h"
  
  static git_net_url conndata;
  
  void test_network_redirect__initialize(void)
  {
  	memset(&conndata, 0, sizeof(conndata));
  }
  
  void test_network_redirect__cleanup(void)
  {
  	git_net_url_dispose(&conndata);
  }
  
  void test_network_redirect__redirect_http(void)
  {
  	cl_git_pass(git_net_url_parse(&conndata,
  				"http://example.com/foo/bar/baz"));
  	cl_git_pass(gitno_connection_data_handle_redirect(&conndata,
  				"http://example.com/foo/bar/baz", "bar/baz"));
  	cl_assert_equal_s(conndata.scheme, "http");
  	cl_assert_equal_s(conndata.host, "example.com");
  	cl_assert_equal_s(conndata.port, "80");
  	cl_assert_equal_s(conndata.path, "/foo/");
  	cl_assert_equal_p(conndata.username, NULL);
  	cl_assert_equal_p(conndata.password, NULL);
  }
  
  void test_network_redirect__redirect_ssl(void)
  {
  	cl_git_pass(git_net_url_parse(&conndata,
  				"https://example.com/foo/bar/baz"));
  	cl_git_pass(gitno_connection_data_handle_redirect(&conndata,
  				"https://example.com/foo/bar/baz", "bar/baz"));
  	cl_assert_equal_s(conndata.scheme, "https");
  	cl_assert_equal_s(conndata.host, "example.com");
  	cl_assert_equal_s(conndata.port, "443");
  	cl_assert_equal_s(conndata.path, "/foo/");
  	cl_assert_equal_p(conndata.username, NULL);
  	cl_assert_equal_p(conndata.password, NULL);
  }
  
  void test_network_redirect__redirect_leaves_root_path(void)
  {
  	cl_git_pass(git_net_url_parse(&conndata,
  				"https://example.com/foo/bar/baz"));
  	cl_git_pass(gitno_connection_data_handle_redirect(&conndata,
  				"https://example.com/foo/bar/baz", "/foo/bar/baz"));
  	cl_assert_equal_s(conndata.scheme, "https");
  	cl_assert_equal_s(conndata.host, "example.com");
  	cl_assert_equal_s(conndata.port, "443");
  	cl_assert_equal_s(conndata.path, "/");
  	cl_assert_equal_p(conndata.username, NULL);
  	cl_assert_equal_p(conndata.password, NULL);
  }
  
  void test_network_redirect__redirect_encoded_username_password(void)
  {
  	cl_git_pass(git_net_url_parse(&conndata,
  				"https://user%2fname:pass%40word%zyx%v@example.com/foo/bar/baz"));
  	cl_git_pass(gitno_connection_data_handle_redirect(&conndata,
  				"https://user%2fname:pass%40word%zyx%v@example.com/foo/bar/baz", "bar/baz"));
  	cl_assert_equal_s(conndata.scheme, "https");
  	cl_assert_equal_s(conndata.host, "example.com");
  	cl_assert_equal_s(conndata.port, "443");
  	cl_assert_equal_s(conndata.path, "/foo/");
  	cl_assert_equal_s(conndata.username, "user/name");
  	cl_assert_equal_s(conndata.password, "pass@word%zyx%v");
  }
  
  void test_network_redirect__redirect_cross_host_denied(void)
  {
  	cl_git_pass(git_net_url_parse(&conndata, "https://bar.com/bar/baz"));
  	cl_git_fail_with(gitno_connection_data_handle_redirect(&conndata,
  				"https://foo.com/bar/baz", NULL),
  			-1);
  }
  
  void test_network_redirect__redirect_http_downgrade_denied(void)
  {
  	cl_git_pass(git_net_url_parse(&conndata, "https://foo.com/bar/baz"));
  	cl_git_fail_with(gitno_connection_data_handle_redirect(&conndata,
  				"http://foo.com/bar/baz", NULL),
  			-1);
  }
  
  void test_network_redirect__redirect_relative(void)
  {
  	cl_git_pass(git_net_url_parse(&conndata, "http://foo.com/bar/baz/biff"));
  	cl_git_pass(gitno_connection_data_handle_redirect(&conndata,
  				"/zap/baz/biff?bam", NULL));
  	cl_assert_equal_s(conndata.scheme, "http");
  	cl_assert_equal_s(conndata.host, "foo.com");
  	cl_assert_equal_s(conndata.port, "80");
  	cl_assert_equal_s(conndata.path, "/zap/baz/biff?bam");
  	cl_assert_equal_p(conndata.username, NULL);
  	cl_assert_equal_p(conndata.password, NULL);
  }
  
  void test_network_redirect__redirect_relative_ssl(void)
  {
  	cl_git_pass(git_net_url_parse(&conndata, "https://foo.com/bar/baz/biff"));
  	cl_git_pass(gitno_connection_data_handle_redirect(&conndata,
  				"/zap/baz/biff?bam", NULL));
  	cl_assert_equal_s(conndata.scheme, "https");
  	cl_assert_equal_s(conndata.host, "foo.com");
  	cl_assert_equal_s(conndata.port, "443");
  	cl_assert_equal_s(conndata.path, "/zap/baz/biff?bam");
  	cl_assert_equal_p(conndata.username, NULL);
  	cl_assert_equal_p(conndata.password, NULL);
  }
  

Download