thodg/libgit2/tests-clar/core/env.c

• Show log

  Commit

• Hash : 56543a60
  Author :
  Date : 2013-02-15T16:02:45
  

  Clear up warnings from cppcheck The cppcheck static analyzer generates warnings for a bunch of places in the libgit2 code base. All the ones fixed in this commit are actually false positives, but I've reorganized the code to hopefully make it easier for static analysis tools to correctly understand the structure. I wouldn't do this if I felt like it was making the code harder to read or worse for humans, but in this case, these fixes don't seem too bad and will hopefully make it easier for better analysis tools to get at any real issues.

Download

• tests-clar/core/env.c

• #include "clar_libgit2.h"
  #include "fileops.h"
  #include "path.h"
  
  #ifdef GIT_WIN32
  #define NUM_VARS 5
  static const char *env_vars[NUM_VARS] = {
  	"HOME", "HOMEDRIVE", "HOMEPATH", "USERPROFILE", "PROGRAMFILES"
  };
  #else
  #define NUM_VARS 1
  static const char *env_vars[NUM_VARS] = { "HOME" };
  #endif
  
  static char *env_save[NUM_VARS];
  
  static char *home_values[] = {
  	"fake_home",
  	"f\xc3\xa1ke_h\xc3\xb5me", /* all in latin-1 supplement */
  	"f\xc4\x80ke_\xc4\xa4ome", /* latin extended */
  	"f\xce\xb1\xce\xba\xce\xb5_h\xce\xbfm\xce\xad",  /* having fun with greek */
  	"fa\xe0" "\xb8" "\x87" "e_\xe0" "\xb8" "\x99" "ome", /* thai characters */
  	"f\xe1\x9cx80ke_\xe1\x9c\x91ome", /* tagalog characters */
  	"\xe1\xb8\x9f\xe1\xba\xa2" "ke_ho" "\xe1" "\xb9" "\x81" "e", /* latin extended additional */
  	"\xf0\x9f\x98\x98\xf0\x9f\x98\x82", /* emoticons */
  	NULL
  };
  
  void test_core_env__initialize(void)
  {
  	int i;
  	for (i = 0; i < NUM_VARS; ++i)
  		env_save[i] = cl_getenv(env_vars[i]);
  }
  
  void test_core_env__cleanup(void)
  {
  	int i;
  	char **val;
  
  	for (i = 0; i < NUM_VARS; ++i) {
  		cl_setenv(env_vars[i], env_save[i]);
  #ifdef GIT_WIN32
  		git__free(env_save[i]);
  #endif
  		env_save[i] = NULL;
  	}
  
  	/* these will probably have already been cleaned up, but if a test
  	 * fails, then it's probably good to try and clear out these dirs
  	 */
  	for (val = home_values; *val != NULL; val++) {
  		if (**val != '\0')
  			(void)p_rmdir(*val);
  	}
  }
  
  static void setenv_and_check(const char *name, const char *value)
  {
  	char *check;
  
  	cl_git_pass(cl_setenv(name, value));
  	check = cl_getenv(name);
  	cl_assert_equal_s(value, check);
  #ifdef GIT_WIN32
  	git__free(check);
  #endif
  }
  
  void test_core_env__0(void)
  {
  	git_buf path = GIT_BUF_INIT, found = GIT_BUF_INIT;
  	char testfile[16], tidx = '0';
  	char **val;
  
  	memset(testfile, 0, sizeof(testfile));
  	cl_assert_equal_s("", testfile);
  
  	memcpy(testfile, "testfile", 8);
  	cl_assert_equal_s("testfile", testfile);
  
  	for (val = home_values; *val != NULL; val++) {
  
  		/* if we can't make the directory, let's just assume
  		 * we are on a filesystem that doesn't support the
  		 * characters in question and skip this test...
  		 */
  		if (p_mkdir(*val, 0777) != 0) {
  			*val = ""; /* mark as not created */
  			continue;
  		}
  
  		cl_git_pass(git_path_prettify(&path, *val, NULL));
  
  		/* vary testfile name in each directory so accidentally leaving
  		 * an environment variable set from a previous iteration won't
  		 * accidentally make this test pass...
  		 */
  		testfile[8] = tidx++;
  		cl_git_pass(git_buf_joinpath(&path, path.ptr, testfile));
  		cl_git_mkfile(path.ptr, "find me");
  		git_buf_rtruncate_at_char(&path, '/');
  
  		cl_assert_equal_i(
  			GIT_ENOTFOUND, git_futils_find_global_file(&found, testfile));
  
  		setenv_and_check("HOME", path.ptr);
  		cl_git_pass(git_futils_find_global_file(&found, testfile));
  
  		cl_setenv("HOME", env_save[0]);
  		cl_assert_equal_i(
  			GIT_ENOTFOUND, git_futils_find_global_file(&found, testfile));
  
  #ifdef GIT_WIN32
  		setenv_and_check("HOMEDRIVE", NULL);
  		setenv_and_check("HOMEPATH", NULL);
  		setenv_and_check("USERPROFILE", path.ptr);
  
  		cl_git_pass(git_futils_find_global_file(&found, testfile));
  
  		{
  			int root = git_path_root(path.ptr);
  			char old;
  
  			if (root >= 0) {
  				setenv_and_check("USERPROFILE", NULL);
  
  				cl_assert_equal_i(
  					GIT_ENOTFOUND, git_futils_find_global_file(&found, testfile));
  
  				old = path.ptr[root];
  				path.ptr[root] = '\0';
  				setenv_and_check("HOMEDRIVE", path.ptr);
  				path.ptr[root] = old;
  				setenv_and_check("HOMEPATH", &path.ptr[root]);
  
  				cl_git_pass(git_futils_find_global_file(&found, testfile));
  			}
  		}
  #endif
  
  		(void)p_rmdir(*val);
  	}
  
  	git_buf_free(&path);
  	git_buf_free(&found);
  }
  
  void test_core_env__1(void)
  {
  	git_buf path = GIT_BUF_INIT;
  
  	cl_assert_equal_i(
  		GIT_ENOTFOUND, git_futils_find_global_file(&path, "nonexistentfile"));
  
  	cl_git_pass(cl_setenv("HOME", "doesnotexist"));
  #ifdef GIT_WIN32
  	cl_git_pass(cl_setenv("HOMEPATH", "doesnotexist"));
  	cl_git_pass(cl_setenv("USERPROFILE", "doesnotexist"));
  #endif
  
  	cl_assert_equal_i(
  		GIT_ENOTFOUND, git_futils_find_global_file(&path, "nonexistentfile"));
  
  	cl_git_pass(cl_setenv("HOME", NULL));
  #ifdef GIT_WIN32
  	cl_git_pass(cl_setenv("HOMEPATH", NULL));
  	cl_git_pass(cl_setenv("USERPROFILE", NULL));
  #endif
  
  	cl_assert_equal_i(
  		GIT_ENOTFOUND, git_futils_find_global_file(&path, "nonexistentfile"));
  
  	cl_assert_equal_i(
  		GIT_ENOTFOUND, git_futils_find_system_file(&path, "nonexistentfile"));
  
  #ifdef GIT_WIN32
  	cl_git_pass(cl_setenv("PROGRAMFILES", NULL));
  	cl_assert_equal_i(
  		GIT_ENOTFOUND, git_futils_find_system_file(&path, "nonexistentfile"));
  #endif
  
  	git_buf_free(&path);
  }
  

Download