Hash :
f0e693b1
Author :
Date :
2021-09-07T17:53:49
str: introduce `git_str` for internal, `git_buf` is external libgit2 has two distinct requirements that were previously solved by `git_buf`. We require: 1. A general purpose string class that provides a number of utility APIs for manipulating data (eg, concatenating, truncating, etc). 2. A structure that we can use to return strings to callers that they can take ownership of. By using a single class (`git_buf`) for both of these purposes, we have confused the API to the point that refactorings are difficult and reasoning about correctness is also difficult. Move the utility class `git_buf` to be called `git_str`: this represents its general purpose, as an internal string buffer class. The name also is an homage to Junio Hamano ("gitstr"). The public API remains `git_buf`, and has a much smaller footprint. It is generally only used as an "out" param with strict requirements that follow the documentation. (Exceptions exist for some legacy APIs to avoid breaking callers unnecessarily.) Utility functions exist to convert a user-specified `git_buf` to a `git_str` so that we can call internal functions, then converting it back again.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176
{
libgit2-git-error-set-buffer
Memcheck:Leak
...
fun:git__realloc
fun:git_str_try_grow
fun:git_str_grow
fun:git_str_vprintf
fun:git_error_set
}
{
mac-setenv-leak-1
Memcheck:Leak
fun:malloc_zone_malloc
fun:__setenv
fun:setenv
}
{
mac-setenv-leak-2
Memcheck:Leak
fun:malloc_zone_malloc
fun:malloc_set_zone_name
...
fun:init__zone0
fun:setenv
}
{
mac-dyld-initializer-leak
Memcheck:Leak
fun:malloc
...
fun:dyld_register_image_state_change_handler
fun:_dyld_initializer
}
{
mac-tz-leak-1
Memcheck:Leak
...
fun:token_table_add
fun:notify_register_check
fun:notify_register_tz
}
{
mac-tz-leak-2
Memcheck:Leak
fun:malloc
fun:tzload
}
{
mac-tz-leak-3
Memcheck:Leak
fun:malloc
fun:tzsetwall_basic
}
{
mac-tz-leak-4
Memcheck:Leak
fun:malloc
fun:gmtsub
}
{
mac-system-init-leak-1
Memcheck:Leak
...
fun:_libxpc_initializer
fun:libSystem_initializer
}
{
mac-system-init-leak-2
Memcheck:Leak
...
fun:__keymgr_initializer
fun:libSystem_initializer
}
{
mac-puts-leak
Memcheck:Leak
fun:malloc
fun:__smakebuf
...
fun:puts
}
{
mac-ssl-uninitialized-1
Memcheck:Cond
obj:/usr/lib/libcrypto.0.9.8.dylib
...
fun:ssl23_connect
}
{
mac-ssl-uninitialized-2
Memcheck:Cond
...
obj:/usr/lib/libssl.0.9.8.dylib
...
fun:ssl23_connect
}
{
mac-ssl-uninitialized-3
Memcheck:Value8
obj:/usr/lib/libcrypto.0.9.8.dylib
...
fun:ssl23_connect
}
{
mac-ssl-leak-1
Memcheck:Leak
...
fun:ERR_load_strings
}
{
mac-ssl-leak-2
Memcheck:Leak
...
fun:SSL_library_init
}
{
mac-ssl-leak-3
Memcheck:Leak
...
fun:si_module_with_name
fun:getaddrinfo
}
{
mac-ssl-leak-4
Memcheck:Leak
fun:malloc
fun:CRYPTO_malloc
...
fun:ssl3_get_server_certificate
}
{
mac-ssl-leak-5
Memcheck:Leak
fun:malloc
fun:CRYPTO_malloc
...
fun:ERR_put_error
}
{
clar-printf-buf
Memcheck:Leak
fun:malloc
fun:__smakebuf
...
fun:printf
fun:clar_print_init
}
{
molo-1
Memcheck:Leak
fun:malloc_zone_malloc
...
fun:_objc_init
}
{
molo-2
Memcheck:Leak
fun:malloc_zone_calloc
...
fun:_objc_init
}
{
molo-3
Memcheck:Leak
fun:malloc
...
fun:_objc_init
}
{
molo-4
Memcheck:Leak
fun:malloc
...
fun:dyld_register_image_state_change_handler
}