thodg/libgit2/tests-clar/refs/unicode.c

• Show log

  Commit

• Hash : 92dac975
  Author :
  Date : 2013-10-08T16:35:57
  

  Make reference lookups apply precomposeunicode
  
  Before these changes, looking up a reference would return the
  same precomposed or decomposed form of the reference name that
  was used to look it up, so on MacOS which ignores the difference
  between the two, a single reference could be looked up either way
  and git_reference_name would return the form of the name that was
  used to look it up!  This change makes lookup always return the
  precomposed name if core.precomposeunicode is set regardless of
  which version was used to look it up.  The reference iterator was
  already returning the precomposed form from earlier work.
  
  This also updates the CMakeLists.txt rules for enabling iconv
  usage because the clar tests for this code were actually not being
  activated properly with the old version.
  
  Finally, this moves git_repository_reset_filesystem from include/
  git2/repository.h to include/git2/sys/repository.h since it is not
  really a function that normal library users should have to think
  about very often.
  

Download

• tests-clar/refs/unicode.c

• #include "clar_libgit2.h"
  
  static git_repository *repo;
  
  void test_refs_unicode__initialize(void)
  {
  	repo = cl_git_sandbox_init("testrepo.git");
  }
  
  void test_refs_unicode__cleanup(void)
  {
  	cl_git_sandbox_cleanup();
  	repo = NULL;
  }
  
  void test_refs_unicode__create_and_lookup(void)
  {
  	git_reference *ref0, *ref1, *ref2;
  	git_repository *repo2;
  
  	const char *REFNAME = "refs/heads/" "\303\205" "ngstr" "\303\266" "m";
  	const char *master = "refs/heads/master";
  
  	/* Create the reference */
  	cl_git_pass(git_reference_lookup(&ref0, repo, master));
  	cl_git_pass(git_reference_create(
  		&ref1, repo, REFNAME, git_reference_target(ref0), 0));
  	cl_assert_equal_s(REFNAME, git_reference_name(ref1));
  	git_reference_free(ref0);
  
  	/* Lookup the reference in a different instance of the repository */
  	cl_git_pass(git_repository_open(&repo2, "testrepo.git"));
  
  	cl_git_pass(git_reference_lookup(&ref2, repo2, REFNAME));
  	cl_assert_equal_i(
  		0, git_oid_cmp(git_reference_target(ref1), git_reference_target(ref2)));
  	cl_assert_equal_s(REFNAME, git_reference_name(ref2));
  	git_reference_free(ref2);
  
  #if GIT_USE_ICONV
  	/* Lookup reference by decomposed unicode name */
  
  #define REFNAME_DECOMPOSED "refs/heads/" "A" "\314\212" "ngstro" "\314\210" "m"
  
  	cl_git_pass(git_reference_lookup(&ref2, repo2, REFNAME_DECOMPOSED));
  	cl_assert_equal_i(
  		0, git_oid_cmp(git_reference_target(ref1), git_reference_target(ref2)));
  	cl_assert_equal_s(REFNAME, git_reference_name(ref2));
  	git_reference_free(ref2);
  #endif
  
  	/* Cleanup */
  
  	git_reference_free(ref1);
  	git_repository_free(repo2);
  }
  

Download