thodg/libgit2/tests/odb/loose.c

• Show log

  Commit

• Hash : 89499078
  Author :
  Date : 2014-03-10T10:53:39
  

  Fix a number of git_odb_exists_prefix bugs The git_odb_exists_prefix API was not dealing correctly when a later backend returned GIT_ENOTFOUND even if an earlier backend had found the object. Additionally, the unit tests were not properly exercising the API and had a couple mistakes in checking the results. Lastly, since the backends are not expected to behavior correctly unless all bytes of the short id are zero except for the prefix, this makes the ODB prefix APIs explicitly clear out the extra bytes so the user doesn't have to be as careful.

Download

• tests/odb/loose.c

• #include "clar_libgit2.h"
  #include "odb.h"
  #include "git2/odb_backend.h"
  #include "posix.h"
  #include "loose_data.h"
  
  #ifdef __ANDROID_API__
  # define S_IREAD        S_IRUSR
  # define S_IWRITE       S_IWUSR
  #endif
  
  static void write_object_files(object_data *d)
  {
  	int fd;
  
  	if (p_mkdir(d->dir, GIT_OBJECT_DIR_MODE) < 0)
  		cl_assert(errno == EEXIST);
  
  	cl_assert((fd = p_creat(d->file, S_IREAD | S_IWRITE)) >= 0);
  	cl_must_pass(p_write(fd, d->bytes, d->blen));
  
  	p_close(fd);
  }
  
  static void cmp_objects(git_rawobj *o, object_data *d)
  {
  	cl_assert(o->type == git_object_string2type(d->type));
  	cl_assert(o->len == d->dlen);
  
  	if (o->len > 0)
  		cl_assert(memcmp(o->data, d->data, o->len) == 0);
  }
  
  static void test_read_object(object_data *data)
  {
      git_oid id;
      git_odb_object *obj;
  	git_odb *odb;
  	git_rawobj tmp;
  
      write_object_files(data);
  
      cl_git_pass(git_odb_open(&odb, "test-objects"));
      cl_git_pass(git_oid_fromstr(&id, data->id));
      cl_git_pass(git_odb_read(&obj, odb, &id));
  
  	tmp.data = obj->buffer;
  	tmp.len = obj->cached.size;
  	tmp.type = obj->cached.type;
  
      cmp_objects(&tmp, data);
  
      git_odb_object_free(obj);
  	git_odb_free(odb);
  }
  
  void test_odb_loose__initialize(void)
  {
  	cl_must_pass(p_mkdir("test-objects", GIT_OBJECT_DIR_MODE));
  }
  
  void test_odb_loose__cleanup(void)
  {
  	cl_fixture_cleanup("test-objects");
  }
  
  void test_odb_loose__exists(void)
  {
  	git_oid id, id2;
  	git_odb *odb;
  
  	write_object_files(&one);
  	cl_git_pass(git_odb_open(&odb, "test-objects"));
  
  	cl_git_pass(git_oid_fromstr(&id, one.id));
  	cl_assert(git_odb_exists(odb, &id));
  
  	cl_git_pass(git_oid_fromstrp(&id, "8b137891"));
  	cl_git_pass(git_odb_exists_prefix(&id2, odb, &id, 8));
  	cl_assert_equal_i(0, git_oid_streq(&id2, one.id));
  
  	/* Test for a missing object */
  	cl_git_pass(git_oid_fromstr(&id, "8b137891791fe96927ad78e64b0aad7bded08baa"));
  	cl_assert(!git_odb_exists(odb, &id));
  
  	cl_git_pass(git_oid_fromstrp(&id, "8b13789a"));
  	cl_assert_equal_i(GIT_ENOTFOUND, git_odb_exists_prefix(&id2, odb, &id, 8));
  
  	git_odb_free(odb);
  }
  
  void test_odb_loose__simple_reads(void)
  {
  	test_read_object(&commit);
  	test_read_object(&tree);
  	test_read_object(&tag);
  	test_read_object(&zero);
  	test_read_object(&one);
  	test_read_object(&two);
  	test_read_object(&some);
  }
  
  void test_write_object_permission(
  	mode_t dir_mode, mode_t file_mode,
  	mode_t expected_dir_mode, mode_t expected_file_mode)
  {
  	git_odb *odb;
  	git_odb_backend *backend;
  	git_oid oid;
  	struct stat statbuf;
  	mode_t mask, os_mask;
  
  	/* Windows does not return group/user bits from stat,
  	* files are never executable.
  	*/
  #ifdef GIT_WIN32
  	os_mask = 0600;
  #else
  	os_mask = 0777;
  #endif
  
  	mask = p_umask(0);
  	p_umask(mask);
  
  	cl_git_pass(git_odb_new(&odb));
  	cl_git_pass(git_odb_backend_loose(&backend, "test-objects", -1, 0, dir_mode, file_mode));
  	cl_git_pass(git_odb_add_backend(odb, backend, 1));
  	cl_git_pass(git_odb_write(&oid, odb, "Test data\n", 10, GIT_OBJ_BLOB));
  
  	cl_git_pass(p_stat("test-objects/67", &statbuf));
  	cl_assert_equal_i(statbuf.st_mode & os_mask, (expected_dir_mode & ~mask) & os_mask);
  
  	cl_git_pass(p_stat("test-objects/67/b808feb36201507a77f85e6d898f0a2836e4a5", &statbuf));
  	cl_assert_equal_i(statbuf.st_mode & os_mask, (expected_file_mode & ~mask) & os_mask);
  
  	git_odb_free(odb);
  }
  
  void test_odb_loose__permissions_standard(void)
  {
  	test_write_object_permission(0, 0, GIT_OBJECT_DIR_MODE, GIT_OBJECT_FILE_MODE);
  }
  
  void test_odb_loose_permissions_readonly(void)
  {
  	test_write_object_permission(0777, 0444, 0777, 0444);
  }
  
  void test_odb_loose__permissions_readwrite(void)
  {
  	test_write_object_permission(0777, 0666, 0777, 0666);
  }
  

Download