thodg/libgit2/tests/object/lookup.c

• Show log

  Commit

• Hash : f0e693b1
  Author :
  Date : 2021-09-07T17:53:49
  

  str: introduce `git_str` for internal, `git_buf` is external
  
  libgit2 has two distinct requirements that were previously solved by
  `git_buf`.  We require:
  
  1. A general purpose string class that provides a number of utility APIs
     for manipulating data (eg, concatenating, truncating, etc).
  2. A structure that we can use to return strings to callers that they
     can take ownership of.
  
  By using a single class (`git_buf`) for both of these purposes, we have
  confused the API to the point that refactorings are difficult and
  reasoning about correctness is also difficult.
  
  Move the utility class `git_buf` to be called `git_str`: this represents
  its general purpose, as an internal string buffer class.  The name also
  is an homage to Junio Hamano ("gitstr").
  
  The public API remains `git_buf`, and has a much smaller footprint.  It
  is generally only used as an "out" param with strict requirements that
  follow the documentation.  (Exceptions exist for some legacy APIs to
  avoid breaking callers unnecessarily.)
  
  Utility functions exist to convert a user-specified `git_buf` to a
  `git_str` so that we can call internal functions, then converting it
  back again.
  

Download

• tests/object/lookup.c

• #include "clar_libgit2.h"
  
  #include "repository.h"
  
  static git_repository *g_repo;
  
  void test_object_lookup__initialize(void)
  {
  	g_repo = cl_git_sandbox_init("testrepo.git");
  }
  
  void test_object_lookup__cleanup(void)
  {
  	cl_git_sandbox_cleanup();
  }
  
  void test_object_lookup__lookup_wrong_type_returns_enotfound(void)
  {
  	const char *commit = "e90810b8df3e80c413d903f631643c716887138d";
  	git_oid oid;
  	git_object *object;
  
  	cl_git_pass(git_oid_fromstr(&oid, commit));
  	cl_assert_equal_i(
  		GIT_ENOTFOUND, git_object_lookup(&object, g_repo, &oid, GIT_OBJECT_TAG));
  }
  
  void test_object_lookup__lookup_nonexisting_returns_enotfound(void)
  {
  	const char *unknown = "deadbeefdeadbeefdeadbeefdeadbeefdeadbeef";
  	git_oid oid;
  	git_object *object;
  
  	cl_git_pass(git_oid_fromstr(&oid, unknown));
  	cl_assert_equal_i(
  		GIT_ENOTFOUND, git_object_lookup(&object, g_repo, &oid, GIT_OBJECT_ANY));
  }
  
  void test_object_lookup__lookup_wrong_type_by_abbreviated_id_returns_enotfound(void)
  {
  	const char *commit = "e90810b";
  	git_oid oid;
  	git_object *object;
  
  	cl_git_pass(git_oid_fromstrn(&oid, commit, strlen(commit)));
  	cl_assert_equal_i(
  		GIT_ENOTFOUND, git_object_lookup_prefix(&object, g_repo, &oid, strlen(commit), GIT_OBJECT_TAG));
  }
  
  void test_object_lookup__lookup_wrong_type_eventually_returns_enotfound(void)
  {
  	const char *commit = "e90810b8df3e80c413d903f631643c716887138d";
  	git_oid oid;
  	git_object *object;
  
  	cl_git_pass(git_oid_fromstr(&oid, commit));
  
  	cl_git_pass(git_object_lookup(&object, g_repo, &oid, GIT_OBJECT_COMMIT));
  	git_object_free(object);
  
  	cl_assert_equal_i(
  		GIT_ENOTFOUND, git_object_lookup(&object, g_repo, &oid, GIT_OBJECT_TAG));
  }
  
  void test_object_lookup__lookup_corrupt_object_returns_error(void)
  {
  	const char *commit = "8e73b769e97678d684b809b163bebdae2911720f",
  	      *file = "objects/8e/73b769e97678d684b809b163bebdae2911720f";
  	git_str path = GIT_STR_INIT, contents = GIT_STR_INIT;
  	git_oid oid;
  	git_object *object;
  	size_t i;
  
  	cl_git_pass(git_oid_fromstr(&oid, commit));
  	cl_git_pass(git_str_joinpath(&path, git_repository_path(g_repo), file));
  	cl_git_pass(git_futils_readbuffer(&contents, path.ptr));
  
  	/* Corrupt and try to read the object */
  	for (i = 0; i < contents.size; i++) {
  		contents.ptr[i] ^= 0x1;
  		cl_git_pass(git_futils_writebuffer(&contents, path.ptr, O_RDWR, 0644));
  		cl_git_fail(git_object_lookup(&object, g_repo, &oid, GIT_OBJECT_COMMIT));
  		contents.ptr[i] ^= 0x1;
  	}
  
  	/* Restore original content and assert we can read the object */
  	cl_git_pass(git_futils_writebuffer(&contents, path.ptr, O_RDWR, 0644));
  	cl_git_pass(git_object_lookup(&object, g_repo, &oid, GIT_OBJECT_COMMIT));
  
  	git_object_free(object);
  	git_str_dispose(&path);
  	git_str_dispose(&contents);
  }
  
  void test_object_lookup__lookup_object_with_wrong_hash_returns_error(void)
  {
  	const char *oldloose = "objects/8e/73b769e97678d684b809b163bebdae2911720f",
  	      *newloose = "objects/8e/73b769e97678d684b809b163bebdae2911720e",
  	      *commit = "8e73b769e97678d684b809b163bebdae2911720e";
  	git_str oldpath = GIT_STR_INIT, newpath = GIT_STR_INIT;
  	git_object *object;
  	git_oid oid;
  
  	cl_git_pass(git_oid_fromstr(&oid, commit));
  
  	/* Copy object to another location with wrong hash */
  	cl_git_pass(git_str_joinpath(&oldpath, git_repository_path(g_repo), oldloose));
  	cl_git_pass(git_str_joinpath(&newpath, git_repository_path(g_repo), newloose));
  	cl_git_pass(git_futils_cp(oldpath.ptr, newpath.ptr, 0644));
  
  	/* Verify that lookup fails due to a hashsum mismatch */
  	cl_git_fail_with(GIT_EMISMATCH, git_object_lookup(&object, g_repo, &oid, GIT_OBJECT_COMMIT));
  
  	/* Disable verification and try again */
  	cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_HASH_VERIFICATION, 0));
  	cl_git_pass(git_object_lookup(&object, g_repo, &oid, GIT_OBJECT_COMMIT));
  	cl_git_pass(git_libgit2_opts(GIT_OPT_ENABLE_STRICT_HASH_VERIFICATION, 1));
  
  	git_object_free(object);
  	git_str_dispose(&oldpath);
  	git_str_dispose(&newpath);
  }
  

Download